From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 870E1C04FF3 for ; Mon, 24 May 2021 14:11:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 66379610CE for ; Mon, 24 May 2021 14:11:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232486AbhEXOM1 (ORCPT ); Mon, 24 May 2021 10:12:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56850 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232462AbhEXOM1 (ORCPT ); Mon, 24 May 2021 10:12:27 -0400 Received: from mail-ua1-x934.google.com (mail-ua1-x934.google.com [IPv6:2607:f8b0:4864:20::934]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 27747C061574 for ; Mon, 24 May 2021 07:10:59 -0700 (PDT) Received: by mail-ua1-x934.google.com with SMTP id c6so8820242uat.0 for ; Mon, 24 May 2021 07:10:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=RpIF5xyKVymbV0kdJLrnlDUYIKLQJeip1Z/LyLzk92o=; b=pSCN5jWDfXPNWvYxUILl8ege4uHm8OyAku+xX7KzGiKCMElPZXmH7kF9ZRqe2PI+4W fKWNNeNgvKWqcavB6j6zeXLHIlvyAusKwKBtjmjNjwmFVdxphTdSa2NQfdBU80hx1BRm RhXaHkOYPmaQvqtnf0upbVJsx6Fp3m18R4rFdDlP7Nn7dK6FrzX7rUYON3NL3esygsTZ Hu+tO64U9e+m3rIRxfPfqunPlOP4imHopp3xFqsrHThZbrht7fKOuHSO7d2Y7RYZEb6P cx/pW5mMpHzY4qwbhMOz81Py2YsmlHW6/tUvmSnIVzXkCxVYcZxjLOkD3sl99ZpTCa1n cLXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=RpIF5xyKVymbV0kdJLrnlDUYIKLQJeip1Z/LyLzk92o=; b=BYN6LjhvaXwKJ2U9hMxcfU3HY9Y9BUHHJ0PXz0zAm8elvVIpkjftLgczOAkvAx+O+S DPp+ZgIXPH4kQCAMj2fCyNMOzksfha/7TqeIVfAVYQ5NCKdYGOwmwQLlJrQc66cutLxt 66t04+KLxjF+uAR/SYR3W+/Eh75RRIWcaRMmq3q93eu3FdRpNzbLVCLZmTs6YbtRLHYt AKmWGCXIMyBWqrqvlKNKgmCuIufTe3kd6vjInMjSGgeodMGFUsQU8I1XE95T1fIOBHxR ydyVO9tT8Fa/DprOyHjiVgPbIO05MAY9rVcJbd9hv/BK+mxIzCGUA+ld0uQegwYieVOI O7ug== X-Gm-Message-State: AOAM530P/l/ku1a0//B624m7dC+J0/qgbAw0UuCFuBGSdpIG1e3VdYg4 PlSGjFhZvTnMPZQG1LRYYB9ZiDTZQGyD5y5UZ38eQg== X-Google-Smtp-Source: ABdhPJw73/f++J0i/T4ayGVFRfYhSzvmCHSgspt8PqKX7pRabXH3i/vkuFvAu4togdjbYVDxLhkgXF5M3vJLtuSfgFk= X-Received: by 2002:a9f:35b3:: with SMTP id t48mr21997689uad.129.1621865458228; Mon, 24 May 2021 07:10:58 -0700 (PDT) MIME-Version: 1.0 References: <20210510190400.105162-1-l.stach@pengutronix.de> <20210510190400.105162-2-l.stach@pengutronix.de> In-Reply-To: <20210510190400.105162-2-l.stach@pengutronix.de> From: Ulf Hansson Date: Mon, 24 May 2021 16:10:19 +0200 Message-ID: Subject: Re: [PATCH v2 2/3] mmc: sdhci-esdhc-imx: advertise HS400 mode through MMC caps To: Lucas Stach Cc: Adrian Hunter , Haibo Chen , Rob Herring , NXP Linux Team , Sascha Hauer , linux-mmc , DTML , Linux ARM Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, 10 May 2021 at 21:04, Lucas Stach wrote: > > Instead of having an indirection through the SDHCI layer and emulating > a capability bit, that isn't there in hardware, do the same same thing > as with HS400_ES and advertise the support for HS400 directly through > the MMC caps. > > Signed-off-by: Lucas Stach Applied for next, thanks! Kind regards Uffe > --- > drivers/mmc/host/sdhci-esdhc-imx.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-esdhc-imx.c > index a20459744d21..65a52586db36 100644 > --- a/drivers/mmc/host/sdhci-esdhc-imx.c > +++ b/drivers/mmc/host/sdhci-esdhc-imx.c > @@ -427,9 +427,6 @@ static u32 esdhc_readl_le(struct sdhci_host *host, int reg) > | FIELD_PREP(SDHCI_RETUNING_MODE_MASK, > SDHCI_TUNING_MODE_3); > > - if (imx_data->socdata->flags & ESDHC_FLAG_HS400) > - val |= SDHCI_SUPPORT_HS400; > - > /* > * Do not advertise faster UHS modes if there are no > * pinctrl states for 100MHz/200MHz. > @@ -1603,7 +1600,7 @@ static int sdhci_esdhc_imx_probe(struct platform_device *pdev) > host->quirks |= SDHCI_QUIRK_BROKEN_ADMA; > > if (imx_data->socdata->flags & ESDHC_FLAG_HS400) > - host->quirks2 |= SDHCI_QUIRK2_CAPS_BIT63_FOR_HS400; > + host->mmc->caps2 |= MMC_CAP2_HS400; > > if (imx_data->socdata->flags & ESDHC_FLAG_BROKEN_AUTO_CMD23) > host->quirks2 |= SDHCI_QUIRK2_ACMD23_BROKEN; > -- > 2.31.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51FA4C04FF3 for ; Mon, 24 May 2021 18:22:43 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 157F661404 for ; Mon, 24 May 2021 18:22:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 157F661404 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+uU+YKfEJG22aMw7jKOcqmQdotYMpXtyQIMCFULz7TQ=; b=DyVHYrsqADdcN+ x8pbniCpMOdoQyjia40a9cdwnysyirjl4lCVcpOTXPbz24dnOgAYXLJ7ES4EB3/7xn4nvb4t6K5pd GDnqn/APQ9zZUywClCdjRCgaJumKDn017Gcq+CaWfhEEoU+023cNrQl7xDyyTB47nqIlzEAFziwd6 EO4cLockQ9GOtdNPDTrEjtstYX13dOZShlTlrNCGZ2wpEAJckpUhwEJ/F/ixxAKd7oGYtwJu+xwFX KXw42Z7K04Cs7aC0hHclaTQdVvJY3bn3KpNKaISRijihv/DWDwMXyw84HNXjo5jeUH47tfEW43bPu 7wz5K1BLgZUE/aogPOsw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1llFBY-001QhP-4G; Mon, 24 May 2021 18:20:16 +0000 Received: from mail-ua1-x930.google.com ([2607:f8b0:4864:20::930]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1llBIJ-000zD8-9t for linux-arm-kernel@lists.infradead.org; Mon, 24 May 2021 14:11:00 +0000 Received: by mail-ua1-x930.google.com with SMTP id 68so1387673uao.11 for ; Mon, 24 May 2021 07:10:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=RpIF5xyKVymbV0kdJLrnlDUYIKLQJeip1Z/LyLzk92o=; b=pSCN5jWDfXPNWvYxUILl8ege4uHm8OyAku+xX7KzGiKCMElPZXmH7kF9ZRqe2PI+4W fKWNNeNgvKWqcavB6j6zeXLHIlvyAusKwKBtjmjNjwmFVdxphTdSa2NQfdBU80hx1BRm RhXaHkOYPmaQvqtnf0upbVJsx6Fp3m18R4rFdDlP7Nn7dK6FrzX7rUYON3NL3esygsTZ Hu+tO64U9e+m3rIRxfPfqunPlOP4imHopp3xFqsrHThZbrht7fKOuHSO7d2Y7RYZEb6P cx/pW5mMpHzY4qwbhMOz81Py2YsmlHW6/tUvmSnIVzXkCxVYcZxjLOkD3sl99ZpTCa1n cLXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=RpIF5xyKVymbV0kdJLrnlDUYIKLQJeip1Z/LyLzk92o=; b=EYrjl5FrdP9YzTif5lEteyNCSUn6gpNAleDRGH9nCiOMw6LhYABvg2oeRKVk7/nG46 6GehQA3bQLaRu6BCxbj1zbvy4frnPBzU1oNl9PqAbhouRqv6sRmnBHulEYPS3xx2g+Ed PRJE8BnHJIgSoCLApxAnq2iQt5n0HbS962alaD7uaxVYMg5pUv/iDMJ1sZXZ6WWGSa4W DMqUhe/f1Tp9GseMK/8hdJ4fLLh5qKeu8WeFckxbM6LJCmGfAPkHTND/q8+lBJ6KwrpS LNKOPN9pyfhmOHlLYqwqZyJ2110y1oQNdAFJFUaYqJEkJGyFJTj8r3xcF3JnQgIwH/o4 QgKw== X-Gm-Message-State: AOAM533m0b2ERdBMG6zJLQXNGJgebG1gxPHCYD9eIlFLSviRxLNYnfSd JBMFytw+fE0PrDy3xVTotkZ1xVVeg/pr5vjuLTjTtg== X-Google-Smtp-Source: ABdhPJw73/f++J0i/T4ayGVFRfYhSzvmCHSgspt8PqKX7pRabXH3i/vkuFvAu4togdjbYVDxLhkgXF5M3vJLtuSfgFk= X-Received: by 2002:a9f:35b3:: with SMTP id t48mr21997689uad.129.1621865458228; Mon, 24 May 2021 07:10:58 -0700 (PDT) MIME-Version: 1.0 References: <20210510190400.105162-1-l.stach@pengutronix.de> <20210510190400.105162-2-l.stach@pengutronix.de> In-Reply-To: <20210510190400.105162-2-l.stach@pengutronix.de> From: Ulf Hansson Date: Mon, 24 May 2021 16:10:19 +0200 Message-ID: Subject: Re: [PATCH v2 2/3] mmc: sdhci-esdhc-imx: advertise HS400 mode through MMC caps To: Lucas Stach Cc: Adrian Hunter , Haibo Chen , Rob Herring , NXP Linux Team , Sascha Hauer , linux-mmc , DTML , Linux ARM X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210524_071059_363899_99047ABA X-CRM114-Status: GOOD ( 18.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 10 May 2021 at 21:04, Lucas Stach wrote: > > Instead of having an indirection through the SDHCI layer and emulating > a capability bit, that isn't there in hardware, do the same same thing > as with HS400_ES and advertise the support for HS400 directly through > the MMC caps. > > Signed-off-by: Lucas Stach Applied for next, thanks! Kind regards Uffe > --- > drivers/mmc/host/sdhci-esdhc-imx.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-esdhc-imx.c > index a20459744d21..65a52586db36 100644 > --- a/drivers/mmc/host/sdhci-esdhc-imx.c > +++ b/drivers/mmc/host/sdhci-esdhc-imx.c > @@ -427,9 +427,6 @@ static u32 esdhc_readl_le(struct sdhci_host *host, int reg) > | FIELD_PREP(SDHCI_RETUNING_MODE_MASK, > SDHCI_TUNING_MODE_3); > > - if (imx_data->socdata->flags & ESDHC_FLAG_HS400) > - val |= SDHCI_SUPPORT_HS400; > - > /* > * Do not advertise faster UHS modes if there are no > * pinctrl states for 100MHz/200MHz. > @@ -1603,7 +1600,7 @@ static int sdhci_esdhc_imx_probe(struct platform_device *pdev) > host->quirks |= SDHCI_QUIRK_BROKEN_ADMA; > > if (imx_data->socdata->flags & ESDHC_FLAG_HS400) > - host->quirks2 |= SDHCI_QUIRK2_CAPS_BIT63_FOR_HS400; > + host->mmc->caps2 |= MMC_CAP2_HS400; > > if (imx_data->socdata->flags & ESDHC_FLAG_BROKEN_AUTO_CMD23) > host->quirks2 |= SDHCI_QUIRK2_ACMD23_BROKEN; > -- > 2.31.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel