From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ulf Hansson Subject: Re: [PATCH V2 2/2] mmc: mmci: Move ios_handler functionality into the driver Date: Fri, 14 Dec 2012 16:52:30 +0100 Message-ID: References: <1355495429-12510-1-git-send-email-ulf.hansson@stericsson.com> <1355495429-12510-3-git-send-email-ulf.hansson@stericsson.com> <20121214151002.GK14363@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7235763428128519286==" Return-path: In-Reply-To: <20121214151002.GK14363@n2100.arm.linux.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Russell King - ARM Linux Cc: Linus Walleij , "linux-mmc@vger.kernel.org" , Chris Ball , Lee Jones , Ulf Hansson , "linux-arm-kernel@lists.infradead.org" List-Id: linux-mmc@vger.kernel.org --===============7235763428128519286== Content-Type: multipart/alternative; boundary=f46d04463040eaf68604d0d204ee --f46d04463040eaf68604d0d204ee Content-Type: text/plain; charset=ISO-8859-1 On Friday, 14 December 2012, Russell King - ARM Linux < linux@arm.linux.org.uk> wrote: > On Fri, Dec 14, 2012 at 03:30:29PM +0100, Ulf Hansson wrote: >> From: Lee Jones >> >> There are currently two instances of the ios_handler being used. >> Both of which mearly toy with some regulator settings. Now there >> is a GPIO regulator API, we can use that instead, and lessen the >> per platform burden. By doing this, we also become more Device >> Tree compatible. > > Err, why is this needed? What's wrong with using the 'vmmc' for this? This is not for power to the card, but for the I/O voltage. Before this was controlled by the ios_handler. > > From what I read in the mmc core, vmmc handling via mmc_regulator_set_ocr() > can cope with GPIO-based regulators, and if you have a single GPIO signal > then you have a single supply (it's either on or off). So what's wrong > with using the existing regulator hooks for this which are already there? Kind regards Ulf Hansson > -- > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > --f46d04463040eaf68604d0d204ee Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable

On Friday, 14 December 2012, Russell King - ARM Linux <linux@arm.linux.org.uk> wrote:> On Fri, Dec 14, 2012 at 03:30:29PM +0100, Ulf Hansson wrote:
>&= gt; From: Lee Jones <lee.jones@l= inaro.org>
>>
>> There are currently two instances of the ios_handler b= eing used.
>> Both of which mearly toy with some regulator setting= s. Now there
>> is a GPIO regulator API, we can use that instead, = and lessen the
>> per platform burden. By doing this, we also become more Device
= >> Tree compatible.
>
> Err, why is this needed? =A0What&= #39;s wrong with using the 'vmmc' for this?

This is not for = power to the card, but for the I/O voltage. Before this was controlled by t= he ios_handler.

>
> From what I read in the mmc core, vmmc handling via mmc_re= gulator_set_ocr()
> can cope with GPIO-based regulators, and if you h= ave a single GPIO signal
> then you have a single supply (it's ei= ther on or off). =A0So what's wrong
> with using the existing regulator hooks for this which are already the= re?

Kind regards
Ulf Hansson

> --
> To unsubscrib= e from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to = majordomo@vger.kernel.org
> More majordomo info at =A0http://vger.kernel.org/majordom= o-info.html
> --f46d04463040eaf68604d0d204ee-- --===============7235763428128519286== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============7235763428128519286==-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: ulf.hansson@linaro.org (Ulf Hansson) Date: Fri, 14 Dec 2012 16:52:30 +0100 Subject: [PATCH V2 2/2] mmc: mmci: Move ios_handler functionality into the driver In-Reply-To: <20121214151002.GK14363@n2100.arm.linux.org.uk> References: <1355495429-12510-1-git-send-email-ulf.hansson@stericsson.com> <1355495429-12510-3-git-send-email-ulf.hansson@stericsson.com> <20121214151002.GK14363@n2100.arm.linux.org.uk> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Friday, 14 December 2012, Russell King - ARM Linux < linux@arm.linux.org.uk> wrote: > On Fri, Dec 14, 2012 at 03:30:29PM +0100, Ulf Hansson wrote: >> From: Lee Jones >> >> There are currently two instances of the ios_handler being used. >> Both of which mearly toy with some regulator settings. Now there >> is a GPIO regulator API, we can use that instead, and lessen the >> per platform burden. By doing this, we also become more Device >> Tree compatible. > > Err, why is this needed? What's wrong with using the 'vmmc' for this? This is not for power to the card, but for the I/O voltage. Before this was controlled by the ios_handler. > > From what I read in the mmc core, vmmc handling via mmc_regulator_set_ocr() > can cope with GPIO-based regulators, and if you have a single GPIO signal > then you have a single supply (it's either on or off). So what's wrong > with using the existing regulator hooks for this which are already there? Kind regards Ulf Hansson > -- > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in > the body of a message to majordomo at vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -------------- next part -------------- An HTML attachment was scrubbed... URL: