From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751591AbdK0JcB (ORCPT ); Mon, 27 Nov 2017 04:32:01 -0500 Received: from mail-it0-f68.google.com ([209.85.214.68]:40430 "EHLO mail-it0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751292AbdK0JcA (ORCPT ); Mon, 27 Nov 2017 04:32:00 -0500 X-Google-Smtp-Source: AGs4zMaUDaCpNEmmtH//r7/WsxN9EhA6xPqoD0C6ZG50CE2CZJG34LNZvkRHLlPaJ2dZxrx9JUDP3TW5BLHVeXcAG90= MIME-Version: 1.0 In-Reply-To: <8fcf045dd4601511186b828d1911ba4659d8f923.1510936216.git.arvind.yadav.cs@gmail.com> References: <8fcf045dd4601511186b828d1911ba4659d8f923.1510936216.git.arvind.yadav.cs@gmail.com> From: Ulf Hansson Date: Mon, 27 Nov 2017 10:31:59 +0100 Message-ID: Subject: Re: [PATCH] mmc: usdhi6rol0: Handle return value of platform_get_irq_byname for card detect To: Arvind Yadav Cc: Wolfram Sang , "linux-kernel@vger.kernel.org" , "linux-mmc@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17 November 2017 at 17:35, Arvind Yadav wrote: > platform_get_irq_byname() can fail here and we must check its return value. NAK. You need to check the code more carefully. irq_cd is dealt with later below in the same function with proper error handling. > > Signed-off-by: Arvind Yadav > --- > drivers/mmc/host/usdhi6rol0.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/usdhi6rol0.c b/drivers/mmc/host/usdhi6rol0.c > index cdfeb15..5a896de 100644 > --- a/drivers/mmc/host/usdhi6rol0.c > +++ b/drivers/mmc/host/usdhi6rol0.c > @@ -1749,7 +1749,7 @@ static int usdhi6_probe(struct platform_device *pdev) > irq_cd = platform_get_irq_byname(pdev, "card detect"); > irq_sd = platform_get_irq_byname(pdev, "data"); > irq_sdio = platform_get_irq_byname(pdev, "SDIO"); > - if (irq_sd < 0 || irq_sdio < 0) > + if (irq_cd < 0 || irq_sd < 0 || irq_sdio < 0) > return -ENODEV; > > mmc = mmc_alloc_host(sizeof(struct usdhi6_host), dev); > -- > 2.7.4 >