From: Ulf Hansson <ulf.hansson@linaro.org>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: "Ulrich Hecht" <uli+renesas@fpond.eu>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"Niklas Söderlund" <niklas.soderlund@ragnatech.se>,
"Masahiro Yamada" <yamada.masahiro@socionext.com>,
"Geert Uytterhoeven" <geert@linux-m68k.org>,
"Magnus Damm" <magnus.damm@gmail.com>
Subject: Re: [PATCH v2 1/2] mmc: tmio: leave clock handling to runtime PM if enabled
Date: Thu, 22 Aug 2019 11:43:27 +0200 [thread overview]
Message-ID: <CAPDyKFojrZB819DvViyP_cAf=s1y4jpHjYKis37XO2ZOSkH1Eg@mail.gmail.com> (raw)
In-Reply-To: <20190822063530.wzee6gy4d2lisj2x@katana>
On Thu, 22 Aug 2019 at 08:35, Wolfram Sang <wsa@the-dreams.de> wrote:
>
> Hi Ulf,
>
> > > +#ifdef CONFIG_PM
> > > + /* PM handles the clock; disable it so it won't be enabled twice. */
> > > + if (_host->clk_disable && pdev->dev.pm_domain)
> >
> > Hmm.
> >
> > This seems to work for most cases of yours, but it's fragile, because
> > how do you know that the pm_domain above is managing the clock? You
> > don't.
> >
>
> ...
>
> > I am going to think a bit more about this, but at this point, my
> > gut-feeling is that may need to add some helper functions to let genpd
> > and/or the pm_clk framework, to share some internal information with
> > drivers.
>
> Any outcome of this? Do you want to do it?
Sorry for delay, it's been vacation period. I have some ideas that we
can try out, just not yet being formalize them in code.
I need to catch up a little bit more on mmc reviews, so unless this is
urgent, I can offer my help and post something soonish.
Is this fine by you?
Kind regards
Uffe
next prev parent reply other threads:[~2019-08-22 9:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-31 16:17 [PATCH v2 0/2] mmc: tmio: remove Gen2+ workaround and fix up Ulrich Hecht
2019-07-31 16:17 ` [PATCH v2 1/2] mmc: tmio: leave clock handling to runtime PM if enabled Ulrich Hecht
2019-08-02 13:24 ` Ulf Hansson
2019-08-22 6:35 ` Wolfram Sang
2019-08-22 9:43 ` Ulf Hansson [this message]
2019-08-22 9:52 ` Wolfram Sang
2019-07-31 16:17 ` [PATCH v2 2/2] mmc: tmio: remove obsolete PM workaround Ulrich Hecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPDyKFojrZB819DvViyP_cAf=s1y4jpHjYKis37XO2ZOSkH1Eg@mail.gmail.com' \
--to=ulf.hansson@linaro.org \
--cc=geert@linux-m68k.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=niklas.soderlund@ragnatech.se \
--cc=uli+renesas@fpond.eu \
--cc=wsa@the-dreams.de \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.