From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A359C432C3 for ; Thu, 14 Nov 2019 14:13:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E466D20724 for ; Thu, 14 Nov 2019 14:13:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="kTe0B79e" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727359AbfKNONZ (ORCPT ); Thu, 14 Nov 2019 09:13:25 -0500 Received: from mail-ua1-f67.google.com ([209.85.222.67]:40931 "EHLO mail-ua1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726307AbfKNONZ (ORCPT ); Thu, 14 Nov 2019 09:13:25 -0500 Received: by mail-ua1-f67.google.com with SMTP id i13so1892146uaq.7 for ; Thu, 14 Nov 2019 06:13:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=FJX4pImmW+1dIAMZK03BtkAIeMegqqUoxzHSgtg4Ca4=; b=kTe0B79e9Q3wfvE896/JqCWZWDPTHUnKJF3MXGJCz0VulZPNVJNms03VWhWhosu0r5 65u5iTmqWQfZhZU6bZ43HtCH3t9odmp08GyQa+kXxDCOH1M9z2/nD017md8ls95KA8VP ScIOnZqRoEAnVGwumKypo7R1jHWTsqOLnL6eBU/RaI2+hdZynt2GBCuBi/hTtG43ri6w rXa5aWAOZxBY1H9M1Y57rS3KQgGaa/rz8QLbkYvZ2P8SjOkhJh96iSXBPr0zCcnFlfWj USwGVkvBZ+QWGkRyEY9OPWD6vy6WDksT8kV8rKsKHSBpk+Gwww5b9A0D0ZRiHDza1Lch oI1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FJX4pImmW+1dIAMZK03BtkAIeMegqqUoxzHSgtg4Ca4=; b=JmfPsc21gl1JNhtTF/nc3groO5zTfFnGSIIVMMTjmq1R9BbJAQf1SR2R535dzgO35e 3MbVaRVQ6te5yJZciBYKgOzEL2QjMVuCbf3L76G0qAH70EGub+hlM6v1gZzjhS5MR9rx hKTFZgfvAqBecBIVHK2M+l0C1maCGmG0tzovqD0jJd8no34amN7dKnQIS6RaA4BcSY94 LUF89VrPmQ8sduRyp18yxzmmag0DGe2F7nfsgbinXWWnjD5VirTjg3g5wh+ydaui5ybM 0ngNhWoMPtA4iSn1ifboCw90aBByulooWOEAB5iQN0Se3xcThmnzTTKFoTML4N3otl4z SS4A== X-Gm-Message-State: APjAAAXDg3UXjcwQdLIRhRx2ItSzE0xieAn/hUoN2E+StzUwm6RE0WdI Vgg3Ta7u6eHww5yMovOcDEyTHXEIYUWgVL/9cZV8iA== X-Google-Smtp-Source: APXvYqx4RK4gWYtCk+erym1uLlCEMYfvmcIf3PPkVWWUkOMrPhdQcGSzRSUDsyWVm4ZWkUAyeM62b0wXUC2Rr+arkK8= X-Received: by 2002:ab0:3399:: with SMTP id y25mr5562495uap.100.1573740804146; Thu, 14 Nov 2019 06:13:24 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Ulf Hansson Date: Thu, 14 Nov 2019 15:12:48 +0100 Message-ID: Subject: Re: [PATCH v3 02/12] net: wireless: ti: wl1251 add device tree support To: "H. Nikolaus Schaller" Cc: =?UTF-8?Q?Beno=C3=AEt_Cousson?= , Tony Lindgren , Rob Herring , Mark Rutland , Russell King , Kalle Valo , Mike Rapoport , David Sterba , "Rafael J. Wysocki" , Petr Mladek , Sakari Ailus , Kefeng Wang , Yangtao Li , Alexios Zavras , Thomas Gleixner , Allison Randal , Greg Kroah-Hartman , John Stultz , Bjorn Helgaas , DTML , Discussions about the Letux Kernel , "linux-mmc@vger.kernel.org" , kernel@pyra-handheld.com, linux-wireless , Linux Kernel Mailing List , netdev , linux-omap , Linux ARM Content-Type: text/plain; charset="UTF-8" Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Thu, 7 Nov 2019 at 11:31, H. Nikolaus Schaller wrote: > > We will have the wl1251 defined as a child node of the mmc interface > and can read setup for gpios, interrupts and the ti,use-eeprom > property from there instead of pdata to be provided by pdata-quirks. > > Fixes: 81eef6ca9201 ("mmc: omap_hsmmc: Use dma_request_chan() for requesting DMA channel") > > Signed-off-by: H. Nikolaus Schaller > Acked-by: Kalle Valo > --- > drivers/net/wireless/ti/wl1251/sdio.c | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/drivers/net/wireless/ti/wl1251/sdio.c b/drivers/net/wireless/ti/wl1251/sdio.c > index 677f1146ccf0..c54a273713ed 100644 > --- a/drivers/net/wireless/ti/wl1251/sdio.c > +++ b/drivers/net/wireless/ti/wl1251/sdio.c > @@ -16,6 +16,9 @@ > #include > #include > #include > +#include > +#include > +#include > > #include "wl1251.h" > > @@ -217,6 +220,7 @@ static int wl1251_sdio_probe(struct sdio_func *func, > struct ieee80211_hw *hw; > struct wl1251_sdio *wl_sdio; > const struct wl1251_platform_data *wl1251_board_data; > + struct device_node *np = func->dev.of_node; > > hw = wl1251_alloc_hw(); > if (IS_ERR(hw)) > @@ -248,6 +252,15 @@ static int wl1251_sdio_probe(struct sdio_func *func, > wl->power_gpio = wl1251_board_data->power_gpio; > wl->irq = wl1251_board_data->irq; > wl->use_eeprom = wl1251_board_data->use_eeprom; > + } else if (np) { > + wl->use_eeprom =of_property_read_bool(np, "ti,wl1251-has-eeprom"); > + wl->power_gpio = of_get_named_gpio(np, "ti,power-gpio", 0); This isn't needed as it seems. Perhaps remove or keep it as optional? > + wl->irq = of_irq_get(np, 0); > + > + if (wl->power_gpio == -EPROBE_DEFER || wl->irq == -EPROBE_DEFER) { > + ret = -EPROBE_DEFER; > + goto disable; > + } > } > > if (gpio_is_valid(wl->power_gpio)) { > -- Kind regards Uffe From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ulf Hansson Subject: Re: [PATCH v3 02/12] net: wireless: ti: wl1251 add device tree support Date: Thu, 14 Nov 2019 15:12:48 +0100 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: "H. Nikolaus Schaller" Cc: =?UTF-8?Q?Beno=C3=AEt_Cousson?= , Tony Lindgren , Rob Herring , Mark Rutland , Russell King , Kalle Valo , Mike Rapoport , David Sterba , "Rafael J. Wysocki" , Petr Mladek , Sakari Ailus , Kefeng Wang , Yangtao Li , Alexios Zavras , Thomas Gleixner , Allison Randal , Greg Kroah-Hartman , John Stultz , Bjorn Helgaas List-Id: linux-mmc@vger.kernel.org On Thu, 7 Nov 2019 at 11:31, H. Nikolaus Schaller wrote: > > We will have the wl1251 defined as a child node of the mmc interface > and can read setup for gpios, interrupts and the ti,use-eeprom > property from there instead of pdata to be provided by pdata-quirks. > > Fixes: 81eef6ca9201 ("mmc: omap_hsmmc: Use dma_request_chan() for requesting DMA channel") > > Signed-off-by: H. Nikolaus Schaller > Acked-by: Kalle Valo > --- > drivers/net/wireless/ti/wl1251/sdio.c | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/drivers/net/wireless/ti/wl1251/sdio.c b/drivers/net/wireless/ti/wl1251/sdio.c > index 677f1146ccf0..c54a273713ed 100644 > --- a/drivers/net/wireless/ti/wl1251/sdio.c > +++ b/drivers/net/wireless/ti/wl1251/sdio.c > @@ -16,6 +16,9 @@ > #include > #include > #include > +#include > +#include > +#include > > #include "wl1251.h" > > @@ -217,6 +220,7 @@ static int wl1251_sdio_probe(struct sdio_func *func, > struct ieee80211_hw *hw; > struct wl1251_sdio *wl_sdio; > const struct wl1251_platform_data *wl1251_board_data; > + struct device_node *np = func->dev.of_node; > > hw = wl1251_alloc_hw(); > if (IS_ERR(hw)) > @@ -248,6 +252,15 @@ static int wl1251_sdio_probe(struct sdio_func *func, > wl->power_gpio = wl1251_board_data->power_gpio; > wl->irq = wl1251_board_data->irq; > wl->use_eeprom = wl1251_board_data->use_eeprom; > + } else if (np) { > + wl->use_eeprom =of_property_read_bool(np, "ti,wl1251-has-eeprom"); > + wl->power_gpio = of_get_named_gpio(np, "ti,power-gpio", 0); This isn't needed as it seems. Perhaps remove or keep it as optional? > + wl->irq = of_irq_get(np, 0); > + > + if (wl->power_gpio == -EPROBE_DEFER || wl->irq == -EPROBE_DEFER) { > + ret = -EPROBE_DEFER; > + goto disable; > + } > } > > if (gpio_is_valid(wl->power_gpio)) { > -- Kind regards Uffe From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2F8AC43141 for ; Thu, 14 Nov 2019 14:13:32 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6BEB420725 for ; Thu, 14 Nov 2019 14:13:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="AbAkRVG5"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="kTe0B79e" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6BEB420725 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VvjeCUW3lzBO+Aiwth1s2HghkvblEXZr3QruVD2zlhc=; b=AbAkRVG5SnRcFu Cv8+jenJOK2wnyFlcO0BTURBhJ+ETuGOsP6TReBhqrtwq71lyMwcC7vY7zTlSqoOsMtrH/hIK1+4s rbOPTQNuav39OucChRDUne9gMOy6+HMLXni1edBDb5Si9T/9FAbr6htucXQXIrkLzX2jTQ2T7nG9A 0twzH8TRm73dXOkMp2Wzm+g6g/Z7oh+rA/32cNhmvcJR1dSTLKTMowUHRCkjM4srRRlptVaSho3Go AKkGr8HUEdthKky5HZRdodv7rw0DjNqk388URtGCa7MtOBo2Oajfya1ezvF5l9zcS9mj4/U02iuNQ GSHW7GKcxvA2lWD8Ymmg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iVFsG-0003sW-7Y; Thu, 14 Nov 2019 14:13:28 +0000 Received: from mail-ua1-x942.google.com ([2607:f8b0:4864:20::942]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iVFsD-0003rp-H1 for linux-arm-kernel@lists.infradead.org; Thu, 14 Nov 2019 14:13:26 +0000 Received: by mail-ua1-x942.google.com with SMTP id z9so1905213uan.3 for ; Thu, 14 Nov 2019 06:13:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=FJX4pImmW+1dIAMZK03BtkAIeMegqqUoxzHSgtg4Ca4=; b=kTe0B79e9Q3wfvE896/JqCWZWDPTHUnKJF3MXGJCz0VulZPNVJNms03VWhWhosu0r5 65u5iTmqWQfZhZU6bZ43HtCH3t9odmp08GyQa+kXxDCOH1M9z2/nD017md8ls95KA8VP ScIOnZqRoEAnVGwumKypo7R1jHWTsqOLnL6eBU/RaI2+hdZynt2GBCuBi/hTtG43ri6w rXa5aWAOZxBY1H9M1Y57rS3KQgGaa/rz8QLbkYvZ2P8SjOkhJh96iSXBPr0zCcnFlfWj USwGVkvBZ+QWGkRyEY9OPWD6vy6WDksT8kV8rKsKHSBpk+Gwww5b9A0D0ZRiHDza1Lch oI1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FJX4pImmW+1dIAMZK03BtkAIeMegqqUoxzHSgtg4Ca4=; b=YnneHc1qnawIY9SARxMabHtRTUXAQAgnri/G1zEB/ABSOXrNsSC7FZMBhI6Y7qODQz netyWEFPlNXHCuDdhO+8QHQS5vC0MQFPAuD2aA49kobEP1Qa+4RDvWuqALIz7zQFNgG7 nKzj6Q7mzJGSK7Ny9eJMqq6WLoJDSFl/UUSiQEcNq84+vXBY26+BOR6KlV4cG3zHsJxJ rYbB5jmsHtDv3vsq3X3Mn3YvT2bYlRmmkdMRB2SJ2v1mPtedWMsf8J4ovun+/nqcseZD 3g2gWgctj4AJmkct6hZrtDCh/7E4fNU4CY1w9XCo10ihAIs4PYDpm76bKOMkjVXSyEKR Vq2g== X-Gm-Message-State: APjAAAXx41iYwsrfLe5FYxzbF1dLismzl0zZmHeDQqiFcwNQfLHI4Tqt IkFv+0iNOw0rGPcShrcqU9v1r0ynrczyTO0nwqZY2Q== X-Google-Smtp-Source: APXvYqx4RK4gWYtCk+erym1uLlCEMYfvmcIf3PPkVWWUkOMrPhdQcGSzRSUDsyWVm4ZWkUAyeM62b0wXUC2Rr+arkK8= X-Received: by 2002:ab0:3399:: with SMTP id y25mr5562495uap.100.1573740804146; Thu, 14 Nov 2019 06:13:24 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Ulf Hansson Date: Thu, 14 Nov 2019 15:12:48 +0100 Message-ID: Subject: Re: [PATCH v3 02/12] net: wireless: ti: wl1251 add device tree support To: "H. Nikolaus Schaller" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191114_061325_574020_EEF2FFE2 X-CRM114-Status: GOOD ( 19.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Kefeng Wang , DTML , Tony Lindgren , linux-wireless , Bjorn Helgaas , netdev , linux-omap , "Rafael J. Wysocki" , Russell King , Mike Rapoport , Yangtao Li , Kalle Valo , Petr Mladek , =?UTF-8?Q?Beno=C3=AEt_Cousson?= , Alexios Zavras , Rob Herring , John Stultz , David Sterba , Thomas Gleixner , Discussions about the Letux Kernel , Allison Randal , Linux ARM , Greg Kroah-Hartman , "linux-mmc@vger.kernel.org" , Linux Kernel Mailing List , Sakari Ailus , kernel@pyra-handheld.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 7 Nov 2019 at 11:31, H. Nikolaus Schaller wrote: > > We will have the wl1251 defined as a child node of the mmc interface > and can read setup for gpios, interrupts and the ti,use-eeprom > property from there instead of pdata to be provided by pdata-quirks. > > Fixes: 81eef6ca9201 ("mmc: omap_hsmmc: Use dma_request_chan() for requesting DMA channel") > > Signed-off-by: H. Nikolaus Schaller > Acked-by: Kalle Valo > --- > drivers/net/wireless/ti/wl1251/sdio.c | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/drivers/net/wireless/ti/wl1251/sdio.c b/drivers/net/wireless/ti/wl1251/sdio.c > index 677f1146ccf0..c54a273713ed 100644 > --- a/drivers/net/wireless/ti/wl1251/sdio.c > +++ b/drivers/net/wireless/ti/wl1251/sdio.c > @@ -16,6 +16,9 @@ > #include > #include > #include > +#include > +#include > +#include > > #include "wl1251.h" > > @@ -217,6 +220,7 @@ static int wl1251_sdio_probe(struct sdio_func *func, > struct ieee80211_hw *hw; > struct wl1251_sdio *wl_sdio; > const struct wl1251_platform_data *wl1251_board_data; > + struct device_node *np = func->dev.of_node; > > hw = wl1251_alloc_hw(); > if (IS_ERR(hw)) > @@ -248,6 +252,15 @@ static int wl1251_sdio_probe(struct sdio_func *func, > wl->power_gpio = wl1251_board_data->power_gpio; > wl->irq = wl1251_board_data->irq; > wl->use_eeprom = wl1251_board_data->use_eeprom; > + } else if (np) { > + wl->use_eeprom =of_property_read_bool(np, "ti,wl1251-has-eeprom"); > + wl->power_gpio = of_get_named_gpio(np, "ti,power-gpio", 0); This isn't needed as it seems. Perhaps remove or keep it as optional? > + wl->irq = of_irq_get(np, 0); > + > + if (wl->power_gpio == -EPROBE_DEFER || wl->irq == -EPROBE_DEFER) { > + ret = -EPROBE_DEFER; > + goto disable; > + } > } > > if (gpio_is_valid(wl->power_gpio)) { > -- Kind regards Uffe _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel