From: Ulf Hansson <ulf.hansson@linaro.org>
To: Shawn Lin <shawn.lin@rock-chips.com>
Cc: "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
Jaehoon Chung <jh80.chung@samsung.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Stefan Wahren <stefan.wahren@i2se.com>,
Fabio Estevam <festevam@gmail.com>,
Jan Glauber <jan.glauber@caviumnetworks.com>
Subject: Re: [PATCH 0/6] mmc: core: Enable mmc hosts to specify support for eMMC DDR 3.3V
Date: Fri, 27 Jan 2017 09:57:39 +0100 [thread overview]
Message-ID: <CAPDyKFotcwkLFgFbsZO+YE_NdrO=31vQ_eOqAyPfVY23-tmYPg@mail.gmail.com> (raw)
In-Reply-To: <2d3a5129-1514-1969-89df-1972427f7856@rock-chips.com>
On 27 January 2017 at 03:27, Shawn Lin <shawn.lin@rock-chips.com> wrote:
> On 2017/1/25 23:12, Ulf Hansson wrote:
>>
>> It's been reported that some mmc hosts don't support a VCCQ (signal
>> voltage) of
>> 1.8V for eMMC DDR mode, but instead only 3.3V. According to the JEDEC
>> spec, an
>> eMMC card must support both if any, which makes the mmc host being the
>> potential limitation. Therefore, let's invent a new mmc cap,
>> MMC_CAP_3_3V_DDR,
>> and a new corresponding DT binding, which tells whether 3.3V is supported
>> for
>> the VCCQ.
>>
>> In the context of these changes, I took the opportunity to make some
>> clean-ups
>> of some related code.
>>
>
> This patchset looks good. Just a nit, maybe we could take this chance
> to improve the patch 3 as we touch it now:)
>
> s/mmc_set_signal_voltage(host, MMC_SIGNAL_VOLTAGE_180) == 0/
> !mmc_set_signal_voltage(host, MMC_SIGNAL_VOLTAGE_180), and so on:)
Good idea! I found three places in mmc_power_up() which I fixed up.
I postpone to send a new version, to wait for further comments. If
none, I will just amend the change in patch3/6.
>
> Anyway,
> Reviewed-by: Shawn Lin <shawn.lin@rock-chips.com>
Thanks for reviewing!
[...]
Kind regards
Uffe
next prev parent reply other threads:[~2017-01-27 8:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-25 15:12 [PATCH 0/6] mmc: core: Enable mmc hosts to specify support for eMMC DDR 3.3V Ulf Hansson
2017-01-25 15:12 ` [PATCH 1/6] mmc: core: Remove redundant code in mmc_set_signal_voltage() Ulf Hansson
2017-01-25 15:12 ` [PATCH 2/6] mmc: core: Clarify usage of mmc_set_signal_voltage() Ulf Hansson
2017-01-25 15:12 ` [PATCH 3/6] mmc: core: Rename __mmc_set_signal_voltage() to mmc_set_signal_voltage() Ulf Hansson
2017-01-25 15:12 ` [PATCH 4/6] mmc: core: Invent MMC_CAP_3_3V_DDR Ulf Hansson
[not found] ` <1485357143-23280-1-git-send-email-ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2017-01-25 15:12 ` [PATCH 5/6] mmc: dt: Document binding for eMMC DDR 3.3V I/O voltage support Ulf Hansson
2017-01-30 19:58 ` Rob Herring
2017-01-25 15:12 ` [PATCH 6/6] mmc: core: Extend mmc_of_parse() to check for mmc-ddr-3_3v Ulf Hansson
2017-01-27 2:27 ` [PATCH 0/6] mmc: core: Enable mmc hosts to specify support for eMMC DDR 3.3V Shawn Lin
2017-01-27 8:57 ` Ulf Hansson [this message]
2017-01-27 12:06 ` Jan Glauber
2017-01-27 14:58 ` Ulf Hansson
2017-01-30 9:13 ` Stefan Wahren
2017-01-30 10:05 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPDyKFotcwkLFgFbsZO+YE_NdrO=31vQ_eOqAyPfVY23-tmYPg@mail.gmail.com' \
--to=ulf.hansson@linaro.org \
--cc=adrian.hunter@intel.com \
--cc=festevam@gmail.com \
--cc=jan.glauber@caviumnetworks.com \
--cc=jh80.chung@samsung.com \
--cc=linux-mmc@vger.kernel.org \
--cc=shawn.lin@rock-chips.com \
--cc=stefan.wahren@i2se.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.