From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ulf Hansson Subject: Re: [PATCH v10 1/3] mmc: sdhci-msm: Qualcomm SDHCI binding documentation Date: Wed, 5 Mar 2014 05:25:08 +0100 Message-ID: References: <1393961226-25618-1-git-send-email-gdjakov@mm-sol.com> <1393961226-25618-2-git-send-email-gdjakov@mm-sol.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Return-path: Received: from mail-qa0-f53.google.com ([209.85.216.53]:32867 "EHLO mail-qa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756275AbaCEEZJ (ORCPT ); Tue, 4 Mar 2014 23:25:09 -0500 Received: by mail-qa0-f53.google.com with SMTP id w8so517357qac.12 for ; Tue, 04 Mar 2014 20:25:08 -0800 (PST) In-Reply-To: <1393961226-25618-2-git-send-email-gdjakov@mm-sol.com> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Georgi Djakov Cc: linux-mmc , Chris Ball , devicetree@vger.kernel.org, grant.likely@linaro.org, Rob Herring , Pawel Moll , Mark Rutland , Stephen Warren , Ian Campbell , Kumar Gala , Rob Landley , linux-doc@vger.kernel.org, "linux-kernel@vger.kernel.org" , linux-arm-msm@vger.kernel.org On 4 March 2014 20:27, Georgi Djakov wrote: > This patch adds the device-tree binding documentation for > Qualcomm SDHCI driver. It contains the differences between > the core properties in mmc.txt and the properties used by > the sdhci-msm driver. > > Signed-off-by: Georgi Djakov > --- > .../devicetree/bindings/mmc/sdhci-msm.txt | 63 ++++++++++++++++++++ > 1 file changed, 63 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mmc/sdhci-msm.txt > > diff --git a/Documentation/devicetree/bindings/mmc/sdhci-msm.txt b/Documentation/devicetree/bindings/mmc/sdhci-msm.txt > new file mode 100644 > index 0000000..c635c53 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mmc/sdhci-msm.txt > @@ -0,0 +1,63 @@ > +* Qualcomm SDHCI controller (sdhci-msm) > + > +This file documents differences between the core properties in mmc.txt > +and the properties used by the sdhci-msm driver. > + > +Required properties: > +- compatible: Should contain "qcom,sdhci-msm-v4". > +- reg: Base address and length of the register set listed in reg-names. > +- reg-names: Should contain the following: > + "hc_mem" - Host controller register map > + "core_mem" - SD Core register map > +- interrupts: Should contain an interrupt-specifiers for the interrupts listed in interrupt-names. > +- interrupt-names: Should contain the following: > + "hc_irq" - Host controller interrupt > + "pwr_irq" - PMIC interrupt > +- vdd-supply: Phandle to the regulator for the vdd (core voltage) supply. > +- vdd-io-supply: Phandle to the regulator for the vdd-io (i/o voltage) supply. The common naming of the above regulators are "vmmc" and "vqmmc". Is there any specific reason to why you can't use these names? Kind regards Ulf Hansson > +- pinctrl-names: Should contain only one value - "default". > +- pinctrl-0: Should specify pin control groups used for this controller. > +- clocks: A list of phandle + clock-specifier pairs for the clocks listed in clock-names. > +- clock-names: Should contain the following: > + "iface" - Main peripheral bus clock (PCLK/HCLK - AHB Bus clock) (required) > + "core" - SDC MMC clock (MCLK) (required) > + "bus" - SDCC bus voter clock (optional) > + > +Example: > + > + sdhc_1: sdhci@f9824900 { > + compatible = "qcom,sdhci-msm-v4"; > + reg = <0xf9824900 0x11c>, <0xf9824000 0x800>; > + reg-names = "hc_mem", "core_mem"; > + interrupts = <0 123 0>, <0 138 0>; > + interrupt-names = "hc_irq", "pwr_irq"; > + bus-width = <8>; > + non-removable; > + > + vdd-supply = <&pm8941_l20>; > + vdd-io-supply = <&pm8941_s3>; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&sdc1_clk &sdc1_cmd &sdc1_data>; > + > + clocks = <&gcc GCC_SDCC1_APPS_CLK>, <&gcc GCC_SDCC1_AHB_CLK>; > + clock-names = "core", "iface"; > + }; > + > + sdhc_2: sdhci@f98a4900 { > + compatible = "qcom,sdhci-msm-v4"; > + reg = <0xf98a4900 0x11c>, <0xf98a4000 0x800>; > + reg-names = "hc_mem", "core_mem"; > + interrupts = <0 125 0>, <0 221 0>; > + interrupt-names = "hc_irq", "pwr_irq"; > + bus-width = <4>; > + > + vdd-supply = <&pm8941_l21>; > + vdd-io-supply = <&pm8941_l13>; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&sdc2_clk &sdc2_cmd &sdc2_data>; > + > + clocks = <&gcc GCC_SDCC2_APPS_CLK>, <&gcc GCC_SDCC2_AHB_CLK>; > + clock-names = "core", "iface"; > + }; > -- > 1.7.9.5 >