From: Ulf Hansson <ulf.hansson@linaro.org>
To: yinbo.zhu@nxp.com
Cc: Adrian Hunter <adrian.hunter@intel.com>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
Yangbo Lu <yangbo.lu@nxp.com>
Subject: Re: [PATCH v2] mmc: sdhci-of-esdhc: fix eMMC couldn't work after kexec
Date: Mon, 27 Nov 2017 10:57:36 +0100 [thread overview]
Message-ID: <CAPDyKFpDyXrXWjkwx+X+z4orOs0iy7fgF=Jox5qBoGNbLT_jgQ@mail.gmail.com> (raw)
In-Reply-To: <20171108090950.4900-1-yinbo.zhu@nxp.com>
On 8 November 2017 at 10:09, <yinbo.zhu@nxp.com> wrote:
> From: "yinbo.zhu" <yinbo.zhu@nxp.com>
>
> The bit eSDHC_TBCTL[TB_EN] couldn't be reset by eSDHC_SYSCTL[RSTA] which is
> used to reset for all. The driver should make sure it's cleared before card
> initialization, otherwise the initialization would fail.
>
> Signed-off-by: yinbo.zhu <yinbo.zhu@nxp.com>
Thanks, applied for next!
Kind regards
Uffe
> ---
> Change in v2:
> Replace ESDHC_TB_DIS with default register bit ESDHC_TB_EN
>
> drivers/mmc/host/sdhci-of-esdhc.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/mmc/host/sdhci-of-esdhc.c b/drivers/mmc/host/sdhci-of-esdhc.c
> index d96a057a7db8..023c24bd0d94 100644
> --- a/drivers/mmc/host/sdhci-of-esdhc.c
> +++ b/drivers/mmc/host/sdhci-of-esdhc.c
> @@ -783,6 +783,10 @@ static void esdhc_init(struct platform_device *pdev, struct sdhci_host *host)
> pltfm_host = sdhci_priv(host);
> esdhc = sdhci_pltfm_priv(pltfm_host);
>
> + val = sdhci_readl(host, ESDHC_TBCTL);
> + val &= ~ESDHC_TB_EN;
> + sdhci_writel(host, val, ESDHC_TBCTL);
> +
> host_ver = sdhci_readw(host, SDHCI_HOST_VERSION);
> esdhc->vendor_ver = (host_ver & SDHCI_VENDOR_VER_MASK) >>
> SDHCI_VENDOR_VER_SHIFT;
> --
> 2.14.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2017-11-27 9:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-08 9:09 [PATCH v2] mmc: sdhci-of-esdhc: fix eMMC couldn't work after kexec yinbo.zhu
2017-11-22 8:29 ` Adrian Hunter
2017-11-27 9:57 ` Ulf Hansson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPDyKFpDyXrXWjkwx+X+z4orOs0iy7fgF=Jox5qBoGNbLT_jgQ@mail.gmail.com' \
--to=ulf.hansson@linaro.org \
--cc=adrian.hunter@intel.com \
--cc=linux-mmc@vger.kernel.org \
--cc=yangbo.lu@nxp.com \
--cc=yinbo.zhu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.