From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDC05C43141 for ; Thu, 14 Nov 2019 14:11:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 98DB220723 for ; Thu, 14 Nov 2019 14:11:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Zxy9Va/g" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727211AbfKNOLu (ORCPT ); Thu, 14 Nov 2019 09:11:50 -0500 Received: from mail-vk1-f193.google.com ([209.85.221.193]:36858 "EHLO mail-vk1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727178AbfKNOLt (ORCPT ); Thu, 14 Nov 2019 09:11:49 -0500 Received: by mail-vk1-f193.google.com with SMTP id d10so1502367vke.3 for ; Thu, 14 Nov 2019 06:11:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=XSmwLWNo5Rh6fe+p8Uu7DFNnAFhXmFiTvhxWz1V+B8w=; b=Zxy9Va/g5HeujT0G/Yr81ssNa+Mrn59GATo64imHO5v4yPYwyPPGs095S9yLGHZZct 1hxeTUWiuBZWvi+O1vf0npeqW5PjS6EDcNVV/BuKq+FHtrEOxZldeFAkfves+9/Zc/nA Jfl+7lufr0kMeZAOu4jE2erwkVZzPMxG8lpE6MQdIaqDuXXS5sdJm3+y9FiWm52EK2l3 WwyGBsnQjzhGRAggZDE4omJqyKpHbyv37Af0YKrpFhQbUSYZTgpsAw3qsoRhd/fdwACE 5iSUjaPDvT/GCI+c4fijdDcGkjUJFX9Fldn0zizjgcTiajuBoo8z8CbjC/JqAxv7Pnw6 eStg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XSmwLWNo5Rh6fe+p8Uu7DFNnAFhXmFiTvhxWz1V+B8w=; b=kM7nYfgcw+vVU98/uTELPjtzKNwUHtnZ1NkNNgxbUZNlWEscvDp7nk3T1kDda4hJfz 1O3K9b6WRthWH8Pq2JL2KmOh0ficbg2niQhth9helj1bDUVwcdqMNeqtaga/Q2y3AJQd IMeAS0XsnkKu4Xc2OXevT1FcZToVG8KL+GwBt1ppg1sHgkKV1qXuJ2hywv/7lG/SUJCb ZZCut4c6UVrkaecabL9H/9ToOv4mkhAdY1/vOGktwwHGa6aVtgIkQ8yIVTRdh+q/HH0J c7xD1DV1/SJ7arxVpGGnEspXcrzmvWqljSHdUJGVSMn1kKWKjrYOEKm8CUOhs4Z3p9iA UcxA== X-Gm-Message-State: APjAAAUWJAYb2T1WEtFqcheNZYcfxwEfv6bNfMLEZ+JzQ0faMgDNCmq8 awofy7JfICVb96gtXqvlrmcLm5SMBOkdBkKjh8OZ6g== X-Google-Smtp-Source: APXvYqxNH6tQ6y7J3OfkNA5oBwmBY5VTe296JKBsrF2xLv130hd/N0da6UeuSUpnmtRg4fw9qbywtQvMfesNLW0c7dc= X-Received: by 2002:a1f:2f51:: with SMTP id v78mr5258686vkv.101.1573740707355; Thu, 14 Nov 2019 06:11:47 -0800 (PST) MIME-Version: 1.0 References: <17b12e91c878dcb74160e3df5f88bc8a9e3f7fce.1573122644.git.hns@goldelico.com> In-Reply-To: <17b12e91c878dcb74160e3df5f88bc8a9e3f7fce.1573122644.git.hns@goldelico.com> From: Ulf Hansson Date: Thu, 14 Nov 2019 15:11:11 +0100 Message-ID: Subject: Re: [PATCH v3 01/12] Documentation: dt: wireless: update wl1251 for sdio To: "H. Nikolaus Schaller" Cc: =?UTF-8?Q?Beno=C3=AEt_Cousson?= , Tony Lindgren , Rob Herring , Mark Rutland , Russell King , Kalle Valo , Mike Rapoport , David Sterba , "Rafael J. Wysocki" , Petr Mladek , Sakari Ailus , Kefeng Wang , Yangtao Li , Alexios Zavras , Thomas Gleixner , Allison Randal , Greg Kroah-Hartman , John Stultz , Bjorn Helgaas , DTML , Discussions about the Letux Kernel , "linux-mmc@vger.kernel.org" , kernel@pyra-handheld.com, linux-wireless , Linux Kernel Mailing List , netdev , linux-omap , Linux ARM Content-Type: text/plain; charset="UTF-8" Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Thu, 7 Nov 2019 at 11:32, H. Nikolaus Schaller wrote: > > The standard method for sdio devices connected to > an sdio interface is to define them as a child node > like we can see with wlcore. > > Signed-off-by: H. Nikolaus Schaller > Acked-by: Kalle Valo > --- > .../bindings/net/wireless/ti,wl1251.txt | 26 +++++++++++++++++++ > 1 file changed, 26 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/wireless/ti,wl1251.txt b/Documentation/devicetree/bindings/net/wireless/ti,wl1251.txt > index bb2fcde6f7ff..f38950560982 100644 > --- a/Documentation/devicetree/bindings/net/wireless/ti,wl1251.txt > +++ b/Documentation/devicetree/bindings/net/wireless/ti,wl1251.txt > @@ -35,3 +35,29 @@ Examples: > ti,power-gpio = <&gpio3 23 GPIO_ACTIVE_HIGH>; /* 87 */ > }; > }; > + > +&mmc3 { > + vmmc-supply = <&wlan_en>; > + > + bus-width = <4>; > + non-removable; > + ti,non-removable; > + cap-power-off-card; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&mmc3_pins>; > + > + #address-cells = <1>; > + #size-cells = <0>; > + > + wlan: wifi@1 { > + compatible = "ti,wl1251"; > + > + reg = <1>; > + > + interrupt-parent = <&gpio1>; > + interrupts = <21 IRQ_TYPE_LEVEL_HIGH>; /* GPIO_21 */ > + > + ti,wl1251-has-eeprom; > + }; > +}; One minor thing, the "ti,power-gpio" is not required anymore, as it's not needed for the SDIO case for pandora. Please move it to an option section. Kind regards Uffe From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ulf Hansson Subject: Re: [PATCH v3 01/12] Documentation: dt: wireless: update wl1251 for sdio Date: Thu, 14 Nov 2019 15:11:11 +0100 Message-ID: References: <17b12e91c878dcb74160e3df5f88bc8a9e3f7fce.1573122644.git.hns@goldelico.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <17b12e91c878dcb74160e3df5f88bc8a9e3f7fce.1573122644.git.hns@goldelico.com> Sender: linux-kernel-owner@vger.kernel.org To: "H. Nikolaus Schaller" Cc: =?UTF-8?Q?Beno=C3=AEt_Cousson?= , Tony Lindgren , Rob Herring , Mark Rutland , Russell King , Kalle Valo , Mike Rapoport , David Sterba , "Rafael J. Wysocki" , Petr Mladek , Sakari Ailus , Kefeng Wang , Yangtao Li , Alexios Zavras , Thomas Gleixner , Allison Randal , Greg Kroah-Hartman , John Stultz , Bjorn Helgaas List-Id: linux-mmc@vger.kernel.org On Thu, 7 Nov 2019 at 11:32, H. Nikolaus Schaller wrote: > > The standard method for sdio devices connected to > an sdio interface is to define them as a child node > like we can see with wlcore. > > Signed-off-by: H. Nikolaus Schaller > Acked-by: Kalle Valo > --- > .../bindings/net/wireless/ti,wl1251.txt | 26 +++++++++++++++++++ > 1 file changed, 26 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/wireless/ti,wl1251.txt b/Documentation/devicetree/bindings/net/wireless/ti,wl1251.txt > index bb2fcde6f7ff..f38950560982 100644 > --- a/Documentation/devicetree/bindings/net/wireless/ti,wl1251.txt > +++ b/Documentation/devicetree/bindings/net/wireless/ti,wl1251.txt > @@ -35,3 +35,29 @@ Examples: > ti,power-gpio = <&gpio3 23 GPIO_ACTIVE_HIGH>; /* 87 */ > }; > }; > + > +&mmc3 { > + vmmc-supply = <&wlan_en>; > + > + bus-width = <4>; > + non-removable; > + ti,non-removable; > + cap-power-off-card; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&mmc3_pins>; > + > + #address-cells = <1>; > + #size-cells = <0>; > + > + wlan: wifi@1 { > + compatible = "ti,wl1251"; > + > + reg = <1>; > + > + interrupt-parent = <&gpio1>; > + interrupts = <21 IRQ_TYPE_LEVEL_HIGH>; /* GPIO_21 */ > + > + ti,wl1251-has-eeprom; > + }; > +}; One minor thing, the "ti,power-gpio" is not required anymore, as it's not needed for the SDIO case for pandora. Please move it to an option section. Kind regards Uffe From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7089FC432C3 for ; Thu, 14 Nov 2019 14:11:54 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4857C20715 for ; Thu, 14 Nov 2019 14:11:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="sP3WcHZd"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Zxy9Va/g" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4857C20715 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AAVvGt21IpHgCGrw37uBttsNcHr3JdcIQzQ5GI5EC6E=; b=sP3WcHZdxvISaE 04vsdYjYV4at41CmB9YTmS6p1yT58wKoP0wC+U1MHqycSdpgNi7U4gvgUWX86V/OUrpEqEpewR7vg ysOjC30ZoARfpKVy5stOfStpbDp+9Bfju7LdSp4KZDSCjid7RXlx4ioh4i3lmdtrkc4InS62Drvqd X0XN2JWDTJORgRLYiqh+MtHh3CVK1O2/lEwP5UD8ZqgncY/SYglEZZdkxflZyM7fz9prTVNQ7ODGu kFScGysytok7P+KFueI1ALCQrT3beHa2IVL+eBCRfpFFlDLe6YG7g4y+OPRnuB/NfO++LTUxbZCxy jO3tYR0IkJBjJCeLMyUg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iVFqj-0003S8-Nc; Thu, 14 Nov 2019 14:11:53 +0000 Received: from mail-vk1-xa42.google.com ([2607:f8b0:4864:20::a42]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iVFqg-0003R4-JR for linux-arm-kernel@lists.infradead.org; Thu, 14 Nov 2019 14:11:51 +0000 Received: by mail-vk1-xa42.google.com with SMTP id e205so1495097vke.2 for ; Thu, 14 Nov 2019 06:11:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=XSmwLWNo5Rh6fe+p8Uu7DFNnAFhXmFiTvhxWz1V+B8w=; b=Zxy9Va/g5HeujT0G/Yr81ssNa+Mrn59GATo64imHO5v4yPYwyPPGs095S9yLGHZZct 1hxeTUWiuBZWvi+O1vf0npeqW5PjS6EDcNVV/BuKq+FHtrEOxZldeFAkfves+9/Zc/nA Jfl+7lufr0kMeZAOu4jE2erwkVZzPMxG8lpE6MQdIaqDuXXS5sdJm3+y9FiWm52EK2l3 WwyGBsnQjzhGRAggZDE4omJqyKpHbyv37Af0YKrpFhQbUSYZTgpsAw3qsoRhd/fdwACE 5iSUjaPDvT/GCI+c4fijdDcGkjUJFX9Fldn0zizjgcTiajuBoo8z8CbjC/JqAxv7Pnw6 eStg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XSmwLWNo5Rh6fe+p8Uu7DFNnAFhXmFiTvhxWz1V+B8w=; b=GPBUe/kHVCzkw1cd6oKRbybxa12c1rAO8W/BcXPWItIm/Zg3z2aGp9iMLgfeqOXTna g94jrxffxLQqZsHF17w9JHdoPy11OypLVBOtOw7PH356q4O+B+Nrgw0RJBc9xhtTulje E0wxgKKc4+amYWzhz4L2oW+eLbz5j23zxqvqhsIYw0Y9S/3Y9rnaOEaNtuVb1YPEXhEC M/Y7jnSDx87QWgTEfM8IVyK8uI5HnWrCE8e/z9tm7kg7ggPOtUIy+Gnc6QLgJPMsMceA keq5FxdSoEeyKaND4CGqHiEiUtiR85z0ejowlrfegJC1bk7fqAOPNL32MhCG5zcHwVGm vXWQ== X-Gm-Message-State: APjAAAW2lgHTNB763p+7jU5JBCd9h0aNg7hqjVbxIj4AUPoiYK0HE7bS Ao5WdzUB9yHNKPrvaJAFS9WqUXiJH4aKrHc5DorOov34xL8= X-Google-Smtp-Source: APXvYqxNH6tQ6y7J3OfkNA5oBwmBY5VTe296JKBsrF2xLv130hd/N0da6UeuSUpnmtRg4fw9qbywtQvMfesNLW0c7dc= X-Received: by 2002:a1f:2f51:: with SMTP id v78mr5258686vkv.101.1573740707355; Thu, 14 Nov 2019 06:11:47 -0800 (PST) MIME-Version: 1.0 References: <17b12e91c878dcb74160e3df5f88bc8a9e3f7fce.1573122644.git.hns@goldelico.com> In-Reply-To: <17b12e91c878dcb74160e3df5f88bc8a9e3f7fce.1573122644.git.hns@goldelico.com> From: Ulf Hansson Date: Thu, 14 Nov 2019 15:11:11 +0100 Message-ID: Subject: Re: [PATCH v3 01/12] Documentation: dt: wireless: update wl1251 for sdio To: "H. Nikolaus Schaller" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191114_061150_669670_1B2BCF6D X-CRM114-Status: GOOD ( 16.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Kefeng Wang , DTML , Tony Lindgren , linux-wireless , Bjorn Helgaas , netdev , linux-omap , "Rafael J. Wysocki" , Russell King , Mike Rapoport , Yangtao Li , Kalle Valo , Petr Mladek , =?UTF-8?Q?Beno=C3=AEt_Cousson?= , Alexios Zavras , Rob Herring , John Stultz , David Sterba , Thomas Gleixner , Discussions about the Letux Kernel , Allison Randal , Linux ARM , Greg Kroah-Hartman , "linux-mmc@vger.kernel.org" , Linux Kernel Mailing List , Sakari Ailus , kernel@pyra-handheld.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 7 Nov 2019 at 11:32, H. Nikolaus Schaller wrote: > > The standard method for sdio devices connected to > an sdio interface is to define them as a child node > like we can see with wlcore. > > Signed-off-by: H. Nikolaus Schaller > Acked-by: Kalle Valo > --- > .../bindings/net/wireless/ti,wl1251.txt | 26 +++++++++++++++++++ > 1 file changed, 26 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/wireless/ti,wl1251.txt b/Documentation/devicetree/bindings/net/wireless/ti,wl1251.txt > index bb2fcde6f7ff..f38950560982 100644 > --- a/Documentation/devicetree/bindings/net/wireless/ti,wl1251.txt > +++ b/Documentation/devicetree/bindings/net/wireless/ti,wl1251.txt > @@ -35,3 +35,29 @@ Examples: > ti,power-gpio = <&gpio3 23 GPIO_ACTIVE_HIGH>; /* 87 */ > }; > }; > + > +&mmc3 { > + vmmc-supply = <&wlan_en>; > + > + bus-width = <4>; > + non-removable; > + ti,non-removable; > + cap-power-off-card; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&mmc3_pins>; > + > + #address-cells = <1>; > + #size-cells = <0>; > + > + wlan: wifi@1 { > + compatible = "ti,wl1251"; > + > + reg = <1>; > + > + interrupt-parent = <&gpio1>; > + interrupts = <21 IRQ_TYPE_LEVEL_HIGH>; /* GPIO_21 */ > + > + ti,wl1251-has-eeprom; > + }; > +}; One minor thing, the "ti,power-gpio" is not required anymore, as it's not needed for the SDIO case for pandora. Please move it to an option section. Kind regards Uffe _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel