From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0151DC43387 for ; Mon, 14 Jan 2019 11:44:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B6DE32086D for ; Mon, 14 Jan 2019 11:44:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linaro.org header.i=@linaro.org header.b="WqppQ9oc" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726600AbfANLov (ORCPT ); Mon, 14 Jan 2019 06:44:51 -0500 Received: from mail-vs1-f67.google.com ([209.85.217.67]:39355 "EHLO mail-vs1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726449AbfANLov (ORCPT ); Mon, 14 Jan 2019 06:44:51 -0500 Received: by mail-vs1-f67.google.com with SMTP id h78so13412123vsi.6 for ; Mon, 14 Jan 2019 03:44:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=M/GPN+W9Qm4l4qSG23KM57QgLaYUka4/vuAsghNSZKo=; b=WqppQ9oc9PRCbFjudLIsWw52Z9zZuUMg2NE6HKMpZlp35adFYLGJH3qRhIT9GMvbu8 VxTdX3aSr3Wd8cO3AObh25lezopyvizEiwO3OM0kcr+Mt3EKBFyoDW46LQZ9NeKgjAgL /CXyB52bstBXMbKVN/PZFKklqdp5KJDxVLpX4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=M/GPN+W9Qm4l4qSG23KM57QgLaYUka4/vuAsghNSZKo=; b=QSl7AnGGvChIl/59lx7NGk3f86W6L05Hkn6IcNstlJWjHQ7CdNxSk6rGgUgQK+FVYT JCDBNIF7J60Nn8TZNxTAKs287T79jSFZq65cIcdioapB1zsBwT4fkM2sbprVgx5OMmtd rwh3vN87t4CecoT9/LBcbSSYdC838uOgaR+ArRlKgbdz80fBVpg6a1Q3oL9PRPrJK7G/ 0EKPfibazJaQ/5Us5lcnLoNNIFC7l1ofCH8vMdFIOZNURN/HcKcQbDVIJU8SIoUe7FMp JWRD5Yn6SYuublKVyC2iQCrPC5Aj8aSPk8Z/wJITEJ1ki+o1D9OlBs9F3No13ZjY+9lr Lyzw== X-Gm-Message-State: AJcUukdctmfm9HU6PHlzh3gh0GH9OK1jMDcYYGJ3CBobGImxOvH/n1mR hEGLJUdA5pgeaPMojVQPF8x1po88hZ8in59KjVEUzA== X-Google-Smtp-Source: ALg8bN4eNqx2LADCv6Dw5FDN+8PUvTOGH0Tw5MpFdGuSZed684aWORE2jHaV4TRPRDK8n58R+v9Hhzn5sScRScXOMXU= X-Received: by 2002:a67:74c2:: with SMTP id p185mr3841665vsc.34.1547466290098; Mon, 14 Jan 2019 03:44:50 -0800 (PST) MIME-Version: 1.0 References: <1545598758-4502-1-git-send-email-stefan.wahren@i2se.com> In-Reply-To: <1545598758-4502-1-git-send-email-stefan.wahren@i2se.com> From: Ulf Hansson Date: Mon, 14 Jan 2019 12:44:14 +0100 Message-ID: Subject: Re: [PATCH 1/2] mmc: sdhci-iproc: handle mmc_of_parse() errors during probe To: Stefan Wahren Cc: Al Cooper , Adrian Hunter , Brian Norris , Gregory Fong , Florian Fainelli , Ray Jui , Scott Branden , Eric Anholt , BCM Kernel Feedback , "linux-mmc@vger.kernel.org" , Linux ARM , "# 4.0+" Content-Type: text/plain; charset="UTF-8" Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Sun, 23 Dec 2018 at 22:00, Stefan Wahren wrote: > > We need to handle mmc_of_parse() errors during probe. > > This finally fixes the wifi regression on Raspberry Pi 3 series. > In error case the wifi chip was permanently in reset because of > the power sequence depending on the deferred probe of the GPIO expander. > > Fixes: b580c52d58d9 ("mmc: sdhci-iproc: add IPROC SDHCI driver") > Cc: stable@vger.kernel.org > Signed-off-by: Stefan Wahren Applied for next, thanks! Kind regards Uffe > --- > drivers/mmc/host/sdhci-iproc.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/sdhci-iproc.c b/drivers/mmc/host/sdhci-iproc.c > index 0db9905..9d12c06 100644 > --- a/drivers/mmc/host/sdhci-iproc.c > +++ b/drivers/mmc/host/sdhci-iproc.c > @@ -296,7 +296,10 @@ static int sdhci_iproc_probe(struct platform_device *pdev) > > iproc_host->data = iproc_data; > > - mmc_of_parse(host->mmc); > + ret = mmc_of_parse(host->mmc); > + if (ret) > + goto err; > + > sdhci_get_property(pdev); > > host->mmc->caps |= iproc_host->data->mmc_caps; > -- > 2.7.4 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E935CC43387 for ; Mon, 14 Jan 2019 11:45:15 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BBD1020659 for ; Mon, 14 Jan 2019 11:45:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="nVsIQFFN"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=linaro.org header.i=@linaro.org header.b="WqppQ9oc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BBD1020659 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KeuWPDkRQaAehCWSSf8WVZ+/I+SEvoGeze4Y1gqM4Tk=; b=nVsIQFFNs2nUA1 iKhb6pTaunuRnEgeKuTzH5HeCQXvxnOcf5cd63R0B8kmIO93iSGrMdav9cpGd9/2LH/EMKtVcQUiO REriYEjK7+lRKXrky0aKiFNwrkk2aFL0Dl5XXeanQwY552/AE+K8uvhwhzc7cLij1fsjreXxgYw6Z xsaxpzkCyJ8nsfEFaKo/fEcgzo0+RWT3duuQaJoEVRDZbVd0AkaRfCL7dbKMXWlyz1qAeLea/T1mp z6v+oBQ/OO+cBRVPRZoUHF6XUbqRiw7ql7BgvSv4aOfg0bTd5IHHxG8D0OGhQq+KXsJW+dc9+fkxH iedb1Z5R86zDDmCPADug==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gj0g3-0003L3-GJ; Mon, 14 Jan 2019 11:45:11 +0000 Received: from mail-vs1-xe42.google.com ([2607:f8b0:4864:20::e42]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gj0fj-0002Yw-HC for linux-arm-kernel@lists.infradead.org; Mon, 14 Jan 2019 11:45:06 +0000 Received: by mail-vs1-xe42.google.com with SMTP id y27so13454570vsi.1 for ; Mon, 14 Jan 2019 03:44:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=M/GPN+W9Qm4l4qSG23KM57QgLaYUka4/vuAsghNSZKo=; b=WqppQ9oc9PRCbFjudLIsWw52Z9zZuUMg2NE6HKMpZlp35adFYLGJH3qRhIT9GMvbu8 VxTdX3aSr3Wd8cO3AObh25lezopyvizEiwO3OM0kcr+Mt3EKBFyoDW46LQZ9NeKgjAgL /CXyB52bstBXMbKVN/PZFKklqdp5KJDxVLpX4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=M/GPN+W9Qm4l4qSG23KM57QgLaYUka4/vuAsghNSZKo=; b=Ti6Uc4UvRq2iYDIj8UT48vRrFIl15dc9BFQXsK49c7wdF9tbiXgPsYjL+YmQh1yvEJ /dtunPDrKBxJ06scOoNqIZyJjSjaTk4A1Df0Fz2BxvghvaE/TN3TJdu5sC+8xiIeEc9n EpO7zQ0boI/DNf95fbvIByJ7F3mo96BQiBlDe6OinarymDT2KtvmlgzI5zxdWiaWXcKq ihAUvR8xqR8Qz+N/S4AFTADbXl8hEp7rtsFC6GtQl1HPu72u3xhvJluOqrnQUalYU+PD HjgDeTQhPCM+qQ3EBgWDQrZSZBJaeUs4aXA3B8dLn8ysiVtQQAoUFEhXhRG72MkEgz9E jj/A== X-Gm-Message-State: AJcUukdsCJ2aFUHCqbeRay4+U0ipPDLcoTw4rvP1UCqzC9noVtlN839p 6ZqbffhGcs0Td6hYdGQwJjeKA5U2Wb6q7GUK9DW/3p4GLWk= X-Google-Smtp-Source: ALg8bN4eNqx2LADCv6Dw5FDN+8PUvTOGH0Tw5MpFdGuSZed684aWORE2jHaV4TRPRDK8n58R+v9Hhzn5sScRScXOMXU= X-Received: by 2002:a67:74c2:: with SMTP id p185mr3841665vsc.34.1547466290098; Mon, 14 Jan 2019 03:44:50 -0800 (PST) MIME-Version: 1.0 References: <1545598758-4502-1-git-send-email-stefan.wahren@i2se.com> In-Reply-To: <1545598758-4502-1-git-send-email-stefan.wahren@i2se.com> From: Ulf Hansson Date: Mon, 14 Jan 2019 12:44:14 +0100 Message-ID: Subject: Re: [PATCH 1/2] mmc: sdhci-iproc: handle mmc_of_parse() errors during probe To: Stefan Wahren X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190114_034451_989854_3AF921C8 X-CRM114-Status: GOOD ( 17.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Florian Fainelli , Scott Branden , Ray Jui , Al Cooper , "linux-mmc@vger.kernel.org" , Adrian Hunter , "# 4.0+" , Eric Anholt , BCM Kernel Feedback , Gregory Fong , Brian Norris , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, 23 Dec 2018 at 22:00, Stefan Wahren wrote: > > We need to handle mmc_of_parse() errors during probe. > > This finally fixes the wifi regression on Raspberry Pi 3 series. > In error case the wifi chip was permanently in reset because of > the power sequence depending on the deferred probe of the GPIO expander. > > Fixes: b580c52d58d9 ("mmc: sdhci-iproc: add IPROC SDHCI driver") > Cc: stable@vger.kernel.org > Signed-off-by: Stefan Wahren Applied for next, thanks! Kind regards Uffe > --- > drivers/mmc/host/sdhci-iproc.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/sdhci-iproc.c b/drivers/mmc/host/sdhci-iproc.c > index 0db9905..9d12c06 100644 > --- a/drivers/mmc/host/sdhci-iproc.c > +++ b/drivers/mmc/host/sdhci-iproc.c > @@ -296,7 +296,10 @@ static int sdhci_iproc_probe(struct platform_device *pdev) > > iproc_host->data = iproc_data; > > - mmc_of_parse(host->mmc); > + ret = mmc_of_parse(host->mmc); > + if (ret) > + goto err; > + > sdhci_get_property(pdev); > > host->mmc->caps |= iproc_host->data->mmc_caps; > -- > 2.7.4 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel