From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754439AbbCMKPs (ORCPT ); Fri, 13 Mar 2015 06:15:48 -0400 Received: from mail-qc0-f176.google.com ([209.85.216.176]:39824 "EHLO mail-qc0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753986AbbCMKPo (ORCPT ); Fri, 13 Mar 2015 06:15:44 -0400 MIME-Version: 1.0 In-Reply-To: <20150313011101.GA24853@dtor-ws> References: <20150313011101.GA24853@dtor-ws> Date: Fri, 13 Mar 2015 11:15:44 +0100 Message-ID: Subject: Re: [PATCH] mmc: sdhci-iproc: fix oops in sdhci_iproc_writew From: Ulf Hansson To: Dmitry Torokhov Cc: Chris Ball , Ray Jui , Scott Branden , Corneliu Doban , linux-mmc , "linux-arm-kernel@lists.infradead.org" , bcm-kernel-feedback-list@broadcom.com, "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13 March 2015 at 02:11, Dmitry Torokhov wrote: > The driver co-allocates sdhci_iproc_host with sdhci_pltfm_host and so to > access it we need to use sdhci_pltfm_priv() and not pltfm_host->priv. > > Signed-off-by: Dmitry Torokhov Thanks, applied! Kind regards Uffe > --- > drivers/mmc/host/sdhci-iproc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/sdhci-iproc.c b/drivers/mmc/host/sdhci-iproc.c > index 4139d34..3b423b0 100644 > --- a/drivers/mmc/host/sdhci-iproc.c > +++ b/drivers/mmc/host/sdhci-iproc.c > @@ -97,7 +97,7 @@ static inline void sdhci_iproc_writel(struct sdhci_host *host, u32 val, int reg) > static void sdhci_iproc_writew(struct sdhci_host *host, u16 val, int reg) > { > struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host); > - struct sdhci_iproc_host *iproc_host = pltfm_host->priv; > + struct sdhci_iproc_host *iproc_host = sdhci_pltfm_priv(pltfm_host); > u32 word_shift = REG_OFFSET_IN_BITS(reg); > u32 mask = 0xffff << word_shift; > u32 oldval, newval; > -- > 2.2.0.rc0.207.ga3a616c > > > -- > Dmitry From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ulf Hansson Subject: Re: [PATCH] mmc: sdhci-iproc: fix oops in sdhci_iproc_writew Date: Fri, 13 Mar 2015 11:15:44 +0100 Message-ID: References: <20150313011101.GA24853@dtor-ws> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <20150313011101.GA24853@dtor-ws> Sender: linux-kernel-owner@vger.kernel.org To: Dmitry Torokhov Cc: Chris Ball , Ray Jui , Scott Branden , Corneliu Doban , linux-mmc , "linux-arm-kernel@lists.infradead.org" , bcm-kernel-feedback-list@broadcom.com, "linux-kernel@vger.kernel.org" List-Id: linux-mmc@vger.kernel.org On 13 March 2015 at 02:11, Dmitry Torokhov wrote: > The driver co-allocates sdhci_iproc_host with sdhci_pltfm_host and so to > access it we need to use sdhci_pltfm_priv() and not pltfm_host->priv. > > Signed-off-by: Dmitry Torokhov Thanks, applied! Kind regards Uffe > --- > drivers/mmc/host/sdhci-iproc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/sdhci-iproc.c b/drivers/mmc/host/sdhci-iproc.c > index 4139d34..3b423b0 100644 > --- a/drivers/mmc/host/sdhci-iproc.c > +++ b/drivers/mmc/host/sdhci-iproc.c > @@ -97,7 +97,7 @@ static inline void sdhci_iproc_writel(struct sdhci_host *host, u32 val, int reg) > static void sdhci_iproc_writew(struct sdhci_host *host, u16 val, int reg) > { > struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host); > - struct sdhci_iproc_host *iproc_host = pltfm_host->priv; > + struct sdhci_iproc_host *iproc_host = sdhci_pltfm_priv(pltfm_host); > u32 word_shift = REG_OFFSET_IN_BITS(reg); > u32 mask = 0xffff << word_shift; > u32 oldval, newval; > -- > 2.2.0.rc0.207.ga3a616c > > > -- > Dmitry From mboxrd@z Thu Jan 1 00:00:00 1970 From: ulf.hansson@linaro.org (Ulf Hansson) Date: Fri, 13 Mar 2015 11:15:44 +0100 Subject: [PATCH] mmc: sdhci-iproc: fix oops in sdhci_iproc_writew In-Reply-To: <20150313011101.GA24853@dtor-ws> References: <20150313011101.GA24853@dtor-ws> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 13 March 2015 at 02:11, Dmitry Torokhov wrote: > The driver co-allocates sdhci_iproc_host with sdhci_pltfm_host and so to > access it we need to use sdhci_pltfm_priv() and not pltfm_host->priv. > > Signed-off-by: Dmitry Torokhov Thanks, applied! Kind regards Uffe > --- > drivers/mmc/host/sdhci-iproc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/sdhci-iproc.c b/drivers/mmc/host/sdhci-iproc.c > index 4139d34..3b423b0 100644 > --- a/drivers/mmc/host/sdhci-iproc.c > +++ b/drivers/mmc/host/sdhci-iproc.c > @@ -97,7 +97,7 @@ static inline void sdhci_iproc_writel(struct sdhci_host *host, u32 val, int reg) > static void sdhci_iproc_writew(struct sdhci_host *host, u16 val, int reg) > { > struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host); > - struct sdhci_iproc_host *iproc_host = pltfm_host->priv; > + struct sdhci_iproc_host *iproc_host = sdhci_pltfm_priv(pltfm_host); > u32 word_shift = REG_OFFSET_IN_BITS(reg); > u32 mask = 0xffff << word_shift; > u32 oldval, newval; > -- > 2.2.0.rc0.207.ga3a616c > > > -- > Dmitry