From: Ulf Hansson <ulf.hansson@linaro.org>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
Ulrich Hecht <uli+renesas@fpond.eu>,
Simon Horman <horms+renesas@verge.net.au>,
Niklas Soderlund <niklas.soderlund@ragnatech.se>
Subject: Re: [PATCH 2/2] mmc: tmio: Make sure the PM domain is 'started' while probing
Date: Tue, 19 May 2020 15:54:45 +0200 [thread overview]
Message-ID: <CAPDyKFpepDt5SyqLJ9-3HfutiW9TSP_jLg8zmqLn-O6LAy+RYQ@mail.gmail.com> (raw)
In-Reply-To: <20200519113545.GK1094@ninjato>
On Tue, 19 May 2020 at 13:35, Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
>
>
> > This means dev_pm_domain_start() is needed only for the SDHI renesas
> > variants. But on the other hand, it doesn't hurt for the others (the
> > uniphier-sd variant doesn't even use runtime PM as confirmed by
> > Yamada-san).
> >
> > I don't have a strong opinion, but it looks like we can either apply
> > $subject patch as is, or modify it to make dev_pm_domain_start() be
> > called only for the SDHI renesas variants.
> >
> > What do you prefer?
>
> Dealing with PM is confusing often enough. To keep it simple, I'd
> suggest to avoid unneeded calls. It may take a while later to rediscover
> if this call is essential or not. So, for the uniphier case, we know it
> is not needed. If we agree on a best effort basis that it is also not
> needed for tmio_mmc, then I think we should keep it only for Renesas
> SDHI.
Alright, I re-spin the series taking into account what has been said.
Then I wait for your tested/reviewed-by tags before applying.
Kind regards
Uffe
next prev parent reply other threads:[~2020-05-19 13:55 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-15 14:04 [PATCH 2/2] mmc: tmio: Make sure the PM domain is 'started' while probing Ulf Hansson
2020-05-18 20:22 ` Wolfram Sang
2020-05-19 7:50 ` Ulf Hansson
2020-05-19 8:46 ` Wolfram Sang
2020-05-19 8:53 ` Geert Uytterhoeven
2020-05-19 9:09 ` Wolfram Sang
2020-05-19 9:15 ` Ulf Hansson
2020-05-19 9:21 ` Ulf Hansson
2020-05-19 11:32 ` Wolfram Sang
2020-05-19 11:35 ` Wolfram Sang
2020-05-19 13:54 ` Ulf Hansson [this message]
2020-05-18 21:07 ` Geert Uytterhoeven
2020-05-19 8:18 ` Ulf Hansson
2020-05-19 8:29 ` Geert Uytterhoeven
2020-05-19 15:24 Ulf Hansson
2020-05-19 16:38 ` Wolfram Sang
2020-05-20 11:35 ` Ulf Hansson
2020-05-20 15:57 ` Geert Uytterhoeven
2020-05-20 16:11 ` Ulf Hansson
2020-05-20 17:42 ` Geert Uytterhoeven
2020-05-25 8:47 ` Ulf Hansson
2020-05-25 10:04 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPDyKFpepDt5SyqLJ9-3HfutiW9TSP_jLg8zmqLn-O6LAy+RYQ@mail.gmail.com \
--to=ulf.hansson@linaro.org \
--cc=geert@linux-m68k.org \
--cc=horms+renesas@verge.net.au \
--cc=linux-mmc@vger.kernel.org \
--cc=niklas.soderlund@ragnatech.se \
--cc=uli+renesas@fpond.eu \
--cc=wsa+renesas@sang-engineering.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.