From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86078C64E8A for ; Wed, 2 Dec 2020 14:11:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 30E1B221FA for ; Wed, 2 Dec 2020 14:11:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730165AbgLBOLX (ORCPT ); Wed, 2 Dec 2020 09:11:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39798 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729010AbgLBOLV (ORCPT ); Wed, 2 Dec 2020 09:11:21 -0500 Received: from mail-vs1-xe44.google.com (mail-vs1-xe44.google.com [IPv6:2607:f8b0:4864:20::e44]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C5F6AC0613CF for ; Wed, 2 Dec 2020 06:10:41 -0800 (PST) Received: by mail-vs1-xe44.google.com with SMTP id s85so152701vsc.3 for ; Wed, 02 Dec 2020 06:10:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Mi0N0NrtTfBp9SWKp7UeI7dL3VImNOs9+9L6eye9hMQ=; b=W5oi9bpnNacowsGe3g8WKzDbPxaVWK9Z6vjkhAlOtlMPfb4rzlnYJC8bQ1l5578EsP S1aNNlXgKQid/xF3zn87Yo57ohKtT7y8DUprvmREt5P2TODCiKWQB1/26li/tMQg2Lrf t/TJUCP/wrB8UpapxRhLFEeL9qHit4ESoWwZANRQkQBXmdp8tv0DNMgbkIVrJJ1ueE/6 aOenXyN+I2SnzHTtD0CRIDBEZf2NVqgnE6OIr+fLPv/TV9oldt02l1EATBRN3sNJYENh wFW+RwvataYIyNNQdbAxxSi8p5WMhNhWKBfTAkK5V/MKLbVFUwkOPpYx9dYiSTg+onbc Bqlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Mi0N0NrtTfBp9SWKp7UeI7dL3VImNOs9+9L6eye9hMQ=; b=Iu5fKFo7B/Aa4gYG+ek3+LfM1QYn6THn0nFOQ+m4eoRHHXL9TCMznkv43khcGBIQbz JKgKyPNe3C+S56mOeTaKjFV9bDeIwuLUqDe5EkaSw+4J+Ka6ET7gnfb2gRj5X1iqxyCx DTCoBrt3092w2Ui+K48R5fzCMbaDR0c6pIWCuJCJUvmx1q2GAe0Q8jdJ0IgGmqSC7p1F 3eHb0ob9PKEUh+IJMJsZ8l2jRUPNOHZtTPzZ9puMfg4PgsNHhb2reAAx58BAPN+4PO7R 7iT0ahwyWIimla6EOfxClUJOADgr1l/YyjWOpOQGnKxpZTeU4sxg1dea+HSLtaYot0O0 LXtg== X-Gm-Message-State: AOAM532bIuthGSAH080vmKUlb6SQEfspvS8cIszuGkZrxk8DzFsLZHjF POYN2aCvlwVAkI+TqfMfO6QEYuW7vb6tji3kMsf3ng== X-Google-Smtp-Source: ABdhPJw/WYc6FSbQLQIS3Efz1BJ3ypbPM9RtpcceJn07dNrX8Y+SBVFSagPCAp/cDLteavR5bRg9b8mXBmYfeHhTq+U= X-Received: by 2002:a67:8c44:: with SMTP id o65mr1471722vsd.55.1606918240884; Wed, 02 Dec 2020 06:10:40 -0800 (PST) MIME-Version: 1.0 References: <20201202150205.20150-1-muhammad.husaini.zulkifli@intel.com> <20201202122520.GD4077@smile.fi.intel.com> In-Reply-To: From: Ulf Hansson Date: Wed, 2 Dec 2020 15:10:04 +0100 Message-ID: Subject: Re: [PATCH v6 0/4] mmc: sdhci-of-arasan: Enable UHS-1 support for Keem Bay SOC To: Andy Shevchenko Cc: "Shevchenko, Andriy" , Linus Walleij , "Zulkifli, Muhammad Husaini" , Adrian Hunter , Michal Simek , "linux-mmc@vger.kernel.org" , Linux ARM , Linux Kernel Mailing List , "Raja Subramanian, Lakshmi Bai" , Wan Ahmad Zainie , Mark Gross Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2 Dec 2020 at 14:09, Andy Shevchenko wrote: > > On Wed, Dec 2, 2020 at 2:44 PM Ulf Hansson wrote: > > On Wed, 2 Dec 2020 at 13:24, Shevchenko, Andriy > > wrote: > > > On Wed, Dec 02, 2020 at 11:53:42AM +0100, Ulf Hansson wrote: > > > > On Wed, 2 Dec 2020 at 08:02, wrote: > > > > > > ... > > > > > > > > Kindly help to review this patch set. > > > > > > > > This version looks a lot better to me, but I am still requesting you > > > > to model the pinctrl correctly. I don't see a reason not to, but I may > > > > have overlooked some things. > > > > > > I'm wondering why we need to mock up a pin control from something which has no > > > pin control interface. It's rather communication with firmware that does pin > > > control under the hood, but it also may be different hardware in the other / > > > future generations. Would you accept mocking up the same calls over the kernel > > > as pin control, as something else? > > > > Well, my point is that modeling this a pinctrl would keep the mmc > > driver portable. Additionally, it's very common to manage pinctrls in > > mmc drivers, so it's not like this is an entirely new thing that I > > propose. > > > > If/when it turns out that there is a new HW having a different pinctrl > > interface, it would just mean that we need a new pinctrl driver, but > > can leave the mmc driver as is. > > My point is that it may be *not* a pin control at all. Sorry, but I don't quite follow, what is *not* a pinctrl? According to the information I have received from the previous discussions [1], it's clear to me that the ARM SMC call ends up changing settings for the I/O-pads. Or did I get that wrong? > And in that case you will need to mock up (what exactly?) and update > the MMC driver. > > -- > With Best Regards, > Andy Shevchenko Kind regards Uffe [1] https://lkml.org/lkml/2020/10/8/320 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 954E8C64E7B for ; Wed, 2 Dec 2020 14:12:14 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2575E22249 for ; Wed, 2 Dec 2020 14:12:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2575E22249 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=sWkehKEzC0B7Fs+z0a9TwC9qGWJuikvrhhiVAnClXPI=; b=x03wqrTqMmG8QME5XMW+qKuHi rZlTRWkoerDYY59NvWxLseV/6vISvtUDVvpEPVVQVQHoQnMWqNzdKYXrJw7Vi0xtTsKdK8qGPCL8p noZogaHCzXDntK5fP6IoDPFTW86xi7EFa/n1CJXatI9UzAGjZwAxdoByWA0BJseWn2u2SCVIwvK+z G/zgO/6yKMWCyCjvbfQn6DoBmrkjkP8MsTXflae3MYEX4SwkR5KK/kd71RTm0lmtHeyE49OBr8gES ZKZMBqssQBslM4lz6YjaoAuoGecZvoQHTEBKu6JJ4W3uNave7PpHQHoqOChreNvsWkt43NqqfslVs jS4IrdzBw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kkSqJ-00019T-Ok; Wed, 02 Dec 2020 14:10:51 +0000 Received: from mail-vs1-xe42.google.com ([2607:f8b0:4864:20::e42]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kkSqB-00014q-FH for linux-arm-kernel@lists.infradead.org; Wed, 02 Dec 2020 14:10:45 +0000 Received: by mail-vs1-xe42.google.com with SMTP id x26so982933vsq.1 for ; Wed, 02 Dec 2020 06:10:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Mi0N0NrtTfBp9SWKp7UeI7dL3VImNOs9+9L6eye9hMQ=; b=W5oi9bpnNacowsGe3g8WKzDbPxaVWK9Z6vjkhAlOtlMPfb4rzlnYJC8bQ1l5578EsP S1aNNlXgKQid/xF3zn87Yo57ohKtT7y8DUprvmREt5P2TODCiKWQB1/26li/tMQg2Lrf t/TJUCP/wrB8UpapxRhLFEeL9qHit4ESoWwZANRQkQBXmdp8tv0DNMgbkIVrJJ1ueE/6 aOenXyN+I2SnzHTtD0CRIDBEZf2NVqgnE6OIr+fLPv/TV9oldt02l1EATBRN3sNJYENh wFW+RwvataYIyNNQdbAxxSi8p5WMhNhWKBfTAkK5V/MKLbVFUwkOPpYx9dYiSTg+onbc Bqlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Mi0N0NrtTfBp9SWKp7UeI7dL3VImNOs9+9L6eye9hMQ=; b=PVF1q65s78SqPVpNoF0PRipYXXjWlGqkUPEvU2dvEjQm+6fFdM8pKa+FXsF5I3kWlo qcprV9PjPbPdyhDoiRNbcgtt/IlFTkMJC9zg7sPqr/U5KTB3bDChpLtE5k0gQ/BoaB7s nOOvtKf7XEsr/MDx7jVNJ524WMyWud4Tk6oC7OS2EUs+F9tXPq+5EDk2C/DoND78EKnH 5N2C//lMZPqc58ywKI047iob4czHc7DM21LvsPLgIXuwIUem/lAt5pLXkxhVRySz1I7/ HJvwOJe/dLvUhuWe9GhlhUXiOOTmYKJzXvcoVtYDf0sFH15WMgpZSGXC2Wy0JCVgnXrp 4jyQ== X-Gm-Message-State: AOAM532PjdElWicQv0UWPoyYIaahzFj4YFDCX3e0ju2byl5W4AO8Oeyd 8GaC7Kj7hunH3xGrZ6pC/4K2fsg882PDeOKHVlWUng== X-Google-Smtp-Source: ABdhPJw/WYc6FSbQLQIS3Efz1BJ3ypbPM9RtpcceJn07dNrX8Y+SBVFSagPCAp/cDLteavR5bRg9b8mXBmYfeHhTq+U= X-Received: by 2002:a67:8c44:: with SMTP id o65mr1471722vsd.55.1606918240884; Wed, 02 Dec 2020 06:10:40 -0800 (PST) MIME-Version: 1.0 References: <20201202150205.20150-1-muhammad.husaini.zulkifli@intel.com> <20201202122520.GD4077@smile.fi.intel.com> In-Reply-To: From: Ulf Hansson Date: Wed, 2 Dec 2020 15:10:04 +0100 Message-ID: Subject: Re: [PATCH v6 0/4] mmc: sdhci-of-arasan: Enable UHS-1 support for Keem Bay SOC To: Andy Shevchenko X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201202_091044_052173_1AF3C2CA X-CRM114-Status: GOOD ( 29.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Gross , "Shevchenko, Andriy" , Linux Kernel Mailing List , Linus Walleij , "linux-mmc@vger.kernel.org" , Michal Simek , Adrian Hunter , Wan Ahmad Zainie , "Raja Subramanian, Lakshmi Bai" , "Zulkifli, Muhammad Husaini" , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 2 Dec 2020 at 14:09, Andy Shevchenko wrote: > > On Wed, Dec 2, 2020 at 2:44 PM Ulf Hansson wrote: > > On Wed, 2 Dec 2020 at 13:24, Shevchenko, Andriy > > wrote: > > > On Wed, Dec 02, 2020 at 11:53:42AM +0100, Ulf Hansson wrote: > > > > On Wed, 2 Dec 2020 at 08:02, wrote: > > > > > > ... > > > > > > > > Kindly help to review this patch set. > > > > > > > > This version looks a lot better to me, but I am still requesting you > > > > to model the pinctrl correctly. I don't see a reason not to, but I may > > > > have overlooked some things. > > > > > > I'm wondering why we need to mock up a pin control from something which has no > > > pin control interface. It's rather communication with firmware that does pin > > > control under the hood, but it also may be different hardware in the other / > > > future generations. Would you accept mocking up the same calls over the kernel > > > as pin control, as something else? > > > > Well, my point is that modeling this a pinctrl would keep the mmc > > driver portable. Additionally, it's very common to manage pinctrls in > > mmc drivers, so it's not like this is an entirely new thing that I > > propose. > > > > If/when it turns out that there is a new HW having a different pinctrl > > interface, it would just mean that we need a new pinctrl driver, but > > can leave the mmc driver as is. > > My point is that it may be *not* a pin control at all. Sorry, but I don't quite follow, what is *not* a pinctrl? According to the information I have received from the previous discussions [1], it's clear to me that the ARM SMC call ends up changing settings for the I/O-pads. Or did I get that wrong? > And in that case you will need to mock up (what exactly?) and update > the MMC driver. > > -- > With Best Regards, > Andy Shevchenko Kind regards Uffe [1] https://lkml.org/lkml/2020/10/8/320 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel