From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41787C8300E for ; Tue, 24 Nov 2020 14:26:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0716420674 for ; Tue, 24 Nov 2020 14:26:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="CvzctcsD" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388988AbgKXO0O (ORCPT ); Tue, 24 Nov 2020 09:26:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42624 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388969AbgKXO0J (ORCPT ); Tue, 24 Nov 2020 09:26:09 -0500 Received: from mail-vs1-xe41.google.com (mail-vs1-xe41.google.com [IPv6:2607:f8b0:4864:20::e41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C871C0617A6 for ; Tue, 24 Nov 2020 06:26:09 -0800 (PST) Received: by mail-vs1-xe41.google.com with SMTP id u24so11144649vsl.9 for ; Tue, 24 Nov 2020 06:26:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=m1U2wkaUC0f5IZsZZi8Kkk8TyQbT4OWSXn4hZYgJ55Y=; b=CvzctcsDg3pnJEsZvrPD7+Iu/O5YYdvDGHnAX2dfJzvk2VrXj/NzRCEfAxuKUe5bK+ rlF4hxdmugezTaknWvwI3TdTHWBElgecI2bPuuCClqNXsKFV9DMyh1bbdGXzzDOV5TfU Wqjzn5bWA4jwrgpqIN4EKbUkbf5Ym3aZsgYYRO1nm+FF1FfHbooafKdlxJhylF1FV059 wiX0TAp+PCzPepo99HE70utr6VRPxUXrqVMIr7qRDeEEWt3H7k33cmjtODyI7a/zmBNn Mdzzd0WwcpfH086zf3LI56BeVigPgQjZK2C6mG2HNP9qupEG9/znwm0g3v7I7J6T5GHd ygZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=m1U2wkaUC0f5IZsZZi8Kkk8TyQbT4OWSXn4hZYgJ55Y=; b=M7bL00OfttoZMif9h48EjhoS2O6HeGddv/SKIlQyHE+YFCSWdVaBOQN/YZ26IKNzw4 zIFZrFv/KOqFtxQ5Zpa5SYgEABP7BZX+Llw07EGtkcn3JeAT3UuANcNUf8EFmXnzYv9h yX2uzIp06E0AWnNVsKYXKFd6YHo1mrUZp1kqJm45KKOljdagxZrZu9AFDHkGqZrqhRWT s6HtmJZXfFTfYoVE8h517BEzXq7sfJTDv/4GMuloASBZL1DOS6vnlGX6Lb7xx5MaLYwr 9UhzP7Kp4oyKSm0lbZvzeeZ2q5WYnapJ5CGG5+fgdX2DME7l7TkPK0Qmp4PM7WEUbjGP tWDA== X-Gm-Message-State: AOAM5303eUQPFbWalfVWD0A7QZLeIZHhNt1WQXWasoeNbpU/kDztAWkd acXUSr6WPAn6FWfckBULrmvT/6C/YE2o+24JYIyaXA== X-Google-Smtp-Source: ABdhPJw/ERvoKk25DcbRx82AXlOgMkvACdtGdBV2dih2YSXMDeqqhB/n6E4pDzIryXosLG2RNaPoJdh2Myh7KD+v76c= X-Received: by 2002:a67:8c44:: with SMTP id o65mr3388053vsd.55.1606227968648; Tue, 24 Nov 2020 06:26:08 -0800 (PST) MIME-Version: 1.0 References: <387cab3a466038aa5d1fc34b8b6a7c4f693826ea.1605896060.git.gustavoars@kernel.org> In-Reply-To: <387cab3a466038aa5d1fc34b8b6a7c4f693826ea.1605896060.git.gustavoars@kernel.org> From: Ulf Hansson Date: Tue, 24 Nov 2020 15:25:32 +0100 Message-ID: Subject: Re: [PATCH 098/141] mmc: sdhci-of-arasan: Fix fall-through warnings for Clang To: "Gustavo A. R. Silva" Cc: Michal Simek , Adrian Hunter , Linux ARM , "linux-mmc@vger.kernel.org" , Linux Kernel Mailing List , linux-hardening@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 20 Nov 2020 at 19:37, Gustavo A. R. Silva wrote: > > In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple > warnings by explicitly adding multiple break statements instead of > letting the code fall through to the next case. > > Link: https://github.com/KSPP/linux/issues/115 > Signed-off-by: Gustavo A. R. Silva Applied for next, thanks! Kind regards Uffe > --- > drivers/mmc/host/sdhci-of-arasan.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c > index 829ccef87426..1f7e42b6ced5 100644 > --- a/drivers/mmc/host/sdhci-of-arasan.c > +++ b/drivers/mmc/host/sdhci-of-arasan.c > @@ -627,6 +627,7 @@ static int sdhci_zynqmp_sdcardclk_set_phase(struct clk_hw *hw, int degrees) > case MMC_TIMING_MMC_HS200: > /* For 200MHz clock, 8 Taps are available */ > tap_max = 8; > + break; > default: > break; > } > @@ -695,6 +696,7 @@ static int sdhci_zynqmp_sampleclk_set_phase(struct clk_hw *hw, int degrees) > case MMC_TIMING_MMC_HS200: > /* For 200MHz clock, 30 Taps are available */ > tap_max = 30; > + break; > default: > break; > } > @@ -760,6 +762,7 @@ static int sdhci_versal_sdcardclk_set_phase(struct clk_hw *hw, int degrees) > case MMC_TIMING_MMC_HS200: > /* For 200MHz clock, 8 Taps are available */ > tap_max = 8; > + break; > default: > break; > } > @@ -831,6 +834,7 @@ static int sdhci_versal_sampleclk_set_phase(struct clk_hw *hw, int degrees) > case MMC_TIMING_MMC_HS200: > /* For 200MHz clock, 30 Taps are available */ > tap_max = 30; > + break; > default: > break; > } > -- > 2.27.0 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B02D3C56201 for ; Tue, 24 Nov 2020 14:28:35 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2DE4820674 for ; Tue, 24 Nov 2020 14:28:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="GCu61WZw"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="CvzctcsD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2DE4820674 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=L/2Gl/oyPvFbZvi8t2K1nG9zhrHZlgz98x0zK/1wzoA=; b=GCu61WZwlDzOQvZzLRN7YkRsM WdNAVFl0pIM7/JlLMXjtHGbdT/n3h/01MsqWpsvhI/Y4heLePYE+FfRSdJ/iSaS635sEYrbYKCubP BRh9I0mJsa5Y2Hd02EkmiYo5xZ58tbciX5zjOdmNFKV2RLoBM8JJuGxbwpiC8NzgEzyrzU8NJdqeK KO8BSJC3qKLHGuXZjbGa1LMMXjjinU0XIk9x36TqBkfYUMfRAiL3r7/a9LtfC3dR3mbKjA72vhO3K euiOp6ifMddMpQAZ5JAwzWiTa/IOInj+rp2cUm9m+60MLjJSS7qdDqXHwj63iLBzEg1DJKiJZKNze ur6ab5NTg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1khZHX-0008Cy-Fq; Tue, 24 Nov 2020 14:26:59 +0000 Received: from mail-vs1-xe41.google.com ([2607:f8b0:4864:20::e41]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1khZGk-0007tn-OM for linux-arm-kernel@lists.infradead.org; Tue, 24 Nov 2020 14:26:12 +0000 Received: by mail-vs1-xe41.google.com with SMTP id r14so11151938vsa.13 for ; Tue, 24 Nov 2020 06:26:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=m1U2wkaUC0f5IZsZZi8Kkk8TyQbT4OWSXn4hZYgJ55Y=; b=CvzctcsDg3pnJEsZvrPD7+Iu/O5YYdvDGHnAX2dfJzvk2VrXj/NzRCEfAxuKUe5bK+ rlF4hxdmugezTaknWvwI3TdTHWBElgecI2bPuuCClqNXsKFV9DMyh1bbdGXzzDOV5TfU Wqjzn5bWA4jwrgpqIN4EKbUkbf5Ym3aZsgYYRO1nm+FF1FfHbooafKdlxJhylF1FV059 wiX0TAp+PCzPepo99HE70utr6VRPxUXrqVMIr7qRDeEEWt3H7k33cmjtODyI7a/zmBNn Mdzzd0WwcpfH086zf3LI56BeVigPgQjZK2C6mG2HNP9qupEG9/znwm0g3v7I7J6T5GHd ygZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=m1U2wkaUC0f5IZsZZi8Kkk8TyQbT4OWSXn4hZYgJ55Y=; b=QBPRl/LaGoPH3t+XMOVFoAAVIhTBtSAF2d5diLFYKydlTiEnmERpkIhPF9LJt/Rr8m mEKy6tuklL/hPzokCxi+fPJFUvEx+LG/ytFuucUM16I+iW7OYnaLMau/S0t4HssWyyuF 9ewUSAfxD/oBOSitKQ+jIWhw+HibYKGpVBkg+5FJQ34MVzmQUcLdDt5GhhPZgMCkcweJ 7+OihYIbN7rxn9nIti54/Ma2FUobzodUra0WSNc50/OlRkjd9ZwYPD3NdQ2MBtWfmqJK RhTHloebqDUe8pEf97szxqAAYJ/umID9mlY3BJbr/B4D3lXZ/aweEghpSN2cDY+UryRB OG0g== X-Gm-Message-State: AOAM530W+NKOtogcrYaxOnhZHup4/Yh+6U3h24YUWdxmRUqC11PibYcz wTG2bdK8+KN+ZDACKMNfeP8dSQku22AMahxyhmd4UQ== X-Google-Smtp-Source: ABdhPJw/ERvoKk25DcbRx82AXlOgMkvACdtGdBV2dih2YSXMDeqqhB/n6E4pDzIryXosLG2RNaPoJdh2Myh7KD+v76c= X-Received: by 2002:a67:8c44:: with SMTP id o65mr3388053vsd.55.1606227968648; Tue, 24 Nov 2020 06:26:08 -0800 (PST) MIME-Version: 1.0 References: <387cab3a466038aa5d1fc34b8b6a7c4f693826ea.1605896060.git.gustavoars@kernel.org> In-Reply-To: <387cab3a466038aa5d1fc34b8b6a7c4f693826ea.1605896060.git.gustavoars@kernel.org> From: Ulf Hansson Date: Tue, 24 Nov 2020 15:25:32 +0100 Message-ID: Subject: Re: [PATCH 098/141] mmc: sdhci-of-arasan: Fix fall-through warnings for Clang To: "Gustavo A. R. Silva" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201124_092611_045232_C1BF6A57 X-CRM114-Status: GOOD ( 15.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "linux-mmc@vger.kernel.org" , Linux Kernel Mailing List , Michal Simek , linux-hardening@vger.kernel.org, Adrian Hunter , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 20 Nov 2020 at 19:37, Gustavo A. R. Silva wrote: > > In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple > warnings by explicitly adding multiple break statements instead of > letting the code fall through to the next case. > > Link: https://github.com/KSPP/linux/issues/115 > Signed-off-by: Gustavo A. R. Silva Applied for next, thanks! Kind regards Uffe > --- > drivers/mmc/host/sdhci-of-arasan.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c > index 829ccef87426..1f7e42b6ced5 100644 > --- a/drivers/mmc/host/sdhci-of-arasan.c > +++ b/drivers/mmc/host/sdhci-of-arasan.c > @@ -627,6 +627,7 @@ static int sdhci_zynqmp_sdcardclk_set_phase(struct clk_hw *hw, int degrees) > case MMC_TIMING_MMC_HS200: > /* For 200MHz clock, 8 Taps are available */ > tap_max = 8; > + break; > default: > break; > } > @@ -695,6 +696,7 @@ static int sdhci_zynqmp_sampleclk_set_phase(struct clk_hw *hw, int degrees) > case MMC_TIMING_MMC_HS200: > /* For 200MHz clock, 30 Taps are available */ > tap_max = 30; > + break; > default: > break; > } > @@ -760,6 +762,7 @@ static int sdhci_versal_sdcardclk_set_phase(struct clk_hw *hw, int degrees) > case MMC_TIMING_MMC_HS200: > /* For 200MHz clock, 8 Taps are available */ > tap_max = 8; > + break; > default: > break; > } > @@ -831,6 +834,7 @@ static int sdhci_versal_sampleclk_set_phase(struct clk_hw *hw, int degrees) > case MMC_TIMING_MMC_HS200: > /* For 200MHz clock, 30 Taps are available */ > tap_max = 30; > + break; > default: > break; > } > -- > 2.27.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel