From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CF35C2B9F7 for ; Mon, 24 May 2021 14:11:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 038776108E for ; Mon, 24 May 2021 14:11:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233065AbhEXONX (ORCPT ); Mon, 24 May 2021 10:13:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57006 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233066AbhEXONK (ORCPT ); Mon, 24 May 2021 10:13:10 -0400 Received: from mail-lj1-x22e.google.com (mail-lj1-x22e.google.com [IPv6:2a00:1450:4864:20::22e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 70060C061349 for ; Mon, 24 May 2021 07:11:40 -0700 (PDT) Received: by mail-lj1-x22e.google.com with SMTP id 131so33775182ljj.3 for ; Mon, 24 May 2021 07:11:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PxFVfCbuSBreuDO3mJ9eqEuh3taUoOdaPE1ozDP14J0=; b=yFb9lCsRcwNUEwCnHxdHHbAwBCHX9AFWkTVDra9cpGbysaCf4lD0N0v1KI9YmXnmkc UL1b/E0rJbeMUg+cBLsm2sO/o1sP/fPhlhY0QUKcGymY5lUiWBGstJbfz/HRk3r0NvKp 7f/SL0rEv7h7X3Gr1DZPKANbWkyzBM5l4rZ3ps9LXF54Hqc4DNsuQQfmIjPRin/l1RJI hK9+WeRKiu1a74CYuhPZV6QeUjd+VyLoEDUolO4nyT6nLBWDwLpxilJXFmttGANtgl14 3dfEu/zakO0G/T186pE5NfTFWsovOlnVfMlDnlfCJ/DPNbbYqi1CNsy4b+aMCsWCnW9M FtCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PxFVfCbuSBreuDO3mJ9eqEuh3taUoOdaPE1ozDP14J0=; b=m7KZMVVFqy/1G5NXjpolcOVn7SYoMbaLwETLAHInqlVbYAs9w++D4oFKL38Zd7msgV m8f72U94RAw0DbfeI2v3WvLgn7cDpnOiqd0ozoZtnkBjOeIPUZU5G38z52PkoBGcpoPK HVZVh8ecFO7LoCc6/RKif27cO0O3ykYY00rkoq5DepFHewjCNglIXKibB7t1ploY19nE apm1o7ytIooGxDP8sbrarGZ8goljt3ipEW/pQ6jcwyaJPn9Jt+koa32JgpOXngffSLvO XVmc6e0fbtVzWcyzTxO4hpCsJ2kEuWKF0CAu+JBzjn2yMAi/H2uSfpSkITQFeMEaMFnS bK4w== X-Gm-Message-State: AOAM533lPHx+f3g/ybpwHGcrUaGIezz1xbrKC/KTIg2tulJks+sSbe1P QU5d9l9hSchSolDDl4jiBeKwC2T8lFWAKX5Tca5eFmZOiVKfnw== X-Google-Smtp-Source: ABdhPJxkYrdw0tkQ65uF7FdwPLjrWDJyTMHDLIz8rx7KUQwRWOSy8sPwddeleLL4Jr0PCmVZUsojIIK/8+iy0FNksL0= X-Received: by 2002:a05:651c:14c:: with SMTP id c12mr11360162ljd.72.1621865498847; Mon, 24 May 2021 07:11:38 -0700 (PDT) MIME-Version: 1.0 References: <20210521133026.17296-1-johan@kernel.org> In-Reply-To: <20210521133026.17296-1-johan@kernel.org> From: Ulf Hansson Date: Mon, 24 May 2021 16:11:00 +0200 Message-ID: Subject: Re: [PATCH] mmc: vub3000: fix control-request direction To: Johan Hovold Cc: linux-mmc , Linux USB List , Linux Kernel Mailing List , "# 4.0+" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 21 May 2021 at 15:30, Johan Hovold wrote: > > The direction of the pipe argument must match the request-type direction > bit or control requests may fail depending on the host-controller-driver > implementation. > > Fix the SET_ROM_WAIT_STATES request which erroneously used > usb_rcvctrlpipe(). > > Fixes: 88095e7b473a ("mmc: Add new VUB300 USB-to-SD/SDIO/MMC driver") > Cc: stable@vger.kernel.org # 3.0 > Signed-off-by: Johan Hovold Applied for next, thanks! Kind regards Uffe > --- > drivers/mmc/host/vub300.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/vub300.c b/drivers/mmc/host/vub300.c > index 739cf63ef6e2..4950d10d3a19 100644 > --- a/drivers/mmc/host/vub300.c > +++ b/drivers/mmc/host/vub300.c > @@ -2279,7 +2279,7 @@ static int vub300_probe(struct usb_interface *interface, > if (retval < 0) > goto error5; > retval = > - usb_control_msg(vub300->udev, usb_rcvctrlpipe(vub300->udev, 0), > + usb_control_msg(vub300->udev, usb_sndctrlpipe(vub300->udev, 0), > SET_ROM_WAIT_STATES, > USB_DIR_OUT | USB_TYPE_VENDOR | USB_RECIP_DEVICE, > firmware_rom_wait_states, 0x0000, NULL, 0, HZ); > -- > 2.26.3 >