From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 719CEC47084 for ; Mon, 24 May 2021 18:01:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4D789613E6 for ; Mon, 24 May 2021 18:01:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233670AbhEXSDX (ORCPT ); Mon, 24 May 2021 14:03:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52662 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233243AbhEXSDW (ORCPT ); Mon, 24 May 2021 14:03:22 -0400 Received: from mail-ua1-x92a.google.com (mail-ua1-x92a.google.com [IPv6:2607:f8b0:4864:20::92a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F15CAC061574 for ; Mon, 24 May 2021 11:01:53 -0700 (PDT) Received: by mail-ua1-x92a.google.com with SMTP id f1so9599709uaj.10 for ; Mon, 24 May 2021 11:01:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6Yts7qQiY5cVw+gZuSHeCN8lE/arX6Qto1/OwLEXAhQ=; b=H8BM+oDJsRf44M+gFJkkX2QGVohKPWVfWWJU1mhWKhdIAEex/y5Apwy3ws0LA6RZyi 6WnwtyNXX+DOUwTZSzorRoijv7lG0bmMnBRaGIkcCaoKmNIIngJHaeJm+gWvkADlTnX6 SMrzNlrJWO25a0iSaOrEJWWo0PzSp6eAMvxpc7k7v4OrARj2Fg/NJkS9tYYMhFlE7frh pBipM/2BBB75n9EseQ9DXqjJrBVWZ9eTAUPph4y3yvHa4C6eDqQyrVxDSBnh3sLXG2JK BlL8LVo2mGZLNKqM8rm1n8F4ahX4fi67nCHB5iam3AIvB7K97PmRBIlxzXzwAX/EqoGm qLgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6Yts7qQiY5cVw+gZuSHeCN8lE/arX6Qto1/OwLEXAhQ=; b=qBGev2vVjLjwzHhaoyGsdCwFXQEFe90STVI+GvZ2MdwM1OZJ+sbhGc3pho25rWwQrl PFDodqSh35RUkQ+A/B8ehLJPn6K3gJH1q7+CcwT/TKyPDa6quRZsB3aOc3O3sTPl/waR l6WC8i0cBd1oFAJBcKMc9xfHdgfjvCBwv5w1vUiqmrWauQ5bqrMSBlW1bMnIEKzl6/oa Fm5D53tzR5Wlv/jdz0eASY+4PW5z1bBTNAUFu4K2XOtppqFEEsnv411NuVP5Hq6KNFpp kJ74msJcd8CXTeBr2cqSf8upw82fKgozAzua7S0pcQu2WXp7j7iL+0sZTZxbOlCsylbM N0VQ== X-Gm-Message-State: AOAM533XVJoi/xQonJ3a5gyrE4DpIeN19WKsM3mqqYLshL8AcrouNXlJ 6z5Vhv+uGVy3Wi+GvvSEhu0/Avbb2PNqmW1X50YBtg== X-Google-Smtp-Source: ABdhPJzldT2KtNW5LanITjVVU8o7Tu39YI61SMrwMRReheJzUy03Rj2D1eZAzB04TnuGNIFPO+/hkePdl+GMFf+OCc0= X-Received: by 2002:a9f:24b4:: with SMTP id 49mr14197782uar.100.1621879313042; Mon, 24 May 2021 11:01:53 -0700 (PDT) MIME-Version: 1.0 References: <20210517130823.796963-1-anup.patel@wdc.com> <20210517130823.796963-6-anup.patel@wdc.com> In-Reply-To: <20210517130823.796963-6-anup.patel@wdc.com> From: Ulf Hansson Date: Mon, 24 May 2021 20:01:16 +0200 Message-ID: Subject: Re: [RFC PATCH v4 5/8] cpuidle: Factor-out power domain related code from PSCI domain driver To: Anup Patel Cc: Palmer Dabbelt , Palmer Dabbelt , Paul Walmsley , Albert Ou , Daniel Lezcano , "Rafael J . Wysocki" , Pavel Machek , Rob Herring , Sandeep Tripathy , Atish Patra , Alistair Francis , Liush , Anup Patel , DTML , linux-riscv@lists.infradead.org, Linux Kernel Mailing List , Linux PM , Linux ARM Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 17 May 2021 at 15:10, Anup Patel wrote: > > The generic power domain related code in PSCI domain driver is largely > independent of PSCI and can be shared with RISC-V SBI domain driver > hence we factor-out this code into dt_idle_genpd.c and dt_idle_genpd.h. > > Signed-off-by: Anup Patel This is clearly a big step in the right direction. Just a couple minor things, see more below. Note that, I have a couple of patches in the pipe for the cpuidle-psci-domain driver (not ready to be posted). I need a couple of more days to confirm this restructuring still makes sense beyond these potential new changes. I will let you know as soon as I can with the outcome. [...] > diff --git a/drivers/cpuidle/dt_idle_genpd.c b/drivers/cpuidle/dt_idle_genpd.c I think it would be a good idea to add a new section for this to the MAINTAINERS file. Perhaps a "DT IDLE DOMAIN" section? Or perhaps you have another idea? In any case, I am happy to continue with maintenance of this code, even in the new restructured form. > new file mode 100644 > index 000000000000..5a901773db60 > --- /dev/null > +++ b/drivers/cpuidle/dt_idle_genpd.c > @@ -0,0 +1,182 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * PM domains for CPUs via genpd. > + * > + * Copyright (C) 2019 Linaro Ltd. > + * Author: Ulf Hansson > + * > + * Copyright (c) 2021 Western Digital Corporation or its affiliates. > + */ > + > +#define pr_fmt(fmt) "dt-idle-genpd: " fmt > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +#include "dt_idle_genpd.h" > + > +static int dt_pd_parse_state_nodes( > + int (*parse_state)(struct device_node *, u32 *), > + struct genpd_power_state *states, int state_count) > +{ > + int i, ret; > + u32 state, *state_buf; > + > + for (i = 0; i < state_count; i++) { > + ret = parse_state(to_of_node(states[i].fwnode), &state); > + if (ret) > + goto free_state; > + > + state_buf = kmalloc(sizeof(u32), GFP_KERNEL); > + if (!state_buf) { > + ret = -ENOMEM; > + goto free_state; > + } > + *state_buf = state; > + states[i].data = state_buf; > + } > + > + return 0; > + > +free_state: > + i--; > + for (; i >= 0; i--) > + kfree(states[i].data); > + return ret; > +} > + > +static int dt_pd_parse_states(struct device_node *np, > + int (*parse_state)(struct device_node *, u32 *), > + struct genpd_power_state **states, > + int *state_count) > +{ > + int ret; > + > + /* Parse the domain idle states. */ > + ret = of_genpd_parse_idle_states(np, states, state_count); > + if (ret) > + return ret; > + > + /* Fill out the dt specifics for each found state. */ > + ret = dt_pd_parse_state_nodes(parse_state, *states, *state_count); > + if (ret) > + kfree(*states); > + > + return ret; > +} > + > +static void dt_pd_free_states(struct genpd_power_state *states, > + unsigned int state_count) > +{ > + int i; > + > + for (i = 0; i < state_count; i++) > + kfree(states[i].data); > + kfree(states); > +} > + > +void dt_pd_free(struct generic_pm_domain *pd) > +{ > + dt_pd_free_states(pd->states, pd->state_count); > + kfree(pd->name); > + kfree(pd); > +} > +EXPORT_SYMBOL_GPL(dt_pd_free); > + > +struct generic_pm_domain *dt_pd_alloc(struct device_node *np, > + int (*parse_state)(struct device_node *, u32 *)) > +{ > + struct generic_pm_domain *pd; > + struct genpd_power_state *states = NULL; > + int ret, state_count = 0; > + > + pd = kzalloc(sizeof(*pd), GFP_KERNEL); > + if (!pd) > + goto out; > + > + pd->name = kasprintf(GFP_KERNEL, "%pOF", np); > + if (!pd->name) > + goto free_pd; > + > + /* > + * Parse the domain idle states and let genpd manage the state selection > + * for those being compatible with "domain-idle-state". > + */ > + ret = dt_pd_parse_states(np, parse_state, &states, &state_count); > + if (ret) > + goto free_name; > + > + pd->free_states = dt_pd_free_states; > + pd->name = kbasename(pd->name); > + pd->states = states; > + pd->state_count = state_count; > + > + pr_debug("alloc PM domain %s\n", pd->name); > + return pd; > + > +free_name: > + kfree(pd->name); > +free_pd: > + kfree(pd); > +out: > + pr_err("failed to alloc PM domain %pOF\n", np); > + return NULL; > +} > +EXPORT_SYMBOL_GPL(dt_pd_alloc); > + > +int dt_pd_init_topology(struct device_node *np) > +{ > + struct device_node *node; > + struct of_phandle_args child, parent; > + int ret; > + > + for_each_child_of_node(np, node) { > + if (of_parse_phandle_with_args(node, "power-domains", > + "#power-domain-cells", 0, &parent)) > + continue; > + > + child.np = node; > + child.args_count = 0; > + ret = of_genpd_add_subdomain(&parent, &child); > + of_node_put(parent.np); > + if (ret) { > + of_node_put(node); > + return ret; > + } > + } > + > + return 0; > +} > +EXPORT_SYMBOL_GPL(dt_pd_init_topology); May I suggest that we stick to dt_idle_* as the prefix for all of the exported functions in this file. Static functions can just skip the prefix altogether. > + > +struct device *dt_idle_genpd_attach_cpu(int cpu, const char *name) > +{ > + struct device *dev; > + > + dev = dev_pm_domain_attach_by_name(get_cpu_device(cpu), name); > + if (IS_ERR_OR_NULL(dev)) > + return dev; > + > + pm_runtime_irq_safe(dev); > + if (cpu_online(cpu)) > + pm_runtime_get_sync(dev); > + > + dev_pm_syscore_device(dev, true); > + > + return dev; > +} > +EXPORT_SYMBOL_GPL(dt_idle_genpd_attach_cpu); > + > +void dt_idle_genpd_detach_cpu(struct device *dev) > +{ > + if (IS_ERR_OR_NULL(dev)) > + return; > + > + dev_pm_domain_detach(dev, false); > +} > +EXPORT_SYMBOL_GPL(dt_idle_genpd_detach_cpu); Again, a minor comment on the naming of the functions. How about skipping "genpd" in the prefix, thus just dt_idle_attach|detach_cpu()? [...] Kind regards Uffe From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14E08C2B9F7 for ; Tue, 25 May 2021 00:42:39 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D32D0611CD for ; Tue, 25 May 2021 00:42:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D32D0611CD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=N9ZRWlmRpoeY187WfmLYoa3qE1Nqpfed022IDlIOn8g=; b=vdUG67ouXbOSDO cFatQxxu43Ua8JZMqmSYb2blOKLfWUN2oiQ33K9DCNC3vIeFxL+IVS52l038BfOk/4F3YBb9EkKvZ OE+we8/ujfwbO4S1xyJ8jTLSbgBtF3LlKgHr2s8VNbjhDtgSXTinYtvjb2vpVoyVHshQZrw+5QcCk 0xurAg2huM1fIQnYSx6IomdDnboIAelhnw/jwqGILhtcUO06KyGlICy/Zi6j9DQBewiEcqy68FKnK YRL7rZhfBjeMdCO5dKLWDUhGOlAkFlbHk+fICWzOrZblRZhdg+pwfYE917o2Y02ck1LZut6Y1HIBx UJOyBRySoZXQLGdWBjkQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1llL9J-002c1T-QE; Tue, 25 May 2021 00:42:21 +0000 Received: from mail-ua1-x936.google.com ([2607:f8b0:4864:20::936]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1llEtp-001Ni7-DU for linux-riscv@lists.infradead.org; Mon, 24 May 2021 18:01:59 +0000 Received: by mail-ua1-x936.google.com with SMTP id 68so1634751uao.11 for ; Mon, 24 May 2021 11:01:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6Yts7qQiY5cVw+gZuSHeCN8lE/arX6Qto1/OwLEXAhQ=; b=H8BM+oDJsRf44M+gFJkkX2QGVohKPWVfWWJU1mhWKhdIAEex/y5Apwy3ws0LA6RZyi 6WnwtyNXX+DOUwTZSzorRoijv7lG0bmMnBRaGIkcCaoKmNIIngJHaeJm+gWvkADlTnX6 SMrzNlrJWO25a0iSaOrEJWWo0PzSp6eAMvxpc7k7v4OrARj2Fg/NJkS9tYYMhFlE7frh pBipM/2BBB75n9EseQ9DXqjJrBVWZ9eTAUPph4y3yvHa4C6eDqQyrVxDSBnh3sLXG2JK BlL8LVo2mGZLNKqM8rm1n8F4ahX4fi67nCHB5iam3AIvB7K97PmRBIlxzXzwAX/EqoGm qLgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6Yts7qQiY5cVw+gZuSHeCN8lE/arX6Qto1/OwLEXAhQ=; b=ZQoZY6/15rFOfLUBuTc43cmCWr01lX5OmfBZE+uU3LgI89x9RPVz9x1Lkq2lr7Yv+4 uBaxlXMW7/HrGS3X2Hf6tQgn3zDQMZBw45nNGfNq69vdaV//KtITy/qnntIBiKi0N2xQ qmCNneX8Qz65I9ccT31vO44K8L6YBE4tV5ci1xRSXlGNG1YlpiIzKxDqp/lQ3pfOomLX /KB18/u0k6YpFyaPaGBjDkLlg5Dw0+Lqqz+c/GVtdBItzMDc42LLtT+wbU94So2LCTdR jaKgcd/AYfkoIp2lj0lUBlg9Vk8m1Fr0tyzO9+WUe2DVbA21qXw1OL5+98vUyOQIL1+v y6zg== X-Gm-Message-State: AOAM532M9Bc7dVD+3xWuP4tQY2/JhgcASpbE19qQhNH3OCt1SVOvG+q7 NaH/4IzfgW/BGwWzDSNXKuwUmSq3MYgLGAGUXGziuA== X-Google-Smtp-Source: ABdhPJzldT2KtNW5LanITjVVU8o7Tu39YI61SMrwMRReheJzUy03Rj2D1eZAzB04TnuGNIFPO+/hkePdl+GMFf+OCc0= X-Received: by 2002:a9f:24b4:: with SMTP id 49mr14197782uar.100.1621879313042; Mon, 24 May 2021 11:01:53 -0700 (PDT) MIME-Version: 1.0 References: <20210517130823.796963-1-anup.patel@wdc.com> <20210517130823.796963-6-anup.patel@wdc.com> In-Reply-To: <20210517130823.796963-6-anup.patel@wdc.com> From: Ulf Hansson Date: Mon, 24 May 2021 20:01:16 +0200 Message-ID: Subject: Re: [RFC PATCH v4 5/8] cpuidle: Factor-out power domain related code from PSCI domain driver To: Anup Patel Cc: Palmer Dabbelt , Palmer Dabbelt , Paul Walmsley , Albert Ou , Daniel Lezcano , "Rafael J . Wysocki" , Pavel Machek , Rob Herring , Sandeep Tripathy , Atish Patra , Alistair Francis , Liush , Anup Patel , DTML , linux-riscv@lists.infradead.org, Linux Kernel Mailing List , Linux PM , Linux ARM X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210524_110157_489374_13959890 X-CRM114-Status: GOOD ( 29.95 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Mon, 17 May 2021 at 15:10, Anup Patel wrote: > > The generic power domain related code in PSCI domain driver is largely > independent of PSCI and can be shared with RISC-V SBI domain driver > hence we factor-out this code into dt_idle_genpd.c and dt_idle_genpd.h. > > Signed-off-by: Anup Patel This is clearly a big step in the right direction. Just a couple minor things, see more below. Note that, I have a couple of patches in the pipe for the cpuidle-psci-domain driver (not ready to be posted). I need a couple of more days to confirm this restructuring still makes sense beyond these potential new changes. I will let you know as soon as I can with the outcome. [...] > diff --git a/drivers/cpuidle/dt_idle_genpd.c b/drivers/cpuidle/dt_idle_genpd.c I think it would be a good idea to add a new section for this to the MAINTAINERS file. Perhaps a "DT IDLE DOMAIN" section? Or perhaps you have another idea? In any case, I am happy to continue with maintenance of this code, even in the new restructured form. > new file mode 100644 > index 000000000000..5a901773db60 > --- /dev/null > +++ b/drivers/cpuidle/dt_idle_genpd.c > @@ -0,0 +1,182 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * PM domains for CPUs via genpd. > + * > + * Copyright (C) 2019 Linaro Ltd. > + * Author: Ulf Hansson > + * > + * Copyright (c) 2021 Western Digital Corporation or its affiliates. > + */ > + > +#define pr_fmt(fmt) "dt-idle-genpd: " fmt > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +#include "dt_idle_genpd.h" > + > +static int dt_pd_parse_state_nodes( > + int (*parse_state)(struct device_node *, u32 *), > + struct genpd_power_state *states, int state_count) > +{ > + int i, ret; > + u32 state, *state_buf; > + > + for (i = 0; i < state_count; i++) { > + ret = parse_state(to_of_node(states[i].fwnode), &state); > + if (ret) > + goto free_state; > + > + state_buf = kmalloc(sizeof(u32), GFP_KERNEL); > + if (!state_buf) { > + ret = -ENOMEM; > + goto free_state; > + } > + *state_buf = state; > + states[i].data = state_buf; > + } > + > + return 0; > + > +free_state: > + i--; > + for (; i >= 0; i--) > + kfree(states[i].data); > + return ret; > +} > + > +static int dt_pd_parse_states(struct device_node *np, > + int (*parse_state)(struct device_node *, u32 *), > + struct genpd_power_state **states, > + int *state_count) > +{ > + int ret; > + > + /* Parse the domain idle states. */ > + ret = of_genpd_parse_idle_states(np, states, state_count); > + if (ret) > + return ret; > + > + /* Fill out the dt specifics for each found state. */ > + ret = dt_pd_parse_state_nodes(parse_state, *states, *state_count); > + if (ret) > + kfree(*states); > + > + return ret; > +} > + > +static void dt_pd_free_states(struct genpd_power_state *states, > + unsigned int state_count) > +{ > + int i; > + > + for (i = 0; i < state_count; i++) > + kfree(states[i].data); > + kfree(states); > +} > + > +void dt_pd_free(struct generic_pm_domain *pd) > +{ > + dt_pd_free_states(pd->states, pd->state_count); > + kfree(pd->name); > + kfree(pd); > +} > +EXPORT_SYMBOL_GPL(dt_pd_free); > + > +struct generic_pm_domain *dt_pd_alloc(struct device_node *np, > + int (*parse_state)(struct device_node *, u32 *)) > +{ > + struct generic_pm_domain *pd; > + struct genpd_power_state *states = NULL; > + int ret, state_count = 0; > + > + pd = kzalloc(sizeof(*pd), GFP_KERNEL); > + if (!pd) > + goto out; > + > + pd->name = kasprintf(GFP_KERNEL, "%pOF", np); > + if (!pd->name) > + goto free_pd; > + > + /* > + * Parse the domain idle states and let genpd manage the state selection > + * for those being compatible with "domain-idle-state". > + */ > + ret = dt_pd_parse_states(np, parse_state, &states, &state_count); > + if (ret) > + goto free_name; > + > + pd->free_states = dt_pd_free_states; > + pd->name = kbasename(pd->name); > + pd->states = states; > + pd->state_count = state_count; > + > + pr_debug("alloc PM domain %s\n", pd->name); > + return pd; > + > +free_name: > + kfree(pd->name); > +free_pd: > + kfree(pd); > +out: > + pr_err("failed to alloc PM domain %pOF\n", np); > + return NULL; > +} > +EXPORT_SYMBOL_GPL(dt_pd_alloc); > + > +int dt_pd_init_topology(struct device_node *np) > +{ > + struct device_node *node; > + struct of_phandle_args child, parent; > + int ret; > + > + for_each_child_of_node(np, node) { > + if (of_parse_phandle_with_args(node, "power-domains", > + "#power-domain-cells", 0, &parent)) > + continue; > + > + child.np = node; > + child.args_count = 0; > + ret = of_genpd_add_subdomain(&parent, &child); > + of_node_put(parent.np); > + if (ret) { > + of_node_put(node); > + return ret; > + } > + } > + > + return 0; > +} > +EXPORT_SYMBOL_GPL(dt_pd_init_topology); May I suggest that we stick to dt_idle_* as the prefix for all of the exported functions in this file. Static functions can just skip the prefix altogether. > + > +struct device *dt_idle_genpd_attach_cpu(int cpu, const char *name) > +{ > + struct device *dev; > + > + dev = dev_pm_domain_attach_by_name(get_cpu_device(cpu), name); > + if (IS_ERR_OR_NULL(dev)) > + return dev; > + > + pm_runtime_irq_safe(dev); > + if (cpu_online(cpu)) > + pm_runtime_get_sync(dev); > + > + dev_pm_syscore_device(dev, true); > + > + return dev; > +} > +EXPORT_SYMBOL_GPL(dt_idle_genpd_attach_cpu); > + > +void dt_idle_genpd_detach_cpu(struct device *dev) > +{ > + if (IS_ERR_OR_NULL(dev)) > + return; > + > + dev_pm_domain_detach(dev, false); > +} > +EXPORT_SYMBOL_GPL(dt_idle_genpd_detach_cpu); Again, a minor comment on the naming of the functions. How about skipping "genpd" in the prefix, thus just dt_idle_attach|detach_cpu()? [...] Kind regards Uffe _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3E2AC2B9F7 for ; Tue, 25 May 2021 00:43:42 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A2FDD611CD for ; Tue, 25 May 2021 00:43:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A2FDD611CD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=u/lVLYO2u8GJd/3Jif0hFehXQW6mQow+17hhY+JD2jk=; b=ClMRilqqfGyisS A2iYbNY1q2cDNGiO9s9wP9pDm9eXNysSY66/Zz0gfKtRjSDkvWv6xyvwCLlaJlp/E4a2SRB1jtqtQ dC1Ni08CNkG0CIVu5HMA7cpeWHXvzKiZ7PnpPvXXrjvcRFdxgYa4imn3uOrWUC/3MQ6dYaswD2KCT wFzntWxmmC2FL6P4lMgAFh+cfcYLibv8kIe47K3RVQU9d6d981JtcG1n8cowIbdqdY9uK3srCr2eH +FqqZ5OpS02ZLiOKruUsyXUMJOM/CJC7OAQOb7UHT7GweqCEBhjGsuOuQSUmt1Y2t5Ek0PKa37Z18 Ej5sVKEOjoKtyRiNmgTA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1llL8Q-002bpA-1Y; Tue, 25 May 2021 00:41:26 +0000 Received: from mail-ua1-x935.google.com ([2607:f8b0:4864:20::935]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1llEtp-001Ni6-9h for linux-arm-kernel@lists.infradead.org; Mon, 24 May 2021 18:01:59 +0000 Received: by mail-ua1-x935.google.com with SMTP id d14so562832ual.5 for ; Mon, 24 May 2021 11:01:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6Yts7qQiY5cVw+gZuSHeCN8lE/arX6Qto1/OwLEXAhQ=; b=H8BM+oDJsRf44M+gFJkkX2QGVohKPWVfWWJU1mhWKhdIAEex/y5Apwy3ws0LA6RZyi 6WnwtyNXX+DOUwTZSzorRoijv7lG0bmMnBRaGIkcCaoKmNIIngJHaeJm+gWvkADlTnX6 SMrzNlrJWO25a0iSaOrEJWWo0PzSp6eAMvxpc7k7v4OrARj2Fg/NJkS9tYYMhFlE7frh pBipM/2BBB75n9EseQ9DXqjJrBVWZ9eTAUPph4y3yvHa4C6eDqQyrVxDSBnh3sLXG2JK BlL8LVo2mGZLNKqM8rm1n8F4ahX4fi67nCHB5iam3AIvB7K97PmRBIlxzXzwAX/EqoGm qLgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6Yts7qQiY5cVw+gZuSHeCN8lE/arX6Qto1/OwLEXAhQ=; b=nAL2yYk56lcr7uIr0wyYxaIp+y8bN/absekG5KgiNCC9fVkGC7o6j5G5sXgqLndQ5z D2I/5UTbLUOCmECDQpDzui3t0WfP6qm/OrHMskTxMmnRVXSUGoebGA2kZHFwU4HXfjgj fkQOKQbUb2/5njYYzCZ060WyJiJKKjr3T5qXW6PvBMZ3jqH6/fPP11Z7Wz0hMrWe1DSW 4tBdRuwq6UDiNlZ0zlRCuL5VOCDuZHscry8TFF3wSmNnH9Nt+ptczi6Xn3D9vUFLKEZu ObY+nZ+XtOPlwI0GG0DQTCcO9n7qjSpFK1p52NwkncDNuU50c6MzOTkdKlIvBEkGO1Mu 2ZEw== X-Gm-Message-State: AOAM531GhCdQzr245pwXBvukkvrwlrUET85NlYJgVt/1pentV/VA34I5 jHlUAKArllxbUgbzB/g3xAfpBFwDOMfGkSR9bfxPEA== X-Google-Smtp-Source: ABdhPJzldT2KtNW5LanITjVVU8o7Tu39YI61SMrwMRReheJzUy03Rj2D1eZAzB04TnuGNIFPO+/hkePdl+GMFf+OCc0= X-Received: by 2002:a9f:24b4:: with SMTP id 49mr14197782uar.100.1621879313042; Mon, 24 May 2021 11:01:53 -0700 (PDT) MIME-Version: 1.0 References: <20210517130823.796963-1-anup.patel@wdc.com> <20210517130823.796963-6-anup.patel@wdc.com> In-Reply-To: <20210517130823.796963-6-anup.patel@wdc.com> From: Ulf Hansson Date: Mon, 24 May 2021 20:01:16 +0200 Message-ID: Subject: Re: [RFC PATCH v4 5/8] cpuidle: Factor-out power domain related code from PSCI domain driver To: Anup Patel Cc: Palmer Dabbelt , Palmer Dabbelt , Paul Walmsley , Albert Ou , Daniel Lezcano , "Rafael J . Wysocki" , Pavel Machek , Rob Herring , Sandeep Tripathy , Atish Patra , Alistair Francis , Liush , Anup Patel , DTML , linux-riscv@lists.infradead.org, Linux Kernel Mailing List , Linux PM , Linux ARM X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210524_110157_487486_3393C205 X-CRM114-Status: GOOD ( 31.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 17 May 2021 at 15:10, Anup Patel wrote: > > The generic power domain related code in PSCI domain driver is largely > independent of PSCI and can be shared with RISC-V SBI domain driver > hence we factor-out this code into dt_idle_genpd.c and dt_idle_genpd.h. > > Signed-off-by: Anup Patel This is clearly a big step in the right direction. Just a couple minor things, see more below. Note that, I have a couple of patches in the pipe for the cpuidle-psci-domain driver (not ready to be posted). I need a couple of more days to confirm this restructuring still makes sense beyond these potential new changes. I will let you know as soon as I can with the outcome. [...] > diff --git a/drivers/cpuidle/dt_idle_genpd.c b/drivers/cpuidle/dt_idle_genpd.c I think it would be a good idea to add a new section for this to the MAINTAINERS file. Perhaps a "DT IDLE DOMAIN" section? Or perhaps you have another idea? In any case, I am happy to continue with maintenance of this code, even in the new restructured form. > new file mode 100644 > index 000000000000..5a901773db60 > --- /dev/null > +++ b/drivers/cpuidle/dt_idle_genpd.c > @@ -0,0 +1,182 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * PM domains for CPUs via genpd. > + * > + * Copyright (C) 2019 Linaro Ltd. > + * Author: Ulf Hansson > + * > + * Copyright (c) 2021 Western Digital Corporation or its affiliates. > + */ > + > +#define pr_fmt(fmt) "dt-idle-genpd: " fmt > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +#include "dt_idle_genpd.h" > + > +static int dt_pd_parse_state_nodes( > + int (*parse_state)(struct device_node *, u32 *), > + struct genpd_power_state *states, int state_count) > +{ > + int i, ret; > + u32 state, *state_buf; > + > + for (i = 0; i < state_count; i++) { > + ret = parse_state(to_of_node(states[i].fwnode), &state); > + if (ret) > + goto free_state; > + > + state_buf = kmalloc(sizeof(u32), GFP_KERNEL); > + if (!state_buf) { > + ret = -ENOMEM; > + goto free_state; > + } > + *state_buf = state; > + states[i].data = state_buf; > + } > + > + return 0; > + > +free_state: > + i--; > + for (; i >= 0; i--) > + kfree(states[i].data); > + return ret; > +} > + > +static int dt_pd_parse_states(struct device_node *np, > + int (*parse_state)(struct device_node *, u32 *), > + struct genpd_power_state **states, > + int *state_count) > +{ > + int ret; > + > + /* Parse the domain idle states. */ > + ret = of_genpd_parse_idle_states(np, states, state_count); > + if (ret) > + return ret; > + > + /* Fill out the dt specifics for each found state. */ > + ret = dt_pd_parse_state_nodes(parse_state, *states, *state_count); > + if (ret) > + kfree(*states); > + > + return ret; > +} > + > +static void dt_pd_free_states(struct genpd_power_state *states, > + unsigned int state_count) > +{ > + int i; > + > + for (i = 0; i < state_count; i++) > + kfree(states[i].data); > + kfree(states); > +} > + > +void dt_pd_free(struct generic_pm_domain *pd) > +{ > + dt_pd_free_states(pd->states, pd->state_count); > + kfree(pd->name); > + kfree(pd); > +} > +EXPORT_SYMBOL_GPL(dt_pd_free); > + > +struct generic_pm_domain *dt_pd_alloc(struct device_node *np, > + int (*parse_state)(struct device_node *, u32 *)) > +{ > + struct generic_pm_domain *pd; > + struct genpd_power_state *states = NULL; > + int ret, state_count = 0; > + > + pd = kzalloc(sizeof(*pd), GFP_KERNEL); > + if (!pd) > + goto out; > + > + pd->name = kasprintf(GFP_KERNEL, "%pOF", np); > + if (!pd->name) > + goto free_pd; > + > + /* > + * Parse the domain idle states and let genpd manage the state selection > + * for those being compatible with "domain-idle-state". > + */ > + ret = dt_pd_parse_states(np, parse_state, &states, &state_count); > + if (ret) > + goto free_name; > + > + pd->free_states = dt_pd_free_states; > + pd->name = kbasename(pd->name); > + pd->states = states; > + pd->state_count = state_count; > + > + pr_debug("alloc PM domain %s\n", pd->name); > + return pd; > + > +free_name: > + kfree(pd->name); > +free_pd: > + kfree(pd); > +out: > + pr_err("failed to alloc PM domain %pOF\n", np); > + return NULL; > +} > +EXPORT_SYMBOL_GPL(dt_pd_alloc); > + > +int dt_pd_init_topology(struct device_node *np) > +{ > + struct device_node *node; > + struct of_phandle_args child, parent; > + int ret; > + > + for_each_child_of_node(np, node) { > + if (of_parse_phandle_with_args(node, "power-domains", > + "#power-domain-cells", 0, &parent)) > + continue; > + > + child.np = node; > + child.args_count = 0; > + ret = of_genpd_add_subdomain(&parent, &child); > + of_node_put(parent.np); > + if (ret) { > + of_node_put(node); > + return ret; > + } > + } > + > + return 0; > +} > +EXPORT_SYMBOL_GPL(dt_pd_init_topology); May I suggest that we stick to dt_idle_* as the prefix for all of the exported functions in this file. Static functions can just skip the prefix altogether. > + > +struct device *dt_idle_genpd_attach_cpu(int cpu, const char *name) > +{ > + struct device *dev; > + > + dev = dev_pm_domain_attach_by_name(get_cpu_device(cpu), name); > + if (IS_ERR_OR_NULL(dev)) > + return dev; > + > + pm_runtime_irq_safe(dev); > + if (cpu_online(cpu)) > + pm_runtime_get_sync(dev); > + > + dev_pm_syscore_device(dev, true); > + > + return dev; > +} > +EXPORT_SYMBOL_GPL(dt_idle_genpd_attach_cpu); > + > +void dt_idle_genpd_detach_cpu(struct device *dev) > +{ > + if (IS_ERR_OR_NULL(dev)) > + return; > + > + dev_pm_domain_detach(dev, false); > +} > +EXPORT_SYMBOL_GPL(dt_idle_genpd_detach_cpu); Again, a minor comment on the naming of the functions. How about skipping "genpd" in the prefix, thus just dt_idle_attach|detach_cpu()? [...] Kind regards Uffe _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel