From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76CBDC32771 for ; Fri, 19 Aug 2022 14:54:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349585AbiHSOyj (ORCPT ); Fri, 19 Aug 2022 10:54:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36974 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349038AbiHSOyh (ORCPT ); Fri, 19 Aug 2022 10:54:37 -0400 Received: from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com [IPv6:2a00:1450:4864:20::22b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4887CD21F7 for ; Fri, 19 Aug 2022 07:54:36 -0700 (PDT) Received: by mail-lj1-x22b.google.com with SMTP id x10so4760546ljq.4 for ; Fri, 19 Aug 2022 07:54:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=RB7AhKhD6AGVN/FWM8EefpXqGSUdKLi/83gJNo8P8A8=; b=ukZZs/HNQ7J9Zv6RG2j0LdMZFmvFxJrKEWtRHDYURQ+zit353wTcB/yZf7UbnuMtCC IYIAQXew86cYDr2fvuAWbPb0YSbeZOImE906+CpGl/s7BZJPgv6GTV+O91jj2CIGU7L5 OFB/YM9cZB5zAy2zgPH+5dCfYRlL1TduBVITtEXjwc6RlDOcqm/4TuFj05rhAMj5Ih4r 61hw0HWDzrg37O1peBmsoSw7bUdkVmrDPYGBE5p80Glr3gqwNl+pUyN3LEmSRj/+larM M3vNc4bh5+WTZms2a7uHR4oWU5xJY6qIhYaIYmyW0PhNkRQTscAnwi81KlFbl/+9kP6M LZoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=RB7AhKhD6AGVN/FWM8EefpXqGSUdKLi/83gJNo8P8A8=; b=5XkeXE8CNVj40rXV8ZQZpQxxfP+j4fyUANK4ymZ5P//3mZFStvcw0j2YOUK/pxLNWe 6oPefon9bb+oECM0nE4HgdjMk0UNFEGDXtirG0+zykevS+ZzOM7ef8Bh+Vvdl3ujE1RG PRZevrKJ9kNLBjkXwHB+OcijEW92S+xxBtYgkAs+NvKONGSjpUvBAYajCu5lfO5LxaVJ O6UZ4GoNdP9/dpe2N6UzfFGq1mthrM/GwcpUmkyL6ejz7fuvnina6SVXbmFqMJspUy6R Ii2qE5G3O4o+pHtkeeb5sOCgzbX70VPoDVWrGCgYWl58/57coIAWyQfat43fIJ1A17aZ yNnQ== X-Gm-Message-State: ACgBeo33vrVOrQNknJYfPOr5piIFOrhNRwbVe7HOypygs/jtPmLqCNTV 6h2RNDXBLyB4S7UEIStiZL8VbdrebuHBJbpfTpYIiw== X-Google-Smtp-Source: AA6agR4LKuTTBMhjnkTTLmdSIUoln5Khx5nC3j9KNqc8+z3/j2pYHnYHmoYM6uxvbd4BKVFc1yC9kLBk0j+xNy3GIBE= X-Received: by 2002:a05:651c:223:b0:261:beb4:1c85 with SMTP id z3-20020a05651c022300b00261beb41c85mr751234ljn.463.1660920874560; Fri, 19 Aug 2022 07:54:34 -0700 (PDT) MIME-Version: 1.0 References: <20220726083257.1730630-1-martin.kepplinger@puri.sm> <20220726083257.1730630-2-martin.kepplinger@puri.sm> In-Reply-To: From: Ulf Hansson Date: Fri, 19 Aug 2022 16:53:58 +0200 Message-ID: Subject: Re: [PATCH v6 1/2] power: domain: handle genpd correctly when needing interrupts To: Martin Kepplinger Cc: rafael@kernel.org, khilman@kernel.org, robh@kernel.org, krzysztof.kozlowski@linaro.org, shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com, pavel@ucw.cz, kernel@puri.sm, linux-imx@nxp.com, broonie@kernel.org, l.stach@pengutronix.de, aford173@gmail.com, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 19 Aug 2022 at 11:17, Martin Kepplinger wrote: > > Am Dienstag, dem 26.07.2022 um 17:07 +0200 schrieb Ulf Hansson: > > On Tue, 26 Jul 2022 at 10:33, Martin Kepplinger > > wrote: > > > > > > If for example the power-domains' power-supply node (regulator) > > > needs > > > interrupts to work, the current setup with noirq callbacks cannot > > > work; for example a pmic regulator on i2c, when suspending, usually > > > already > > > times out during suspend_noirq: > > > > > > [ 41.024193] buck4: failed to disable: -ETIMEDOUT > > > > > > So fix system suspend and resume for these power-domains by using > > > the > > > "outer" suspend/resume callbacks instead. Tested on the imx8mq- > > > librem5 board, > > > but by looking at the dts, this will fix imx8mq-evk and possibly > > > many other > > > boards too. > > > > > > This is designed so that genpd providers just say "this genpd needs > > > interrupts" (by setting the flag) - without implying an > > > implementation. > > > > > > Initially system suspend problems had been discussed at > > > https://lore.kernel.org/linux-arm-kernel/20211002005954.1367653-8-l.stach@pengutronix.de/ > > > which led to discussing the pmic that contains the regulators which > > > serve as power-domain power-supplies: > > > https://lore.kernel.org/linux-pm/573166b75e524517782471c2b7f96e03fd93d175.camel@puri.sm/T/ > > > > > > Signed-off-by: Martin Kepplinger > > > --- > > > drivers/base/power/domain.c | 13 +++++++++++-- > > > include/linux/pm_domain.h | 5 +++++ > > > 2 files changed, 16 insertions(+), 2 deletions(-) > > > > > > diff --git a/drivers/base/power/domain.c > > > b/drivers/base/power/domain.c > > > index 5a2e0232862e..58376752a4de 100644 > > > --- a/drivers/base/power/domain.c > > > +++ b/drivers/base/power/domain.c > > > @@ -130,6 +130,7 @@ static const struct genpd_lock_ops > > > genpd_spin_ops = { > > > #define genpd_is_active_wakeup(genpd) (genpd->flags & > > > GENPD_FLAG_ACTIVE_WAKEUP) > > > #define genpd_is_cpu_domain(genpd) (genpd->flags & > > > GENPD_FLAG_CPU_DOMAIN) > > > #define genpd_is_rpm_always_on(genpd) (genpd->flags & > > > GENPD_FLAG_RPM_ALWAYS_ON) > > > +#define genpd_irq_on(genpd) (genpd->flags & > > > GENPD_FLAG_IRQ_ON) > > > > > > static inline bool irq_safe_dev_in_sleep_domain(struct device > > > *dev, > > > const struct generic_pm_domain *genpd) > > > @@ -2065,8 +2066,15 @@ int pm_genpd_init(struct generic_pm_domain > > > *genpd, > > > genpd->domain.ops.runtime_suspend = genpd_runtime_suspend; > > > genpd->domain.ops.runtime_resume = genpd_runtime_resume; > > > genpd->domain.ops.prepare = genpd_prepare; > > > - genpd->domain.ops.suspend_noirq = genpd_suspend_noirq; > > > - genpd->domain.ops.resume_noirq = genpd_resume_noirq; > > > + > > > + if (genpd_irq_on(genpd)) { > > > + genpd->domain.ops.suspend = genpd_suspend_noirq; > > > + genpd->domain.ops.resume = genpd_resume_noirq; > > > + } else { > > > + genpd->domain.ops.suspend_noirq = > > > genpd_suspend_noirq; > > > + genpd->domain.ops.resume_noirq = > > > genpd_resume_noirq; > > > > As we discussed previously, I am thinking that it may be better to > > move to using genpd->domain.ops.suspend_late and > > genpd->domain.ops.resume_early instead. > > Wouldn't that better be a separate patch (on top)? Do you really want > me to change the current behaviour (default case) to from noirq to > late? Then I'll resend this series with such a patch added. Sorry, I wasn't clear enough, the default behaviour should remain as is. What I meant was, when genpd_irq_on() is true, we should use the genpd->domain.ops.suspend_late and genpd->domain.ops.resume_early. Kind regards Uffe From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A7C79C32772 for ; Fri, 19 Aug 2022 14:55:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=y07+R4WKPcI7riOPxHdSNWiTBoL3JpVx3kaW9SKGCn8=; b=CzBN4XU1buxlgX OCUcQBJ3Bcf/Kn1BWBhPoIH6iCPSVSLZKVz88wMkdfjB7dFHR+QKB28FhtHL/MYKCeqzSUwP4kzI3 au8Az3nopQk9+9N0G+Hs4srSb697Mp7Iey6xeF6JDSnmJZwNSrcOQHT5Zfc32elbLqXuVu/O2JRvX cQKI/8JW4e8CXkK07Z5xDnzSyvO7geBtr5e23ljNGtM5+C6+hiEEfvHmbHQTXL7n8Dhdh9r7EINaE RHeYYKDuM5b3bmSdSLpu9r9qLO+1Km1LkK5dHU3pMnNs8trEw5SyhMMd77iletlnHzOknPIarKq4b qL+h84tSO1MWG+UPUYMg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oP3OU-009gQp-2s; Fri, 19 Aug 2022 14:54:42 +0000 Received: from mail-lj1-x22b.google.com ([2a00:1450:4864:20::22b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oP3OQ-009gND-Iy for linux-arm-kernel@lists.infradead.org; Fri, 19 Aug 2022 14:54:40 +0000 Received: by mail-lj1-x22b.google.com with SMTP id n24so2714443ljc.13 for ; Fri, 19 Aug 2022 07:54:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=RB7AhKhD6AGVN/FWM8EefpXqGSUdKLi/83gJNo8P8A8=; b=ukZZs/HNQ7J9Zv6RG2j0LdMZFmvFxJrKEWtRHDYURQ+zit353wTcB/yZf7UbnuMtCC IYIAQXew86cYDr2fvuAWbPb0YSbeZOImE906+CpGl/s7BZJPgv6GTV+O91jj2CIGU7L5 OFB/YM9cZB5zAy2zgPH+5dCfYRlL1TduBVITtEXjwc6RlDOcqm/4TuFj05rhAMj5Ih4r 61hw0HWDzrg37O1peBmsoSw7bUdkVmrDPYGBE5p80Glr3gqwNl+pUyN3LEmSRj/+larM M3vNc4bh5+WTZms2a7uHR4oWU5xJY6qIhYaIYmyW0PhNkRQTscAnwi81KlFbl/+9kP6M LZoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=RB7AhKhD6AGVN/FWM8EefpXqGSUdKLi/83gJNo8P8A8=; b=BQ3V0/lfw094bZNvzyFKqCSGHyJMu29ze6cvKC7+zuParfyMzY3WHcn3IWoNLqhT6+ 9IXpJv+/L7G/69j529nE14Eznh4jNN5PjKMBqRyswddqfQZY8TnThq4+wnJLzvx3xQET QFVClQt43NfR0a0Y86k01OXaGg6RNtxFnsAHfmQdVy2vDREkdo0Mzmp6lChhpXdbEevd l1wRwSocs8nIazM33oUnUeQNm7mHuEZZ0pxAa2B4oJf6MiOFXVg75R9X4r43aOHjuofS SVcOIhrXTH4Nqil46A/i4K94GwQOzbFHGyzs/U2iSzZlChfevQutlFk62PYGvIC2FaDT uUSQ== X-Gm-Message-State: ACgBeo1ooFvkJajJ3YAMD6sSZrO2vWk3XaVA4pYBumoYhc6Xvb76qehM EkRRYctIjCR7rGXpM1fFzrNtuH5M5mWcG6D21qIxqw== X-Google-Smtp-Source: AA6agR4LKuTTBMhjnkTTLmdSIUoln5Khx5nC3j9KNqc8+z3/j2pYHnYHmoYM6uxvbd4BKVFc1yC9kLBk0j+xNy3GIBE= X-Received: by 2002:a05:651c:223:b0:261:beb4:1c85 with SMTP id z3-20020a05651c022300b00261beb41c85mr751234ljn.463.1660920874560; Fri, 19 Aug 2022 07:54:34 -0700 (PDT) MIME-Version: 1.0 References: <20220726083257.1730630-1-martin.kepplinger@puri.sm> <20220726083257.1730630-2-martin.kepplinger@puri.sm> In-Reply-To: From: Ulf Hansson Date: Fri, 19 Aug 2022 16:53:58 +0200 Message-ID: Subject: Re: [PATCH v6 1/2] power: domain: handle genpd correctly when needing interrupts To: Martin Kepplinger Cc: rafael@kernel.org, khilman@kernel.org, robh@kernel.org, krzysztof.kozlowski@linaro.org, shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com, pavel@ucw.cz, kernel@puri.sm, linux-imx@nxp.com, broonie@kernel.org, l.stach@pengutronix.de, aford173@gmail.com, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220819_075438_716568_D8D5EE8A X-CRM114-Status: GOOD ( 33.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 19 Aug 2022 at 11:17, Martin Kepplinger wrote: > > Am Dienstag, dem 26.07.2022 um 17:07 +0200 schrieb Ulf Hansson: > > On Tue, 26 Jul 2022 at 10:33, Martin Kepplinger > > wrote: > > > > > > If for example the power-domains' power-supply node (regulator) > > > needs > > > interrupts to work, the current setup with noirq callbacks cannot > > > work; for example a pmic regulator on i2c, when suspending, usually > > > already > > > times out during suspend_noirq: > > > > > > [ 41.024193] buck4: failed to disable: -ETIMEDOUT > > > > > > So fix system suspend and resume for these power-domains by using > > > the > > > "outer" suspend/resume callbacks instead. Tested on the imx8mq- > > > librem5 board, > > > but by looking at the dts, this will fix imx8mq-evk and possibly > > > many other > > > boards too. > > > > > > This is designed so that genpd providers just say "this genpd needs > > > interrupts" (by setting the flag) - without implying an > > > implementation. > > > > > > Initially system suspend problems had been discussed at > > > https://lore.kernel.org/linux-arm-kernel/20211002005954.1367653-8-l.stach@pengutronix.de/ > > > which led to discussing the pmic that contains the regulators which > > > serve as power-domain power-supplies: > > > https://lore.kernel.org/linux-pm/573166b75e524517782471c2b7f96e03fd93d175.camel@puri.sm/T/ > > > > > > Signed-off-by: Martin Kepplinger > > > --- > > > drivers/base/power/domain.c | 13 +++++++++++-- > > > include/linux/pm_domain.h | 5 +++++ > > > 2 files changed, 16 insertions(+), 2 deletions(-) > > > > > > diff --git a/drivers/base/power/domain.c > > > b/drivers/base/power/domain.c > > > index 5a2e0232862e..58376752a4de 100644 > > > --- a/drivers/base/power/domain.c > > > +++ b/drivers/base/power/domain.c > > > @@ -130,6 +130,7 @@ static const struct genpd_lock_ops > > > genpd_spin_ops = { > > > #define genpd_is_active_wakeup(genpd) (genpd->flags & > > > GENPD_FLAG_ACTIVE_WAKEUP) > > > #define genpd_is_cpu_domain(genpd) (genpd->flags & > > > GENPD_FLAG_CPU_DOMAIN) > > > #define genpd_is_rpm_always_on(genpd) (genpd->flags & > > > GENPD_FLAG_RPM_ALWAYS_ON) > > > +#define genpd_irq_on(genpd) (genpd->flags & > > > GENPD_FLAG_IRQ_ON) > > > > > > static inline bool irq_safe_dev_in_sleep_domain(struct device > > > *dev, > > > const struct generic_pm_domain *genpd) > > > @@ -2065,8 +2066,15 @@ int pm_genpd_init(struct generic_pm_domain > > > *genpd, > > > genpd->domain.ops.runtime_suspend = genpd_runtime_suspend; > > > genpd->domain.ops.runtime_resume = genpd_runtime_resume; > > > genpd->domain.ops.prepare = genpd_prepare; > > > - genpd->domain.ops.suspend_noirq = genpd_suspend_noirq; > > > - genpd->domain.ops.resume_noirq = genpd_resume_noirq; > > > + > > > + if (genpd_irq_on(genpd)) { > > > + genpd->domain.ops.suspend = genpd_suspend_noirq; > > > + genpd->domain.ops.resume = genpd_resume_noirq; > > > + } else { > > > + genpd->domain.ops.suspend_noirq = > > > genpd_suspend_noirq; > > > + genpd->domain.ops.resume_noirq = > > > genpd_resume_noirq; > > > > As we discussed previously, I am thinking that it may be better to > > move to using genpd->domain.ops.suspend_late and > > genpd->domain.ops.resume_early instead. > > Wouldn't that better be a separate patch (on top)? Do you really want > me to change the current behaviour (default case) to from noirq to > late? Then I'll resend this series with such a patch added. Sorry, I wasn't clear enough, the default behaviour should remain as is. What I meant was, when genpd_irq_on() is true, we should use the genpd->domain.ops.suspend_late and genpd->domain.ops.resume_early. Kind regards Uffe _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel