* [PATCH v2] dt-bindings: mmc: Clean-up examples to match documented bindings
@ 2021-05-19 15:37 Rob Herring
2021-05-24 14:10 ` Ulf Hansson
0 siblings, 1 reply; 2+ messages in thread
From: Rob Herring @ 2021-05-19 15:37 UTC (permalink / raw)
To: Ulf Hansson; +Cc: devicetree, linux-kernel, linux-mmc
The "sdhci" compatible is not documented though used as a fallback in a
few cases. It is also not supported by a Linux driver. Just remove the
example as part of ridding examples of undocumented bindings.
The "brcm,bcm43xx-fmac" compatible is also not documented. Update the
example to use one of the correct ones, "brcm,bcm4329-fmac", instead and
use a device class based nodename.
Cc: Ulf Hansson <ulf.hansson@linaro.org>
Cc: linux-mmc@vger.kernel.org
Signed-off-by: Rob Herring <robh@kernel.org>
---
v2:
- Also fix "brcm,bcm43xx-fmac" example
.../bindings/mmc/mmc-controller.yaml | 20 ++-----------------
1 file changed, 2 insertions(+), 18 deletions(-)
diff --git a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
index e141330c1114..646ae768d625 100644
--- a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
+++ b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
@@ -357,22 +357,6 @@ dependencies:
additionalProperties: true
examples:
- - |
- mmc@ab000000 {
- compatible = "sdhci";
- reg = <0xab000000 0x200>;
- interrupts = <23>;
- bus-width = <4>;
- cd-gpios = <&gpio 69 0>;
- cd-inverted;
- wp-gpios = <&gpio 70 0>;
- max-frequency = <50000000>;
- keep-power-in-suspend;
- wakeup-source;
- mmc-pwrseq = <&sdhci0_pwrseq>;
- clk-phase-sd-hs = <63>, <72>;
- };
-
- |
mmc3: mmc@1c12000 {
#address-cells = <1>;
@@ -385,9 +369,9 @@ examples:
non-removable;
mmc-pwrseq = <&sdhci0_pwrseq>;
- brcmf: bcrmf@1 {
+ brcmf: wifi@1 {
reg = <1>;
- compatible = "brcm,bcm43xx-fmac";
+ compatible = "brcm,bcm4329-fmac";
interrupt-parent = <&pio>;
interrupts = <10 8>;
interrupt-names = "host-wake";
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] dt-bindings: mmc: Clean-up examples to match documented bindings
2021-05-19 15:37 [PATCH v2] dt-bindings: mmc: Clean-up examples to match documented bindings Rob Herring
@ 2021-05-24 14:10 ` Ulf Hansson
0 siblings, 0 replies; 2+ messages in thread
From: Ulf Hansson @ 2021-05-24 14:10 UTC (permalink / raw)
To: Rob Herring; +Cc: DTML, Linux Kernel Mailing List, linux-mmc
On Wed, 19 May 2021 at 17:37, Rob Herring <robh@kernel.org> wrote:
>
> The "sdhci" compatible is not documented though used as a fallback in a
> few cases. It is also not supported by a Linux driver. Just remove the
> example as part of ridding examples of undocumented bindings.
>
> The "brcm,bcm43xx-fmac" compatible is also not documented. Update the
> example to use one of the correct ones, "brcm,bcm4329-fmac", instead and
> use a device class based nodename.
>
> Cc: Ulf Hansson <ulf.hansson@linaro.org>
> Cc: linux-mmc@vger.kernel.org
> Signed-off-by: Rob Herring <robh@kernel.org>
Applied for next, thanks!
Kind regards
Uffe
> ---
> v2:
> - Also fix "brcm,bcm43xx-fmac" example
>
> .../bindings/mmc/mmc-controller.yaml | 20 ++-----------------
> 1 file changed, 2 insertions(+), 18 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> index e141330c1114..646ae768d625 100644
> --- a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> +++ b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> @@ -357,22 +357,6 @@ dependencies:
> additionalProperties: true
>
> examples:
> - - |
> - mmc@ab000000 {
> - compatible = "sdhci";
> - reg = <0xab000000 0x200>;
> - interrupts = <23>;
> - bus-width = <4>;
> - cd-gpios = <&gpio 69 0>;
> - cd-inverted;
> - wp-gpios = <&gpio 70 0>;
> - max-frequency = <50000000>;
> - keep-power-in-suspend;
> - wakeup-source;
> - mmc-pwrseq = <&sdhci0_pwrseq>;
> - clk-phase-sd-hs = <63>, <72>;
> - };
> -
> - |
> mmc3: mmc@1c12000 {
> #address-cells = <1>;
> @@ -385,9 +369,9 @@ examples:
> non-removable;
> mmc-pwrseq = <&sdhci0_pwrseq>;
>
> - brcmf: bcrmf@1 {
> + brcmf: wifi@1 {
> reg = <1>;
> - compatible = "brcm,bcm43xx-fmac";
> + compatible = "brcm,bcm4329-fmac";
> interrupt-parent = <&pio>;
> interrupts = <10 8>;
> interrupt-names = "host-wake";
> --
> 2.27.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-24 14:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-19 15:37 [PATCH v2] dt-bindings: mmc: Clean-up examples to match documented bindings Rob Herring
2021-05-24 14:10 ` Ulf Hansson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.