From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97E5DC433E3 for ; Mon, 22 Mar 2021 12:21:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5E3D461992 for ; Mon, 22 Mar 2021 12:21:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230330AbhCVMVV (ORCPT ); Mon, 22 Mar 2021 08:21:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49690 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230338AbhCVMVO (ORCPT ); Mon, 22 Mar 2021 08:21:14 -0400 Received: from mail-vs1-xe2b.google.com (mail-vs1-xe2b.google.com [IPv6:2607:f8b0:4864:20::e2b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 19B72C061763 for ; Mon, 22 Mar 2021 05:21:13 -0700 (PDT) Received: by mail-vs1-xe2b.google.com with SMTP id l13so7314831vst.8 for ; Mon, 22 Mar 2021 05:21:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=XGgimpglaRwteb/Bgl+pO/u/VHpnAlSvFxg2F0n2KCo=; b=p6ePlsePjZxtZiq6dspm5RqfO23b/cRwiaAUzyGDHXFYH5sx1t4bJGWn0FOttl90Fl 9l+Pfmy1A5eZFy/TSoAvoVzQdfoD2qAan4ZvPA6wRfZWyReRLg4ebDoHO03QxuwMUSbG Xw/8chYtadgBTlSZOweb9p+3rtNCRRcjugB/lnaBMco22zR1SkNQM6lzIQNj8EexBez6 v7JH/YONvbt8dLTbvqGS0sAH1lBuk1leff10dNlL9TDI1CpIRaVwIzuXwq2+NNyRsGqx z1w0fgf4bGexsX5E3k40FkRmO1RTFVZAOD6tpBLRoVWKOKlZDiXK9Zj5nr2RvdtstoJq nujA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=XGgimpglaRwteb/Bgl+pO/u/VHpnAlSvFxg2F0n2KCo=; b=J/Q6i0P3LDt7aoSylvNn6YNCBO6pd7Js7GJCrEdovayT8ePCoktyDHBAl1KuI22MsS LMW4XFCp7vfMxnSnQLvmLGfwGylZi1Vsfmjd4bZ9X8SFzgJ9fpY8STWixoyJ0gPpjRTS Vy83iNmx8t2o5D5inYb1EudPRvtOE9AFQhkh96dej58m9VGJw77Ot0lHqde1if6fgmNC VvNS7YQZb/T6dzINjOFlNEw9pELI/5ijt35g+o1dCSoM6Bt7XqtPV5rAGdrVbv2Sjlsf IF9JVpL2WVMm7H8zdLZGP/MKGDeh832HYp06SCvgLUglEX7C/rQssLzj1CQOhqwQhe70 tePA== X-Gm-Message-State: AOAM532764+lmLn6/ZvjZY2zZxFlpm/GzV1JNEA1WkULkKQbMIbcRz6H u413PYZRLQ3nRgVcFC9Pu82LEWduUIuwJ48kexctgw== X-Google-Smtp-Source: ABdhPJxi1HPq3PGcbuB9unHpIbKlJszyykT5Ik5ywDW/5koSttdd0dNdIDei/RcqxPZPwkzSrOy7RcSt9jXbJOzDcy4= X-Received: by 2002:a67:2a85:: with SMTP id q127mr8477457vsq.19.1616415672109; Mon, 22 Mar 2021 05:21:12 -0700 (PDT) MIME-Version: 1.0 References: <20210315132501.441681-1-Jerome.Pouiller@silabs.com> <20210315132501.441681-9-Jerome.Pouiller@silabs.com> In-Reply-To: <20210315132501.441681-9-Jerome.Pouiller@silabs.com> From: Ulf Hansson Date: Mon, 22 Mar 2021 13:20:35 +0100 Message-ID: Subject: Re: [PATCH v5 08/24] wfx: add bus_sdio.c To: Jerome Pouiller Cc: linux-wireless , netdev , driverdevel , Linux Kernel Mailing List , Greg Kroah-Hartman , Kalle Valo , "David S . Miller" , DTML , Rob Herring , linux-mmc , =?UTF-8?Q?Pali_Roh=C3=A1r?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Mon, 15 Mar 2021 at 14:25, Jerome Pouiller wrote: > > From: J=C3=A9r=C3=B4me Pouiller > > Signed-off-by: J=C3=A9r=C3=B4me Pouiller > --- > drivers/net/wireless/silabs/wfx/bus_sdio.c | 259 +++++++++++++++++++++ > 1 file changed, 259 insertions(+) > create mode 100644 drivers/net/wireless/silabs/wfx/bus_sdio.c [...] > +static const struct sdio_device_id wfx_sdio_ids[] =3D { > + { SDIO_DEVICE(SDIO_VENDOR_ID_SILABS, SDIO_DEVICE_ID_SILABS_WF200)= }, > + { }, > +}; > +MODULE_DEVICE_TABLE(sdio, wfx_sdio_ids); > + > +struct sdio_driver wfx_sdio_driver =3D { > + .name =3D "wfx-sdio", > + .id_table =3D wfx_sdio_ids, > + .probe =3D wfx_sdio_probe, > + .remove =3D wfx_sdio_remove, > + .drv =3D { > + .owner =3D THIS_MODULE, > + .of_match_table =3D wfx_sdio_of_match, It's not mandatory to support power management, like system suspend/resume. However, as this looks like this is a driver for an embedded SDIO device, you probably want this. If that is the case, please assign the dev_pm_ops here and implement the ->suspend|resume() callbacks. [...] Kind regards Uffe From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F48FC433C1 for ; Mon, 22 Mar 2021 12:21:18 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 40ACA6198B for ; Mon, 22 Mar 2021 12:21:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 40ACA6198B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 03FF440172; Mon, 22 Mar 2021 12:21:18 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id x0YdGaSoJocJ; Mon, 22 Mar 2021 12:21:17 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp2.osuosl.org (Postfix) with ESMTP id EC67040221; Mon, 22 Mar 2021 12:21:16 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 7346C1BF37F for ; Mon, 22 Mar 2021 12:21:15 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 623A640221 for ; Mon, 22 Mar 2021 12:21:15 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Jr-TJuPNBiIo for ; Mon, 22 Mar 2021 12:21:13 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from mail-vs1-xe31.google.com (mail-vs1-xe31.google.com [IPv6:2607:f8b0:4864:20::e31]) by smtp2.osuosl.org (Postfix) with ESMTPS id 42FA840172 for ; Mon, 22 Mar 2021 12:21:13 +0000 (UTC) Received: by mail-vs1-xe31.google.com with SMTP id z68so7324744vsb.10 for ; Mon, 22 Mar 2021 05:21:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=XGgimpglaRwteb/Bgl+pO/u/VHpnAlSvFxg2F0n2KCo=; b=p6ePlsePjZxtZiq6dspm5RqfO23b/cRwiaAUzyGDHXFYH5sx1t4bJGWn0FOttl90Fl 9l+Pfmy1A5eZFy/TSoAvoVzQdfoD2qAan4ZvPA6wRfZWyReRLg4ebDoHO03QxuwMUSbG Xw/8chYtadgBTlSZOweb9p+3rtNCRRcjugB/lnaBMco22zR1SkNQM6lzIQNj8EexBez6 v7JH/YONvbt8dLTbvqGS0sAH1lBuk1leff10dNlL9TDI1CpIRaVwIzuXwq2+NNyRsGqx z1w0fgf4bGexsX5E3k40FkRmO1RTFVZAOD6tpBLRoVWKOKlZDiXK9Zj5nr2RvdtstoJq nujA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=XGgimpglaRwteb/Bgl+pO/u/VHpnAlSvFxg2F0n2KCo=; b=kZu/DWZEfOtRRE33NuGbgewKYI8n6ukmZtQeF/kqbz+4WNwcoKeb1IgCO3dw8hCnMZ 2gX9ypiIVYTCqfNaLRpFK+ReRjbhRu6RlpQldfVMqrVMS99s0zQo1yqfikSuBGZsefjo CaJjktxFxTkxF3wZSLP7i5EWQ1YHz6Q9SGEUdnAgh6OC7KOoLOZ1YM0yqK17wIVcV9H9 CWarssBaexUf2CuAI9VIevfEegu28fBtjx8+RfXS+gG0qKaERz9OBlBLM5dJ1IKd/99B x3Gzq7JJlmAVlTGa00hCDtk2/jIxZWzVkUeJqfFbByi9u0D8cMek9QW+sxc4Pjlqgcqo 2ZKg== X-Gm-Message-State: AOAM5321uKqWUbpStoxxnJbKmZW9SF468VWBYvzeb7P2YdTQ/89yoXB8 oU+hrKDiFOfdb2IwJMrQUcykZhwxo39WZghVpvAS7g== X-Google-Smtp-Source: ABdhPJxi1HPq3PGcbuB9unHpIbKlJszyykT5Ik5ywDW/5koSttdd0dNdIDei/RcqxPZPwkzSrOy7RcSt9jXbJOzDcy4= X-Received: by 2002:a67:2a85:: with SMTP id q127mr8477457vsq.19.1616415672109; Mon, 22 Mar 2021 05:21:12 -0700 (PDT) MIME-Version: 1.0 References: <20210315132501.441681-1-Jerome.Pouiller@silabs.com> <20210315132501.441681-9-Jerome.Pouiller@silabs.com> In-Reply-To: <20210315132501.441681-9-Jerome.Pouiller@silabs.com> From: Ulf Hansson Date: Mon, 22 Mar 2021 13:20:35 +0100 Message-ID: Subject: Re: [PATCH v5 08/24] wfx: add bus_sdio.c To: Jerome Pouiller X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: driverdevel , DTML , netdev , linux-wireless , Linux Kernel Mailing List , Rob Herring , Greg Kroah-Hartman , linux-mmc , =?UTF-8?Q?Pali_Roh=C3=A1r?= , "David S . Miller" , Kalle Valo Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" T24gTW9uLCAxNSBNYXIgMjAyMSBhdCAxNDoyNSwgSmVyb21lIFBvdWlsbGVyCjxKZXJvbWUuUG91 aWxsZXJAc2lsYWJzLmNvbT4gd3JvdGU6Cj4KPiBGcm9tOiBKw6lyw7RtZSBQb3VpbGxlciA8amVy b21lLnBvdWlsbGVyQHNpbGFicy5jb20+Cj4KPiBTaWduZWQtb2ZmLWJ5OiBKw6lyw7RtZSBQb3Vp bGxlciA8amVyb21lLnBvdWlsbGVyQHNpbGFicy5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvbmV0L3dp cmVsZXNzL3NpbGFicy93ZngvYnVzX3NkaW8uYyB8IDI1OSArKysrKysrKysrKysrKysrKysrKysK PiAgMSBmaWxlIGNoYW5nZWQsIDI1OSBpbnNlcnRpb25zKCspCj4gIGNyZWF0ZSBtb2RlIDEwMDY0 NCBkcml2ZXJzL25ldC93aXJlbGVzcy9zaWxhYnMvd2Z4L2J1c19zZGlvLmMKClsuLi5dCgo+ICtz dGF0aWMgY29uc3Qgc3RydWN0IHNkaW9fZGV2aWNlX2lkIHdmeF9zZGlvX2lkc1tdID0gewo+ICsg ICAgICAgeyBTRElPX0RFVklDRShTRElPX1ZFTkRPUl9JRF9TSUxBQlMsIFNESU9fREVWSUNFX0lE X1NJTEFCU19XRjIwMCkgfSwKPiArICAgICAgIHsgfSwKPiArfTsKPiArTU9EVUxFX0RFVklDRV9U QUJMRShzZGlvLCB3Znhfc2Rpb19pZHMpOwo+ICsKPiArc3RydWN0IHNkaW9fZHJpdmVyIHdmeF9z ZGlvX2RyaXZlciA9IHsKPiArICAgICAgIC5uYW1lID0gIndmeC1zZGlvIiwKPiArICAgICAgIC5p ZF90YWJsZSA9IHdmeF9zZGlvX2lkcywKPiArICAgICAgIC5wcm9iZSA9IHdmeF9zZGlvX3Byb2Jl LAo+ICsgICAgICAgLnJlbW92ZSA9IHdmeF9zZGlvX3JlbW92ZSwKPiArICAgICAgIC5kcnYgPSB7 Cj4gKyAgICAgICAgICAgICAgIC5vd25lciA9IFRISVNfTU9EVUxFLAo+ICsgICAgICAgICAgICAg ICAub2ZfbWF0Y2hfdGFibGUgPSB3Znhfc2Rpb19vZl9tYXRjaCwKCkl0J3Mgbm90IG1hbmRhdG9y eSB0byBzdXBwb3J0IHBvd2VyIG1hbmFnZW1lbnQsIGxpa2Ugc3lzdGVtCnN1c3BlbmQvcmVzdW1l LiBIb3dldmVyLCBhcyB0aGlzIGxvb2tzIGxpa2UgdGhpcyBpcyBhIGRyaXZlciBmb3IgYW4KZW1i ZWRkZWQgU0RJTyBkZXZpY2UsIHlvdSBwcm9iYWJseSB3YW50IHRoaXMuCgpJZiB0aGF0IGlzIHRo ZSBjYXNlLCBwbGVhc2UgYXNzaWduIHRoZSBkZXZfcG1fb3BzIGhlcmUgYW5kIGltcGxlbWVudAp0 aGUgLT5zdXNwZW5kfHJlc3VtZSgpIGNhbGxiYWNrcy4KClsuLi5dCgpLaW5kIHJlZ2FyZHMKVWZm ZQpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkZXZlbCBt YWlsaW5nIGxpc3QKZGV2ZWxAbGludXhkcml2ZXJwcm9qZWN0Lm9yZwpodHRwOi8vZHJpdmVyZGV2 LmxpbnV4ZHJpdmVycHJvamVjdC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcml2ZXJkZXYtZGV2ZWwK