From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1DF6C25B0E for ; Mon, 15 Aug 2022 18:47:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243508AbiHOSrF (ORCPT ); Mon, 15 Aug 2022 14:47:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39944 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244200AbiHOSqp (ORCPT ); Mon, 15 Aug 2022 14:46:45 -0400 Received: from mail-oa1-x30.google.com (mail-oa1-x30.google.com [IPv6:2001:4860:4864:20::30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 29ADF41995 for ; Mon, 15 Aug 2022 11:28:20 -0700 (PDT) Received: by mail-oa1-x30.google.com with SMTP id 586e51a60fabf-10ee900cce0so9048435fac.5 for ; Mon, 15 Aug 2022 11:28:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=nzkiEUN15yoqYwUDSmfmqqu1RJj8u2Ige+qgLeq8dNM=; b=FnOF2oSIHjQvZrwpfABWIYj5vm/rL+xzLQN5tdxF2TYxqZl7qfG/TuxzlBQYurEeLV I7stWMJfvgdP2wA7mAtXJl9tEcWoBK6sRrn29p4ZXtpm86Xn1LRa07Zfat736zBxea/S s8FIVp85dDCCT3qWBTQjjrkzZfdG/qlXPvPclxM6ugvyfNVmBxHVIwuDgaRtCz2eoMnX BnF8b9Joa5itybCca04tGBL0/1r9KU/W10Q048cHl6o7ETTrp/cMXBqvk8MpjULc+rw9 aEgf54uj6sh0mhJTk7OKhGYLUOP6Gy7n7d+zCu8cqJAWwsGvDGE80moCkuDC4Ea4SJzP ndAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=nzkiEUN15yoqYwUDSmfmqqu1RJj8u2Ige+qgLeq8dNM=; b=G0I+JUnrUw+/qPnTQzOhz681+xalbnrecP0rASg38j/j+eKU253MoNvGKEhKiKGUa6 oYLVXRaUGFuwMqHQ9nACUulElKw/JLgjh/zIUhUQXIyEG7gQ61bVhlTpT4QvCLPNnm9Q A9Uo9GG+Vfy5r65bPessQTqPWwmJ+UEYWycABYCPnFK2HMejH3kBLREx1Z4iztY920xo V8npQIzxnPMF/+7ppEla2lEIJqccAgHErqGBBd0gI3D35CVfQnXWsl9kwQ0k/z4vlC3J GAM0PuiD0ldvS98sQXDTozlGOmQWsibB9PcnWEdn328ehkVsWQHpCAjHB01E+5rXYeD6 aVJA== X-Gm-Message-State: ACgBeo3jBHkSa6sCYC/FcdK3W74tQnxkYsinIuWEurvNxxSun9lO9eTy rSaYCFXv1lrV5o/lMDwK8cJlgDQ0lNKF6vrVZKIFqA== X-Google-Smtp-Source: AA6agR4FscaLC2K7CnGdFK/q1e0Cm8YfPFt5HcTAN/4NAB1QfTL5GPe7+vLFjgDWtK8eYVDrTdv0xm2Bk5gFEK24ec4= X-Received: by 2002:a05:6870:a18c:b0:118:5b96:1cc6 with SMTP id a12-20020a056870a18c00b001185b961cc6mr6865278oaf.105.1660588099459; Mon, 15 Aug 2022 11:28:19 -0700 (PDT) MIME-Version: 1.0 References: <20220726084520.2895454-1-bhupesh.sharma@linaro.org> In-Reply-To: <20220726084520.2895454-1-bhupesh.sharma@linaro.org> From: Ulf Hansson Date: Mon, 15 Aug 2022 20:27:42 +0200 Message-ID: Subject: Re: [PATCH v2] dt-bindings: mmc: Set maximum documented operating frequency as 384MHz To: Bhupesh Sharma Cc: linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, robh@kernel.org, bhupesh.linux@gmail.com, linux-kernel@vger.kernel.org, bjorn.andersson@linaro.org, agross@kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Tue, 26 Jul 2022 at 10:45, Bhupesh Sharma wrote: > > As Ulf noted in [1], the maximum operating frequency > documented in the mmc-controller device-tree bindings > should be updated to the maximum frequency supported > by the mmc controller(s). > > Without this fix in place, the 'make dtbs_check' reports > issues with 'max-frequency' value for ipq8074 sdhci node: > > arch/arm64/boot/dts/qcom/ipq8074-hk01.dtb: mmc@7824900: > max-frequency:0:0: 384000000 is greater than the maximum of 200000000 > > [1]. https://www.spinics.net/lists/kernel/msg4442049.html > > Cc: Ulf Hansson > Cc: Bjorn Andersson > Cc: Rob Herring > Signed-off-by: Bhupesh Sharma Applied for next, thanks! Kind regards Uffe > --- > - v1 can be viewed here: https://lore.kernel.org/linux-arm-msm/20220725180916.2850228-1-bhupesh.sharma@linaro.org/ > - Rebased on linux-next/master > > .../devicetree/bindings/mmc/mmc-controller.yaml | 13 ++++++++++--- > 1 file changed, 10 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml > index ff5ce89e5111..802e3ca8be4d 100644 > --- a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml > +++ b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml > @@ -88,11 +88,18 @@ properties: > default: 1 > > max-frequency: > - description: > - Maximum operating frequency of the bus. > + description: | > + Maximum operating frequency of the bus: > + - for eMMC, the maximum supported frequency is 200MHz, > + - for SD/SDIO cards the SDR104 mode has a max supported > + frequency of 208MHz, > + - some mmc host controllers do support a max frequency upto > + 384MHz. > + So, lets keep the maximum supported value here. > + > $ref: /schemas/types.yaml#/definitions/uint32 > minimum: 400000 > - maximum: 200000000 > + maximum: 384000000 > > disable-wp: > $ref: /schemas/types.yaml#/definitions/flag > -- > 2.35.3 >