From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ulf Hansson Date: Fri, 29 Jan 2016 11:40:54 +0000 Subject: Re: [PATCH 0/9] mmc: sdhi: some refactoring and adding basic r8a7795 support Message-Id: List-Id: References: <1453749316-1848-1-git-send-email-wsa@the-dreams.de> In-Reply-To: <1453749316-1848-1-git-send-email-wsa@the-dreams.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Wolfram Sang Cc: linux-mmc , linux-renesas-soc@vger.kernel.org, Linux-sh list , Kuninori Morimoto , Magnus Damm , Yoshihiro Shimoda , Dirk Behme On 25 January 2016 at 20:15, Wolfram Sang wrote: > So, here is the series to enable basic SD support on r8a7795; no DMA and UHS-I > for now. Will be added incrementally. It turns out that the driver needs a > little love, so some refactoring is also in place before adding the actual > support. > > eMMC works in 4-bit mode, too. 8-bit mode sadly fails currently. I'll post MMC > support patches once this issue is fixed. > > These patches have been tested on Gen3 (Salvator-X) and Gen2 (Lager), doing > basic operations with SD cards and running the mmc_test driver (its results > point out some potential corner cases to check later). > > A branch can be found here (including clock and DTS patches): > > git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git renesas/v8-sdhi > > Changes since RFC (only sent to sh-devel lists): > > * patches 1,7,8 are new > * patch 4 drops 10ms wait also for set_clock > * patch 9 also sets MMC_CAP_WAIT_WHILE_BUSY (see comment there) > * some commit message rewording > > Please test, comment, apply... > > Thanks, > > Wolfram > > > Shinobu Uehara (1): > mmc: sdhi: Add EXT_ACC register busy check > > Wolfram Sang (8): > mmc: tmio_dma: remove debug messages with little information > mmc: sdhi: error message on ENOMEM is superfluous > mmc: tmio: add flag to reduce delay after changing clock status > mmc: tmio: remove stale comments > mmc: sdhi: use faster clock handling on RCar Gen2 > mmc: tmio: refactor set_clock a little > mmc: tmio: disable clock before changing it > mmc: sdhi: Add r8a7795 support > > Documentation/devicetree/bindings/mmc/tmio_mmc.txt | 1 + > drivers/mmc/host/Kconfig | 2 +- > drivers/mmc/host/sh_mobile_sdhi.c | 54 +++++++++++++++------- > drivers/mmc/host/tmio_mmc_dma.c | 12 ----- > drivers/mmc/host/tmio_mmc_pio.c | 27 ++++++----- > include/linux/mfd/tmio.h | 4 ++ > include/linux/mmc/tmio.h | 5 ++ > 7 files changed, 63 insertions(+), 42 deletions(-) > > -- > 2.1.4 > Patch 1->8 looks good. Although, I couldn't apply patch1, could you please send a new version rebased onto my next branch. Kind regards Uffe From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ulf Hansson Subject: Re: [PATCH 0/9] mmc: sdhi: some refactoring and adding basic r8a7795 support Date: Fri, 29 Jan 2016 12:40:54 +0100 Message-ID: References: <1453749316-1848-1-git-send-email-wsa@the-dreams.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from mail-yk0-f179.google.com ([209.85.160.179]:33253 "EHLO mail-yk0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755943AbcA2Lkz (ORCPT ); Fri, 29 Jan 2016 06:40:55 -0500 Received: by mail-yk0-f179.google.com with SMTP id k129so65650547yke.0 for ; Fri, 29 Jan 2016 03:40:55 -0800 (PST) In-Reply-To: <1453749316-1848-1-git-send-email-wsa@the-dreams.de> Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Wolfram Sang Cc: linux-mmc , linux-renesas-soc@vger.kernel.org, Linux-sh list , Kuninori Morimoto , Magnus Damm , Yoshihiro Shimoda , Dirk Behme On 25 January 2016 at 20:15, Wolfram Sang wrote: > So, here is the series to enable basic SD support on r8a7795; no DMA and UHS-I > for now. Will be added incrementally. It turns out that the driver needs a > little love, so some refactoring is also in place before adding the actual > support. > > eMMC works in 4-bit mode, too. 8-bit mode sadly fails currently. I'll post MMC > support patches once this issue is fixed. > > These patches have been tested on Gen3 (Salvator-X) and Gen2 (Lager), doing > basic operations with SD cards and running the mmc_test driver (its results > point out some potential corner cases to check later). > > A branch can be found here (including clock and DTS patches): > > git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git renesas/v8-sdhi > > Changes since RFC (only sent to sh-devel lists): > > * patches 1,7,8 are new > * patch 4 drops 10ms wait also for set_clock > * patch 9 also sets MMC_CAP_WAIT_WHILE_BUSY (see comment there) > * some commit message rewording > > Please test, comment, apply... > > Thanks, > > Wolfram > > > Shinobu Uehara (1): > mmc: sdhi: Add EXT_ACC register busy check > > Wolfram Sang (8): > mmc: tmio_dma: remove debug messages with little information > mmc: sdhi: error message on ENOMEM is superfluous > mmc: tmio: add flag to reduce delay after changing clock status > mmc: tmio: remove stale comments > mmc: sdhi: use faster clock handling on RCar Gen2 > mmc: tmio: refactor set_clock a little > mmc: tmio: disable clock before changing it > mmc: sdhi: Add r8a7795 support > > Documentation/devicetree/bindings/mmc/tmio_mmc.txt | 1 + > drivers/mmc/host/Kconfig | 2 +- > drivers/mmc/host/sh_mobile_sdhi.c | 54 +++++++++++++++------- > drivers/mmc/host/tmio_mmc_dma.c | 12 ----- > drivers/mmc/host/tmio_mmc_pio.c | 27 ++++++----- > include/linux/mfd/tmio.h | 4 ++ > include/linux/mmc/tmio.h | 5 ++ > 7 files changed, 63 insertions(+), 42 deletions(-) > > -- > 2.1.4 > Patch 1->8 looks good. Although, I couldn't apply patch1, could you please send a new version rebased onto my next branch. Kind regards Uffe