From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEFE8C6FA82 for ; Fri, 23 Sep 2022 13:56:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231903AbiIWN4G (ORCPT ); Fri, 23 Sep 2022 09:56:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49960 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229496AbiIWN4B (ORCPT ); Fri, 23 Sep 2022 09:56:01 -0400 Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 05BC313D1F5 for ; Fri, 23 Sep 2022 06:56:00 -0700 (PDT) Received: by mail-wr1-x433.google.com with SMTP id n12so99592wrx.9 for ; Fri, 23 Sep 2022 06:55:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=S/p8TvXlsMGXG51CkXeBekBV47MmYMaNjH+nwQik6mo=; b=pesQIkJa1x9mg8LE7c1BamUwx4uzYPg0MQOvF7vkEfvtp0xDXdNWK4UsxwdeYxqP1G f5lXAOWWPOITHbY2gdNkFN7/IsH5pu+axiN8GES5mepjN+IAWBGkMYSkXFG9h2d3hgME T+UOpQi4Vvp9qxmkK3+IXptPL8pBBH782k8y6fTghfF7kPK2muCQfKu9ox11hKgvVm8j vBOqaOiTKtiiE0ekdqBpg6AB407tl+GtSV30SyWW7CsJBiYWtGtGKitpIu8NG7tZ7gHW O1a2s8TQS1Tc4zC7PaGuTjDzgY2V3EWfF14CTgQb6abAp9h2DDbR7Z00ljb01PAm8n11 LDeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=S/p8TvXlsMGXG51CkXeBekBV47MmYMaNjH+nwQik6mo=; b=JieoYMz5sTIgDKwj6FVHueII/sdDrFk8W3k5X/FKlG7SkMCiKh476GYz6X+MIC/fzn fvrIhrHkDw0Sg+4RT2GSEclZb9/dIkQcnr4IQyBNnARp0w7iwKI9ZUqHRHqUTJo5WW/b LUZKLx0nWUcSZ8ZgtSAC4fwHo059lQFWtLSVfK+atP+5wxDUPOIZcFDDogpWU6P/FZX3 TWMSzqolNqF41vqSMDD2KWMWOVrOT1LOveXViEfUBKQUAMv2P51AdQ2ndGBxSFDq42rA e+SMozY+o1yPpNAiF/z94eHs7s/TE/8MVVe1WsAXvkF4JPxaH6Rn5e6SNhLTO/F8wMW6 S3kw== X-Gm-Message-State: ACrzQf03yzJmgWNysg7cmjlM0YSWsDXyWUIdLpnVFJOXF2SKX/5ys5Hu jK6B8A8R7odd3Lo8YyfNNf/cIl1Gtyyy/4+u60laUA== X-Google-Smtp-Source: AMsMyM5JD0LHLzdgiPuW93f49BMsTWiW6nyvuGbZbM+xrf5PUIHPYMm+BgwIrZTLBwTvkItjALXG7xZhx/Y05gOiULI= X-Received: by 2002:a5d:588f:0:b0:22b:5cc:e1d3 with SMTP id n15-20020a5d588f000000b0022b05cce1d3mr5073130wrf.142.1663941358489; Fri, 23 Sep 2022 06:55:58 -0700 (PDT) MIME-Version: 1.0 References: <20220726083257.1730630-1-martin.kepplinger@puri.sm> <20220726083257.1730630-2-martin.kepplinger@puri.sm> <77baacb930bf2ba1a65cb1515e6795b48d2d4ed5.camel@puri.sm> <3bbba64dc4fd9ef37fb937f5176b1ef50b8b2d73.camel@puri.sm> In-Reply-To: <3bbba64dc4fd9ef37fb937f5176b1ef50b8b2d73.camel@puri.sm> From: Ulf Hansson Date: Fri, 23 Sep 2022 15:55:21 +0200 Message-ID: Subject: Re: [PATCH v6 1/2] power: domain: handle genpd correctly when needing interrupts To: Martin Kepplinger Cc: rafael@kernel.org, khilman@kernel.org, robh@kernel.org, krzysztof.kozlowski@linaro.org, shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com, pavel@ucw.cz, kernel@puri.sm, linux-imx@nxp.com, broonie@kernel.org, l.stach@pengutronix.de, aford173@gmail.com, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 25 Aug 2022 at 09:06, Martin Kepplinger wrote: > > Am Mittwoch, dem 24.08.2022 um 15:30 +0200 schrieb Ulf Hansson: > > On Mon, 22 Aug 2022 at 10:38, Martin Kepplinger > > wrote: > > > > > > Am Freitag, dem 19.08.2022 um 16:53 +0200 schrieb Ulf Hansson: > > > > On Fri, 19 Aug 2022 at 11:17, Martin Kepplinger > > > > wrote: > > > > > > > > > > Am Dienstag, dem 26.07.2022 um 17:07 +0200 schrieb Ulf Hansson: > > > > > > On Tue, 26 Jul 2022 at 10:33, Martin Kepplinger > > > > > > wrote: > > > > > > > > > > > > > > If for example the power-domains' power-supply node > > > > > > > (regulator) > > > > > > > needs > > > > > > > interrupts to work, the current setup with noirq callbacks > > > > > > > cannot > > > > > > > work; for example a pmic regulator on i2c, when suspending, > > > > > > > usually > > > > > > > already > > > > > > > times out during suspend_noirq: > > > > > > > > > > > > > > [ 41.024193] buck4: failed to disable: -ETIMEDOUT > > > > > > > > > > > > > > So fix system suspend and resume for these power-domains by > > > > > > > using > > > > > > > the > > > > > > > "outer" suspend/resume callbacks instead. Tested on the > > > > > > > imx8mq- > > > > > > > librem5 board, > > > > > > > but by looking at the dts, this will fix imx8mq-evk and > > > > > > > possibly > > > > > > > many other > > > > > > > boards too. > > > > > > > > > > > > > > This is designed so that genpd providers just say "this > > > > > > > genpd > > > > > > > needs > > > > > > > interrupts" (by setting the flag) - without implying an > > > > > > > implementation. > > > > > > > > > > > > > > Initially system suspend problems had been discussed at > > > > > > > https://lore.kernel.org/linux-arm-kernel/20211002005954.1367653-8-l.stach@pengutronix.de/ > > > > > > > which led to discussing the pmic that contains the > > > > > > > regulators > > > > > > > which > > > > > > > serve as power-domain power-supplies: > > > > > > > https://lore.kernel.org/linux-pm/573166b75e524517782471c2b7f96e03fd93d175.camel@puri.sm/T/ > > > > > > > > > > > > > > Signed-off-by: Martin Kepplinger > > > > > > > > > > > > > > --- > > > > > > > drivers/base/power/domain.c | 13 +++++++++++-- > > > > > > > include/linux/pm_domain.h | 5 +++++ > > > > > > > 2 files changed, 16 insertions(+), 2 deletions(-) > > > > > > > > > > > > > > diff --git a/drivers/base/power/domain.c > > > > > > > b/drivers/base/power/domain.c > > > > > > > index 5a2e0232862e..58376752a4de 100644 > > > > > > > --- a/drivers/base/power/domain.c > > > > > > > +++ b/drivers/base/power/domain.c > > > > > > > @@ -130,6 +130,7 @@ static const struct genpd_lock_ops > > > > > > > genpd_spin_ops = { > > > > > > > #define genpd_is_active_wakeup(genpd) (genpd->flags & > > > > > > > GENPD_FLAG_ACTIVE_WAKEUP) > > > > > > > #define genpd_is_cpu_domain(genpd) (genpd->flags & > > > > > > > GENPD_FLAG_CPU_DOMAIN) > > > > > > > #define genpd_is_rpm_always_on(genpd) (genpd->flags & > > > > > > > GENPD_FLAG_RPM_ALWAYS_ON) > > > > > > > +#define genpd_irq_on(genpd) (genpd->flags & > > > > > > > GENPD_FLAG_IRQ_ON) > > > > > > > > > > > > > > static inline bool irq_safe_dev_in_sleep_domain(struct > > > > > > > device > > > > > > > *dev, > > > > > > > const struct generic_pm_domain *genpd) > > > > > > > @@ -2065,8 +2066,15 @@ int pm_genpd_init(struct > > > > > > > generic_pm_domain > > > > > > > *genpd, > > > > > > > genpd->domain.ops.runtime_suspend = > > > > > > > genpd_runtime_suspend; > > > > > > > genpd->domain.ops.runtime_resume = > > > > > > > genpd_runtime_resume; > > > > > > > genpd->domain.ops.prepare = genpd_prepare; > > > > > > > - genpd->domain.ops.suspend_noirq = > > > > > > > genpd_suspend_noirq; > > > > > > > - genpd->domain.ops.resume_noirq = > > > > > > > genpd_resume_noirq; > > > > > > > + > > > > > > > + if (genpd_irq_on(genpd)) { > > > > > > > + genpd->domain.ops.suspend = > > > > > > > genpd_suspend_noirq; > > > > > > > + genpd->domain.ops.resume = > > > > > > > genpd_resume_noirq; > > > > > > > + } else { > > > > > > > + genpd->domain.ops.suspend_noirq = > > > > > > > genpd_suspend_noirq; > > > > > > > + genpd->domain.ops.resume_noirq = > > > > > > > genpd_resume_noirq; > > > > > > > > > > > > As we discussed previously, I am thinking that it may be > > > > > > better > > > > > > to > > > > > > move to using genpd->domain.ops.suspend_late and > > > > > > genpd->domain.ops.resume_early instead. > > > > > > > > > > Wouldn't that better be a separate patch (on top)? Do you > > > > > really > > > > > want > > > > > me to change the current behaviour (default case) to from noirq > > > > > to > > > > > late? Then I'll resend this series with such a patch added. > > > > > > > > Sorry, I wasn't clear enough, the default behaviour should remain > > > > as > > > > is. > > > > > > > > What I meant was, when genpd_irq_on() is true, we should use the > > > > genpd->domain.ops.suspend_late and genpd- > > > > >domain.ops.resume_early. > > > > > > Testing that shows that this isn't working. I can provide the logs > > > later, but suspend fails and I think it makes sense: "suspend_late" > > > is > > > simply already too late when i2c (or any needed driver) uses > > > "suspend". > > > > Okay, I see. > > > > The reason why I suggested moving the callbacks to "suspend_late", > > was > > that I was worried that some of the attached devices to genpd could > > use "suspend_late" themselves. This is the case for some drivers for > > DMA/clock/gpio/pinctrl-controllers, for example. That said, I am > > curious to look at the DT files for the platform you are running, > > would you mind giving me a pointer? > > I'm running > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi > with these (small) patches on top: > https://source.puri.sm/martin.kepplinger/linux-next/-/commits/5.19.3/librem5 Thanks for sharing the information! > > > > > So, this made me think about this a bit more. In the end, just using > > different levels (suspend, suspend_late, suspend_noirq) of callbacks > > are just papering over the real *dependency* problem. > > true, it doesn't feel like a stable solution. > > > > > What we need for the genpd provider driver, is to be asked to be > > suspended under the following conditions: > > 1. All consumer devices (and child-domains) for its corresponding PM > > domain have been suspended. > > 2. All its supplier devices supplies must remain resumed, until the > > genpd provider has been suspended. > > > > Please allow me a few more days to think in more detail about this. > > Thanks a lot for thinking about this! I have made some more thinking, but it's been a busy period for me, so unfortunately I need some additional time (another week). It seems like I also need to do some prototyping, to convince myself about the approach. So, my apologies for the delay! Kind regards Uffe From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 377D7C6FA82 for ; Fri, 23 Sep 2022 13:57:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=l7BvdQ3sRg+4c2tBVtpBfOQZ/gL7ZUstoEtFbLiqRnA=; b=XjBKI9ZirZG+vB 1yTksRlExlTUA2NyklmzNTA4x3q9tFPjXURBwUJMRDuG3P4BIBqifMBRe113YPiOt56ncmTYj6tNT DIPF4YGX+UGvF6F2HuXdcjiDDEvWFghDpc0mhAPYcrKqloA6m/6Hf2wXzXuUltG/Dc6D9ahzw6/Xb DMJpsgZcGQ8DskYm0q+EWwI/JLtahs3cQGN3PyZcjKnexiu2/UB1RapigWBZBr+3NAx8UOSbpI0+3 IVSLgLPD/JsYoXCI5lhOUENsA9toIvbk2T39mJrI+PzVY1SVVxDqAssoCY8g5Bep6G/Lwdysjj4S6 gw1avX927Fa/AVbx0yFg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1objA0-004WvA-Pk; Fri, 23 Sep 2022 13:56:08 +0000 Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1obj9u-004WrT-HC for linux-arm-kernel@lists.infradead.org; Fri, 23 Sep 2022 13:56:06 +0000 Received: by mail-wr1-x434.google.com with SMTP id n10so73510wrw.12 for ; Fri, 23 Sep 2022 06:55:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=S/p8TvXlsMGXG51CkXeBekBV47MmYMaNjH+nwQik6mo=; b=pesQIkJa1x9mg8LE7c1BamUwx4uzYPg0MQOvF7vkEfvtp0xDXdNWK4UsxwdeYxqP1G f5lXAOWWPOITHbY2gdNkFN7/IsH5pu+axiN8GES5mepjN+IAWBGkMYSkXFG9h2d3hgME T+UOpQi4Vvp9qxmkK3+IXptPL8pBBH782k8y6fTghfF7kPK2muCQfKu9ox11hKgvVm8j vBOqaOiTKtiiE0ekdqBpg6AB407tl+GtSV30SyWW7CsJBiYWtGtGKitpIu8NG7tZ7gHW O1a2s8TQS1Tc4zC7PaGuTjDzgY2V3EWfF14CTgQb6abAp9h2DDbR7Z00ljb01PAm8n11 LDeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=S/p8TvXlsMGXG51CkXeBekBV47MmYMaNjH+nwQik6mo=; b=BMtYvUaoEXOTvqTa2WQpEyIHdJDsp7kq8XJ9Ki7p3o933pwiuXD8ivm6r44U7s3YQW E+TUmppI4JZtadZBNuAVzsbq85iICt0BaK9KyzssO/vZTb6y9GK5K5eTo/M97zlUQBFb 0m9EJVMGgLh7h4gRhjyQ2EuVWX0/GVE+7sK3jSS6Y01dwUZA6KZ7T7li8zecKdUy24nQ XPLw7UtyxoJ0xy3EL32iXIKEj3SlmnvGM6+sDZglPxmRHheLZeYboCLfnDdLTKaWTN/M njiClfVMYnl3w8fq5EqD9kg7vCEygJog31rb7/ZASrxeWZqw05bdTxDyb+vHXu9HHbY1 UlGA== X-Gm-Message-State: ACrzQf1ZiqiC1s37QD9oYI3moeu/qSW1Qf0B27FxuUNckZVaGVhMEbwX KQFzi6g29HrvFdsAo96KVZO+iHf3aPDvV8G684r6wQ== X-Google-Smtp-Source: AMsMyM5JD0LHLzdgiPuW93f49BMsTWiW6nyvuGbZbM+xrf5PUIHPYMm+BgwIrZTLBwTvkItjALXG7xZhx/Y05gOiULI= X-Received: by 2002:a5d:588f:0:b0:22b:5cc:e1d3 with SMTP id n15-20020a5d588f000000b0022b05cce1d3mr5073130wrf.142.1663941358489; Fri, 23 Sep 2022 06:55:58 -0700 (PDT) MIME-Version: 1.0 References: <20220726083257.1730630-1-martin.kepplinger@puri.sm> <20220726083257.1730630-2-martin.kepplinger@puri.sm> <77baacb930bf2ba1a65cb1515e6795b48d2d4ed5.camel@puri.sm> <3bbba64dc4fd9ef37fb937f5176b1ef50b8b2d73.camel@puri.sm> In-Reply-To: <3bbba64dc4fd9ef37fb937f5176b1ef50b8b2d73.camel@puri.sm> From: Ulf Hansson Date: Fri, 23 Sep 2022 15:55:21 +0200 Message-ID: Subject: Re: [PATCH v6 1/2] power: domain: handle genpd correctly when needing interrupts To: Martin Kepplinger Cc: rafael@kernel.org, khilman@kernel.org, robh@kernel.org, krzysztof.kozlowski@linaro.org, shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com, pavel@ucw.cz, kernel@puri.sm, linux-imx@nxp.com, broonie@kernel.org, l.stach@pengutronix.de, aford173@gmail.com, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220923_065602_617263_84C1F9E7 X-CRM114-Status: GOOD ( 54.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 25 Aug 2022 at 09:06, Martin Kepplinger wrote: > > Am Mittwoch, dem 24.08.2022 um 15:30 +0200 schrieb Ulf Hansson: > > On Mon, 22 Aug 2022 at 10:38, Martin Kepplinger > > wrote: > > > > > > Am Freitag, dem 19.08.2022 um 16:53 +0200 schrieb Ulf Hansson: > > > > On Fri, 19 Aug 2022 at 11:17, Martin Kepplinger > > > > wrote: > > > > > > > > > > Am Dienstag, dem 26.07.2022 um 17:07 +0200 schrieb Ulf Hansson: > > > > > > On Tue, 26 Jul 2022 at 10:33, Martin Kepplinger > > > > > > wrote: > > > > > > > > > > > > > > If for example the power-domains' power-supply node > > > > > > > (regulator) > > > > > > > needs > > > > > > > interrupts to work, the current setup with noirq callbacks > > > > > > > cannot > > > > > > > work; for example a pmic regulator on i2c, when suspending, > > > > > > > usually > > > > > > > already > > > > > > > times out during suspend_noirq: > > > > > > > > > > > > > > [ 41.024193] buck4: failed to disable: -ETIMEDOUT > > > > > > > > > > > > > > So fix system suspend and resume for these power-domains by > > > > > > > using > > > > > > > the > > > > > > > "outer" suspend/resume callbacks instead. Tested on the > > > > > > > imx8mq- > > > > > > > librem5 board, > > > > > > > but by looking at the dts, this will fix imx8mq-evk and > > > > > > > possibly > > > > > > > many other > > > > > > > boards too. > > > > > > > > > > > > > > This is designed so that genpd providers just say "this > > > > > > > genpd > > > > > > > needs > > > > > > > interrupts" (by setting the flag) - without implying an > > > > > > > implementation. > > > > > > > > > > > > > > Initially system suspend problems had been discussed at > > > > > > > https://lore.kernel.org/linux-arm-kernel/20211002005954.1367653-8-l.stach@pengutronix.de/ > > > > > > > which led to discussing the pmic that contains the > > > > > > > regulators > > > > > > > which > > > > > > > serve as power-domain power-supplies: > > > > > > > https://lore.kernel.org/linux-pm/573166b75e524517782471c2b7f96e03fd93d175.camel@puri.sm/T/ > > > > > > > > > > > > > > Signed-off-by: Martin Kepplinger > > > > > > > > > > > > > > --- > > > > > > > drivers/base/power/domain.c | 13 +++++++++++-- > > > > > > > include/linux/pm_domain.h | 5 +++++ > > > > > > > 2 files changed, 16 insertions(+), 2 deletions(-) > > > > > > > > > > > > > > diff --git a/drivers/base/power/domain.c > > > > > > > b/drivers/base/power/domain.c > > > > > > > index 5a2e0232862e..58376752a4de 100644 > > > > > > > --- a/drivers/base/power/domain.c > > > > > > > +++ b/drivers/base/power/domain.c > > > > > > > @@ -130,6 +130,7 @@ static const struct genpd_lock_ops > > > > > > > genpd_spin_ops = { > > > > > > > #define genpd_is_active_wakeup(genpd) (genpd->flags & > > > > > > > GENPD_FLAG_ACTIVE_WAKEUP) > > > > > > > #define genpd_is_cpu_domain(genpd) (genpd->flags & > > > > > > > GENPD_FLAG_CPU_DOMAIN) > > > > > > > #define genpd_is_rpm_always_on(genpd) (genpd->flags & > > > > > > > GENPD_FLAG_RPM_ALWAYS_ON) > > > > > > > +#define genpd_irq_on(genpd) (genpd->flags & > > > > > > > GENPD_FLAG_IRQ_ON) > > > > > > > > > > > > > > static inline bool irq_safe_dev_in_sleep_domain(struct > > > > > > > device > > > > > > > *dev, > > > > > > > const struct generic_pm_domain *genpd) > > > > > > > @@ -2065,8 +2066,15 @@ int pm_genpd_init(struct > > > > > > > generic_pm_domain > > > > > > > *genpd, > > > > > > > genpd->domain.ops.runtime_suspend = > > > > > > > genpd_runtime_suspend; > > > > > > > genpd->domain.ops.runtime_resume = > > > > > > > genpd_runtime_resume; > > > > > > > genpd->domain.ops.prepare = genpd_prepare; > > > > > > > - genpd->domain.ops.suspend_noirq = > > > > > > > genpd_suspend_noirq; > > > > > > > - genpd->domain.ops.resume_noirq = > > > > > > > genpd_resume_noirq; > > > > > > > + > > > > > > > + if (genpd_irq_on(genpd)) { > > > > > > > + genpd->domain.ops.suspend = > > > > > > > genpd_suspend_noirq; > > > > > > > + genpd->domain.ops.resume = > > > > > > > genpd_resume_noirq; > > > > > > > + } else { > > > > > > > + genpd->domain.ops.suspend_noirq = > > > > > > > genpd_suspend_noirq; > > > > > > > + genpd->domain.ops.resume_noirq = > > > > > > > genpd_resume_noirq; > > > > > > > > > > > > As we discussed previously, I am thinking that it may be > > > > > > better > > > > > > to > > > > > > move to using genpd->domain.ops.suspend_late and > > > > > > genpd->domain.ops.resume_early instead. > > > > > > > > > > Wouldn't that better be a separate patch (on top)? Do you > > > > > really > > > > > want > > > > > me to change the current behaviour (default case) to from noirq > > > > > to > > > > > late? Then I'll resend this series with such a patch added. > > > > > > > > Sorry, I wasn't clear enough, the default behaviour should remain > > > > as > > > > is. > > > > > > > > What I meant was, when genpd_irq_on() is true, we should use the > > > > genpd->domain.ops.suspend_late and genpd- > > > > >domain.ops.resume_early. > > > > > > Testing that shows that this isn't working. I can provide the logs > > > later, but suspend fails and I think it makes sense: "suspend_late" > > > is > > > simply already too late when i2c (or any needed driver) uses > > > "suspend". > > > > Okay, I see. > > > > The reason why I suggested moving the callbacks to "suspend_late", > > was > > that I was worried that some of the attached devices to genpd could > > use "suspend_late" themselves. This is the case for some drivers for > > DMA/clock/gpio/pinctrl-controllers, for example. That said, I am > > curious to look at the DT files for the platform you are running, > > would you mind giving me a pointer? > > I'm running > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi > with these (small) patches on top: > https://source.puri.sm/martin.kepplinger/linux-next/-/commits/5.19.3/librem5 Thanks for sharing the information! > > > > > So, this made me think about this a bit more. In the end, just using > > different levels (suspend, suspend_late, suspend_noirq) of callbacks > > are just papering over the real *dependency* problem. > > true, it doesn't feel like a stable solution. > > > > > What we need for the genpd provider driver, is to be asked to be > > suspended under the following conditions: > > 1. All consumer devices (and child-domains) for its corresponding PM > > domain have been suspended. > > 2. All its supplier devices supplies must remain resumed, until the > > genpd provider has been suspended. > > > > Please allow me a few more days to think in more detail about this. > > Thanks a lot for thinking about this! I have made some more thinking, but it's been a busy period for me, so unfortunately I need some additional time (another week). It seems like I also need to do some prototyping, to convince myself about the approach. So, my apologies for the delay! Kind regards Uffe _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel