All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ulf Hansson <ulf.hansson@linaro.org>
To: YueHaibing <yuehaibing@huawei.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>,
	Thierry Reding <thierry.reding@gmail.com>,
	Jon Hunter <jonathanh@nvidia.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
	linux-tegra@vger.kernel.org
Subject: Re: [PATCH] mmc: tegra: fix inconsistent IS_ERR and PTR_ERR
Date: Tue, 4 Sep 2018 16:34:36 +0200	[thread overview]
Message-ID: <CAPDyKFqSqsXLt0HPJNXbmsfia53yHk5GaPhDpGo=NL1nMp-JRw@mail.gmail.com> (raw)
In-Reply-To: <20180904025909.13700-1-yuehaibing@huawei.com>

On 4 September 2018 at 04:59, YueHaibing <yuehaibing@huawei.com> wrote:
> Fix inconsistent IS_ERR and PTR_ERR in tegra_sdhci_init_pinctrl_info,
> the proper pointer to be passed as argument is 'pinctrl_state_1v8'
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Thanks, applied for next!

Kind regards
Uffe

> ---
>  drivers/mmc/host/sdhci-tegra.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c
> index e80716c..c789158 100644
> --- a/drivers/mmc/host/sdhci-tegra.c
> +++ b/drivers/mmc/host/sdhci-tegra.c
> @@ -724,7 +724,7 @@ static int tegra_sdhci_init_pinctrl_info(struct device *dev,
>                 pinctrl_lookup_state(tegra_host->pinctrl_sdmmc, "sdmmc-1v8");
>         if (IS_ERR(tegra_host->pinctrl_state_1v8)) {
>                 dev_warn(dev, "Missing 1.8V pad state, err: %ld\n",
> -                        PTR_ERR(tegra_host->pinctrl_state_3v3));
> +                        PTR_ERR(tegra_host->pinctrl_state_1v8));
>                 return -1;
>         }
>
> --
> 2.7.0
>
>

      parent reply	other threads:[~2018-09-04 14:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-04  2:59 [PATCH] mmc: tegra: fix inconsistent IS_ERR and PTR_ERR YueHaibing
2018-09-04  2:59 ` YueHaibing
2018-09-04 10:13 ` Aapo Vienamo
2018-09-04 10:13   ` Aapo Vienamo
2018-09-04 14:34 ` Ulf Hansson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPDyKFqSqsXLt0HPJNXbmsfia53yHk5GaPhDpGo=NL1nMp-JRw@mail.gmail.com' \
    --to=ulf.hansson@linaro.org \
    --cc=adrian.hunter@intel.com \
    --cc=jonathanh@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=thierry.reding@gmail.com \
    --cc=yuehaibing@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.