From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: ARC-Seal: i=1; a=rsa-sha256; t=1526308553; cv=none; d=google.com; s=arc-20160816; b=BI5Ahfol0EBuxoVT32NKMUD/e1ld8d82MUUtdSM07ZovrJuSyd9BlpGh9ooquOgy+r fuvNtkiQDAWLxwM9M0oeooTUKirqN/U6ktaK4UWcs9E/7XoTLY98mV3p7URb3D5Mxzfo MVO6pJk+s6xI66vKUJpWIcZ+CucCT3ObwO3WIdQz2bjXQERgOXBH/BNgKlvILNVNFrK3 O48oGkSH1XhVQ9cNH11/GahHoZKH57E39mQBbWTh/22EV51CyO/FIr959exe0P8h76XT jPFa9dXRzYqg3xOjd0WkCDmfmBj6YhuxKYivxf3c7d6EhB6f6jNSFF8asPvX2iXFv9N/ vKsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:dkim-signature:arc-authentication-results; bh=zLI6CkfNIwXpOre0tjLJaG68qltRG/XfRp47Oq3uJpA=; b=o6WblcBgqNiuJqCLgkBhaiu+ywveeSe91yawJgA1LM/vJo9pjvg1MSP0vrSrdZ6mWB zvyC+hxBRF39Lr+DISOatr6sV1+6MRVairwQMZ+PoeRY394S9/1nrJx/KNz7Pa8VBhaE 5Ph07o3/DlmHJiiHsVWO/cfvL8ANfpiivBpWxAq4vLzJbf+jR8mZkNhxSxz7mIKfayIH w/pMLFkehzIu/ugDs0RmBr3KWuMUD0XscfitOQ+DO5UZEJXNkXucX+BYBUic+s/L93Q6 erqQ77ncyuLnQllpdIeu7kWC0qUWjOpl8MU1JOQk98IEVvzI81lMt45DRnwfrvgq5065 O9eQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=jQ0JJQ5V; spf=pass (google.com: domain of ulf.hansson@linaro.org designates 209.85.220.65 as permitted sender) smtp.mailfrom=ulf.hansson@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=jQ0JJQ5V; spf=pass (google.com: domain of ulf.hansson@linaro.org designates 209.85.220.65 as permitted sender) smtp.mailfrom=ulf.hansson@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org X-Google-Smtp-Source: AB8JxZpY2vVsHVJdWJuraZZ/YpwVlmOVWCgz6nBYpTk/+TiqUwXECURFh8MqgIwIv/4Vagh7OAUtjavMruBTEHmgTBI= MIME-Version: 1.0 In-Reply-To: References: From: Ulf Hansson Date: Mon, 14 May 2018 16:35:52 +0200 Message-ID: Subject: Re: [FAIL bisect] Sound card probe error To: Krzysztof Kozlowski , "Rafael J. Wysocki" Cc: Sylwester Nawrocki , Greg Kroah-Hartman , "Rafael J. Wysocki" , Marek Szyprowski , Mark Brown , Inki Dae , "linux-samsung-soc@vger.kernel.org" , Linux Kernel Mailing List , Linux ARM , Andrzej Hajda Content-Type: text/plain; charset="UTF-8" X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1600434255100788752?= X-GMAIL-MSGID: =?utf-8?q?1600450517864551424?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On 14 May 2018 at 14:43, Krzysztof Kozlowski wrote: > On Mon, May 14, 2018 at 2:30 PM, Ulf Hansson wrote: >> On 14 May 2018 at 14:22, Sylwester Nawrocki wrote: >>> Hi, >>> >>> On 05/14/2018 12:17 PM, Krzysztof Kozlowski wrote: >>> >>>> Bisected to: >>>> 8c123c14bbba4add148536b6d47a9226deda2f7a is the first bad commit >>>> commit 8c123c14bbba4add148536b6d47a9226deda2f7a >>>> Author: Ulf Hansson >>>> Date: Thu Apr 26 10:53:06 2018 +0200 >>>> >>>> driver core: Respect all error codes from dev_pm_domain_attach() >>>> >>>> The limitation of being able to check only for -EPROBE_DEFER from >>>> dev_pm_domain_attach() has been removed. Hence let's respect all error >>>> codes and bail out accordingly. >>>> >>>> Signed-off-by: Ulf Hansson >>>> Acked-by: Greg Kroah-Hartman >>>> Signed-off-by: Rafael J. Wysocki >>> >>> The DRM driver creates the HDMI codec but its registration fails, due >>> to some missing clocks. The clock are missing because the exynos5-subcmu >>> driver probing fails. >>> >>> [ 0.678578] exynos5-subcmu: probe of GSC failed with error -17 >>> [ 0.679250] exynos5-subcmu: probe of MFC failed with error -17 >>> [ 0.679992] exynos5-subcmu: probe of DISP failed with error -17 >>> >>> The exynos5-subcmu driver before registering platform device makes >>> of_genpd_add_device() call, so in platform_drv_probe() dev_pm_domain_attach() >>> call will fail, as dev->pm_domain is already set. Previously the error >>> was masked by code removed in the above commit and platform_drv_probe() >>> was could complete successfully. >> >> Thanks for providing this information! >> >> I was about to tell that I overlooked the fact that there is more than >> one way to assign PM domain pointers to devices. To fix the problem, >> dev_pm_domain_attach() should return 0, not -EEXIST when it finds and >> existing PM domain pointer. >> >> Does the below patch fix the problem? >> >> From: Ulf Hansson >> Date: Mon, 14 May 2018 14:26:16 +0200 >> Subject: [PATCH] PM / Domains: Don't return -EEXIST at attach when PM domain >> exists >> >> As dev_pm_domain_attach() isn't the only way to assign PM domain pointers >> to devices, clearly we must allow a device to have the pointer already >> being assigned. For this reason, return 0 instead of -EEXIST. >> >> Reported-by: Krzysztof Kozlowski >> Signed-off-by: Ulf Hansson >> --- >> drivers/base/power/common.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > > Yes, this fixes the issue. > Tested-by: Krzysztof Kozlowski Thanks for the confirmation! I am going to re-post the patch to include linux-pm, then let's see how Rafael wants to handle it. Kind regards Uffe From mboxrd@z Thu Jan 1 00:00:00 1970 From: ulf.hansson@linaro.org (Ulf Hansson) Date: Mon, 14 May 2018 16:35:52 +0200 Subject: [FAIL bisect] Sound card probe error In-Reply-To: References: Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 14 May 2018 at 14:43, Krzysztof Kozlowski wrote: > On Mon, May 14, 2018 at 2:30 PM, Ulf Hansson wrote: >> On 14 May 2018 at 14:22, Sylwester Nawrocki wrote: >>> Hi, >>> >>> On 05/14/2018 12:17 PM, Krzysztof Kozlowski wrote: >>> >>>> Bisected to: >>>> 8c123c14bbba4add148536b6d47a9226deda2f7a is the first bad commit >>>> commit 8c123c14bbba4add148536b6d47a9226deda2f7a >>>> Author: Ulf Hansson >>>> Date: Thu Apr 26 10:53:06 2018 +0200 >>>> >>>> driver core: Respect all error codes from dev_pm_domain_attach() >>>> >>>> The limitation of being able to check only for -EPROBE_DEFER from >>>> dev_pm_domain_attach() has been removed. Hence let's respect all error >>>> codes and bail out accordingly. >>>> >>>> Signed-off-by: Ulf Hansson >>>> Acked-by: Greg Kroah-Hartman >>>> Signed-off-by: Rafael J. Wysocki >>> >>> The DRM driver creates the HDMI codec but its registration fails, due >>> to some missing clocks. The clock are missing because the exynos5-subcmu >>> driver probing fails. >>> >>> [ 0.678578] exynos5-subcmu: probe of GSC failed with error -17 >>> [ 0.679250] exynos5-subcmu: probe of MFC failed with error -17 >>> [ 0.679992] exynos5-subcmu: probe of DISP failed with error -17 >>> >>> The exynos5-subcmu driver before registering platform device makes >>> of_genpd_add_device() call, so in platform_drv_probe() dev_pm_domain_attach() >>> call will fail, as dev->pm_domain is already set. Previously the error >>> was masked by code removed in the above commit and platform_drv_probe() >>> was could complete successfully. >> >> Thanks for providing this information! >> >> I was about to tell that I overlooked the fact that there is more than >> one way to assign PM domain pointers to devices. To fix the problem, >> dev_pm_domain_attach() should return 0, not -EEXIST when it finds and >> existing PM domain pointer. >> >> Does the below patch fix the problem? >> >> From: Ulf Hansson >> Date: Mon, 14 May 2018 14:26:16 +0200 >> Subject: [PATCH] PM / Domains: Don't return -EEXIST at attach when PM domain >> exists >> >> As dev_pm_domain_attach() isn't the only way to assign PM domain pointers >> to devices, clearly we must allow a device to have the pointer already >> being assigned. For this reason, return 0 instead of -EEXIST. >> >> Reported-by: Krzysztof Kozlowski >> Signed-off-by: Ulf Hansson >> --- >> drivers/base/power/common.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > > Yes, this fixes the issue. > Tested-by: Krzysztof Kozlowski Thanks for the confirmation! I am going to re-post the patch to include linux-pm, then let's see how Rafael wants to handle it. Kind regards Uffe