From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E718C3524D for ; Tue, 4 Feb 2020 16:11:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 31B9721744 for ; Tue, 4 Feb 2020 16:11:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="A21gEwgi" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727308AbgBDQLa (ORCPT ); Tue, 4 Feb 2020 11:11:30 -0500 Received: from mail-ua1-f68.google.com ([209.85.222.68]:43746 "EHLO mail-ua1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727310AbgBDQLa (ORCPT ); Tue, 4 Feb 2020 11:11:30 -0500 Received: by mail-ua1-f68.google.com with SMTP id o42so6921611uad.10 for ; Tue, 04 Feb 2020 08:11:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3Wna36vo5UJeWT90pPlyYZdqk7kd5cJ0fLDcJ01xAb0=; b=A21gEwgiD1x55Cgg9LjGfwbgFr/pS5Aa5glZkaPN7ewWZr/AH0Ut8TFTqMXagzixII y8sWSkkrWyr8VTB+HQi587L2bzikWmqncXEqczU4GRd//Y2QP4QzAqDdpemle9Gx7TmS ZqhPoj2VUI2qjwzncsxNVVYt7jOZQPsWfcsuHdfqNnAylB0pHJwSk9FNSlSYg8DDtG9E YbxGiVEcPl2GkyvB4xTgsGSkrhVY1V5NiWFIFA7qflV7rgMwWepSjz71KmQFVPppN+Ea FXtbPXPIhygSTNxHKTu2nZ/U1sjRvLcmKrstFw5MmhQbKI+Vh7JXa5PgOzWZ3VVtVcMX 79Pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3Wna36vo5UJeWT90pPlyYZdqk7kd5cJ0fLDcJ01xAb0=; b=P0LMua13Z5tDw9zeFeTFVQ3TCX/yADfva1HW5tS/Wf/NFJ7ZOoJHm+OTbR418n67Nx lnbdmOfgY/YSrdt5BseayP0xO+lXe2bFk+90sFzlCCmNZ1J3VpWkp3IFIeFCVWt6sQjA ar5nSU+V+o/4WLiPWviwkW+x60/pzlSnnPTi6nFb3hNJwjuCwm6dFxdVBL0SK4+RNk7S AqFm1wMTQz4nB/x4D7AnTyEwhU5vf6alEUpkYxOOhXCLnEziJjhmhEOn0skLNALZpnro S6i6XiSmKbdrQ9KzW5lGjuMUIQ4h0oJQbqzAH38hLkK9KoK7nK/zyTfC6387M88seDeQ IlSA== X-Gm-Message-State: APjAAAXxkh/SVELLMCqSqd61NibJHFXPvRNDCn44iq+p8dL4FrCUXdQT erEC6XC4YUAarhWdbIRiUsoGvAT3Ds6TqnhqRi60hQ== X-Google-Smtp-Source: APXvYqxOPdcglcZaUAT0pZaljv73i4NlWwFKpThbuWemE8YWkXfRhT7zfpj0xd/OaNAUkecAe3IzrKUUtxl5vdmvEEc= X-Received: by 2002:ab0:e16:: with SMTP id g22mr17400525uak.129.1580832689305; Tue, 04 Feb 2020 08:11:29 -0800 (PST) MIME-Version: 1.0 References: <1574254593-16078-1-git-send-email-thara.gopinath@linaro.org> <1574254593-16078-3-git-send-email-thara.gopinath@linaro.org> In-Reply-To: <1574254593-16078-3-git-send-email-thara.gopinath@linaro.org> From: Ulf Hansson Date: Tue, 4 Feb 2020 17:10:53 +0100 Message-ID: Subject: Re: [Patch v4 2/7] soc: qcom: rpmhpd: Introduce function to retrieve power domain performance state count To: Thara Gopinath Cc: Eduardo Valentin , Zhang Rui , Daniel Lezcano , Bjorn Andersson , Andy Gross , Amit Kucheria , Mark Rutland , "Rafael J. Wysocki" , Linux PM , DTML , linux-arm-msm , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Wed, 20 Nov 2019 at 13:56, Thara Gopinath wrote: > > Populate .get_performace_state_count in genpd ops to retrieve the count of > performance states supported by a rpmh power domain. > > Signed-off-by: Thara Gopinath Apologize for the delays! Re-kicking reviews now, I will provide further comments later today or tomorrow. For this one: Reviewed-by: Ulf Hansson Kind regards Uffe > --- > drivers/soc/qcom/rpmhpd.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/drivers/soc/qcom/rpmhpd.c b/drivers/soc/qcom/rpmhpd.c > index 5741ec3..9d37534 100644 > --- a/drivers/soc/qcom/rpmhpd.c > +++ b/drivers/soc/qcom/rpmhpd.c > @@ -285,6 +285,13 @@ static unsigned int rpmhpd_get_performance_state(struct generic_pm_domain *genpd > return dev_pm_opp_get_level(opp); > } > > +static int rpmhpd_performance_states_count(struct generic_pm_domain *domain) > +{ > + struct rpmhpd *pd = domain_to_rpmhpd(domain); > + > + return pd->level_count; > +} > + > static int rpmhpd_update_level_mapping(struct rpmhpd *rpmhpd) > { > int i; > @@ -373,6 +380,8 @@ static int rpmhpd_probe(struct platform_device *pdev) > rpmhpds[i]->pd.power_on = rpmhpd_power_on; > rpmhpds[i]->pd.set_performance_state = rpmhpd_set_performance_state; > rpmhpds[i]->pd.opp_to_performance_state = rpmhpd_get_performance_state; > + rpmhpds[i]->pd.get_performance_state_count = > + rpmhpd_performance_states_count; > pm_genpd_init(&rpmhpds[i]->pd, NULL, true); > > data->domains[i] = &rpmhpds[i]->pd; > -- > 2.1.4 >