From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04C4CC432BE for ; Fri, 27 Aug 2021 14:45:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D731160F4C for ; Fri, 27 Aug 2021 14:45:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233282AbhH0Op4 (ORCPT ); Fri, 27 Aug 2021 10:45:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52360 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233079AbhH0Op4 (ORCPT ); Fri, 27 Aug 2021 10:45:56 -0400 Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [IPv6:2a00:1450:4864:20::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 455F3C061757 for ; Fri, 27 Aug 2021 07:45:07 -0700 (PDT) Received: by mail-lf1-x133.google.com with SMTP id x27so14905900lfu.5 for ; Fri, 27 Aug 2021 07:45:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fPzxOIvGsTyz9w7SKmrDx7J/vThP1s5YQWVEdvQ3C48=; b=w5Gz1Zw6lKlt3MVJJonQEaWT9c3wLiTbHU3ouUSFwVhf2n6Em5SjXoMDFSOAL6tqLP oY/sihEvw29t46J/3TnMbwd1G83kDDnl1hWDsJA1QvceB6PPTRQVaRLgnuw7HepHZolK NAuy3DCfbZZUCaQ3mGVGnZE/2j3I+vok82QzE9dda/DGVZcdUg7UApv4vge6D1uo0PSt vgG5SnuVagfQEuTs+fbOlRiur2VL8EgyA6XDcZ3ZAZvTxa3HyQZRSoxwgECEod2FB15L UCcxtE3UyD3WbNvfMxEKtMtQ0Q5iaK6n9FZXYImLrAHkp0XaY7Rwoerx1suLFcCgearm AaKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fPzxOIvGsTyz9w7SKmrDx7J/vThP1s5YQWVEdvQ3C48=; b=QhjllfFiJxMa3a/Z2/oapfbSfMI26hrT9YZzqi6GArkjJzF57pafMGGyupYTG8mZiw MU5ve90+uigy+6uQYq0lf28obgWRfs4gaWuYSXBWqgRkYtt8FlU+fSq3zM//1eY4LHys JLaVM71JR3ts7FfGe9Jzf5g1/dsfj0vOWreyTMruE4lFkS1yCxi1DWHVu+NRtU7qFK/Z P0HVR3fBT2sy7gB2KQTjGGgSlq81PI6n20h21E+UeqDiYgjhH0tzLWJ6AboXmW9gpf8z AM4wjsQhqPHdoHKi+H0aRwyNZVU97kceY/2j5H+3U8rNUGZ8nc3PQnX9inR37wVl9Kv7 f2Yw== X-Gm-Message-State: AOAM530PnzbLWMMTQ+8vkSDPwfPk/VV5n+hncZv1dAcTH0t3/2Ii93c2 hT0Czgvqm0b9kmFDGk2JmVZqheHCQewsRbd8hTMU2A== X-Google-Smtp-Source: ABdhPJzFvyxkVD7VCOu2ppCBvck5NduKSFyMtwmbo55aJImBw1yBWxcyKQLNeBXSX7tb+LHt77snFrsQoxQ6TJt57Bg= X-Received: by 2002:a19:655e:: with SMTP id c30mr6918317lfj.142.1630075505658; Fri, 27 Aug 2021 07:45:05 -0700 (PDT) MIME-Version: 1.0 References: <1628334401-6577-1-git-send-email-stefan.wahren@i2se.com> <1628334401-6577-6-git-send-email-stefan.wahren@i2se.com> <3e8bfa67-e3fe-bcfd-1941-90cae7ed0176@arm.com> <127aeb73-528d-9118-3f84-6ad6c6debe84@i2se.com> In-Reply-To: <127aeb73-528d-9118-3f84-6ad6c6debe84@i2se.com> From: Ulf Hansson Date: Fri, 27 Aug 2021 16:44:28 +0200 Message-ID: Subject: Re: [PATCH V2 05/10] mmc: sdhci-iproc: Set SDHCI_QUIRK_CAP_CLOCK_BASE_BROKEN on BCM2711 To: Stefan Wahren , Jeremy Linton Cc: Rob Herring , Nicolas Saenz Julienne , Florian Fainelli , Adrian Hunter , Ray Jui , Scott Branden , BCM Kernel Feedback , Maxime Ripard , iivanov@suse.de, DTML , "moderated list:BROADCOM BCM2835..." , linux-mmc , Linux ARM Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, 26 Aug 2021 at 13:18, Stefan Wahren wrote: > > Am 26.08.21 um 11:22 schrieb Ulf Hansson: > > On Thu, 26 Aug 2021 at 08:36, Jeremy Linton wrote: > >> Hi, > >> > >> > >> On 8/7/21 6:06 AM, Stefan Wahren wrote: > >>> From: Nicolas Saenz Julienne > >>> > >>> The controller doesn't seem to pick-up on clock changes, so set the > >>> SDHCI_QUIRK_CAP_CLOCK_BASE_BROKEN flag to query the clock frequency > >>> directly from the clock. > >>> > >>> Fixes: f84e411c85be ("mmc: sdhci-iproc: Add support for emmc2 of the BCM2711") > >>> Signed-off-by: Nicolas Saenz Julienne > >>> Signed-off-by: Stefan Wahren > >>> --- > >>> drivers/mmc/host/sdhci-iproc.c | 3 ++- > >>> 1 file changed, 2 insertions(+), 1 deletion(-) > >>> > >>> diff --git a/drivers/mmc/host/sdhci-iproc.c b/drivers/mmc/host/sdhci-iproc.c > >>> index 032bf85..e7565c6 100644 > >>> --- a/drivers/mmc/host/sdhci-iproc.c > >>> +++ b/drivers/mmc/host/sdhci-iproc.c > >>> @@ -295,7 +295,8 @@ static const struct sdhci_ops sdhci_iproc_bcm2711_ops = { > >>> }; > >>> > >>> static const struct sdhci_pltfm_data sdhci_bcm2711_pltfm_data = { > >>> - .quirks = SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12, > >>> + .quirks = SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12 | > >>> + SDHCI_QUIRK_CAP_CLOCK_BASE_BROKEN, > >>> .ops = &sdhci_iproc_bcm2711_ops, > >>> }; > >> I just noticed that this got merged to rc7, and it breaks the ACPI based > >> rpi's because it causes the 100Mhz max clock to be overridden to the > >> return from sdhci_iproc_get_max_clock() which is 0 because there isn't a > >> OF/DT based clock device. > > Thanks for reporting! I allow Stefan to respond in a day or two, > > before I do a revert of it. > > I'm fine with a revert. > > Thanks Patch reverted and applied for fixes, thanks! Kind regards Uffe From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CC1EC432BE for ; Fri, 27 Aug 2021 14:47:25 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C8D8E60F4C for ; Fri, 27 Aug 2021 14:47:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C8D8E60F4C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kWSmlQTaQQvzXuyMVr52ZdMmoBaeJK3t495k3CwtapM=; b=TY26BipFDOGZyZ oO+sshDHpiiqjU2MTZZe+WCEYfl8LUv27TZMZOZVbrwk7+nze8263VsE2noJ2cfuCyYuwMu35dxFW 5TuhVOo4QA3h6fNM1brN7N4HPzuMPPhQ1+ViXeLqpqjeaWhTspLDVYHIdASRbEdZ00cXvTZw10LKm CRI8/MyiOP9PPXWj5K96GVn7vNoXg4y5L4CXVIJ9ivN0yKje5LqvTLUAzC0QU3OjQEiI3GW3pVz+D wAw5YGfCNa+iV1UdcFB+14EogPxRNIHnJJCgRiwDkH/7Xw5Ih++tZeSFmmz1x0msHyiU5BojIopxJ ejWpMQdkyR9k4M/PV8cw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mJd6Z-00CZZx-3z; Fri, 27 Aug 2021 14:45:15 +0000 Received: from mail-lf1-x12e.google.com ([2a00:1450:4864:20::12e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mJd6S-00CZZ7-Kl for linux-arm-kernel@lists.infradead.org; Fri, 27 Aug 2021 14:45:12 +0000 Received: by mail-lf1-x12e.google.com with SMTP id k5so14902392lfu.4 for ; Fri, 27 Aug 2021 07:45:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fPzxOIvGsTyz9w7SKmrDx7J/vThP1s5YQWVEdvQ3C48=; b=w5Gz1Zw6lKlt3MVJJonQEaWT9c3wLiTbHU3ouUSFwVhf2n6Em5SjXoMDFSOAL6tqLP oY/sihEvw29t46J/3TnMbwd1G83kDDnl1hWDsJA1QvceB6PPTRQVaRLgnuw7HepHZolK NAuy3DCfbZZUCaQ3mGVGnZE/2j3I+vok82QzE9dda/DGVZcdUg7UApv4vge6D1uo0PSt vgG5SnuVagfQEuTs+fbOlRiur2VL8EgyA6XDcZ3ZAZvTxa3HyQZRSoxwgECEod2FB15L UCcxtE3UyD3WbNvfMxEKtMtQ0Q5iaK6n9FZXYImLrAHkp0XaY7Rwoerx1suLFcCgearm AaKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fPzxOIvGsTyz9w7SKmrDx7J/vThP1s5YQWVEdvQ3C48=; b=IeshF/KOKgRMmKHOk9Kylh0/SE0kGtW1nzE8LE8ki+iiIfwZ7660peZhuVmd04uEdd OAQss9PfyKFBV2VUB4C/EyB6Ss9jPu+66eKCEaGPE0I0f8eRqF/tVdy5fvhIK+Rj5Tx+ D3UDSxg/aY4gya1a2VutQE/+T+mvzxj6Y3DTldok5/n5M0TozNvf2CdvMHNtnGlCmAtE oeikYSTNWUWOi3Gbu+ow5zCGZhE3r9GofNqMUiUTx2WKI8SST4qsYjKTtRkiFjfsqh+A 9d1LzqrJZHPpfFYIkg96wzW5GxtogGA+M22y33Jw+xVUHz0PIBRJd2PkICj7ox4SmM3k +7Cw== X-Gm-Message-State: AOAM533ikYE64goxitBvfK337GwTj8jMb4yKqcGl7YhXpbMPIHnXOddP xS4HiUdqGbeNWoa0ttceY4c7VefeeB8YRJ7iYvunBg== X-Google-Smtp-Source: ABdhPJzFvyxkVD7VCOu2ppCBvck5NduKSFyMtwmbo55aJImBw1yBWxcyKQLNeBXSX7tb+LHt77snFrsQoxQ6TJt57Bg= X-Received: by 2002:a19:655e:: with SMTP id c30mr6918317lfj.142.1630075505658; Fri, 27 Aug 2021 07:45:05 -0700 (PDT) MIME-Version: 1.0 References: <1628334401-6577-1-git-send-email-stefan.wahren@i2se.com> <1628334401-6577-6-git-send-email-stefan.wahren@i2se.com> <3e8bfa67-e3fe-bcfd-1941-90cae7ed0176@arm.com> <127aeb73-528d-9118-3f84-6ad6c6debe84@i2se.com> In-Reply-To: <127aeb73-528d-9118-3f84-6ad6c6debe84@i2se.com> From: Ulf Hansson Date: Fri, 27 Aug 2021 16:44:28 +0200 Message-ID: Subject: Re: [PATCH V2 05/10] mmc: sdhci-iproc: Set SDHCI_QUIRK_CAP_CLOCK_BASE_BROKEN on BCM2711 To: Stefan Wahren , Jeremy Linton Cc: Rob Herring , Nicolas Saenz Julienne , Florian Fainelli , Adrian Hunter , Ray Jui , Scott Branden , BCM Kernel Feedback , Maxime Ripard , iivanov@suse.de, DTML , "moderated list:BROADCOM BCM2835..." , linux-mmc , Linux ARM X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210827_074508_730417_9E4B58AF X-CRM114-Status: GOOD ( 25.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 26 Aug 2021 at 13:18, Stefan Wahren wrote: > > Am 26.08.21 um 11:22 schrieb Ulf Hansson: > > On Thu, 26 Aug 2021 at 08:36, Jeremy Linton wrote: > >> Hi, > >> > >> > >> On 8/7/21 6:06 AM, Stefan Wahren wrote: > >>> From: Nicolas Saenz Julienne > >>> > >>> The controller doesn't seem to pick-up on clock changes, so set the > >>> SDHCI_QUIRK_CAP_CLOCK_BASE_BROKEN flag to query the clock frequency > >>> directly from the clock. > >>> > >>> Fixes: f84e411c85be ("mmc: sdhci-iproc: Add support for emmc2 of the BCM2711") > >>> Signed-off-by: Nicolas Saenz Julienne > >>> Signed-off-by: Stefan Wahren > >>> --- > >>> drivers/mmc/host/sdhci-iproc.c | 3 ++- > >>> 1 file changed, 2 insertions(+), 1 deletion(-) > >>> > >>> diff --git a/drivers/mmc/host/sdhci-iproc.c b/drivers/mmc/host/sdhci-iproc.c > >>> index 032bf85..e7565c6 100644 > >>> --- a/drivers/mmc/host/sdhci-iproc.c > >>> +++ b/drivers/mmc/host/sdhci-iproc.c > >>> @@ -295,7 +295,8 @@ static const struct sdhci_ops sdhci_iproc_bcm2711_ops = { > >>> }; > >>> > >>> static const struct sdhci_pltfm_data sdhci_bcm2711_pltfm_data = { > >>> - .quirks = SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12, > >>> + .quirks = SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12 | > >>> + SDHCI_QUIRK_CAP_CLOCK_BASE_BROKEN, > >>> .ops = &sdhci_iproc_bcm2711_ops, > >>> }; > >> I just noticed that this got merged to rc7, and it breaks the ACPI based > >> rpi's because it causes the 100Mhz max clock to be overridden to the > >> return from sdhci_iproc_get_max_clock() which is 0 because there isn't a > >> OF/DT based clock device. > > Thanks for reporting! I allow Stefan to respond in a day or two, > > before I do a revert of it. > > I'm fine with a revert. > > Thanks Patch reverted and applied for fixes, thanks! Kind regards Uffe _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel