From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ua1-f43.google.com (mail-ua1-f43.google.com [209.85.222.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A1CE86D38 for ; Thu, 19 Aug 2021 14:05:27 +0000 (UTC) Received: by mail-ua1-f43.google.com with SMTP id x19so2672503uat.2 for ; Thu, 19 Aug 2021 07:05:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=z8ppYolHk+6MAlg/iRV3TOW64DDORViSUFtjVS4tPfU=; b=pf8lMOnxg/R18hy9RmRXn53gTyaSPBEYPRXidYbCWDeGyj1Q84GnstXRTsE70HIZwL rOZaYQbJ0JsuexxwGKTbxTnmUkIeE3lCIDKi4y5M7EdG4KOJ33bce1Ym5TIJ8eyXrlgP dbE7l+Rznz9FT+hME0DQqhK7lxhDgOPmbvRDcLaquo7wS/EVnyYYfbE9J5SpPQV1WnQ8 fXPIAlBPmH1/Wbcsr6ERwHJaV/U7LQTY8nCTXj0WtrNaCQEnZqZy2yVRdVBh7ZdPgr+l lQknd5LJKpfGihHNxJOG9NmGE/fM0gVDzrjpqFwZqJoFyhmk+xoMBA6IKCATwNl/L1GC MrVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=z8ppYolHk+6MAlg/iRV3TOW64DDORViSUFtjVS4tPfU=; b=UMfMm+3XQrr7sJmZN8FTh/6VgGX/D8i/ygYPvgdHVwP/bvxGbfE+t8H1M0mPdIprhP 1yp4+Mgq5MqsCN1f2oxMTtKNkkIWua/yzF1UuXfcHIdySYztY05JRanzp9TeUgryveRg yWN1QyZfVu0M8UqmxOZG1jlhrj8OmfchHQfVoM8Nmeyy+l1LeEAqdRccvtG8UonqCXlZ 4KYNfOLoxrb/zE9sjYpuObWaK9FudEI1ewTpi82WL0Trcr/EhoYy0pwT7sIAt2CHUULm GavpL38Uin4JYauSSlPUZ16ZZYZQ45Zi8Xxp5qxh8AFy/n9CfZPgQ+PsIP9VKvBaAm3l QySg== X-Gm-Message-State: AOAM532qt/t+OYr8wOwLmRjt7i3dvoGzmLpdy2/ua3wTXueX8qlbB5ji ANypS+tZEmHt1g1yedpX7bvK+1k3APYK596qpyKgEA== X-Google-Smtp-Source: ABdhPJy/9RKTdWSvjYHKQ+0uBbarqxq9rsGLaiJcPg/kihysGVgUWTFM+D2WJBPDbj8B50jGA4KtwzpHd41jDaJSEK8= X-Received: by 2002:a9f:25a7:: with SMTP id 36mr11206760uaf.129.1629381926495; Thu, 19 Aug 2021 07:05:26 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20210817012754.8710-1-digetx@gmail.com> <20210817012754.8710-20-digetx@gmail.com> In-Reply-To: From: Ulf Hansson Date: Thu, 19 Aug 2021 16:04:50 +0200 Message-ID: Subject: Re: [PATCH v8 19/34] pwm: tegra: Add runtime PM and OPP support To: Thierry Reding Cc: Dmitry Osipenko , Jonathan Hunter , Viresh Kumar , Stephen Boyd , Peter De Schrijver , Mikko Perttunen , Peter Chen , Mark Brown , Lee Jones , =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , Nishanth Menon , Vignesh Raghavendra , Richard Weinberger , Miquel Raynal , Lucas Stach , Stefan Agner , Adrian Hunter , Mauro Carvalho Chehab , Rob Herring , Michael Turquette , Linux Kernel Mailing List , linux-tegra , Linux PM , Linux USB List , linux-staging@lists.linux.dev, linux-spi@vger.kernel.org, linux-pwm@vger.kernel.org, linux-mtd@lists.infradead.org, linux-mmc , Linux Media Mailing List , dri-devel , DTML , linux-clk Content-Type: text/plain; charset="UTF-8" On Thu, 19 Aug 2021 at 15:21, Thierry Reding wrote: > > On Tue, Aug 17, 2021 at 04:27:39AM +0300, Dmitry Osipenko wrote: > > The PWM on Tegra belongs to the core power domain and we're going to > > enable GENPD support for the core domain. Now PWM must be resumed using > > runtime PM API in order to initialize the PWM power state. The PWM clock > > rate must be changed using OPP API that will reconfigure the power domain > > performance state in accordance to the rate. Add runtime PM and OPP > > support to the PWM driver. > > > > Signed-off-by: Dmitry Osipenko > > --- > > drivers/pwm/pwm-tegra.c | 104 ++++++++++++++++++++++++++++++++-------- > > 1 file changed, 85 insertions(+), 19 deletions(-) > > Can this be safely applied independently of the rest of the series, or > are there any dependencies on earlier patches? Just to make sure we don't rush something in, I would rather withhold all runtime PM related patches in the series, until we have agreed on how to fix the in genpd/opp core parts. Simply, because those may very well affect the deployments in the drivers. > > Thierry Kind regards Uffe From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D644FC4338F for ; Thu, 19 Aug 2021 14:07:57 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A977861100 for ; Thu, 19 Aug 2021 14:07:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A977861100 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RRukR/5BCjETUX894tvBvHYegAcayo1C16Ndw7xjfUM=; b=JR2VbKMJWPfdsV wa2kaK2wv296QjGwUUwmPlo3ijN2VljDOd+tpNMOrE9AqF/SlnArerXQL0cVwv1oH7SBUmfvwDT/C QopXkhWCuuv/8PlFhxp4ac76NO+rQjix1UI8wPtlLvNRN0EK5hg5cD73ZiFZnZXBMuyFKCpsVUgCF TQihPGlyTkXYNlY7ytS2qyPOj8nkzpFzcbqCtbK5OLpAnq2qHdIHNNiiK/0yqNdcFw3FitOAmgyPL t5srSqzz4rcTY+N2x4sK+AUfXZkuNvyOOro5PuusifTpaZjByeOIKdVVPjIhyyE+jucU03pfZyEaO X9wBO95lpd+NZPDRi5Wg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mGihI-008Z04-RL; Thu, 19 Aug 2021 14:07:09 +0000 Received: from mail-ua1-x92a.google.com ([2607:f8b0:4864:20::92a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mGiff-008YEI-Ts for linux-mtd@lists.infradead.org; Thu, 19 Aug 2021 14:05:31 +0000 Received: by mail-ua1-x92a.google.com with SMTP id m39so2644501uad.9 for ; Thu, 19 Aug 2021 07:05:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=z8ppYolHk+6MAlg/iRV3TOW64DDORViSUFtjVS4tPfU=; b=pf8lMOnxg/R18hy9RmRXn53gTyaSPBEYPRXidYbCWDeGyj1Q84GnstXRTsE70HIZwL rOZaYQbJ0JsuexxwGKTbxTnmUkIeE3lCIDKi4y5M7EdG4KOJ33bce1Ym5TIJ8eyXrlgP dbE7l+Rznz9FT+hME0DQqhK7lxhDgOPmbvRDcLaquo7wS/EVnyYYfbE9J5SpPQV1WnQ8 fXPIAlBPmH1/Wbcsr6ERwHJaV/U7LQTY8nCTXj0WtrNaCQEnZqZy2yVRdVBh7ZdPgr+l lQknd5LJKpfGihHNxJOG9NmGE/fM0gVDzrjpqFwZqJoFyhmk+xoMBA6IKCATwNl/L1GC MrVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=z8ppYolHk+6MAlg/iRV3TOW64DDORViSUFtjVS4tPfU=; b=dadU7GYHspgygEPQPfjVu6+LxlrLrZe2Y3ck0e7dIUcH7Odaxvw0LdqD9L7Cn3+i/8 kkyFVgDst0DnBrC/RqZ05YlyhJdy9uqjs9Hylv5WuomBLX6E3qkgBe9K1N6Ru4Y1hntn QqW9XJEAY82UbhHRcoqTJy1ylPk79JahUNiygXioUmodwMjG0ooaaU3xdXnIpXTVP0Fr pPnYHQn0HQ/ZMMZ4rbMs+QsIQ4qjiAwtEt6MEGMdu+B7LcvUUdrvCQmX7Qbt+q8KDenl j09nENZLgSWFKsgpR/96+H7BKDrGZQBm+JD4vivfddArdK2jw3SxLENARLN9IQVwVPVv 7VxQ== X-Gm-Message-State: AOAM530kQaNHsskk8QPmFP62+W22RcB/vDRb3zzYkUytigq3wXY877Q5 Q1jHSrSqLlke1r2wA5fOkNTILG25rgn7oUgNA6hAqQ== X-Google-Smtp-Source: ABdhPJy/9RKTdWSvjYHKQ+0uBbarqxq9rsGLaiJcPg/kihysGVgUWTFM+D2WJBPDbj8B50jGA4KtwzpHd41jDaJSEK8= X-Received: by 2002:a9f:25a7:: with SMTP id 36mr11206760uaf.129.1629381926495; Thu, 19 Aug 2021 07:05:26 -0700 (PDT) MIME-Version: 1.0 References: <20210817012754.8710-1-digetx@gmail.com> <20210817012754.8710-20-digetx@gmail.com> In-Reply-To: From: Ulf Hansson Date: Thu, 19 Aug 2021 16:04:50 +0200 Message-ID: Subject: Re: [PATCH v8 19/34] pwm: tegra: Add runtime PM and OPP support To: Thierry Reding Cc: Dmitry Osipenko , Jonathan Hunter , Viresh Kumar , Stephen Boyd , Peter De Schrijver , Mikko Perttunen , Peter Chen , Mark Brown , Lee Jones , =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , Nishanth Menon , Vignesh Raghavendra , Richard Weinberger , Miquel Raynal , Lucas Stach , Stefan Agner , Adrian Hunter , Mauro Carvalho Chehab , Rob Herring , Michael Turquette , Linux Kernel Mailing List , linux-tegra , Linux PM , Linux USB List , linux-staging@lists.linux.dev, linux-spi@vger.kernel.org, linux-pwm@vger.kernel.org, linux-mtd@lists.infradead.org, linux-mmc , Linux Media Mailing List , dri-devel , DTML , linux-clk X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210819_070528_041117_1C91D732 X-CRM114-Status: GOOD ( 20.79 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Thu, 19 Aug 2021 at 15:21, Thierry Reding wrote: > > On Tue, Aug 17, 2021 at 04:27:39AM +0300, Dmitry Osipenko wrote: > > The PWM on Tegra belongs to the core power domain and we're going to > > enable GENPD support for the core domain. Now PWM must be resumed using > > runtime PM API in order to initialize the PWM power state. The PWM clock > > rate must be changed using OPP API that will reconfigure the power domain > > performance state in accordance to the rate. Add runtime PM and OPP > > support to the PWM driver. > > > > Signed-off-by: Dmitry Osipenko > > --- > > drivers/pwm/pwm-tegra.c | 104 ++++++++++++++++++++++++++++++++-------- > > 1 file changed, 85 insertions(+), 19 deletions(-) > > Can this be safely applied independently of the rest of the series, or > are there any dependencies on earlier patches? Just to make sure we don't rush something in, I would rather withhold all runtime PM related patches in the series, until we have agreed on how to fix the in genpd/opp core parts. Simply, because those may very well affect the deployments in the drivers. > > Thierry Kind regards Uffe ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/