From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADA4EC433FE for ; Thu, 17 Feb 2022 15:39:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242610AbiBQPkK (ORCPT ); Thu, 17 Feb 2022 10:40:10 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:60904 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238324AbiBQPkI (ORCPT ); Thu, 17 Feb 2022 10:40:08 -0500 Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BD1C52B2E15 for ; Thu, 17 Feb 2022 07:39:53 -0800 (PST) Received: by mail-lf1-x136.google.com with SMTP id b9so10732104lfv.7 for ; Thu, 17 Feb 2022 07:39:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=U2cIkQoSyV/uoYmrp2FFR+PMJsIjwxkMBhA2ESiWt/c=; b=irgKRKkZ9T7jN+IYDnE3HbB0ZKFJSvwHktgqtGHXqrNvrXiBqXAtZ4fRvHLfPiTrJh AqNdJVAnnp4ODJx58Fm4PjIeEbuBMT7hPJlDdT77elMGp/zpfNgcwWaJNa8PgqTOKNRW 7l7b5G3XD9p4n3lbnn1b4jLZ/KH0qtJX+Af8VpbJ+sCB6srjQqWp1P04vYYwpdU962xz MGwmsQkClNOs6sqCeYuDT9kRQZQ3CxViKt1kQjH8JWbhxQCnl39gYbLLNkTUfp/zq6gq GmY/jOpAJKMTDII4B1hnKosm7sn2jk1IAQeeOXkBcc3PwHm51epFQiu0AqjlgxOZAH4H EtjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=U2cIkQoSyV/uoYmrp2FFR+PMJsIjwxkMBhA2ESiWt/c=; b=YN0ZyPf3t4njiKBqgBOHmB2Og45y/SUT2GFaH+Da9MJwz9Q9aLXdF07VmoW9XZmTm1 jX+dBhVYcuL9IrNLJFGxLlN/Vp7FyqoyTJZCfx8vLEhHS/icR5zQLpQ5JpVsyKJoKRKq nPwks4WZyTlyvR2wsxVMnrvUY718Js6aIvGpGfz/JLwZVCq4LUqKaVH3DBc1lOPIHAjU 8qYmrUzjkKQgNddjVJWgECJZqGGcHL+M0tQmlWmIzFtRENGrdTvMyIXHLELtgqh8z7ds Pz49maUhllxLT2LGHy0UCHzxBySOd0AVWfw5h2gJThwWM71SmxV1gb9I12+H+4T4Mgrm KTZA== X-Gm-Message-State: AOAM530HJHwOPgV3gv/coq92hvPFlawoa4+gXUshlCqRRtRtQ1/4/iLS mvEeUrJTMDlKG/TwbDjFRaILgqbP+LW/YjDOAqGN7A== X-Google-Smtp-Source: ABdhPJxySvao13bawbL/6voEBW6OIbyLML55whQqeuxe5in4ddY/RXXRus+yOhL0IM7O4ZRy9PMY9ZEzeviBoYjSv4A= X-Received: by 2002:a19:9144:0:b0:43b:86a4:1497 with SMTP id y4-20020a199144000000b0043b86a41497mr2419922lfj.254.1645112392017; Thu, 17 Feb 2022 07:39:52 -0800 (PST) MIME-Version: 1.0 References: <20220210224933.379149-1-yury.norov@gmail.com> <20220210224933.379149-30-yury.norov@gmail.com> In-Reply-To: <20220210224933.379149-30-yury.norov@gmail.com> From: Ulf Hansson Date: Thu, 17 Feb 2022 16:39:15 +0100 Message-ID: Subject: Re: [PATCH 29/49] memstick: replace bitmap_weight with bitmap_weight_eq where appropriate To: Yury Norov Cc: Andy Shevchenko , Rasmus Villemoes , Andrew Morton , =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , Greg Kroah-Hartman , Peter Zijlstra , David Laight , Joe Perches , Dennis Zhou , Emil Renner Berthing , Nicholas Piggin , Matti Vaittinen , Alexey Klimov , linux-kernel@vger.kernel.org, Maxim Levitsky , Alex Dubov , Jens Axboe , Luis Chamberlain , Colin Ian King , Arnd Bergmann , Shubhankar Kuranagatti , linux-mmc@vger.kernel.org, Shubhankar Kuranagatti Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 11 Feb 2022 at 00:55, Yury Norov wrote: > > msb_validate_used_block_bitmap() calls bitmap_weight() to compare the > weight of bitmap with a given number. We can do it more efficiently with > bitmap_weight_eq because conditional bitmap_weight may stop traversing the > bitmap earlier, as soon as condition is (or can't be) met. > > Signed-off-by: Yury Norov > Acked-by: Ulf Hansson > Acked-by: Shubhankar Kuranagatti Applied for next, thanks! Kind regards Uffe > --- > drivers/memstick/core/ms_block.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/memstick/core/ms_block.c b/drivers/memstick/core/ms_block.c > index 0cda6c6baefc..5cdd987e78f7 100644 > --- a/drivers/memstick/core/ms_block.c > +++ b/drivers/memstick/core/ms_block.c > @@ -155,8 +155,8 @@ static int msb_validate_used_block_bitmap(struct msb_data *msb) > for (i = 0; i < msb->zone_count; i++) > total_free_blocks += msb->free_block_count[i]; > > - if (msb->block_count - bitmap_weight(msb->used_blocks_bitmap, > - msb->block_count) == total_free_blocks) > + if (bitmap_weight_eq(msb->used_blocks_bitmap, msb->block_count, > + msb->block_count - total_free_blocks)) > return 0; > > pr_err("BUG: free block counts don't match the bitmap"); > -- > 2.32.0 >