From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23518C433E0 for ; Mon, 25 May 2020 07:15:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0159D2075F for ; Mon, 25 May 2020 07:15:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="X3f906WA" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388985AbgEYHPy (ORCPT ); Mon, 25 May 2020 03:15:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34836 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388976AbgEYHPx (ORCPT ); Mon, 25 May 2020 03:15:53 -0400 Received: from mail-ua1-x943.google.com (mail-ua1-x943.google.com [IPv6:2607:f8b0:4864:20::943]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7775CC05BD43 for ; Mon, 25 May 2020 00:15:53 -0700 (PDT) Received: by mail-ua1-x943.google.com with SMTP id 14so5787687uaq.11 for ; Mon, 25 May 2020 00:15:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=tW47sLPl7yvQUlpsqFGaRt0/eA0f/XtExRc8VNJ5L8s=; b=X3f906WAm1B7znVikPVukV6tgsYYUkm8v+SSd0x+rtjZfgsQwXU/C5hodPsbUpzf+R BsNenIyHnRQKNVI0gEyOsBlWkBG9l8kpemHYf5arLdSXoKccfSR3MFVTK8U28fiH6RFy zpF/6oIiC1R937exP0cxNj+fLhwVY5mLbZLV4dAnb+aI8JqZcUh6rWxOf0f+av+GNbEO Qno7YKLbvApPD9bO42MZre7gFikypcUpyT6VmJmffeKr84+gD7MR4Fb6R8cH1oPFWWTr ICbH30dzo42Yu5VE2FUsF3x6DtchJd7jbvjnBmUjmQDi3KtvBDtnQfJBA4d0R3eKGEM7 ad7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=tW47sLPl7yvQUlpsqFGaRt0/eA0f/XtExRc8VNJ5L8s=; b=nfAoBHR8katp/1SL/RN0rscQM+iY2d8nD8wUDChIiBug5gyDa/wbWDWsrXaHDqjloZ yI2TNumn6XUvPnKbUOmY7hqbUIMTi6XuKMIjYmtP9Cu/+C5fBnRPz+NXnTdeH5aYXWT8 trKr7RGVm4TqejnPvM3pgvW/GCdcWBbgAC73ct37OAjHxZ4LDkPBebBe3AMG3slKkcEs xsjm8hUQ32kR86hYGhcmEm7WAr/ql/Dbmvr4luQW0iRPs2oIme6xzm7uNJ3A/bLqA2qv TaA+V+3Ud5ZtbEuy26/U/nIkTYZfpy4OuwuYb7HfsCCkqS5d6xIFNZiU9epPAP8Yfx7d m6jQ== X-Gm-Message-State: AOAM532bJJQ8a5J64yjRg/PSEXuXi8Nc8IaPmtNfkDPdkiQH9KNn8Sqr 44p1t+a54D8LHhjVthwp3t0xgO2wW2KsG840jma/rA== X-Google-Smtp-Source: ABdhPJyn+vBET+wry7tIEPuyPG84ngjDJAb2r8EvcfU02yuysMA8153T8p81LOO/yO3mggJ+Oo/TpwlvMW9/07YJ+KQ= X-Received: by 2002:ab0:7293:: with SMTP id w19mr17816123uao.129.1590390952511; Mon, 25 May 2020 00:15:52 -0700 (PDT) MIME-Version: 1.0 References: <20200522144412.19712-1-pali@kernel.org> In-Reply-To: <20200522144412.19712-1-pali@kernel.org> From: Ulf Hansson Date: Mon, 25 May 2020 09:15:16 +0200 Message-ID: Subject: Re: [PATCH 00/11] mmc: sdio: Move SDIO IDs from drivers to common include file To: =?UTF-8?Q?Pali_Roh=C3=A1r?= Cc: "linux-mmc@vger.kernel.org" , Matthias Brugger , Mauro Carvalho Chehab , Kalle Valo , Amitkumar Karwar , Ganapathi Bhat , Xinming Hu , Linux Kernel Mailing List , ath10k@lists.infradead.org, b43-dev@lists.infradead.org, brcm80211-dev-list.pdl@broadcom.com, brcm80211-dev-list , libertas-dev@lists.infradead.org, linux-wireless , =?UTF-8?B?TWFyZWsgQmVow7pu?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Fri, 22 May 2020 at 16:45, Pali Roh=C3=A1r wrote: > > Most SDIO IDs are defined in the common include file linux/mmc/sdio_ids.h= . > But some drivers define IDs locally or do not use existing macros from th= e > common include file. > > This patch series fixes above inconsistency. It defines missing macro nam= es > and moves all remaining SDIO IDs from drivers to the common include file. > Also some macro names are changed to follow existing naming conventions. Thanks - a nice cleanup! I guess this is best queued via my mmc tree, unless bluetooth/wireless maintainers think there are some problems with that. I will wait for an ack from them before applying. Kind regards Uffe > > Pali Roh=C3=A1r (11): > mmc: sdio: Fix macro name for Marvell device with ID 0x9134 > mmc: sdio: Change macro names for Marvell 8688 modules > mmc: sdio: Move SDIO IDs from mwifiex driver to common include file > mmc: sdio: Move SDIO IDs from btmrvl driver to common include file > mmc: sdio: Move SDIO IDs from btmtksdio driver to common include file > mmc: sdio: Move SDIO IDs from smssdio driver to common include file > mmc: sdio: Move SDIO IDs from ath6kl driver to common include file > mmc: sdio: Move SDIO IDs from ath10k driver to common include file > mmc: sdio: Move SDIO IDs from b43-sdio driver to common include file > mmc: sdio: Fix Cypress SDIO IDs macros in common include file > mmc: sdio: Sort all SDIO IDs in common include file > > drivers/bluetooth/btmrvl_sdio.c | 18 ++-- > drivers/bluetooth/btmtksdio.c | 4 +- > drivers/media/mmc/siano/smssdio.c | 10 +- > drivers/mmc/core/quirks.h | 2 +- > drivers/net/wireless/ath/ath10k/sdio.c | 25 ++--- > drivers/net/wireless/ath/ath10k/sdio.h | 8 -- > drivers/net/wireless/ath/ath6kl/hif.h | 6 -- > drivers/net/wireless/ath/ath6kl/sdio.c | 17 ++-- > drivers/net/wireless/broadcom/b43/sdio.c | 4 +- > .../broadcom/brcm80211/brcmfmac/bcmsdh.c | 6 +- > .../broadcom/brcm80211/brcmfmac/sdio.c | 4 +- > .../net/wireless/marvell/libertas/if_sdio.c | 2 +- > drivers/net/wireless/marvell/mwifiex/sdio.c | 38 ++------ > include/linux/mmc/sdio_ids.h | 94 ++++++++++++++----- > 14 files changed, 120 insertions(+), 118 deletions(-) > > -- > 2.20.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-ua1-x944.google.com ([2607:f8b0:4864:20::944]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jd7L0-000249-VO for ath10k@lists.infradead.org; Mon, 25 May 2020 07:15:57 +0000 Received: by mail-ua1-x944.google.com with SMTP id r9so1123982ual.1 for ; Mon, 25 May 2020 00:15:53 -0700 (PDT) MIME-Version: 1.0 References: <20200522144412.19712-1-pali@kernel.org> In-Reply-To: <20200522144412.19712-1-pali@kernel.org> From: Ulf Hansson Date: Mon, 25 May 2020 09:15:16 +0200 Message-ID: Subject: Re: [PATCH 00/11] mmc: sdio: Move SDIO IDs from drivers to common include file List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: =?UTF-8?Q?Pali_Roh=C3=A1r?= Cc: brcm80211-dev-list.pdl@broadcom.com, libertas-dev@lists.infradead.org, Xinming Hu , linux-wireless , "linux-mmc@vger.kernel.org" , Linux Kernel Mailing List , Amitkumar Karwar , =?UTF-8?B?TWFyZWsgQmVow7pu?= , Ganapathi Bhat , ath10k@lists.infradead.org, Matthias Brugger , Mauro Carvalho Chehab , brcm80211-dev-list , Kalle Valo , b43-dev@lists.infradead.org T24gRnJpLCAyMiBNYXkgMjAyMCBhdCAxNjo0NSwgUGFsaSBSb2jDoXIgPHBhbGlAa2VybmVsLm9y Zz4gd3JvdGU6Cj4KPiBNb3N0IFNESU8gSURzIGFyZSBkZWZpbmVkIGluIHRoZSBjb21tb24gaW5j bHVkZSBmaWxlIGxpbnV4L21tYy9zZGlvX2lkcy5oLgo+IEJ1dCBzb21lIGRyaXZlcnMgZGVmaW5l IElEcyBsb2NhbGx5IG9yIGRvIG5vdCB1c2UgZXhpc3RpbmcgbWFjcm9zIGZyb20gdGhlCj4gY29t bW9uIGluY2x1ZGUgZmlsZS4KPgo+IFRoaXMgcGF0Y2ggc2VyaWVzIGZpeGVzIGFib3ZlIGluY29u c2lzdGVuY3kuIEl0IGRlZmluZXMgbWlzc2luZyBtYWNybyBuYW1lcwo+IGFuZCBtb3ZlcyBhbGwg cmVtYWluaW5nIFNESU8gSURzIGZyb20gZHJpdmVycyB0byB0aGUgY29tbW9uIGluY2x1ZGUgZmls ZS4KPiBBbHNvIHNvbWUgbWFjcm8gbmFtZXMgYXJlIGNoYW5nZWQgdG8gZm9sbG93IGV4aXN0aW5n IG5hbWluZyBjb252ZW50aW9ucy4KClRoYW5rcyAtIGEgbmljZSBjbGVhbnVwIQoKSSBndWVzcyB0 aGlzIGlzIGJlc3QgcXVldWVkIHZpYSBteSBtbWMgdHJlZSwgdW5sZXNzIGJsdWV0b290aC93aXJl bGVzcwptYWludGFpbmVycyB0aGluayB0aGVyZSBhcmUgc29tZSBwcm9ibGVtcyB3aXRoIHRoYXQu IEkgd2lsbCB3YWl0IGZvcgphbiBhY2sgZnJvbSB0aGVtIGJlZm9yZSBhcHBseWluZy4KCktpbmQg cmVnYXJkcwpVZmZlCgo+Cj4gUGFsaSBSb2jDoXIgKDExKToKPiAgIG1tYzogc2RpbzogRml4IG1h Y3JvIG5hbWUgZm9yIE1hcnZlbGwgZGV2aWNlIHdpdGggSUQgMHg5MTM0Cj4gICBtbWM6IHNkaW86 IENoYW5nZSBtYWNybyBuYW1lcyBmb3IgTWFydmVsbCA4Njg4IG1vZHVsZXMKPiAgIG1tYzogc2Rp bzogTW92ZSBTRElPIElEcyBmcm9tIG13aWZpZXggZHJpdmVyIHRvIGNvbW1vbiBpbmNsdWRlIGZp bGUKPiAgIG1tYzogc2RpbzogTW92ZSBTRElPIElEcyBmcm9tIGJ0bXJ2bCBkcml2ZXIgdG8gY29t bW9uIGluY2x1ZGUgZmlsZQo+ICAgbW1jOiBzZGlvOiBNb3ZlIFNESU8gSURzIGZyb20gYnRtdGtz ZGlvIGRyaXZlciB0byBjb21tb24gaW5jbHVkZSBmaWxlCj4gICBtbWM6IHNkaW86IE1vdmUgU0RJ TyBJRHMgZnJvbSBzbXNzZGlvIGRyaXZlciB0byBjb21tb24gaW5jbHVkZSBmaWxlCj4gICBtbWM6 IHNkaW86IE1vdmUgU0RJTyBJRHMgZnJvbSBhdGg2a2wgZHJpdmVyIHRvIGNvbW1vbiBpbmNsdWRl IGZpbGUKPiAgIG1tYzogc2RpbzogTW92ZSBTRElPIElEcyBmcm9tIGF0aDEwayBkcml2ZXIgdG8g Y29tbW9uIGluY2x1ZGUgZmlsZQo+ICAgbW1jOiBzZGlvOiBNb3ZlIFNESU8gSURzIGZyb20gYjQz LXNkaW8gZHJpdmVyIHRvIGNvbW1vbiBpbmNsdWRlIGZpbGUKPiAgIG1tYzogc2RpbzogRml4IEN5 cHJlc3MgU0RJTyBJRHMgbWFjcm9zIGluIGNvbW1vbiBpbmNsdWRlIGZpbGUKPiAgIG1tYzogc2Rp bzogU29ydCBhbGwgU0RJTyBJRHMgaW4gY29tbW9uIGluY2x1ZGUgZmlsZQo+Cj4gIGRyaXZlcnMv Ymx1ZXRvb3RoL2J0bXJ2bF9zZGlvLmMgICAgICAgICAgICAgICB8IDE4ICsrLS0KPiAgZHJpdmVy cy9ibHVldG9vdGgvYnRtdGtzZGlvLmMgICAgICAgICAgICAgICAgIHwgIDQgKy0KPiAgZHJpdmVy cy9tZWRpYS9tbWMvc2lhbm8vc21zc2Rpby5jICAgICAgICAgICAgIHwgMTAgKy0KPiAgZHJpdmVy cy9tbWMvY29yZS9xdWlya3MuaCAgICAgICAgICAgICAgICAgICAgIHwgIDIgKy0KPiAgZHJpdmVy cy9uZXQvd2lyZWxlc3MvYXRoL2F0aDEway9zZGlvLmMgICAgICAgIHwgMjUgKystLS0KPiAgZHJp dmVycy9uZXQvd2lyZWxlc3MvYXRoL2F0aDEway9zZGlvLmggICAgICAgIHwgIDggLS0KPiAgZHJp dmVycy9uZXQvd2lyZWxlc3MvYXRoL2F0aDZrbC9oaWYuaCAgICAgICAgIHwgIDYgLS0KPiAgZHJp dmVycy9uZXQvd2lyZWxlc3MvYXRoL2F0aDZrbC9zZGlvLmMgICAgICAgIHwgMTcgKystLQo+ICBk cml2ZXJzL25ldC93aXJlbGVzcy9icm9hZGNvbS9iNDMvc2Rpby5jICAgICAgfCAgNCArLQo+ICAu Li4vYnJvYWRjb20vYnJjbTgwMjExL2JyY21mbWFjL2JjbXNkaC5jICAgICAgfCAgNiArLQo+ICAu Li4vYnJvYWRjb20vYnJjbTgwMjExL2JyY21mbWFjL3NkaW8uYyAgICAgICAgfCAgNCArLQo+ICAu Li4vbmV0L3dpcmVsZXNzL21hcnZlbGwvbGliZXJ0YXMvaWZfc2Rpby5jICAgfCAgMiArLQo+ICBk cml2ZXJzL25ldC93aXJlbGVzcy9tYXJ2ZWxsL213aWZpZXgvc2Rpby5jICAgfCAzOCArKy0tLS0t LQo+ICBpbmNsdWRlL2xpbnV4L21tYy9zZGlvX2lkcy5oICAgICAgICAgICAgICAgICAgfCA5NCAr KysrKysrKysrKysrKy0tLS0tCj4gIDE0IGZpbGVzIGNoYW5nZWQsIDEyMCBpbnNlcnRpb25zKCsp LCAxMTggZGVsZXRpb25zKC0pCj4KPiAtLQo+IDIuMjAuMQo+CgpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwphdGgxMGsgbWFpbGluZyBsaXN0CmF0aDEwa0Bs aXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlz dGluZm8vYXRoMTBrCg==