From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755195AbaD1LCW (ORCPT ); Mon, 28 Apr 2014 07:02:22 -0400 Received: from mail-qa0-f46.google.com ([209.85.216.46]:56883 "EHLO mail-qa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754284AbaD1LCU (ORCPT ); Mon, 28 Apr 2014 07:02:20 -0400 MIME-Version: 1.0 In-Reply-To: <1398540855-27367-2-git-send-email-sebastian.hesselbarth@gmail.com> References: <1398540855-27367-1-git-send-email-sebastian.hesselbarth@gmail.com> <1398540855-27367-2-git-send-email-sebastian.hesselbarth@gmail.com> Date: Mon, 28 Apr 2014 13:02:19 +0200 Message-ID: Subject: Re: [PATCH RESEND 1/3] mmc: mvsdio: silence card detect notice From: Ulf Hansson To: Sebastian Hesselbarth Cc: Nicolas Pitre , Chris Ball , Jason Cooper , Andrew Lunn , Gregory Clement , linux-mmc , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26 April 2014 21:34, Sebastian Hesselbarth wrote: > mvsdio reports method of card detection with dev_notice, while for > removable cards it may be sane, for non-removable cards it is not. > Also, as the user cannot do anything about it, silence the message > by reducing it from dev_notice to dev_dbg. > > Signed-off-by: Sebastian Hesselbarth > Acked-by: Jason Cooper > --- > Cc: Nicolas Pitre > Cc: Chris Ball > Cc: Ulf Hansson > Cc: Jason Cooper > Cc: Andrew Lunn > Cc: Gregory Clement > Cc: linux-mmc@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org Acked-by: Ulf Hansson > --- > drivers/mmc/host/mvsdio.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/mmc/host/mvsdio.c b/drivers/mmc/host/mvsdio.c > index 45aa2206741d..41aca7f28c23 100644 > --- a/drivers/mmc/host/mvsdio.c > +++ b/drivers/mmc/host/mvsdio.c > @@ -801,10 +801,10 @@ static int mvsd_probe(struct platform_device *pdev) > goto out; > > if (!(mmc->caps & MMC_CAP_NEEDS_POLL)) > - dev_notice(&pdev->dev, "using GPIO for card detection\n"); > + dev_dbg(&pdev->dev, "using GPIO for card detection\n"); > else > - dev_notice(&pdev->dev, > - "lacking card detect (fall back to polling)\n"); > + dev_dbg(&pdev->dev, "lacking card detect (fall back to polling)\n"); > + > return 0; > > out: > -- > 1.9.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ulf Hansson Subject: Re: [PATCH RESEND 1/3] mmc: mvsdio: silence card detect notice Date: Mon, 28 Apr 2014 13:02:19 +0200 Message-ID: References: <1398540855-27367-1-git-send-email-sebastian.hesselbarth@gmail.com> <1398540855-27367-2-git-send-email-sebastian.hesselbarth@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from mail-qa0-f45.google.com ([209.85.216.45]:36500 "EHLO mail-qa0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754440AbaD1LCU (ORCPT ); Mon, 28 Apr 2014 07:02:20 -0400 Received: by mail-qa0-f45.google.com with SMTP id cm18so6161999qab.32 for ; Mon, 28 Apr 2014 04:02:19 -0700 (PDT) In-Reply-To: <1398540855-27367-2-git-send-email-sebastian.hesselbarth@gmail.com> Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Sebastian Hesselbarth Cc: Nicolas Pitre , Chris Ball , Jason Cooper , Andrew Lunn , Gregory Clement , linux-mmc , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" On 26 April 2014 21:34, Sebastian Hesselbarth wrote: > mvsdio reports method of card detection with dev_notice, while for > removable cards it may be sane, for non-removable cards it is not. > Also, as the user cannot do anything about it, silence the message > by reducing it from dev_notice to dev_dbg. > > Signed-off-by: Sebastian Hesselbarth > Acked-by: Jason Cooper > --- > Cc: Nicolas Pitre > Cc: Chris Ball > Cc: Ulf Hansson > Cc: Jason Cooper > Cc: Andrew Lunn > Cc: Gregory Clement > Cc: linux-mmc@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org Acked-by: Ulf Hansson > --- > drivers/mmc/host/mvsdio.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/mmc/host/mvsdio.c b/drivers/mmc/host/mvsdio.c > index 45aa2206741d..41aca7f28c23 100644 > --- a/drivers/mmc/host/mvsdio.c > +++ b/drivers/mmc/host/mvsdio.c > @@ -801,10 +801,10 @@ static int mvsd_probe(struct platform_device *pdev) > goto out; > > if (!(mmc->caps & MMC_CAP_NEEDS_POLL)) > - dev_notice(&pdev->dev, "using GPIO for card detection\n"); > + dev_dbg(&pdev->dev, "using GPIO for card detection\n"); > else > - dev_notice(&pdev->dev, > - "lacking card detect (fall back to polling)\n"); > + dev_dbg(&pdev->dev, "lacking card detect (fall back to polling)\n"); > + > return 0; > > out: > -- > 1.9.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 From: ulf.hansson@linaro.org (Ulf Hansson) Date: Mon, 28 Apr 2014 13:02:19 +0200 Subject: [PATCH RESEND 1/3] mmc: mvsdio: silence card detect notice In-Reply-To: <1398540855-27367-2-git-send-email-sebastian.hesselbarth@gmail.com> References: <1398540855-27367-1-git-send-email-sebastian.hesselbarth@gmail.com> <1398540855-27367-2-git-send-email-sebastian.hesselbarth@gmail.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 26 April 2014 21:34, Sebastian Hesselbarth wrote: > mvsdio reports method of card detection with dev_notice, while for > removable cards it may be sane, for non-removable cards it is not. > Also, as the user cannot do anything about it, silence the message > by reducing it from dev_notice to dev_dbg. > > Signed-off-by: Sebastian Hesselbarth > Acked-by: Jason Cooper > --- > Cc: Nicolas Pitre > Cc: Chris Ball > Cc: Ulf Hansson > Cc: Jason Cooper > Cc: Andrew Lunn > Cc: Gregory Clement > Cc: linux-mmc at vger.kernel.org > Cc: linux-arm-kernel at lists.infradead.org > Cc: linux-kernel at vger.kernel.org Acked-by: Ulf Hansson > --- > drivers/mmc/host/mvsdio.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/mmc/host/mvsdio.c b/drivers/mmc/host/mvsdio.c > index 45aa2206741d..41aca7f28c23 100644 > --- a/drivers/mmc/host/mvsdio.c > +++ b/drivers/mmc/host/mvsdio.c > @@ -801,10 +801,10 @@ static int mvsd_probe(struct platform_device *pdev) > goto out; > > if (!(mmc->caps & MMC_CAP_NEEDS_POLL)) > - dev_notice(&pdev->dev, "using GPIO for card detection\n"); > + dev_dbg(&pdev->dev, "using GPIO for card detection\n"); > else > - dev_notice(&pdev->dev, > - "lacking card detect (fall back to polling)\n"); > + dev_dbg(&pdev->dev, "lacking card detect (fall back to polling)\n"); > + > return 0; > > out: > -- > 1.9.1 >