From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BBFAC433E2 for ; Wed, 9 Sep 2020 14:25:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5CFC82076C for ; Wed, 9 Sep 2020 14:25:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Ir+Aia3k" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730531AbgIIOZr (ORCPT ); Wed, 9 Sep 2020 10:25:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52190 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729298AbgIIM7a (ORCPT ); Wed, 9 Sep 2020 08:59:30 -0400 Received: from mail-ua1-x944.google.com (mail-ua1-x944.google.com [IPv6:2607:f8b0:4864:20::944]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AC9C4C06179B for ; Wed, 9 Sep 2020 05:48:41 -0700 (PDT) Received: by mail-ua1-x944.google.com with SMTP id e41so815768uad.6 for ; Wed, 09 Sep 2020 05:48:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Q9M1Vskts4JRHY9FBKuy5Sl90Ew3XMdMRCLYYCvUArU=; b=Ir+Aia3k1phkbjo07kIy3KryziEAUctzOrRfSX0hHbEaIIaFzvCIHoB6CfDuJY7T2n cNbGu0p3qDNT60dSu4TPUyPjir0s+gOl2VwwnvNVL9Nnq0x8pLYNyTwysa54ofQ6hZTr S/V2zmAsJ4IhxygFVxkZGwF/fH7EQg3/OHK8NrhRGWuRxvT96z/OJur4wjDewVY5+UeM 7tpi51C47+E2EM9oPhzZlPDDk/j3TM96dqWItzfBKv6Oq5cVYioygMpGXrHyKJ5la7QU 7+YQMJKbvbjIkezmrtAgpGKLnP0PHEHbeINRKBjlOHjNJpuiaEnpcBLb3SXm9k/4bNV4 wi/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Q9M1Vskts4JRHY9FBKuy5Sl90Ew3XMdMRCLYYCvUArU=; b=eLXex8uQHSVxiB4aCPcT7vbCTexjEXrtRbUpb7s6BqGSgDtUaA/BNfAGuGYayWLyRs oV/d1KudjLt1pUpcqVHJxKChH35F7XI7scn/EcSFiNio1aibRe7dNmSfFRhG00EzIa7N zjlgkPZS5F4yjxaptHtV+DFwK2JgpXCo/mmk86NYraM9Lg9hOewfjL06ZDp/haU/kF+Y zxY4F0cowIklXPC3zb/7mJ2dokv/SuVXhLJILUGUQv9Ps2iTq4GkpKoYihuTZHkJZnXV tQm63jyzd4gflkdv77HnoANLOR01kHRGvDrE+zjFbPllp3maReVhfD1Q37KxnV2RJts+ FEBg== X-Gm-Message-State: AOAM532zpkZUtzOW6ng+vwdQ6QKFA8PQvNbU/mTjbspYpvf0URzdMT4o oOHUPwVf6AKWMJYwUyb+81+W+avQF7gogiR3OpG6LA== X-Google-Smtp-Source: ABdhPJwdE+navQ2r6yXbpY92vwAATdTQhd3CubjjUMOOk3FM3FdxGXP5NUGBX80ycQbG1aS7lVhw7lyGqD/GlOFmbG0= X-Received: by 2002:ab0:2ea1:: with SMTP id y1mr368999uay.104.1599655720008; Wed, 09 Sep 2020 05:48:40 -0700 (PDT) MIME-Version: 1.0 References: <1d7c97524b9e1fbc60271d9c246c5461ca8a106c.1598594714.git.viresh.kumar@linaro.org> <20200831104453.ux5fb5bpt57tj5am@vireshk-i7> <20200909110707.jv2beta5rdr3wux3@vireshk-i7> In-Reply-To: <20200909110707.jv2beta5rdr3wux3@vireshk-i7> From: Ulf Hansson Date: Wed, 9 Sep 2020 14:48:03 +0200 Message-ID: Subject: Re: [PATCH V2 4/8] mmc: sdhci-msm: Unconditionally call dev_pm_opp_of_remove_table() To: Viresh Kumar Cc: Rajendra Nayak , Adrian Hunter , Andy Gross , Bjorn Andersson , Linux PM , Vincent Guittot , Rafael Wysocki , Stephen Boyd , Nishanth Menon , Douglas Anderson , Naresh Kamboju , linux-arm-msm , "linux-mmc@vger.kernel.org" , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Wed, 9 Sep 2020 at 13:07, Viresh Kumar wrote: > > On 31-08-20, 12:57, Ulf Hansson wrote: > > On Mon, 31 Aug 2020 at 12:45, Viresh Kumar wrote: > > > > > > On 28-08-20, 10:43, Ulf Hansson wrote: > > > > On Fri, 28 Aug 2020 at 08:08, Viresh Kumar wrote: > > > > > > > > > > dev_pm_opp_of_remove_table() doesn't report any errors when it fails to > > > > > find the OPP table with error -ENODEV (i.e. OPP table not present for > > > > > the device). And we can call dev_pm_opp_of_remove_table() > > > > > unconditionally here. > > > > > > > > > > Signed-off-by: Viresh Kumar > > > > > > > > Replaced v1 with v2 on my next branch, thanks! > > > > > > > > Just to be sure, this patch doesn't depend on any changes for the opp > > > > core that are queued for v5.10? > > > > > > The recent crashes reported by Anders and Naresh were related to a OPP > > > core bug, for which I have just sent the fix here: > > > > > > https://lore.kernel.org/lkml/922ff0759a16299e24cacfc981ac07914d8f1826.1598865786.git.viresh.kumar@linaro.org/ > > > > > > This is already tested by Naresh now and finally everything works as > > > expected. > > > > > > I am going to get this fix merged in 5.9-rc4, but we do have a > > > dependency now with that fix. > > > > > > What's the best way to handle this stuff now ? The easiest IMO would > > > be for me to send these patches through the OPP tree, otherwise people > > > need to carry this and the OPP fix (for which I can provide the > > > branch/tag). > > > > No need for a tag/branch to be shared. Instead I am simply going to > > defer to pick up any related changes for mmc, until I can rebase my > > tree on an rc[n] that contains your fix. > > > > When that is possible, please re-post the mmc patches. > > The dependency patch got merged in 5.9-rc4. Do you still want me to > resend this patch or you can apply it directly from here ? Please re-submit, then I will pick it from the patchtracker. Kind regards Uffe