From: Ulf Hansson <ulf.hansson@linaro.org>
To: Jon Hunter <jonathanh@nvidia.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>,
Thierry Reding <thierry.reding@gmail.com>,
linux-mmc <linux-mmc@vger.kernel.org>,
linux-tegra <linux-tegra@vger.kernel.org>,
Aniruddha Tvs Rao <anrao@nvidia.com>,
Kamal Mostafa <kamal@canonical.com>
Subject: Re: [PATCH] mmc: sdhci-tegra: Add required callbacks to set/clear CQE_EN bit
Date: Mon, 12 Apr 2021 13:51:28 +0200 [thread overview]
Message-ID: <CAPDyKFr0Mg5m6ndKf=ge5rj0+XGTXMbtwc7c6oEEma0b-_yi2g@mail.gmail.com> (raw)
In-Reply-To: <69fd5e22-2d85-46bd-8abf-0baf0d97fc95@nvidia.com>
On Mon, 12 Apr 2021 at 11:35, Jon Hunter <jonathanh@nvidia.com> wrote:
>
>
> On 12/04/2021 08:52, Ulf Hansson wrote:
> > On Wed, 7 Apr 2021 at 11:46, Jon Hunter <jonathanh@nvidia.com> wrote:
> >>
> >> From: Aniruddha Tvs Rao <anrao@nvidia.com>
> >>
> >> CMD8 is not supported with Command Queue Enabled. Add required callback
> >> to clear CQE_EN and CQE_INTR fields in the host controller register
> >> before sending CMD8. Add corresponding callback in the CQHCI resume path
> >> to re-enable CQE_EN and CQE_INTR fields.
> >>
> >> Reported-by: Kamal Mostafa <kamal@canonical.com>
> >> Tested-by: Kamal Mostafa <kamal@canonical.com>
> >> Signed-off-by: Aniruddha Tvs Rao <anrao@nvidia.com>
> >> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
> >
> > Applied for next, thanks!
> >
> > Please tell, if you think this needs to be tagged for stable kernels
> > as well (and if so, perhaps we can set a fixes tag as well?).
>
> Thanks. We were talking about that. I believe that the callbacks were
> only added in v5.10 and so that is the earliest we could apply. The most
> logical fixes tag would be ...
>
> Fixes: 3c4019f97978 ("mmc: tegra: HW Command Queue Support for Tegra SDMMC")
>
> However, this does come before the support for the command queue callbacks.
>
> I would like to get this into the v5.10 stable branch and I can either
> send Greg a direct request once merged or we can tag for stable. Let me
> know what you think.
Let me amend the change and add a stable tag like below:
Cc: stable@vger.kerne.org # v5.10+
Kind regards
Uffe
prev parent reply other threads:[~2021-04-12 11:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-07 9:46 [PATCH] mmc: sdhci-tegra: Add required callbacks to set/clear CQE_EN bit Jon Hunter
2021-04-07 11:03 ` Adrian Hunter
2021-04-07 15:07 ` Thierry Reding
2021-04-12 7:52 ` Ulf Hansson
2021-04-12 9:35 ` Jon Hunter
2021-04-12 11:51 ` Ulf Hansson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPDyKFr0Mg5m6ndKf=ge5rj0+XGTXMbtwc7c6oEEma0b-_yi2g@mail.gmail.com' \
--to=ulf.hansson@linaro.org \
--cc=adrian.hunter@intel.com \
--cc=anrao@nvidia.com \
--cc=jonathanh@nvidia.com \
--cc=kamal@canonical.com \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.