From: Ulf Hansson <ulf.hansson@linaro.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Arend van Spriel <arend.vanspriel@broadcom.com>,
Arend van Spriel <aspriel@gmail.com>,
Franky Lin <franky.lin@broadcom.com>,
Hante Meuleman <hante.meuleman@broadcom.com>,
Chi-hsien Lin <chi-hsien.lin@infineon.com>,
Wright Feng <wright.feng@infineon.com>,
Chung-hsien Hsu <chung-hsien.hsu@infineon.com>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] brcmfmac: Obtain reset GPIO
Date: Fri, 21 May 2021 13:44:49 +0200 [thread overview]
Message-ID: <CAPDyKFr3YbHJG4+ZUiwQym54udEERSygj8=QA0FoL6U5x3S7Dw@mail.gmail.com> (raw)
In-Reply-To: <CACRpkdY9RUc78dj7sw5_A5XJwpbYROzaq1ziYmN2=cqs_AJfrw@mail.gmail.com>
On Thu, 20 May 2021 at 01:41, Linus Walleij <linus.walleij@linaro.org> wrote:
>
> On Tue, May 11, 2021 at 10:48 AM Ulf Hansson <ulf.hansson@linaro.org> wrote:
>
> > I think this boils down to that to allow the mmc core to detect and
> > initialize the SDIO card, it needs to manage potential reset pins as
> > well.
> >
> > In cases when the SDIO func driver may need to execute a reset, the
> > mmc core provides two APIs, mmc_hw|sw_reset().
> >
> > Does this make sense to you?
>
> I think so, in this case (Samsung Janice on Ux500) the boot loader
> desserts reset so we are fine, but I think it should be utilized properly
> somehow, the vendor went to lots of trouble to put this reset line
> there physically.
>
> What is my next step? :D
Have a look at the mmc-pwrseq simple DT bindings.
Documentation/devicetree/bindings/mmc/mmc-pwrseq-simple.yaml
If things are as simple as I hope/think, all you should need to do is
to add a mmc-pwrseq node where you specify the GPIO reset line. Then
from the mmc controller node, just add a phandle to the mmc-pwrseq
node and things should just work. :-)
git grep mmc-pwrseq should give you a bunch of references of existing users.
Kind regards
Uffe
prev parent reply other threads:[~2021-05-21 11:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-09 22:42 [PATCH] brcmfmac: Obtain reset GPIO Linus Walleij
2021-05-10 7:37 ` Arend Van Spriel
2021-05-10 9:14 ` Ulf Hansson
2021-05-10 9:27 ` Arend van Spriel
2021-05-11 8:48 ` Ulf Hansson
2021-05-12 7:42 ` Arend van Spriel
2021-05-19 23:41 ` Linus Walleij
2021-05-21 11:44 ` Ulf Hansson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPDyKFr3YbHJG4+ZUiwQym54udEERSygj8=QA0FoL6U5x3S7Dw@mail.gmail.com' \
--to=ulf.hansson@linaro.org \
--cc=arend.vanspriel@broadcom.com \
--cc=aspriel@gmail.com \
--cc=chi-hsien.lin@infineon.com \
--cc=chung-hsien.hsu@infineon.com \
--cc=franky.lin@broadcom.com \
--cc=hante.meuleman@broadcom.com \
--cc=linus.walleij@linaro.org \
--cc=linux-wireless@vger.kernel.org \
--cc=wright.feng@infineon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.