From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6D31C47258 for ; Tue, 5 May 2020 11:33:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B340F2073B for ; Tue, 5 May 2020 11:33:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="UYK94dyb" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728857AbgEELdi (ORCPT ); Tue, 5 May 2020 07:33:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51610 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1728842AbgEELdg (ORCPT ); Tue, 5 May 2020 07:33:36 -0400 Received: from mail-vs1-xe41.google.com (mail-vs1-xe41.google.com [IPv6:2607:f8b0:4864:20::e41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 061FDC061A0F for ; Tue, 5 May 2020 04:33:36 -0700 (PDT) Received: by mail-vs1-xe41.google.com with SMTP id g2so1010919vsb.4 for ; Tue, 05 May 2020 04:33:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mZtQfMwsau4hXUgC2ytDzDH5vT1ljtwb6OQQ8vXwGtk=; b=UYK94dybxNxOkIGP1e32wETlXo600Rs4e6ZrihQU7OIsONVA8ranRfXqvG3T6/40IF 7YXVaKvmsKja6JJVIBYp/WY4tRj3Z6cHteftQW64ftDI11AJViWNCqapE3AO51CACD4/ QgTQQvslirVHF5/ZKtu6oWIbCMfnIhIFlwollGVgtB0yXohA9dgCOGu1dIxxvG5NusqA mXJZwrdjJH620B9EBuqXiDHRC9mbmxJeTlxB3FTKbZOtiIFhPXFm071PVYR8ZElYUMLn fbXdqgeWzWwZ+qUlyGQ/XJeyig2lXH3Rpx1LGnd8i3opPuogmUfW/0MuT2JS7ljOZCD/ hijw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mZtQfMwsau4hXUgC2ytDzDH5vT1ljtwb6OQQ8vXwGtk=; b=Rr0dGRzUbG9eDKK5UGJd/U7+QtNVt2M+ZunCZvgZooo2WuTBKJCdXDlVPDZ6Ob3YE7 OjexvKsDUG5DoZ7ZZkGvBoFqThsTagWMFzsRBYx+ftc1UyXIpWMlih0Td0Ef02lDXNG4 3S312pxnR6lBnkkRAyXNFq+tVcamaXpr0MB0XT1oDYb45ZrX3jp9hfJI5O2Jm7eQMgpk AbOP83Dg4+NR+RPePJDhQgxUIZfLX+ZoiCThc62lER72uAHYLUsGHmlRYAQseGdyu7zy KY02rk3XeM7VVQYfTrBBr2z67mI8PB/T7i7Z/pmGy5vglAWOXo9PKdn4+0b55ajGPvCV JKwA== X-Gm-Message-State: AGi0PuaxMJOMoGL+3s00B/006Dycz8Zay4TEhbGkRM7kOR9sYz9Iytq5 lB6MzscqASiPgsRi0eTYsSn3a2ISeDsQLbIL3aQmRA== X-Google-Smtp-Source: APiQypLtmJ2Woq0r8nhb32D0SwRppJLteDyUIcJbgHg+8pXZFuenqhZ1ABOFw3HIaMRHpHlUGPbA9t5jsQVoxy6TJzE= X-Received: by 2002:a67:8b46:: with SMTP id n67mr2293219vsd.35.1588678414754; Tue, 05 May 2020 04:33:34 -0700 (PDT) MIME-Version: 1.0 References: <20200504063957.6638-1-benchuanggli@gmail.com> In-Reply-To: <20200504063957.6638-1-benchuanggli@gmail.com> From: Ulf Hansson Date: Tue, 5 May 2020 13:32:58 +0200 Message-ID: Subject: Re: [PATCH] mmc: sdhci-pci-gli: Fix can not access GL9750 after reboot from Windows 10 To: Ben Chuang Cc: Adrian Hunter , "linux-mmc@vger.kernel.org" , Linux Kernel Mailing List , Ben Chuang , renius.chen@genesyslogic.com.tw, custos.mentis@gmail.com Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 4 May 2020 at 08:41, Ben Chuang wrote: > > From: Ben Chuang > > Need to clear some bits in a vendor-defined register after reboot from > Windows 10. > > Fixes: e51df6ce668a ("mmc: host: sdhci-pci: Add Genesys Logic GL975x support") > Reported-by: Grzegorz Kowal > Signed-off-by: Ben Chuang Applied for fixes, thanks! Kind regards Uffe > --- > drivers/mmc/host/sdhci-pci-gli.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/mmc/host/sdhci-pci-gli.c b/drivers/mmc/host/sdhci-pci-gli.c > index ce15a05f23d4..8170b659f2af 100644 > --- a/drivers/mmc/host/sdhci-pci-gli.c > +++ b/drivers/mmc/host/sdhci-pci-gli.c > @@ -26,6 +26,9 @@ > #define SDHCI_GLI_9750_DRIVING_2 GENMASK(27, 26) > #define GLI_9750_DRIVING_1_VALUE 0xFFF > #define GLI_9750_DRIVING_2_VALUE 0x3 > +#define SDHCI_GLI_9750_SEL_1 BIT(29) > +#define SDHCI_GLI_9750_SEL_2 BIT(31) > +#define SDHCI_GLI_9750_ALL_RST (BIT(24)|BIT(25)|BIT(28)|BIT(30)) > > #define SDHCI_GLI_9750_PLL 0x864 > #define SDHCI_GLI_9750_PLL_TX2_INV BIT(23) > @@ -122,6 +125,8 @@ static void gli_set_9750(struct sdhci_host *host) > GLI_9750_DRIVING_1_VALUE); > driving_value |= FIELD_PREP(SDHCI_GLI_9750_DRIVING_2, > GLI_9750_DRIVING_2_VALUE); > + driving_value &= ~(SDHCI_GLI_9750_SEL_1|SDHCI_GLI_9750_SEL_2|SDHCI_GLI_9750_ALL_RST); > + driving_value |= SDHCI_GLI_9750_SEL_2; > sdhci_writel(host, driving_value, SDHCI_GLI_9750_DRIVING); > > sw_ctrl_value &= ~SDHCI_GLI_9750_SW_CTRL_4; > -- > 2.26.2 >