From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2443C433EF for ; Wed, 24 Nov 2021 19:25:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245741AbhKXT2y (ORCPT ); Wed, 24 Nov 2021 14:28:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60448 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245479AbhKXT2p (ORCPT ); Wed, 24 Nov 2021 14:28:45 -0500 Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 677B9C061746 for ; Wed, 24 Nov 2021 11:25:35 -0800 (PST) Received: by mail-lf1-x134.google.com with SMTP id t26so9948661lfk.9 for ; Wed, 24 Nov 2021 11:25:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=KeS8gzA/xfPhh34ugNpumxJ4yVD03DKGSAXtYcv0CNY=; b=SAc/SLcjr/Co2yuN16R4GlaVzZSj3SGoLB+z8GEtc5h3aU8zidJIe+uJIfa5Bt3D1m nuadLC4dAavDlWMr1PeQuweQd+2WdTckNNsIconSEReAJErSpN6N4gfv9qVsidgXYX4W DgLzz9OtmsjjUCln49Mp1puk5J/PS0oP5pNQGW6/PODbWKgIQA2683kIWTMVDF2u1GaU zUk/hBrZv/Y5JYpAKGEZV59d7yKkGNXiC8ECZpl5WSyDCfVqbJatNNvZekBqH872CrLv DnkBT6Ag/Y+r1nbhQmm3dynY5ZAPZOqTB78XiVuqR4zUUwyampX0urGluugIt56Dj2tu WlHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KeS8gzA/xfPhh34ugNpumxJ4yVD03DKGSAXtYcv0CNY=; b=XgUQXpMDcftHz7Exh29FbFxmcWr9p2iuvWye26Me77gT95Zh8SCeZDAvbSAHLTdpPc QRBU/D/lqBZAlsE9Repu6oX2y4IJRB4E1YMcDCc7mNonuZBBktfBDg/B9UiruaEuRuVa IWC62LjURyB6agsoziyt1L0r3UiXgrcDrY/lRuvlUgqWunifXkhIsIMlX7s0EHn7TqUa IiGx2///3TIj4jvSt9b8MQFBsx7e5daQp6NuTmyFyG4b8WmC2Kabimxi7PbPYnKWk/L+ Qd3voGW99T3SRC9H6eYaTCXDgxg+v13DLORUysT/ZJW08YPHCy0YqBDTXeZsDpNyL/Wf joPA== X-Gm-Message-State: AOAM533X+ojkaT9CtXfn/RXATvgHZ+SRrKVo3Bjwpllq0XigfayhM/6A r+rAQUUkuftkpUzv4+SrddJRhKChsPAgDl7EJTNhvQ== X-Google-Smtp-Source: ABdhPJzSEYCURJSiTw//vdik61HAkzTY0+VAOHaDC/VmX4bo1DEpc6xicGzGrpeh42Ukrn7jGcsGzS4EiBrSWD3re9Y= X-Received: by 2002:ac2:5a46:: with SMTP id r6mr18103844lfn.358.1637781932136; Wed, 24 Nov 2021 11:25:32 -0800 (PST) MIME-Version: 1.0 References: <20211124184603.3897245-1-john@metanate.com> In-Reply-To: <20211124184603.3897245-1-john@metanate.com> From: Ulf Hansson Date: Wed, 24 Nov 2021 20:24:56 +0100 Message-ID: Subject: Re: [PATCH 0/4] mmc: dw_mmc: start deprecating mshcN aliases To: John Keeping Cc: linux-mmc@vger.kernel.org, Heiko Stuebner , Jaehoon Chung , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 24 Nov 2021 at 19:46, John Keeping wrote: > > This series is prompted by discussion on a previous patch set [1] but is > a totally different approach and only a partial solution. > > With these patches, the dependency on the mshcN alias is totally removed > from dw_mmc-hi3798cv200 and dw_mmc-rockchip and dw_mmc-exynos moves > towards being able to consider the mshcN aliases deprecated. > > I haven't changed dw_mci_hi6220_caps here, although it looks like it's > possible to apply MMC_CAP_CMD23 to all controllers there with no change > in behaviour as the final entry is SDIO for which CMD23 is not > applicable IIUC. But I'm not familiar with that hardware and don't feel > confident making that change. > > [1] https://lore.kernel.org/all/20211116190244.1417591-1-john@metanate.com/ > > John Keeping (4): > mmc: dw_mmc: add common capabilities to replace caps > mmc: dw_mmc: hi3798cv200: use common_caps > mmc: dw_mmc: rockchip: use common_caps > mmc: dw_mmc: exynos: use common_caps > > drivers/mmc/host/dw_mmc-exynos.c | 9 +++++---- > drivers/mmc/host/dw_mmc-hi3798cv200.c | 9 +-------- > drivers/mmc/host/dw_mmc-rockchip.c | 11 +---------- > drivers/mmc/host/dw_mmc.c | 3 +++ > drivers/mmc/host/dw_mmc.h | 3 +++ > 5 files changed, 13 insertions(+), 22 deletions(-) > > -- > 2.34.0 > This looks good to me, I intend to apply this later this week, unless objections of course. In the meantime, I will continue to look at what we can do to resolve the exynos/k3 issues around this. Kind regards Uffe From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 084F6C433F5 for ; Wed, 24 Nov 2021 19:26:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=M2hftyy2V7l/0i9HGvCjlSwsOOYwfS/eKFrBvPWPs7g=; b=v104bDUb2j19AL uDxDAlZtzIB8+gyEULfYZFvSC7761OUTQASYJyKdl71K7VXdWfoD2fkalFIxhjzlp37xi9wU+j8N0 osr9dCVNzXQcXWi5FE81iskEFHriCQbIctkMPiX6OjzKSTerw3+pO/Q3s2t1dZGfA8lYIJlefgBFc OZH/48CIAvTQU7WZAgYGEJyCCUN76YifzGPB4hRPHvm5wheTu/+gpOLxXa7RtHG+2vMbOxddHbaxc RFZXCiC4rBeKbaBiaUy8G9Quz1xR6cPFhEB7bohjEDL9IJQR/wFaYSY1Ao6mBYx8QhV35wOjBlYQ2 xjecbThR1tPgoQEPlMJQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mpxu1-005fDw-8e; Wed, 24 Nov 2021 19:25:57 +0000 Received: from mail-lf1-x131.google.com ([2a00:1450:4864:20::131]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mpxtg-005f5q-7N for linux-rockchip@lists.infradead.org; Wed, 24 Nov 2021 19:25:37 +0000 Received: by mail-lf1-x131.google.com with SMTP id r26so9978417lfn.8 for ; Wed, 24 Nov 2021 11:25:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=KeS8gzA/xfPhh34ugNpumxJ4yVD03DKGSAXtYcv0CNY=; b=SAc/SLcjr/Co2yuN16R4GlaVzZSj3SGoLB+z8GEtc5h3aU8zidJIe+uJIfa5Bt3D1m nuadLC4dAavDlWMr1PeQuweQd+2WdTckNNsIconSEReAJErSpN6N4gfv9qVsidgXYX4W DgLzz9OtmsjjUCln49Mp1puk5J/PS0oP5pNQGW6/PODbWKgIQA2683kIWTMVDF2u1GaU zUk/hBrZv/Y5JYpAKGEZV59d7yKkGNXiC8ECZpl5WSyDCfVqbJatNNvZekBqH872CrLv DnkBT6Ag/Y+r1nbhQmm3dynY5ZAPZOqTB78XiVuqR4zUUwyampX0urGluugIt56Dj2tu WlHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KeS8gzA/xfPhh34ugNpumxJ4yVD03DKGSAXtYcv0CNY=; b=W8fuQy9/X/jHY7zgaoYfEAEUF/qlkS36Yqs8QflS5oT8gXc0JYcFDPtmD6KgysfxjJ 5TdsPUn+go0+j4CQn3CgRVyLHRgncXD9u90hDO9pEZ15EXYYGOIcN70unLyBc/6Y8pwg tsLyAqmu52FYcFQJjolQQiJC3Zcq43ozhMx8epmPRbKNj23BLw4Fn3l20ecSNZtD8iTS jIUH65KzdOxrKYtUD2Nl4Qa7GACgUwwjalsavZZV5q/xR9S6bEe5KqVa2OTatvmFnMEi aUKAZk8IU1R25SMSFxBJG1PsHqD+E44Br36BFso1jF3wSBUMXTqNherQR3XEQbv9eAEO GV0A== X-Gm-Message-State: AOAM531SnfoVs7Qgo/u6MBUssQGvwj5IL9ksJwXY5DGVivt2lh2HuEB7 47siTR5vrJRMUM7hdjCC6YfTO8Y98R07bwHZUIgLyA== X-Google-Smtp-Source: ABdhPJzSEYCURJSiTw//vdik61HAkzTY0+VAOHaDC/VmX4bo1DEpc6xicGzGrpeh42Ukrn7jGcsGzS4EiBrSWD3re9Y= X-Received: by 2002:ac2:5a46:: with SMTP id r6mr18103844lfn.358.1637781932136; Wed, 24 Nov 2021 11:25:32 -0800 (PST) MIME-Version: 1.0 References: <20211124184603.3897245-1-john@metanate.com> In-Reply-To: <20211124184603.3897245-1-john@metanate.com> From: Ulf Hansson Date: Wed, 24 Nov 2021 20:24:56 +0100 Message-ID: Subject: Re: [PATCH 0/4] mmc: dw_mmc: start deprecating mshcN aliases To: John Keeping Cc: linux-mmc@vger.kernel.org, Heiko Stuebner , Jaehoon Chung , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211124_112536_306750_EB05DC08 X-CRM114-Status: GOOD ( 19.00 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On Wed, 24 Nov 2021 at 19:46, John Keeping wrote: > > This series is prompted by discussion on a previous patch set [1] but is > a totally different approach and only a partial solution. > > With these patches, the dependency on the mshcN alias is totally removed > from dw_mmc-hi3798cv200 and dw_mmc-rockchip and dw_mmc-exynos moves > towards being able to consider the mshcN aliases deprecated. > > I haven't changed dw_mci_hi6220_caps here, although it looks like it's > possible to apply MMC_CAP_CMD23 to all controllers there with no change > in behaviour as the final entry is SDIO for which CMD23 is not > applicable IIUC. But I'm not familiar with that hardware and don't feel > confident making that change. > > [1] https://lore.kernel.org/all/20211116190244.1417591-1-john@metanate.com/ > > John Keeping (4): > mmc: dw_mmc: add common capabilities to replace caps > mmc: dw_mmc: hi3798cv200: use common_caps > mmc: dw_mmc: rockchip: use common_caps > mmc: dw_mmc: exynos: use common_caps > > drivers/mmc/host/dw_mmc-exynos.c | 9 +++++---- > drivers/mmc/host/dw_mmc-hi3798cv200.c | 9 +-------- > drivers/mmc/host/dw_mmc-rockchip.c | 11 +---------- > drivers/mmc/host/dw_mmc.c | 3 +++ > drivers/mmc/host/dw_mmc.h | 3 +++ > 5 files changed, 13 insertions(+), 22 deletions(-) > > -- > 2.34.0 > This looks good to me, I intend to apply this later this week, unless objections of course. In the meantime, I will continue to look at what we can do to resolve the exynos/k3 issues around this. Kind regards Uffe _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3E81AC433EF for ; Wed, 24 Nov 2021 19:26:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CzxMNQNTcbkr8J90yX/N8N2MrjK2TINBkb+kb3CZIqA=; b=ZoKy7UmxF2JEfI XN/llaJ9S6g1/mse8eL8H4+jlL6DuUHbssfaCRHo1Qvwby6T8VoR8xMNfz1t4yM5uJtd8ArlsXdjh 6JqKp4FOPlp5zoWQyxfHajaq0DsMVGWVAiMuhRZiuIp0o2CT0rVew+S6xInsJfOY69RBGDqSxh39c C3/KyBymF+m381n1jVicCkHPpckiGNn55R4R1o1CVkdZjJc7Wc9aEigkE43zWy+YJzTJbyL33wLqw I6oasCOm+KWXhybDYjrOY8DidhoAkFzeT6+VCtM+2VAID2mssdcuBG3LzdkiK2JutciYzqvDLt1ur T/elM8S9KEppMk9RXXlQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mpxtl-005f7c-G8; Wed, 24 Nov 2021 19:25:41 +0000 Received: from mail-lf1-x133.google.com ([2a00:1450:4864:20::133]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mpxtg-005f5r-8k for linux-arm-kernel@lists.infradead.org; Wed, 24 Nov 2021 19:25:37 +0000 Received: by mail-lf1-x133.google.com with SMTP id k37so10027875lfv.3 for ; Wed, 24 Nov 2021 11:25:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=KeS8gzA/xfPhh34ugNpumxJ4yVD03DKGSAXtYcv0CNY=; b=SAc/SLcjr/Co2yuN16R4GlaVzZSj3SGoLB+z8GEtc5h3aU8zidJIe+uJIfa5Bt3D1m nuadLC4dAavDlWMr1PeQuweQd+2WdTckNNsIconSEReAJErSpN6N4gfv9qVsidgXYX4W DgLzz9OtmsjjUCln49Mp1puk5J/PS0oP5pNQGW6/PODbWKgIQA2683kIWTMVDF2u1GaU zUk/hBrZv/Y5JYpAKGEZV59d7yKkGNXiC8ECZpl5WSyDCfVqbJatNNvZekBqH872CrLv DnkBT6Ag/Y+r1nbhQmm3dynY5ZAPZOqTB78XiVuqR4zUUwyampX0urGluugIt56Dj2tu WlHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KeS8gzA/xfPhh34ugNpumxJ4yVD03DKGSAXtYcv0CNY=; b=Xljue+8NqzypYjyfPZxGCrN3ARUL/reb1LlreCLBRJ1VfdJIvkMP8UxZkRh4xwoGyS yuvXe5b+jWksC+RrBVw4t18mn8RDhGQsk7jVPoPuLATn/h3Q0epRBFWV3+4nQgGRD/lX dz9LJZsVlF/Mv8zWJfmIVJC0b6/12M8siTOeaZIt8LuJtCR4XySGVFKmxXvDbX5P1wAU L6ZWkYkyxBcYLwstVYzxuiSHnUw//8weM0Us5yM30jnxm9AoRwuid5mYGSd77tbkxvXd QIQFH8DqpZU9x8civtFOlUfjYIuTQpyHAZJKZiPdpeoxnvMKuv4pVo34RofN0PdbnyeV LPUQ== X-Gm-Message-State: AOAM533I8cxsDX9ykDVwe10JSSHpRu6KWzS3+FRxDRtGK8TmQHhZn3gN LEa8D1y4FCCZiCz+uhIBUKj/tHNyzVc4UBjdeGh5zA== X-Google-Smtp-Source: ABdhPJzSEYCURJSiTw//vdik61HAkzTY0+VAOHaDC/VmX4bo1DEpc6xicGzGrpeh42Ukrn7jGcsGzS4EiBrSWD3re9Y= X-Received: by 2002:ac2:5a46:: with SMTP id r6mr18103844lfn.358.1637781932136; Wed, 24 Nov 2021 11:25:32 -0800 (PST) MIME-Version: 1.0 References: <20211124184603.3897245-1-john@metanate.com> In-Reply-To: <20211124184603.3897245-1-john@metanate.com> From: Ulf Hansson Date: Wed, 24 Nov 2021 20:24:56 +0100 Message-ID: Subject: Re: [PATCH 0/4] mmc: dw_mmc: start deprecating mshcN aliases To: John Keeping Cc: linux-mmc@vger.kernel.org, Heiko Stuebner , Jaehoon Chung , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211124_112536_328326_83EAF62D X-CRM114-Status: GOOD ( 20.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 24 Nov 2021 at 19:46, John Keeping wrote: > > This series is prompted by discussion on a previous patch set [1] but is > a totally different approach and only a partial solution. > > With these patches, the dependency on the mshcN alias is totally removed > from dw_mmc-hi3798cv200 and dw_mmc-rockchip and dw_mmc-exynos moves > towards being able to consider the mshcN aliases deprecated. > > I haven't changed dw_mci_hi6220_caps here, although it looks like it's > possible to apply MMC_CAP_CMD23 to all controllers there with no change > in behaviour as the final entry is SDIO for which CMD23 is not > applicable IIUC. But I'm not familiar with that hardware and don't feel > confident making that change. > > [1] https://lore.kernel.org/all/20211116190244.1417591-1-john@metanate.com/ > > John Keeping (4): > mmc: dw_mmc: add common capabilities to replace caps > mmc: dw_mmc: hi3798cv200: use common_caps > mmc: dw_mmc: rockchip: use common_caps > mmc: dw_mmc: exynos: use common_caps > > drivers/mmc/host/dw_mmc-exynos.c | 9 +++++---- > drivers/mmc/host/dw_mmc-hi3798cv200.c | 9 +-------- > drivers/mmc/host/dw_mmc-rockchip.c | 11 +---------- > drivers/mmc/host/dw_mmc.c | 3 +++ > drivers/mmc/host/dw_mmc.h | 3 +++ > 5 files changed, 13 insertions(+), 22 deletions(-) > > -- > 2.34.0 > This looks good to me, I intend to apply this later this week, unless objections of course. In the meantime, I will continue to look at what we can do to resolve the exynos/k3 issues around this. Kind regards Uffe _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel