From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 666D0C433B4 for ; Tue, 11 May 2021 11:15:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2B2D16191B for ; Tue, 11 May 2021 11:15:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231397AbhEKLQ2 (ORCPT ); Tue, 11 May 2021 07:16:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32954 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230443AbhEKLQ1 (ORCPT ); Tue, 11 May 2021 07:16:27 -0400 Received: from mail-vk1-xa2e.google.com (mail-vk1-xa2e.google.com [IPv6:2607:f8b0:4864:20::a2e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F0704C061574 for ; Tue, 11 May 2021 04:15:20 -0700 (PDT) Received: by mail-vk1-xa2e.google.com with SMTP id l124so3901350vkh.7 for ; Tue, 11 May 2021 04:15:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hHAQPVzBsVWn5SIpJgCp6vriYjWaGYRU2fNUBN0wdpw=; b=o+S/wjsPy/FGxRO/OYk6oXHPiTIptpc5DQdLEJLZDMeyGJLtpaH9D4X3Oy69dI/DKh W6SmuaZ2/PT/d/P7p40GeqWIgudOzlm5zoiV6AQ6Z1t8cq+maDbGzvNUM6L8nv7xZH2U XSqX3QmG5TGZk/orIoOidfCyS3GrbtCCNTOBFUcv/bVctmUbL2t+CTHIPUu+Jx3B7bdc EpV+95xKr2FS5xTWZkljH9d6ZtUOAWDCaU47nKNXWZO5scDai2sv1bkxUzcUZ6Z9/RYD 9ZGm+4GkWNZQKHsPtjkUf+9zvRhQEeUKKPRj5o25OogUkb1o+k+csM17ltTp56AAZ30J Jfig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hHAQPVzBsVWn5SIpJgCp6vriYjWaGYRU2fNUBN0wdpw=; b=Y0zNkFmERPOjQcc0xssD8JVI7OYimqLAel8ThIqgj7EoBPEqxQdc2IyUcexP5g6QPf XgrHsrgI5ezqPknSPU4FdnhggM96BXQYn2q9qyHUvbTKOzskQZfiHQ60Z+c5JxObVjNV lucvi5ADxbMDWQ005w+uuNTKDlkWiNCQQlZkLHyRfWb7gIXWLBgfL3NwttEw08Usl822 JGQHJUAMjoVQDC1Hj479HNjOtT2HaqISStWMV63vyannO9yapt8wBSdi2uVl9UGu6fJF Olnqp+Uf6GzGH6V/zqIc9w+kendcgmiun3zIBzRLNAaRawNtk2MEayGwZ2orCGRBDCtJ 7SqQ== X-Gm-Message-State: AOAM5310ZUMQYOLzd3NEqSkoLAlym261f9GM6569mpyOayj29qjV1A6w auyMmlqa/1L94QWOx/e+PYYKHhxJO8BekwnTmSikTA== X-Google-Smtp-Source: ABdhPJxYxWbFj2qO8+8U3f8oWGl4hGBN1E219YphlbQgPjhS4n0vUXrkjDTIzdBj9d6FR8xgDoHg7YisbPO/vyknD2Q= X-Received: by 2002:a1f:f2ce:: with SMTP id q197mr21391439vkh.15.1620731720168; Tue, 11 May 2021 04:15:20 -0700 (PDT) MIME-Version: 1.0 References: <20210510190400.105162-1-l.stach@pengutronix.de> <20210510190400.105162-3-l.stach@pengutronix.de> In-Reply-To: <20210510190400.105162-3-l.stach@pengutronix.de> From: Ulf Hansson Date: Tue, 11 May 2021 13:14:44 +0200 Message-ID: Subject: Re: [PATCH v2 3/3] mmc: core: add support for disabling HS400 mode via DT To: Lucas Stach , Chris Ruehl Cc: Adrian Hunter , Haibo Chen , Rob Herring , NXP Linux Team , Sascha Hauer , linux-mmc , DTML , Linux ARM Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org + Chris Ruehl On Mon, 10 May 2021 at 21:04, Lucas Stach wrote: > > From: Lucas Stach > > On some boards the data strobe line isn't wired up, rendering HS400 > support broken, even if both the controller and the eMMC claim to > support it. Allow to disable HS400 mode via DT. Before I review the series, I just wanted to highlight that quite recently we got a related series posted from Chris [1]. I made some comments, but he hasn't replied yet. In any case, if I understood it correctly, it looks like some controllers may support HS400 ES, but not HS200. Could that be the case here as well? Or is this a different problem? Kind regards Uffe [1] https://patchwork.kernel.org/project/linux-mmc/patch/20201208061839.21163-7-chris.ruehl@gtsys.com.hk/ > > Signed-off-by: Lucas Stach > --- > v2: > - move to core > - actually disable all HS400 modes > --- > drivers/mmc/core/host.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/mmc/core/host.c b/drivers/mmc/core/host.c > index 9b89a91b6b47..0e066c5f5243 100644 > --- a/drivers/mmc/core/host.c > +++ b/drivers/mmc/core/host.c > @@ -351,6 +351,9 @@ int mmc_of_parse(struct mmc_host *host) > host->caps2 |= MMC_CAP2_NO_SD; > if (device_property_read_bool(dev, "no-mmc")) > host->caps2 |= MMC_CAP2_NO_MMC; > + if (device_property_read_bool(dev, "no-mmc-hs400")) > + host->caps2 &= ~(MMC_CAP2_HS400_1_8V | MMC_CAP2_HS400_1_2V | > + MMC_CAP2_HS400_ES); > > /* Must be after "non-removable" check */ > if (device_property_read_u32(dev, "fixed-emmc-driver-type", &drv_type) == 0) { > -- > 2.31.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 833FFC433ED for ; Tue, 11 May 2021 13:06:19 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D7F69611BE for ; Tue, 11 May 2021 13:06:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D7F69611BE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=lm0CStvkWygIvDZX1kziF8UdjC6iTs6qPxdJby3Awlw=; b=WCSJDQZVUTmeZyuV6MxVLfwtm /rzFViwzLOUwg4KmBFf5cmvyTSGgoB4fkJzcVMjbUsFEpJoWWvFfr68kArabeFKYodwjvaam7LUhX JXP9fzWmN3lZ27Th8CDy+yV/eN5H3FMJTwbhUT6d22jhC8GTH/VhGF0/f/p9Y6ODPLd5c418kvKEq A4h8xLYkmqcrs4U4FDSiERUIeO/WYc1FVExXehKfE8n0k1R+Ih12oP6566uG+/yWkQo7N4riZMcBs X+nKFtR0nKfjFqNKncnnku9HV1VHL89Ef19tJjGLkXQSEVhgBaXUYra+pbAACUmD13urqTWOApjpE cvM1OxTow==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lgS42-00HZ5E-EC; Tue, 11 May 2021 13:04:42 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lgQMG-00H5qX-Nr for linux-arm-kernel@desiato.infradead.org; Tue, 11 May 2021 11:15:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Type:Cc:To:Subject:Message-ID :Date:From:In-Reply-To:References:MIME-Version:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=hHAQPVzBsVWn5SIpJgCp6vriYjWaGYRU2fNUBN0wdpw=; b=Xl2OPrWsm/o3H5S/28kwh7ACot iOgOgxUgfpXZRjMT/zFjEJXbSdt3dbJl5kWGH8KNlMqnen5LyxMkFf5QFGA5fFQ+wZ76/4KGZC8le TRBlBc2bSS6ohKbECTJZrKmVtPbR+WgyOqHKrm/L0WD7Zu+fUrLtHBm8zOliUmnaaYqnjDBc5b5TL nn8l/qAM2ZJnw1vU0wPYOuwuCQLCIBGLUnfq3j02iE2rM/5uofsaQiBNAAbSxurowv30yWFthjq0d 1EdLxu+TOOrgwfrw9y4fPJ1GEgq07ECExJrR8jOWWZ1ZFhwt34+lxoYCcR/muFfdmx7a1KE3Q2XpE WxdocEsA==; Received: from mail-vk1-xa2e.google.com ([2607:f8b0:4864:20::a2e]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lgQMD-009Vkh-R3 for linux-arm-kernel@lists.infradead.org; Tue, 11 May 2021 11:15:23 +0000 Received: by mail-vk1-xa2e.google.com with SMTP id s2so2162402vkf.13 for ; Tue, 11 May 2021 04:15:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hHAQPVzBsVWn5SIpJgCp6vriYjWaGYRU2fNUBN0wdpw=; b=o+S/wjsPy/FGxRO/OYk6oXHPiTIptpc5DQdLEJLZDMeyGJLtpaH9D4X3Oy69dI/DKh W6SmuaZ2/PT/d/P7p40GeqWIgudOzlm5zoiV6AQ6Z1t8cq+maDbGzvNUM6L8nv7xZH2U XSqX3QmG5TGZk/orIoOidfCyS3GrbtCCNTOBFUcv/bVctmUbL2t+CTHIPUu+Jx3B7bdc EpV+95xKr2FS5xTWZkljH9d6ZtUOAWDCaU47nKNXWZO5scDai2sv1bkxUzcUZ6Z9/RYD 9ZGm+4GkWNZQKHsPtjkUf+9zvRhQEeUKKPRj5o25OogUkb1o+k+csM17ltTp56AAZ30J Jfig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hHAQPVzBsVWn5SIpJgCp6vriYjWaGYRU2fNUBN0wdpw=; b=Y5YIn4eiVhbP0DcDiHdlKufO26B5ENXg0SlzRstxCaH+0sDxQkXjEut2DUZNC3grGZ 14gixpnMtG6jkXmlvuxmVy5nHU/PX+Uv4yzL/61DOX95CqbAlXacy+DxsKsca1TUwMho 88F0XOtqhUOyjJt/ctHhcFpd/8f3aaQCAIXggIdxc7srNzAJCzPYQiWY6J/woIk2NGZa JOURXUM3t4OMAygkQdfQVukqYosVGOA9+j8Yo5iwRYwVuZtSlzt1fXuRvqVKu/P/CS5k q3WRrm1A/8qBNwcZycdOT2sNtDKVzGr/KRZQIxdiOyXIKG+8vAuP+WyhQa6deG6R2YNh UYlw== X-Gm-Message-State: AOAM531va6uMJRKqfNzb4sNy6I65XLS75NmW6boUs0si7E68q6VtyiGw qXB9bS+ji5Jm7PUh8OsHVgZ3P/bCkt306rFHBk+ZTaZbPAyMz69n X-Google-Smtp-Source: ABdhPJxYxWbFj2qO8+8U3f8oWGl4hGBN1E219YphlbQgPjhS4n0vUXrkjDTIzdBj9d6FR8xgDoHg7YisbPO/vyknD2Q= X-Received: by 2002:a1f:f2ce:: with SMTP id q197mr21391439vkh.15.1620731720168; Tue, 11 May 2021 04:15:20 -0700 (PDT) MIME-Version: 1.0 References: <20210510190400.105162-1-l.stach@pengutronix.de> <20210510190400.105162-3-l.stach@pengutronix.de> In-Reply-To: <20210510190400.105162-3-l.stach@pengutronix.de> From: Ulf Hansson Date: Tue, 11 May 2021 13:14:44 +0200 Message-ID: Subject: Re: [PATCH v2 3/3] mmc: core: add support for disabling HS400 mode via DT To: Lucas Stach , Chris Ruehl Cc: Adrian Hunter , Haibo Chen , Rob Herring , NXP Linux Team , Sascha Hauer , linux-mmc , DTML , Linux ARM X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210511_041521_977059_DA483CA6 X-CRM114-Status: GOOD ( 21.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org + Chris Ruehl On Mon, 10 May 2021 at 21:04, Lucas Stach wrote: > > From: Lucas Stach > > On some boards the data strobe line isn't wired up, rendering HS400 > support broken, even if both the controller and the eMMC claim to > support it. Allow to disable HS400 mode via DT. Before I review the series, I just wanted to highlight that quite recently we got a related series posted from Chris [1]. I made some comments, but he hasn't replied yet. In any case, if I understood it correctly, it looks like some controllers may support HS400 ES, but not HS200. Could that be the case here as well? Or is this a different problem? Kind regards Uffe [1] https://patchwork.kernel.org/project/linux-mmc/patch/20201208061839.21163-7-chris.ruehl@gtsys.com.hk/ > > Signed-off-by: Lucas Stach > --- > v2: > - move to core > - actually disable all HS400 modes > --- > drivers/mmc/core/host.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/mmc/core/host.c b/drivers/mmc/core/host.c > index 9b89a91b6b47..0e066c5f5243 100644 > --- a/drivers/mmc/core/host.c > +++ b/drivers/mmc/core/host.c > @@ -351,6 +351,9 @@ int mmc_of_parse(struct mmc_host *host) > host->caps2 |= MMC_CAP2_NO_SD; > if (device_property_read_bool(dev, "no-mmc")) > host->caps2 |= MMC_CAP2_NO_MMC; > + if (device_property_read_bool(dev, "no-mmc-hs400")) > + host->caps2 &= ~(MMC_CAP2_HS400_1_8V | MMC_CAP2_HS400_1_2V | > + MMC_CAP2_HS400_ES); > > /* Must be after "non-removable" check */ > if (device_property_read_u32(dev, "fixed-emmc-driver-type", &drv_type) == 0) { > -- > 2.31.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel