All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ulf Hansson <ulf.hansson@linaro.org>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Saravana Kannan <saravanak@google.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Sandeep Patil <sspatil@android.com>,
	Baolin Wang <baolin.wang7@gmail.com>,
	Orson Zhai <orsonzhai@gmail.com>,
	Chunyan Zhang <zhang.lyra@gmail.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Android Kernel Team <kernel-team@android.com>
Subject: Re: [PATCH 1/2] drivers/clocksource/timer-of: Remove __init markings
Date: Thu, 30 Apr 2020 14:56:32 +0200	[thread overview]
Message-ID: <CAPDyKFrDSqnkhCVweaA0D-d+KWN_8=OiXW74tDM1DhnCZAgPww@mail.gmail.com> (raw)
In-Reply-To: <da25dc33-addb-298d-103a-fcf1cf0e6793@linaro.org>

On Tue, 28 Apr 2020 at 20:55, Daniel Lezcano <daniel.lezcano@linaro.org> wrote:
>
> On 28/04/2020 20:23, Saravana Kannan wrote:
> > On Tue, Apr 28, 2020 at 12:02 AM Daniel Lezcano
> > <daniel.lezcano@linaro.org> wrote:
> >>
> >>
> >> Hi Saravana,
> >
> > You were replying to Sandeep :)
>
> Oh, right :)
>
> Sorry Sandeep. Thanks for taking the time to elaborate a clear statement
> of the GKI.
>
> [ ... ]
>
> >> That was my understanding of the GKI, thanks for confirming.
> >>
> >> Putting apart the non-technical aspect of these changes, the benefit I
> >> see is the memory usage optimization regarding the single kernel image.
> >>
> >> With the ARM64 defconfig, multiple platforms and their corresponding
> >> drivers are compiled-in. It results in a big kernel image which fails to
> >> load because of overlapping on DT load address (or something else). When
> >> that is detected, it is fine to adjust the load addresses, otherwise it
> >> is painful to narrow down the root cause.
> >>
> >> In order to prevent this, we have to customize the defconfig each
> >> version release.
> >
> > Sorry, I'm not sure I understand where you are going with this. Are
> > you agreeing to pick up this change?
>
> Right. I agree with the change but I would like to have Thomas opinion
> on this before picking the patch.
>
> Thomas ?

I am not Thomas :-) But just wanted to provide some feedback from my side.

In general we are careful when deciding to export symbols. And at
least, I think at least we should require one user of it before
allowing it to be exported (I assume that is what is happening in
patch2/2 - I couldn't find it)

Kind regards
Uffe

  reply	other threads:[~2020-04-30 12:57 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-24  5:59 [PATCH 1/2] drivers/clocksource/timer-of: Remove __init markings Baolin Wang
2020-03-24  5:59 ` [PATCH 2/2] clocksource/drivers/sprd: Add module support to Spreadtrum timer Baolin Wang
2020-04-13  2:55 ` [PATCH 1/2] drivers/clocksource/timer-of: Remove __init markings Baolin Wang
2020-04-27 17:13   ` Daniel Lezcano
2020-04-27 19:04     ` Saravana Kannan
2020-04-27 20:09       ` Daniel Lezcano
2020-04-27 20:12         ` Saravana Kannan
2020-04-27 20:50           ` Daniel Lezcano
2020-04-27 22:17             ` Sandeep Patil
2020-04-28  7:02               ` Daniel Lezcano
2020-04-28 18:23                 ` Saravana Kannan
2020-04-28 18:31                   ` Daniel Lezcano
2020-04-30 12:56                     ` Ulf Hansson [this message]
2020-04-30 16:52                       ` Saravana Kannan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPDyKFrDSqnkhCVweaA0D-d+KWN_8=OiXW74tDM1DhnCZAgPww@mail.gmail.com' \
    --to=ulf.hansson@linaro.org \
    --cc=baolin.wang7@gmail.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=kernel-team@android.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=orsonzhai@gmail.com \
    --cc=saravanak@google.com \
    --cc=sspatil@android.com \
    --cc=tglx@linutronix.de \
    --cc=zhang.lyra@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.