Re: [PATCH V2] mmc: mmc: Attempt to flush cache before reset

[Ulf Hansson <ulf.hansson@linaro.org>]

On 4 May 2016 at 09:38, Adrian Hunter <adrian.hunter@intel.com> wrote:
> CMD0 or hardware reset may invalidate the cache, so it needs to be
> flushed before reset.
>
> In the case of recovery, we can't expect flushing the cache to work
> always, but have a go and ignore errors.
>
> Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>

Thanks, applied for next!

Kind regards
Uffe

> ---
>
>
> Changes in V2:
>
>         Do flush in mmc_reset() instead of mmc_hw_reset()
>
>
>  drivers/mmc/core/mmc.c | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c
> index 0cf42af33d0f..d4d1b77c1c1e 100644
> --- a/drivers/mmc/core/mmc.c
> +++ b/drivers/mmc/core/mmc.c
> @@ -1965,6 +1965,12 @@ static int mmc_reset(struct mmc_host *host)
>  {
>         struct mmc_card *card = host->card;
>
> +       /*
> +        * In the case of recovery, we can't expect flushing the cache to work
> +        * always, but we have a go and ignore errors.
> +        */
> +       mmc_flush_cache(host->card);
> +
>         if ((host->caps & MMC_CAP_HW_RESET) && host->ops->hw_reset &&
>              mmc_can_reset(card)) {
>                 /* If the card accept RST_n signal, send it. */
> --
> 1.9.1
>
>