From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67AB6C433FE for ; Tue, 22 Feb 2022 15:49:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233607AbiBVPuM (ORCPT ); Tue, 22 Feb 2022 10:50:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39814 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233537AbiBVPuK (ORCPT ); Tue, 22 Feb 2022 10:50:10 -0500 Received: from mail-lj1-x235.google.com (mail-lj1-x235.google.com [IPv6:2a00:1450:4864:20::235]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 36C6646B16 for ; Tue, 22 Feb 2022 07:49:45 -0800 (PST) Received: by mail-lj1-x235.google.com with SMTP id e8so12308564ljj.2 for ; Tue, 22 Feb 2022 07:49:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NZZm6qWe1SwIb8KcDfZKZw7LrmnA+xYk4KC1Fi2iiNE=; b=jA1SbpiMI50DskuXEcULhrcfAjfibrqLpVBH3lqP1WwhyFGAF1jl4QMYw604Vx1F9q mABbjxiYoPiSIukSqdDGQGVACjoj7FV/Fgv2DZLtQIPHEgdeJoLtTTfScDhQGkE7m99g dr8nVAJQBVZtgAvqZo2tk9v5PNjx/2B6V3rQOKpfCfQkbixc3YqlEwWhWZulvqYBcY2W 7JdY752tB7ucvHNYzoQN5mxFvCGDEGvSOynjbuXjg/rpMVHKFh22UChIChVNIDTtidSE doCqXCFTE4b/lM46YRaQLsIrcPPDEDaFBPVtQSIoCfXxrVL0yu5l48CYksa/mV1VbXa4 w5gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NZZm6qWe1SwIb8KcDfZKZw7LrmnA+xYk4KC1Fi2iiNE=; b=uCtb757LqLmUCotZMvZNNtlETRoZMQf4XZZvo9QFTM5593pQu37yYaxSPEzZIneq0G I0zC36ueSq9OIJfQN0jL4xMaJ1DUexOHUuAGOMFaXSpNswhPrwjkt5Y7XgXyXRNhqZWW snB0Io2nmoWz0ICfd+p7AjTigmLuNopxsmcupyCvzxbmbb9I0rNPAGuZw3BfgXlT/aR+ UR1lfprWY4Z20AAn7ZiTJ5o/IGVXDg91ytirQEKg42Fh73JrZMJqCZ9b2m66xsinFSNa UfE8zEy0N/f0mDhODQZKW86R7OCYo6o4Cznv1meXsKyHsjKeC+Stu+h71TxG062nIMf9 VH0A== X-Gm-Message-State: AOAM5336HaDhFCi8t6dGHFXGxtUGgk2aftH8n/p70hAbQrjnVscTJzYA Kt+S7Bg38LHIs/6aio7WmtjvjRXt5b5thiMZ8yzkPQ== X-Google-Smtp-Source: ABdhPJxYfUXFM+iKqXhXbTywYwmn9Khlzeo+cKheqXmeD90PcADvNxqnaj2q13pvIyXLd8v98tx/p5QVeBa5F0jQIVc= X-Received: by 2002:a2e:9cc5:0:b0:239:da6e:290d with SMTP id g5-20020a2e9cc5000000b00239da6e290dmr18128143ljj.4.1645544983573; Tue, 22 Feb 2022 07:49:43 -0800 (PST) MIME-Version: 1.0 References: <20220210224933.379149-1-yury.norov@gmail.com> <20220210224933.379149-30-yury.norov@gmail.com> In-Reply-To: From: Ulf Hansson Date: Tue, 22 Feb 2022 16:49:06 +0100 Message-ID: Subject: Re: [PATCH 29/49] memstick: replace bitmap_weight with bitmap_weight_eq where appropriate To: Yury Norov Cc: Andy Shevchenko , Rasmus Villemoes , Andrew Morton , =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , Greg Kroah-Hartman , Peter Zijlstra , David Laight , Joe Perches , Dennis Zhou , Emil Renner Berthing , Nicholas Piggin , Matti Vaittinen , Alexey Klimov , linux-kernel@vger.kernel.org, Maxim Levitsky , Alex Dubov , Jens Axboe , Luis Chamberlain , Colin Ian King , Arnd Bergmann , Shubhankar Kuranagatti , linux-mmc@vger.kernel.org, Shubhankar Kuranagatti Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 17 Feb 2022 at 17:55, Yury Norov wrote: > > On Thu, Feb 17, 2022 at 7:39 AM Ulf Hansson wrote: > > > > On Fri, 11 Feb 2022 at 00:55, Yury Norov wrote: > > > > > > msb_validate_used_block_bitmap() calls bitmap_weight() to compare the > > > weight of bitmap with a given number. We can do it more efficiently with > > > bitmap_weight_eq because conditional bitmap_weight may stop traversing the > > > bitmap earlier, as soon as condition is (or can't be) met. > > > > > > Signed-off-by: Yury Norov > > > Acked-by: Ulf Hansson > > > Acked-by: Shubhankar Kuranagatti > > > > Applied for next, thanks! > > Hi Ulf, > > This patch depends on patch 26/49 "bitmap: add bitmap_weight_{cmp, eq, > gt, ge, lt, le} functions" > from this series. Can you make sure you applied them together? Or I can > apply it later. I can't apply them, unless there is an immutable branch being shared between the different trees. Therefore I have dropped the patch for now. Kind regards Uffe