From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 105BAC00144 for ; Tue, 26 Jul 2022 15:08:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238826AbiGZPIp (ORCPT ); Tue, 26 Jul 2022 11:08:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42966 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233844AbiGZPIn (ORCPT ); Tue, 26 Jul 2022 11:08:43 -0400 Received: from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com [IPv6:2a00:1450:4864:20::22b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0FCE42ED79 for ; Tue, 26 Jul 2022 08:08:42 -0700 (PDT) Received: by mail-lj1-x22b.google.com with SMTP id p21so9181598ljh.12 for ; Tue, 26 Jul 2022 08:08:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zYxlO4qUEsJsTyo7qlyDijTEk/pzFLiwn3btcavQ1D0=; b=uuhHrIG6mqSq2NDpyxxWcAyvFfrfVFtOOHZKG2EWZ7K/XYXOltg3ag96J1R6NvFd8H NmrC2x6kfY6Da6UP06qsiBdDcpuhzSirWgF8kyxIV+dlIvV4CL/IB/yGrw5Co3S1AV44 otfO7qj75+8vMwnCPysQmfZxIrkNyst0reNkHAIWQURn5GVIbp7QibZ38i0T4LTZwpxj JNHvSIS+FchHzNAV5XYxcBVm58uSOa3UufR6PNfTWmWWxd1KYFKdd5l+2TvfGg2YRl88 XE5c1srEsmlMsGXlgrbn6AqIB87URnXhqWpswcu7LqTwgGiBD2DrS/9ef32bhh5XEe0M zUSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zYxlO4qUEsJsTyo7qlyDijTEk/pzFLiwn3btcavQ1D0=; b=v79fKWnp8QE3oC6TeusTm0r7x1P+VtsBDRKNHooUWxz6RZDi6lmQhObxJNq3Fp3bTA oYKR/02s28SYu3DfIDw901qWsnAKddbldaQGp4TEGpA54p5Zat5jW4argp0eWlFT10yH xmiSqrhDiZiQpABvuPlTToKUk0YGWWbYPPmc7bcShivtLh6nqzal7AIhWaFSH49GktJ5 dRXJgDb7ZRPEODe4rAXNukElONo+Fb7gohnS91ZF4vcJ/5Qdyukxn67oLlBNewHKJxKh sZNTwMj7ETUO3doWqK7rQe/J0PHTk63LVeIFXaUy6PK8iM5HxyCjtAqIg/1zcSIWj/Hi TP7g== X-Gm-Message-State: AJIora+QhGMWAgbDbwkXCMrLHDiY5RO7SclMXyjlc6hJPW8sRe/28xEX mnVBcJkNF++hA65NtesUbW+EIcjQJUIVPYNq0++OLg== X-Google-Smtp-Source: AGRyM1vnhd9AgeMqMzIkST0+/MXJDtwSb3YqzIyqyTqvlFcJcyaQaABNFhj6gPv8lwbSPKqYYTbIGbtjlIYJJDUyOMU= X-Received: by 2002:a2e:900e:0:b0:25e:9fe:f8d4 with SMTP id h14-20020a2e900e000000b0025e09fef8d4mr3038980ljg.273.1658848120400; Tue, 26 Jul 2022 08:08:40 -0700 (PDT) MIME-Version: 1.0 References: <20220726083257.1730630-1-martin.kepplinger@puri.sm> <20220726083257.1730630-3-martin.kepplinger@puri.sm> In-Reply-To: <20220726083257.1730630-3-martin.kepplinger@puri.sm> From: Ulf Hansson Date: Tue, 26 Jul 2022 17:08:03 +0200 Message-ID: Subject: Re: [PATCH v6 2/2] soc: imx: gpcv2: fix suspend/resume by setting GENPD_FLAG_IRQ_ON To: Martin Kepplinger Cc: rafael@kernel.org, khilman@kernel.org, robh@kernel.org, krzysztof.kozlowski@linaro.org, shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com, pavel@ucw.cz, kernel@puri.sm, linux-imx@nxp.com, broonie@kernel.org, l.stach@pengutronix.de, aford173@gmail.com, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 26 Jul 2022 at 10:33, Martin Kepplinger wrote: > > For boards that use power-domains' power-supplies that need interrupts > to work (like regulator over i2c), set GENPD_FLAG_IRQ_ON. > This will tell genpd to adjust accordingly. Currently it "only" sets the > correct suspend/resume callbacks. > > This fixes suspend/resume on imx8mq-librem5 boards (tested) and > imx8mq-evk (by looking at dts) and possibly more. > > Signed-off-by: Martin Kepplinger Reviewed-by: Ulf Hansson Kind regards Uffe > --- > drivers/soc/imx/gpcv2.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/soc/imx/gpcv2.c b/drivers/soc/imx/gpcv2.c > index 6383a4edc360..199a621d8186 100644 > --- a/drivers/soc/imx/gpcv2.c > +++ b/drivers/soc/imx/gpcv2.c > @@ -1337,6 +1337,9 @@ static int imx_pgc_domain_probe(struct platform_device *pdev) > regmap_update_bits(domain->regmap, domain->regs->map, > domain->bits.map, domain->bits.map); > > + if (of_property_read_bool(domain->dev->of_node, "power-supply")) > + domain->genpd.flags |= GENPD_FLAG_IRQ_ON; > + > ret = pm_genpd_init(&domain->genpd, NULL, true); > if (ret) { > dev_err(domain->dev, "Failed to init power domain\n"); > -- > 2.30.2 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E7C59C00140 for ; Tue, 26 Jul 2022 15:09:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2hg+nKY01Qk+o7eCWNR75sXoEKz3Mag9eLe2H6PvUCI=; b=4CWhLZPDkFxiRd SNhJO64tgm+iH7H/++0aCrc1VSCUK9fu/w3kq0Mi2IxZmwkbhbGqmtEbKJYp4R4UerQETXTu5hV3g DRRJJJNok9SHa+g9mYddFKbIZiUr6mRDp/3pEkcIUgANZF5GE9jFeUTwx6JJ1GguG04GQ3Rtx6w0b NBH11I9dR5FRUfOnuAi89ipkwwHe8kvoyliTaL0F+4kV4+OJDdgRGLk5udMKkzk167Bl+ktAaYHe0 ctWcc1ZyU0BWk2EGYgDZITbt/u3e9G1lH5JoZ8iXGxZ7JBBsWGiYf2/Pv/T4ixA7uRjPOsuc5AeKZ x7Ks1X3YGewTE5kAXJag==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oGMB0-000TFH-HS; Tue, 26 Jul 2022 15:08:51 +0000 Received: from mail-lj1-x232.google.com ([2a00:1450:4864:20::232]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oGMAt-000T9w-2n for linux-arm-kernel@lists.infradead.org; Tue, 26 Jul 2022 15:08:45 +0000 Received: by mail-lj1-x232.google.com with SMTP id q7so1393433ljp.13 for ; Tue, 26 Jul 2022 08:08:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zYxlO4qUEsJsTyo7qlyDijTEk/pzFLiwn3btcavQ1D0=; b=uuhHrIG6mqSq2NDpyxxWcAyvFfrfVFtOOHZKG2EWZ7K/XYXOltg3ag96J1R6NvFd8H NmrC2x6kfY6Da6UP06qsiBdDcpuhzSirWgF8kyxIV+dlIvV4CL/IB/yGrw5Co3S1AV44 otfO7qj75+8vMwnCPysQmfZxIrkNyst0reNkHAIWQURn5GVIbp7QibZ38i0T4LTZwpxj JNHvSIS+FchHzNAV5XYxcBVm58uSOa3UufR6PNfTWmWWxd1KYFKdd5l+2TvfGg2YRl88 XE5c1srEsmlMsGXlgrbn6AqIB87URnXhqWpswcu7LqTwgGiBD2DrS/9ef32bhh5XEe0M zUSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zYxlO4qUEsJsTyo7qlyDijTEk/pzFLiwn3btcavQ1D0=; b=TM9k8s9TMyoobwraulaGAj0z5/nzeC2fgU//SivhBbxG82XZiBARPAnBv8GanwUR2m KPBL9IeQcnifr+h/FiS/y93wapn3dbUCUfks12Ij1InB1FMYVMxb6s62CZGpjX93U1Uk SrD0Dc8YomSjUR3X0+vdcnECa/DInFc8hLctzKnhGhLyw0ioYxN0JRVB/LmBySrceh3D vXxafi4deIuBVJqn05I5W3rH8IOyf3nbdWVb5KkaRyT8yrbokfaiYgAEOT1mDMdebf/g fQn8DCHTFSmVMgMMyPaQncIN+hy6WNzpni9Nw0/bLzUxbq7vy/oeZNFhlVQQ0X7dhPDI n7SQ== X-Gm-Message-State: AJIora8EL5kWC17VEQJJnHCdXCsd1GcAbZDSh+nk8l6YSAaiouGwgX7m YqJPElzl6aWAzzsltlsWLcV6W4AvdE3ErsiCWxuIog== X-Google-Smtp-Source: AGRyM1vnhd9AgeMqMzIkST0+/MXJDtwSb3YqzIyqyTqvlFcJcyaQaABNFhj6gPv8lwbSPKqYYTbIGbtjlIYJJDUyOMU= X-Received: by 2002:a2e:900e:0:b0:25e:9fe:f8d4 with SMTP id h14-20020a2e900e000000b0025e09fef8d4mr3038980ljg.273.1658848120400; Tue, 26 Jul 2022 08:08:40 -0700 (PDT) MIME-Version: 1.0 References: <20220726083257.1730630-1-martin.kepplinger@puri.sm> <20220726083257.1730630-3-martin.kepplinger@puri.sm> In-Reply-To: <20220726083257.1730630-3-martin.kepplinger@puri.sm> From: Ulf Hansson Date: Tue, 26 Jul 2022 17:08:03 +0200 Message-ID: Subject: Re: [PATCH v6 2/2] soc: imx: gpcv2: fix suspend/resume by setting GENPD_FLAG_IRQ_ON To: Martin Kepplinger Cc: rafael@kernel.org, khilman@kernel.org, robh@kernel.org, krzysztof.kozlowski@linaro.org, shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com, pavel@ucw.cz, kernel@puri.sm, linux-imx@nxp.com, broonie@kernel.org, l.stach@pengutronix.de, aford173@gmail.com, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220726_080843_219653_54AA81BE X-CRM114-Status: GOOD ( 18.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 26 Jul 2022 at 10:33, Martin Kepplinger wrote: > > For boards that use power-domains' power-supplies that need interrupts > to work (like regulator over i2c), set GENPD_FLAG_IRQ_ON. > This will tell genpd to adjust accordingly. Currently it "only" sets the > correct suspend/resume callbacks. > > This fixes suspend/resume on imx8mq-librem5 boards (tested) and > imx8mq-evk (by looking at dts) and possibly more. > > Signed-off-by: Martin Kepplinger Reviewed-by: Ulf Hansson Kind regards Uffe > --- > drivers/soc/imx/gpcv2.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/soc/imx/gpcv2.c b/drivers/soc/imx/gpcv2.c > index 6383a4edc360..199a621d8186 100644 > --- a/drivers/soc/imx/gpcv2.c > +++ b/drivers/soc/imx/gpcv2.c > @@ -1337,6 +1337,9 @@ static int imx_pgc_domain_probe(struct platform_device *pdev) > regmap_update_bits(domain->regmap, domain->regs->map, > domain->bits.map, domain->bits.map); > > + if (of_property_read_bool(domain->dev->of_node, "power-supply")) > + domain->genpd.flags |= GENPD_FLAG_IRQ_ON; > + > ret = pm_genpd_init(&domain->genpd, NULL, true); > if (ret) { > dev_err(domain->dev, "Failed to init power domain\n"); > -- > 2.30.2 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel