From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8B36C2D0E2 for ; Tue, 22 Sep 2020 07:31:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5775223A32 for ; Tue, 22 Sep 2020 07:31:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="NzXqgHqa" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730022AbgIVHb6 (ORCPT ); Tue, 22 Sep 2020 03:31:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57714 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730015AbgIVHb6 (ORCPT ); Tue, 22 Sep 2020 03:31:58 -0400 Received: from mail-vs1-xe44.google.com (mail-vs1-xe44.google.com [IPv6:2607:f8b0:4864:20::e44]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6D808C0613CF for ; Tue, 22 Sep 2020 00:31:58 -0700 (PDT) Received: by mail-vs1-xe44.google.com with SMTP id a16so9681581vsp.12 for ; Tue, 22 Sep 2020 00:31:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=P/RqbrzOlXZ/TBQu2smR9qpwNWSy/awy50sEEzyqxs4=; b=NzXqgHqaCNw/6HqSrE4LnebQtEdFqVo71WEXgRS3C5d3KCEjdEQbjjHhVVKfISpARC o+D5hkLpTwwG/e/OGilw2haftR+SghGlX/J8r79F68eMN4uE6RL3hro1qASYDbKR4QRA g/imvtIEP5oN6z0d8L5H+KxE9J4XVypTFsFctV8Uc4N+V6viBoh3t54F+OsgHHg83BpY 941L26mUdVPekmBBTIJscROx4+mes+qw8v6E17lCjxBXiSB9xgkULXMYfd9OoJyLlTPb Y3/Hy3ASehxTkEQWm/0xjFMT8ot08JgxmOmpDiPfMZN2nAf2Blm5XGPpg1OIBxc+mk/5 SsZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=P/RqbrzOlXZ/TBQu2smR9qpwNWSy/awy50sEEzyqxs4=; b=R8JebhpT3HVXmzdN3nQ7H+socTajiKth7AP/AmlwXLRMBdSCoU0GCXJOY6x4NLTOvM n1UkPvgvs4JQ/2klCZgAWmHtgVffOt0pNl97ZEOTrw9/O0g3sXkRrjoPkb/UDPnD3DiM BhEJi88drrpT7Cy9Ek85W4gopGhYrgL0hTk9gXTISc+jpuDM08ziusyyS9y8MJyD5dL2 n4SkEfSsD1gwGEFCKmnQPbdmSXriu+mqRMoxyAkibc1Q5lCgKH+hwNkENNUvvTAX4wwz jcnYJjb1gj7hhc32xAarpMRZLUxHCZ73h9B+CZFQi412cJmxsBGnqocUtwja+6CFzLTj Vqug== X-Gm-Message-State: AOAM531W5Hf3AnLHVjlUbpQvtVqoErx9hb99G+f6owz/CYJcaMuRQcYZ +nB58LCUE5o1Tv0tNXHDlka55R0YTdalXje+8AE0Ig== X-Google-Smtp-Source: ABdhPJxeNIhY7wlyypnbF1IB9nBP4fszWTaZhnPAC20Ij1ZN2+2wp8/96cKt6PitFKNSShqnOdzY9WTVyvTwP4KTaPc= X-Received: by 2002:a67:d011:: with SMTP id r17mr2601456vsi.48.1600759917536; Tue, 22 Sep 2020 00:31:57 -0700 (PDT) MIME-Version: 1.0 References: <20200821204921.32536-1-sibis@codeaurora.org> <160071818317.4188128.15658877054019388462@swboyd.mtv.corp.google.com> <14eb0558c8ff820280bb7354cfe33326@codeaurora.org> In-Reply-To: <14eb0558c8ff820280bb7354cfe33326@codeaurora.org> From: Ulf Hansson Date: Tue, 22 Sep 2020 09:31:21 +0200 Message-ID: Subject: Re: [PATCH v2 1/2] PM / Domains: Add GENPD_FLAG_NO_SUSPEND/RESUME flags To: Sibi Sankar Cc: Stephen Boyd , "Rafael J. Wysocki" , Bjorn Andersson , Kevin Hilman , "Rafael J. Wysocki" , Andy Gross , Linux Kernel Mailing List , linux-arm-msm , Linux PM , Greg Kroah-Hartman , Pavel Machek , Len Brown , "Nayak, Rajendra" , Doug Anderson , Matthias Kaehlcke Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Tue, 22 Sep 2020 at 06:51, Sibi Sankar wrote: > > On 2020-09-22 01:26, Stephen Boyd wrote: > > Quoting Rafael J. Wysocki (2020-09-21 09:18:17) > >> On Fri, Aug 21, 2020 at 10:49 PM Sibi Sankar > >> wrote: > >> > > >> > Add GENPD_FLAG_NO_SUSPEND/RESUME flags to instruct genpd to keep the > >> > status of the PM domain unaltered during suspend/resume respectively. > >> > The flags are aimed at power domains coupled to co-processors which > >> > enter low-power modes independent to that of the application processor. > >> > > >> > Specifically the flags are to be used by the power domains exposed > >> > by the AOSS QMP driver linked to modem, adsp, cdsp remoteprocs. These > >> > power domains are used to notify the Always on Subsystem (AOSS) that > >> > a particular co-processor is up. AOSS uses this information to wait > >> > for the co-processors to suspend before starting its sleep sequence. > >> > The application processor powers off these power domains only if the > >> > co-processor has crashed or powered off and remains unaltered during > >> > system suspend/resume. > >> > > >> > Signed-off-by: Sibi Sankar > >> > >> Applied with the Ulf's R-by along with the [2/2] as 5.10 material, > >> thanks! > >> > > > > There was a bunch of discussion on this patch series and I thought the > > consensus was to not apply these patches and instead implement a custom > > qcom specific API that does this instead. > > https://lore.kernel.org/lkml/20200913034603.GV3715@yoga/ > > The power domains which were targeted > to use the flags will be replaced by > custom qcom specific API. So let's not > pick up the patch series. I am fine with either option. However, please keep me posted, as I am a bit curious how this will look like in the qcom specific drivers. Kind regards Uffe