From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 805F4C35247 for ; Tue, 4 Feb 2020 17:58:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 48BD32084E for ; Tue, 4 Feb 2020 17:58:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="O5VDOtm/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727454AbgBDR6i (ORCPT ); Tue, 4 Feb 2020 12:58:38 -0500 Received: from mail-vs1-f66.google.com ([209.85.217.66]:45266 "EHLO mail-vs1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727363AbgBDR6i (ORCPT ); Tue, 4 Feb 2020 12:58:38 -0500 Received: by mail-vs1-f66.google.com with SMTP id v141so11901626vsv.12 for ; Tue, 04 Feb 2020 09:58:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=tzVO/i3RlK8wTW0CtIUDqXR3obK88NMKP/u+iDd4rUQ=; b=O5VDOtm/ib9l1nZlkLp5aAjoHDGmbe/pDbvrnrOFQxx0ugJzt1szBuYP/xwnZgETip P7HAfIEw3unJXYEVS4ie/bxig8VQ0AorpiyBzWFvlFBu2KjH3y4NnS7MNtts3L5btYIC ij6sGv8mGSatOqli5mxV83kZVF3PE/4COaxgB7LSHF5HBP1q8UWGxi8IFnO4JFFHivpB 4P+JhkKMxD2r24UnI3YkDjuXSbSgbHBTDZuRqnMayX0j18RWJJ47chbBK1li9ZMqSFeQ hiZrZN3Z8qSqzz9dE8/gSy8tALakqrzvM01IHNEFKAhrSTNr8tFlilhaAGg4OUOCOCvD kdwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tzVO/i3RlK8wTW0CtIUDqXR3obK88NMKP/u+iDd4rUQ=; b=jOcpv97WsDIj77nuQTmUi+VTRgELo+g/NjwSB4F+a5IgWkVT4r767Bo17UFNtdBD2p oepI460LJKwCnfmb92Y6cug88TCPC3t23z0//Jdb7B2h3wDsuoXEsbVd/aontbJFNVJi d4B0R7MBzvr0EKk7O0XhanJHXK9B7aqKdKveE3p9F6oFzUAe8M3v3+nbjwA+4mQRF3s6 WDdP4ezxRCiM7Vgf2YbPqlPGKagBPWWnF3Fqmhu1MDWnYEW2q3RPIrxzPDCqH4H1tJOB twHXMUuxA8r3/qS6sJTTyfkmcMPjLPCjXQpb7x0KD1FDfTwmR3jrZm0pGrV/HTRr+4mM dKWg== X-Gm-Message-State: APjAAAWIFA2MBteZ+4iBGayI0lnxZmDf30boFydV2vhsX6n4K8YULAq4 ZBxLsHasxQbVktHhvHLck9cHBXBKGZlEAwGjInYG0g== X-Google-Smtp-Source: APXvYqy8K0HZyom2Se94kPkPrPAC4jNuAoEYRybckINHoKbQmKOYiKuIMKD8CqYzd04t+SoQUijdLLODpClkxzUnst0= X-Received: by 2002:a05:6102:757:: with SMTP id v23mr19931507vsg.35.1580839116928; Tue, 04 Feb 2020 09:58:36 -0800 (PST) MIME-Version: 1.0 References: <20200115013751.249588-1-swboyd@chromium.org> In-Reply-To: <20200115013751.249588-1-swboyd@chromium.org> From: Ulf Hansson Date: Tue, 4 Feb 2020 18:58:00 +0100 Message-ID: Subject: Re: [PATCH] drivers: qcom: rpmh-rsc: Use rcuidle tracepoints for rpmh To: Stephen Boyd Cc: Andy Gross , Bjorn Andersson , Linux Kernel Mailing List , linux-arm-msm , Linux PM , Sai Prakash Ranjan Content-Type: text/plain; charset="UTF-8" Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Wed, 15 Jan 2020 at 02:37, Stephen Boyd wrote: > > This tracepoint is hit now that we call into the rpmh code from the cpu > idle path. Let's move this to be an rcuidle tracepoint so that we avoid > the RCU idle splat below > > ============================= > WARNING: suspicious RCU usage > 5.4.10 #68 Tainted: G S > ----------------------------- > drivers/soc/qcom/trace-rpmh.h:72 suspicious rcu_dereference_check() usage! > > other info that might help us debug this: > > RCU used illegally from idle CPU! > rcu_scheduler_active = 2, debug_locks = 1 > RCU used illegally from extended quiescent state! > 5 locks held by swapper/2/0: > #0: ffffff81745d6ee8 (&(&genpd->slock)->rlock){+.+.}, at: genpd_lock_spin+0x1c/0x2c > #1: ffffff81745da6e8 (&(&genpd->slock)->rlock/1){....}, at: genpd_lock_nested_spin+0x24/0x34 > #2: ffffff8174f2ca20 (&(&genpd->slock)->rlock/2){....}, at: genpd_lock_nested_spin+0x24/0x34 > #3: ffffff8174f2c300 (&(&drv->client.cache_lock)->rlock){....}, at: rpmh_flush+0x48/0x24c > #4: ffffff8174f2c150 (&(&tcs->lock)->rlock){+.+.}, at: rpmh_rsc_write_ctrl_data+0x74/0x270 > > stack backtrace: > CPU: 2 PID: 0 Comm: swapper/2 Tainted: G S 5.4.10 #68 > Call trace: > dump_backtrace+0x0/0x174 > show_stack+0x20/0x2c > dump_stack+0xc8/0x124 > lockdep_rcu_suspicious+0xe4/0x104 > __tcs_buffer_write+0x230/0x2d0 > rpmh_rsc_write_ctrl_data+0x210/0x270 > rpmh_flush+0x84/0x24c > rpmh_domain_power_off+0x78/0x98 > _genpd_power_off+0x40/0xc0 > genpd_power_off+0x168/0x208 > genpd_power_off+0x1e0/0x208 > genpd_power_off+0x1e0/0x208 > genpd_runtime_suspend+0x1ac/0x220 > __rpm_callback+0x70/0xfc > rpm_callback+0x34/0x8c > rpm_suspend+0x218/0x4a4 > __pm_runtime_suspend+0x88/0xac > psci_enter_domain_idle_state+0x3c/0xb4 > cpuidle_enter_state+0xb8/0x284 > cpuidle_enter+0x38/0x4c > call_cpuidle+0x3c/0x68 > do_idle+0x194/0x260 > cpu_startup_entry+0x24/0x28 > secondary_start_kernel+0x150/0x15c > > Fixes: a65a397f2451 ("cpuidle: psci: Add support for PM domains by using genpd") > Reported-by: Sai Prakash Ranjan > Cc: Ulf Hansson > Signed-off-by: Stephen Boyd Sorry for the delay and many thanks for fixing this! > --- > > I think the commit that this is "Fixes"ing is a stable commit, but I'm > not positive. Correct, the commit is in Linus' tree by now. Acked-by: Ulf Hansson Kind regards Uffe > > drivers/soc/qcom/rpmh-rsc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/soc/qcom/rpmh-rsc.c b/drivers/soc/qcom/rpmh-rsc.c > index e278fc11fe5c..b71822131f59 100644 > --- a/drivers/soc/qcom/rpmh-rsc.c > +++ b/drivers/soc/qcom/rpmh-rsc.c > @@ -277,7 +277,7 @@ static void __tcs_buffer_write(struct rsc_drv *drv, int tcs_id, int cmd_id, > write_tcs_cmd(drv, RSC_DRV_CMD_MSGID, tcs_id, j, msgid); > write_tcs_cmd(drv, RSC_DRV_CMD_ADDR, tcs_id, j, cmd->addr); > write_tcs_cmd(drv, RSC_DRV_CMD_DATA, tcs_id, j, cmd->data); > - trace_rpmh_send_msg(drv, tcs_id, j, msgid, cmd); > + trace_rpmh_send_msg_rcuidle(drv, tcs_id, j, msgid, cmd); > } > > write_tcs_reg(drv, RSC_DRV_CMD_WAIT_FOR_CMPL, tcs_id, cmd_complete); > -- > Sent by a computer, using git, on the internet >