From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BC73ECDE46 for ; Thu, 25 Oct 2018 10:55:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E5F742082E for ; Thu, 25 Oct 2018 10:55:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linaro.org header.i=@linaro.org header.b="AYyw3eyA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E5F742082E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727498AbeJYT1x (ORCPT ); Thu, 25 Oct 2018 15:27:53 -0400 Received: from mail-it1-f194.google.com ([209.85.166.194]:33320 "EHLO mail-it1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727420AbeJYT1w (ORCPT ); Thu, 25 Oct 2018 15:27:52 -0400 Received: by mail-it1-f194.google.com with SMTP id h6-v6so1851921ith.0 for ; Thu, 25 Oct 2018 03:55:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=pcxsBOUqf7jB+ycXPk9VXpTvvTVpdenL7acA5++7KMc=; b=AYyw3eyAWV6KKJz1pBK0t0ik0TGcHASACzsemXBCja0VW6AIpvm+b6dF9Qb55GOJyd ln8lKveFoZOdDqNBqWA9vOikrL94FphJkhU83C33QAv28YBBYD0GMsIBvvg6KJgv4niX 7EEy+MGICZXQFE6ktAANDbwbmU9L5GljerKUk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=pcxsBOUqf7jB+ycXPk9VXpTvvTVpdenL7acA5++7KMc=; b=a63pWXDHQVXaeVIrpz8ywsVNlshIumPtjfuNVIdLhD2vI42JeAeOeiRBwhGrESxcm3 k9y/lHxwvJ0BpHjlPYJPj4gx9L/uVy7jAOi2wIFQ9+Wsl1onrjDIlfr6X5w9dRBhUA8p w1zdF+wpx9M+kf+i5PbBpKmbMqDntnv6Hjwse7VwB8LFkOIqRwtQWx4IDTGr3tf48jug pc+P4zU25Ao8gaM9Xl/diLoS5WDCgj/BlBZff/H9d+7OIFWNCG3kobVmscw7XVjQFasp kLuBjrPd+gofDjcSuT+7ckjaRm/Lz/lpoVJQaSpQ/2r8jUHIuO/ixsyc7YxdtclIoP8W kIdQ== X-Gm-Message-State: AGRZ1gJFeSd8MOw5doa/irNj6NRtCB/oyzltsMm/+UcNgt5dY5Oui4By tiugaU/FG/UE6fCaWIRY7izQlSvB+u3f+j3tWDpoNQ== X-Google-Smtp-Source: AJdET5dRDAzU/HnUw4DwW+OVqbcX8nxVyj5FVPkt+GzmslfQLeNNrfmeXki+nbGlcUXuJ+NmKfdIuE8HHdjyHE7efYQ= X-Received: by 2002:a24:47c5:: with SMTP id t188-v6mr583882itb.78.1540464938157; Thu, 25 Oct 2018 03:55:38 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a02:3941:0:0:0:0:0 with HTTP; Thu, 25 Oct 2018 03:54:57 -0700 (PDT) In-Reply-To: References: From: Ulf Hansson Date: Thu, 25 Oct 2018 12:54:57 +0200 Message-ID: Subject: Re: [PATCH V3 10/10] OPP: Remove of_dev_pm_opp_find_required_opp() To: Viresh Kumar Cc: Viresh Kumar , Nishanth Menon , Stephen Boyd , "Rafael J. Wysocki" , Linux PM , Vincent Guittot , Niklas Cassel , Rajendra Nayak , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25 October 2018 at 07:52, Viresh Kumar wrote: > This isn't used anymore, remove it. > > Signed-off-by: Viresh Kumar Reviewed-by: Ulf Hansson Kind regards Uffe > --- > drivers/opp/of.c | 54 ------------------------------------------ > include/linux/pm_opp.h | 5 ---- > 2 files changed, 59 deletions(-) > > diff --git a/drivers/opp/of.c b/drivers/opp/of.c > index 0755ee307b1a..da31874c7fe9 100644 > --- a/drivers/opp/of.c > +++ b/drivers/opp/of.c > @@ -1013,60 +1013,6 @@ unsigned int of_get_required_opp_performance_state(struct device_node *np, > } > EXPORT_SYMBOL_GPL(of_get_required_opp_performance_state); > > -/** > - * of_dev_pm_opp_find_required_opp() - Search for required OPP. > - * @dev: The device whose OPP node is referenced by the 'np' DT node. > - * @np: Node that contains the "required-opps" property. > - * > - * Returns the OPP of the device 'dev', whose phandle is present in the "np" > - * node. Although the "required-opps" property supports having multiple > - * phandles, this helper routine only parses the very first phandle in the list. > - * > - * Return: Matching opp, else returns ERR_PTR in case of error and should be > - * handled using IS_ERR. > - * > - * The callers are required to call dev_pm_opp_put() for the returned OPP after > - * use. > - */ > -struct dev_pm_opp *of_dev_pm_opp_find_required_opp(struct device *dev, > - struct device_node *np) > -{ > - struct dev_pm_opp *temp_opp, *opp = ERR_PTR(-ENODEV); > - struct device_node *required_np; > - struct opp_table *opp_table; > - > - opp_table = _find_opp_table(dev); > - if (IS_ERR(opp_table)) > - return ERR_CAST(opp_table); > - > - required_np = of_parse_phandle(np, "required-opps", 0); > - if (unlikely(!required_np)) { > - dev_err(dev, "Unable to parse required-opps\n"); > - goto put_opp_table; > - } > - > - mutex_lock(&opp_table->lock); > - > - list_for_each_entry(temp_opp, &opp_table->opp_list, node) { > - if (temp_opp->available && temp_opp->np == required_np) { > - opp = temp_opp; > - > - /* Increment the reference count of OPP */ > - dev_pm_opp_get(opp); > - break; > - } > - } > - > - mutex_unlock(&opp_table->lock); > - > - of_node_put(required_np); > -put_opp_table: > - dev_pm_opp_put_opp_table(opp_table); > - > - return opp; > -} > -EXPORT_SYMBOL_GPL(of_dev_pm_opp_find_required_opp); > - > /** > * dev_pm_opp_get_of_node() - Gets the DT node corresponding to an opp > * @opp: opp for which DT node has to be returned for > diff --git a/include/linux/pm_opp.h b/include/linux/pm_opp.h > index 889bb347fbd9..2b2c3fd985ab 100644 > --- a/include/linux/pm_opp.h > +++ b/include/linux/pm_opp.h > @@ -313,7 +313,6 @@ int dev_pm_opp_of_cpumask_add_table(const struct cpumask *cpumask); > void dev_pm_opp_of_cpumask_remove_table(const struct cpumask *cpumask); > int dev_pm_opp_of_get_sharing_cpus(struct device *cpu_dev, struct cpumask *cpumask); > struct device_node *dev_pm_opp_of_get_opp_desc_node(struct device *dev); > -struct dev_pm_opp *of_dev_pm_opp_find_required_opp(struct device *dev, struct device_node *np); > struct device_node *dev_pm_opp_get_of_node(struct dev_pm_opp *opp); > unsigned int of_get_required_opp_performance_state(struct device_node *np, int index); > #else > @@ -350,10 +349,6 @@ static inline struct device_node *dev_pm_opp_of_get_opp_desc_node(struct device > return NULL; > } > > -static inline struct dev_pm_opp *of_dev_pm_opp_find_required_opp(struct device *dev, struct device_node *np) > -{ > - return NULL; > -} > static inline struct device_node *dev_pm_opp_get_of_node(struct dev_pm_opp *opp) > { > return NULL; > -- > 2.19.1.568.g152ad8e3369a >