From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD4E2C4320E for ; Tue, 24 Aug 2021 14:57:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A55B861214 for ; Tue, 24 Aug 2021 14:57:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238013AbhHXO5v (ORCPT ); Tue, 24 Aug 2021 10:57:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56078 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237990AbhHXO5u (ORCPT ); Tue, 24 Aug 2021 10:57:50 -0400 Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com [IPv6:2a00:1450:4864:20::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4ED1FC0613C1 for ; Tue, 24 Aug 2021 07:57:06 -0700 (PDT) Received: by mail-lj1-x229.google.com with SMTP id f2so38224554ljn.1 for ; Tue, 24 Aug 2021 07:57:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=q47KpM04JtXbjrX4Th8KJJ2WJfmQTigKdxRxjyOEcFo=; b=irzcDqLfZcL8M9bY1pfhENXo7KmRfT4Wa6liQxiru7DlQIPrr1a1jcv+sdlnVTnfNF kTz3nq4Terj5e/D8wMuUpLch/sXpwIiGVaq/EdRAeC7Xgc2CuBuDMHzM5AJFzczgmdbP kK7r68SgojvNOSfuRDLqBqnDF/bg+ugza3KEjo6vIH50Eb9gFaSWJIgIhUwGtgtTwIoh C3nNBskl60FUC8rW3xPt7l7xfXwFnzHL2r+nJvVQhdav3DmrDGvkOqQgLLTDWOPBM67c cYhCheaEK39sFD1rWMqyYpBsWve18iBR7JNHv2FHSYV37DsIH86p5FEl5d21EtJAxhuN moRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=q47KpM04JtXbjrX4Th8KJJ2WJfmQTigKdxRxjyOEcFo=; b=ABRrS2DXjO1LYhKNElJwKJrbgIonKzVFGU6D53EGvfhK6/+GMyu1ZzvG46gmpLttnB FPzqIccakCV+xlLD+Lja0VDk2ZPgNcpa0K9XRJGFOqLJAAkgnjjJsCpucqptWoWV2KRE S05Teic28jROedTv42mo3eWYpBjMmuLy6bvBrQxsZJsxKWZQrkcycKq+dLF1SnQWIWhP h5MpLbjLwy6c5t47BP5+0cjr5Hw2FYjz1Zky6hZBvDojG+/o5ss38MQglj2QHqQ7XrcL FKzN/NsDZ7DZavPibrkD05/bKPN286mWqzxjmj5aXZlHShLv1OdJEqLJrQJwSQQZLuSX Y8IQ== X-Gm-Message-State: AOAM533g6Jb9PZHo2tWV1qqkaovDDvpRyte6RZabObmx8djvBHpv4sIe au9SxdZyO1dAWk/v50PoaAG2mNHVEHHEjpjgHTx4qLa+BXziSw== X-Google-Smtp-Source: ABdhPJwfFJKHpnxXv8/1gum9S+upuN8rQP4xRwN2p75hcpwjG5NXTI3vyGKYLQMErsI6Eqom9XZxt10tCGCE/VjFsV0= X-Received: by 2002:a2e:84ca:: with SMTP id q10mr18815903ljh.182.1629817024632; Tue, 24 Aug 2021 07:57:04 -0700 (PDT) MIME-Version: 1.0 References: <20210817090313.31858-1-biju.das.jz@bp.renesas.com> <20210817090313.31858-2-biju.das.jz@bp.renesas.com> In-Reply-To: <20210817090313.31858-2-biju.das.jz@bp.renesas.com> From: Ulf Hansson Date: Tue, 24 Aug 2021 16:56:27 +0200 Message-ID: Subject: Re: [PATCH v4 1/2] dt-bindings: mmc: renesas,sdhi: Fix dtbs-check warning To: Biju Das Cc: Rob Herring , Wolfram Sang , linux-mmc , DTML , Geert Uytterhoeven , Chris Paterson , Biju Das , Prabhakar Mahadev Lad , Linux-Renesas Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, 17 Aug 2021 at 11:03, Biju Das wrote: > > Fix dtbs-check warning pinctrl-names:0:'default' was expected > for r8a77470-iwg23s-sbc.dts file. > > Signed-off-by: Biju Das > Reviewed-by: Lad Prabhakar Applied for next, thanks! Kind regards Uffe > --- > v3->v4: > * Removed duplicate clock-names for sdhi-r7sxxxx SoC's > Ref:- https://patchwork.kernel.org/project/linux-renesas-soc/patch/20210804161325.26996-2-biju.das.jz@bp.renesas.com/ > v3: > * New patch to fix the dtbs-check warnings > Ref:- https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20210804091940.23983-1-biju.das.jz@bp.renesas.com/ > --- > .../devicetree/bindings/mmc/renesas,sdhi.yaml | 60 ++++++++++++------- > 1 file changed, 37 insertions(+), 23 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml > index 677989bc5924..43584f4f4c7e 100644 > --- a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml > +++ b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml > @@ -9,9 +9,6 @@ title: Renesas SDHI SD/MMC controller > maintainers: > - Wolfram Sang > > -allOf: > - - $ref: "mmc-controller.yaml" > - > properties: > compatible: > oneOf: > @@ -104,14 +101,46 @@ properties: > pinctrl-1: > maxItems: 1 > > - pinctrl-names: > - minItems: 1 > - items: > - - const: default > - - const: state_uhs > + pinctrl-names: true > > max-frequency: true > > +allOf: > + - $ref: "mmc-controller.yaml" > + > + - if: > + properties: > + compatible: > + contains: > + const: renesas,sdhi-mmc-r8a77470 > + then: > + properties: > + pinctrl-names: > + items: > + - const: state_uhs > + else: > + properties: > + pinctrl-names: > + minItems: 1 > + items: > + - const: default > + - const: state_uhs > + > + - if: > + properties: > + compatible: > + contains: > + enum: > + - renesas,sdhi-r7s72100 > + - renesas,sdhi-r7s9210 > + then: > + required: > + - clock-names > + description: > + The internal card detection logic that exists in these controllers is > + sectioned off to be run by a separate second clock source to allow > + the main core clock to be turned off to save power. > + > required: > - compatible > - reg > @@ -119,21 +148,6 @@ required: > - clocks > - power-domains > > -if: > - properties: > - compatible: > - contains: > - enum: > - - renesas,sdhi-r7s72100 > - - renesas,sdhi-r7s9210 > -then: > - required: > - - clock-names > - description: > - The internal card detection logic that exists in these controllers is > - sectioned off to be run by a separate second clock source to allow > - the main core clock to be turned off to save power. > - > unevaluatedProperties: false > > examples: > -- > 2.17.1 >