From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ulf Hansson Subject: Re: [PATCH v3 1/2] dt-bindings: mmc: Add YAML schemas for the generic MMC options Date: Tue, 28 May 2019 21:32:31 +0200 Message-ID: References: <20190528172649.6mkdkscnu5d2rybi@flea> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190528172649.6mkdkscnu5d2rybi@flea> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Maxime Ripard Cc: Mark Rutland , DTML , Rob Herring , "linux-mmc@vger.kernel.org" , Chen-Yu Tsai , Rob Herring , Frank Rowand , Linux ARM List-Id: devicetree@vger.kernel.org On Tue, 28 May 2019 at 19:26, Maxime Ripard wrote: > > Hi Ulf, > > On Tue, May 28, 2019 at 10:40:16AM +0200, Ulf Hansson wrote: > > > +patternProperties: > > > + "^.*@[0-9]+$": > > > + properties: > > > + reg: > > > + items: > > > + - minimum: 0 > > > + maximum: 7 > > > + description: > > > + Must contain the SDIO function number of the function this > > > + subnode describes. A value of 0 denotes the memory SD > > > + function, values from 1 to 7 denote the SDIO functions. > > > + > > > + broken-hpi: > > > + $ref: /schemas/types.yaml#/definitions/flag > > > + description: > > > + Use this to indicate that the mmc-card has a broken hpi > > > + implementation, and that hpi should not be used. > > > + > > > + required: > > > + - reg > > > + > > > > [...] > > > > > -Use of Function subnodes > > > ------------------------- > > > - > > > -On embedded systems the cards connected to a host may need additional > > > -properties. These can be specified in subnodes to the host controller node. > > > -The subnodes are identified by the standard 'reg' property. > > > -Which information exactly can be specified depends on the bindings for the > > > -SDIO function driver for the subnode, as specified by the compatible string. > > > - > > > -Required host node properties when using function subnodes: > > > -- #address-cells: should be one. The cell is the slot id. > > > -- #size-cells: should be zero. > > > - > > > -Required function subnode properties: > > > -- reg: Must contain the SDIO function number of the function this subnode > > > - describes. A value of 0 denotes the memory SD function, values from > > > - 1 to 7 denote the SDIO functions. > > > - > > > -Optional function subnode properties: > > > -- compatible: name of SDIO function following generic names recommended practice > > > - > > > > I think most of the information of how we use sub(child) nodes > > disappeared in this conversion - or at least gets harder to > > understand. Could we perhaps keep some of this? > > Sure, what would you like to keep in particular? Most of it, so we can understand what can be described in sub-nodes. Additionally, we should also include what is stated in Documentation/devicetree/bindings/mmc/mmc-card.txt, as that also refers to how subnodes should be used, when it has the "mmc-card" compatible. Or maybe we should simply move all things related to subnodes into a separate .yaml? Kind regards Uffe From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, T_DKIMWL_WL_HIGH,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B7B5C04AB6 for ; Tue, 28 May 2019 19:33:17 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B08AC208C3 for ; Tue, 28 May 2019 19:33:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="cKuynCdR"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="dMMWYbAr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B08AC208C3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xxOlRD3w5jU5kXUa/zAwHF9Tzyhcw49mdBKNgj+OOAA=; b=cKuynCdRa+HweB 4OyPb+LlfL+B1uIf1HUi9BzdG/IJkZ0mh+IyI2O12Nt6G/mQGCVQUXS7NMpAtgoSFRySKotXc+puD IlUHzWgMxqRuAL5hyVmoZVjfa92k9WdFsWjcwVCvcGgEP/S3OB/VRxHfonClslwLiEq4IkdUHklnr zZr2cfMQgc+9Y37//B4vAReNOVHUxhWLNidTBWygP0v7qbxzo6UWwCEbSZhUKJYjynr+PL32AKOqZ iXWAnYlyi9Oyf+5AEleDaTRdPhQxH0v5QwACCbEpPVuFhWSVZD4K8xAjuUArDxdJ3ULShPL608awD vXijZz7899bmqiiM4svA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hVhqT-0006KX-9D; Tue, 28 May 2019 19:33:13 +0000 Received: from mail-vs1-xe43.google.com ([2607:f8b0:4864:20::e43]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hVhqP-0006Ju-TJ for linux-arm-kernel@lists.infradead.org; Tue, 28 May 2019 19:33:11 +0000 Received: by mail-vs1-xe43.google.com with SMTP id k187so1024892vsk.12 for ; Tue, 28 May 2019 12:33:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=a/4WAdDHD7o2J6jLaTa03Ods2jMwUYJoiUyhNBxjWQI=; b=dMMWYbArcJceM9L9LmUxOvLkkrX2JOFBhsd3cXHlbV62EkEx3ql6/xwnm6N5ua68wq lfkom4j6oFv/YNmvQUm8B1OQGZ2zulvaZOZ4Vb/2f9dLCgPmMB9Ugey3bU87fOc/WHEw p7Sw2zAKvnev37PmWp+aAzuUJUkQppWVldppFq2B2zoUI2yWw6WtGdGKVjULC+Dn/H6e d3sLokS7BkvYEDy3Hes7bzROVLsETM8bkQAKS2rty6owPH9VPSYb57J7qWuBL1cc+AVg V9jyGJ9CiMd+OVDQN8n0mjfPQP1ssYNAAjmKXpcP/+z1XJBMKFdd+vvMGuzqNeTQcjMe XoSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=a/4WAdDHD7o2J6jLaTa03Ods2jMwUYJoiUyhNBxjWQI=; b=nDBLjuf1VR560U9TGOc0J4BjcaNncZGaLF9uyBBgb0X6Tmw15VlepugKqnK+HsZnwN oXe0r8AsQ/IxdgeYcGzazdT0IC18EHvCoBcPHPksU8kTGi+Wn8lNFTh5zG4qVyA4+PZD yOgqHSNK/xYwNs+EOV0PJ0Zs29xaoD8uD3nwUCQj29n5uaYlp6Kyfgg4opXmUoTy5Pzy hc3u7fduXh1B2Brr5rnTtykvLvpsDZYgP4DsNGs3JTYyMkIgCRxcohW2uZqg2pF661Tn SXdpnGaNbuiaarTp+DEeQgyPw+2D6ugvwiNvCjpYx5tkd4X8wD2jP9bGSxJXMbpLwbTw d9aA== X-Gm-Message-State: APjAAAX8lvCda/bEhmhdfPsN0+F0BRjPEueYCaGDyFg3t5OPWGWM86yg 9Py+6ryVmRwt6NGpC2rFuBSzUbAXbPZMEFt1Z31ZCA== X-Google-Smtp-Source: APXvYqwd813q3SqUy11sYCOolIowQZSdilqwamuHYez09q5jBp5bAunxVlKM4u8MuI3TDxKOUo/xgfSsPHni9ARExfo= X-Received: by 2002:a67:f485:: with SMTP id o5mr2970694vsn.165.1559071987467; Tue, 28 May 2019 12:33:07 -0700 (PDT) MIME-Version: 1.0 References: <20190528172649.6mkdkscnu5d2rybi@flea> In-Reply-To: <20190528172649.6mkdkscnu5d2rybi@flea> From: Ulf Hansson Date: Tue, 28 May 2019 21:32:31 +0200 Message-ID: Subject: Re: [PATCH v3 1/2] dt-bindings: mmc: Add YAML schemas for the generic MMC options To: Maxime Ripard X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190528_123310_015707_BE627C84 X-CRM114-Status: GOOD ( 20.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , DTML , Rob Herring , "linux-mmc@vger.kernel.org" , Chen-Yu Tsai , Rob Herring , Frank Rowand , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 28 May 2019 at 19:26, Maxime Ripard wrote: > > Hi Ulf, > > On Tue, May 28, 2019 at 10:40:16AM +0200, Ulf Hansson wrote: > > > +patternProperties: > > > + "^.*@[0-9]+$": > > > + properties: > > > + reg: > > > + items: > > > + - minimum: 0 > > > + maximum: 7 > > > + description: > > > + Must contain the SDIO function number of the function this > > > + subnode describes. A value of 0 denotes the memory SD > > > + function, values from 1 to 7 denote the SDIO functions. > > > + > > > + broken-hpi: > > > + $ref: /schemas/types.yaml#/definitions/flag > > > + description: > > > + Use this to indicate that the mmc-card has a broken hpi > > > + implementation, and that hpi should not be used. > > > + > > > + required: > > > + - reg > > > + > > > > [...] > > > > > -Use of Function subnodes > > > ------------------------- > > > - > > > -On embedded systems the cards connected to a host may need additional > > > -properties. These can be specified in subnodes to the host controller node. > > > -The subnodes are identified by the standard 'reg' property. > > > -Which information exactly can be specified depends on the bindings for the > > > -SDIO function driver for the subnode, as specified by the compatible string. > > > - > > > -Required host node properties when using function subnodes: > > > -- #address-cells: should be one. The cell is the slot id. > > > -- #size-cells: should be zero. > > > - > > > -Required function subnode properties: > > > -- reg: Must contain the SDIO function number of the function this subnode > > > - describes. A value of 0 denotes the memory SD function, values from > > > - 1 to 7 denote the SDIO functions. > > > - > > > -Optional function subnode properties: > > > -- compatible: name of SDIO function following generic names recommended practice > > > - > > > > I think most of the information of how we use sub(child) nodes > > disappeared in this conversion - or at least gets harder to > > understand. Could we perhaps keep some of this? > > Sure, what would you like to keep in particular? Most of it, so we can understand what can be described in sub-nodes. Additionally, we should also include what is stated in Documentation/devicetree/bindings/mmc/mmc-card.txt, as that also refers to how subnodes should be used, when it has the "mmc-card" compatible. Or maybe we should simply move all things related to subnodes into a separate .yaml? Kind regards Uffe _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel