From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69A23C64E7C for ; Wed, 2 Dec 2020 12:42:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 00C43221FE for ; Wed, 2 Dec 2020 12:42:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727495AbgLBMmg (ORCPT ); Wed, 2 Dec 2020 07:42:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54302 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726736AbgLBMmg (ORCPT ); Wed, 2 Dec 2020 07:42:36 -0500 Received: from mail-vs1-xe41.google.com (mail-vs1-xe41.google.com [IPv6:2607:f8b0:4864:20::e41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 17C58C0613CF for ; Wed, 2 Dec 2020 04:41:50 -0800 (PST) Received: by mail-vs1-xe41.google.com with SMTP id v8so840072vso.2 for ; Wed, 02 Dec 2020 04:41:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=kXMUAU2XPmm9w5lTnyXOI4+QFALzMfNDFQIh0c94WPA=; b=okJw6qJdJQQLgwoGkITAZ2RzTakzKviiWbNlSxfhQaCslP04glk6JlxDe01Dn+WUsf UNfsOjMSh/6EV0scoKGD1ucdfaZ8r6tv+2emxCtiYWzLzairDs/DyB4gax3DB0R//jkg qFCFmFC0otE1FKTXcVmVNVFWghen/i3fv0L4IbjumIHptCgljZrKHIeCtjSINM+xGAfS mnMzPJxQmi4N992OZfE6XrjOWPAgkhj2IjnXrF4EwQBF4jlljmDCPGznbJVsM+l40v2s SDihjgH1x0GN0MeIT/vJ01edB5XrI0uCggSkyv7teg7Und3usureLXU6BBncOR8f5lP5 rUpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kXMUAU2XPmm9w5lTnyXOI4+QFALzMfNDFQIh0c94WPA=; b=rZ/tmzfBWR319Rp8OZLH3JTxBikOFx83EfsjQg7DpWTPmSK8FXDbz1HhDJR24+Krhw PkIafPlSokJY+H0RWOh5SugWcM07RgxJ1E3fbJGFZ69dWAqzxm4XUYEpEctcOU5ATznx JgDsmbZJ5x2jYDcfkXVBFEpTQbmudoxKAgaPpodZEujhMQSMV+q5XE5o5iIsD643bpe2 rg1s+JJGDHZahXZE3Clv92wv0BRQMDdzXP5wQFC+a3ONgINBOA0ZGRUgyGjdPINLRtBg 4UVgybbsJtdaUJpORYlH62m/avKVmGGD2BGuBD1v8YStP/3JfYa9RiL0xspZ0VcHuY7q mtXw== X-Gm-Message-State: AOAM531r/nOqu6wqoeeO3mc7SCOvGsOavUyC8571uxFjDYN/uTzcgwmo ulu1WxG+VSzrsK0B4xRTEgMqk0/VcNGft5o6YSprJQ== X-Google-Smtp-Source: ABdhPJyjlRZBwaPxY2L6aa5oVJBa8flUGbh3ZROcX5EjBNbuv11Il4IqU0IGC14Qb2rc5oj9JK1g/jLzRg66x8FuDtI= X-Received: by 2002:a67:ce8e:: with SMTP id c14mr1115811vse.42.1606912909320; Wed, 02 Dec 2020 04:41:49 -0800 (PST) MIME-Version: 1.0 References: <20201202150205.20150-1-muhammad.husaini.zulkifli@intel.com> <20201202122520.GD4077@smile.fi.intel.com> In-Reply-To: <20201202122520.GD4077@smile.fi.intel.com> From: Ulf Hansson Date: Wed, 2 Dec 2020 13:41:12 +0100 Message-ID: Subject: Re: [PATCH v6 0/4] mmc: sdhci-of-arasan: Enable UHS-1 support for Keem Bay SOC To: "Shevchenko, Andriy" , Linus Walleij Cc: "Zulkifli, Muhammad Husaini" , Adrian Hunter , Michal Simek , "linux-mmc@vger.kernel.org" , Linux ARM , Linux Kernel Mailing List , "Raja Subramanian, Lakshmi Bai" , Wan Ahmad Zainie , mgross@linux.intel.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2 Dec 2020 at 13:24, Shevchenko, Andriy wrote: > > On Wed, Dec 02, 2020 at 11:53:42AM +0100, Ulf Hansson wrote: > > On Wed, 2 Dec 2020 at 08:02, wrote: > > ... > > > > Kindly help to review this patch set. > > > > This version looks a lot better to me, but I am still requesting you > > to model the pinctrl correctly. I don't see a reason not to, but I may > > have overlooked some things. > > I'm wondering why we need to mock up a pin control from something which has no > pin control interface. It's rather communication with firmware that does pin > control under the hood, but it also may be different hardware in the other / > future generations. Would you accept mocking up the same calls over the kernel > as pin control, as something else? Well, my point is that modeling this a pinctrl would keep the mmc driver portable. Additionally, it's very common to manage pinctrls in mmc drivers, so it's not like this is an entirely new thing that I propose. If/when it turns out that there is a new HW having a different pinctrl interface, it would just mean that we need a new pinctrl driver, but can leave the mmc driver as is. > > > Would you mind to re-submit to include the gpio/pinctlr list and the > > maintainers, to get their opinion. > > And I will send immediately the same comment which I believe Linus W. supports. > But who knows... > > Cc'ed to Linus as I mentioned him. Thanks, let's see what Linus thinks then. Kind regards Uffe From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F082C64E8A for ; Wed, 2 Dec 2020 12:43:04 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 83C96221FE for ; Wed, 2 Dec 2020 12:43:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 83C96221FE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=xuPgEK5++vDBPn5KradvQZIZzIL5YW+UmCX41t+ZjlY=; b=kf7AYuTp18siVPCskhJ2EWw7G i+0iQ3j0PtQxRAw9qX0F42P4aeB5YobBjH4vCpJlg6CyfNA3RCXA9j67PQYOa8j3/S2jxO2pIMPlC aYX8NwJxYd89OLk4jHo7mzCbqdcdG47WJ1y45AUitUO8hWrUjUC9fKCVqow+40T3tYGv4AgQ6ClKf BUBgivJcu3YonvHWm7pMBp2557xMjHCA6giu2UyKx4Dy8TcUFzbVs6uG4wwxc8pViGfmECSJ7wlmZ OjXg1PltyHk0j4oNncCWhVzjZRs5Aw/thgZ3+0eXL+SxkPd/0FvPDJZYSU7uXECKqYp1s7yyMON/F NvKUql8BQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kkRSF-0000YY-E8; Wed, 02 Dec 2020 12:41:55 +0000 Received: from mail-vs1-xe44.google.com ([2607:f8b0:4864:20::e44]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kkRSB-0000XN-Cu for linux-arm-kernel@lists.infradead.org; Wed, 02 Dec 2020 12:41:54 +0000 Received: by mail-vs1-xe44.google.com with SMTP id u7so817645vsq.11 for ; Wed, 02 Dec 2020 04:41:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=kXMUAU2XPmm9w5lTnyXOI4+QFALzMfNDFQIh0c94WPA=; b=okJw6qJdJQQLgwoGkITAZ2RzTakzKviiWbNlSxfhQaCslP04glk6JlxDe01Dn+WUsf UNfsOjMSh/6EV0scoKGD1ucdfaZ8r6tv+2emxCtiYWzLzairDs/DyB4gax3DB0R//jkg qFCFmFC0otE1FKTXcVmVNVFWghen/i3fv0L4IbjumIHptCgljZrKHIeCtjSINM+xGAfS mnMzPJxQmi4N992OZfE6XrjOWPAgkhj2IjnXrF4EwQBF4jlljmDCPGznbJVsM+l40v2s SDihjgH1x0GN0MeIT/vJ01edB5XrI0uCggSkyv7teg7Und3usureLXU6BBncOR8f5lP5 rUpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kXMUAU2XPmm9w5lTnyXOI4+QFALzMfNDFQIh0c94WPA=; b=pbj0HhrscX1uvQta24+GbcCJrl/80BAcA1tJ+t0ln4oU9Y/EyGybkSX5gT7VBaDPjH yvXwJoCxuzdtmdSaQJBs0M2hTAIQsatHa5dct0SuziuWF9HmtKSrQPNKYc+zL/s6U8B1 zmZ+qE8/JLEsCENTTSEaV818A4gJs2kxPmUduDPmYKWEd1xs51to/JoL0ztX/Jt6ol5p /NqUk18phSogpDFBlHadSwuvqYrvdk1JvzhL/igCSJWdneGs0nr1NXpal3M1BXZGAS0b uTeOGc6uCfJWSwHIeQfeTgyjK/wc2SUCnirUMrAWZJIaj1ZNCBds2SayfNCRzSQpueup tkXg== X-Gm-Message-State: AOAM532gCnG3lm64+xBj9GygaDEwrDzjlNmqsHANGTxa6zpx3mZ4KHxh HBil7S3QI1QUpIE8l6Cljbz0rJDQxKwkEDCMNnzIKQ== X-Google-Smtp-Source: ABdhPJyjlRZBwaPxY2L6aa5oVJBa8flUGbh3ZROcX5EjBNbuv11Il4IqU0IGC14Qb2rc5oj9JK1g/jLzRg66x8FuDtI= X-Received: by 2002:a67:ce8e:: with SMTP id c14mr1115811vse.42.1606912909320; Wed, 02 Dec 2020 04:41:49 -0800 (PST) MIME-Version: 1.0 References: <20201202150205.20150-1-muhammad.husaini.zulkifli@intel.com> <20201202122520.GD4077@smile.fi.intel.com> In-Reply-To: <20201202122520.GD4077@smile.fi.intel.com> From: Ulf Hansson Date: Wed, 2 Dec 2020 13:41:12 +0100 Message-ID: Subject: Re: [PATCH v6 0/4] mmc: sdhci-of-arasan: Enable UHS-1 support for Keem Bay SOC To: "Shevchenko, Andriy" , Linus Walleij X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201202_074151_801353_693BF757 X-CRM114-Status: GOOD ( 21.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mgross@linux.intel.com, "Raja Subramanian, Lakshmi Bai" , "linux-mmc@vger.kernel.org" , Linux Kernel Mailing List , Adrian Hunter , Wan Ahmad Zainie , "Zulkifli, Muhammad Husaini" , Michal Simek , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 2 Dec 2020 at 13:24, Shevchenko, Andriy wrote: > > On Wed, Dec 02, 2020 at 11:53:42AM +0100, Ulf Hansson wrote: > > On Wed, 2 Dec 2020 at 08:02, wrote: > > ... > > > > Kindly help to review this patch set. > > > > This version looks a lot better to me, but I am still requesting you > > to model the pinctrl correctly. I don't see a reason not to, but I may > > have overlooked some things. > > I'm wondering why we need to mock up a pin control from something which has no > pin control interface. It's rather communication with firmware that does pin > control under the hood, but it also may be different hardware in the other / > future generations. Would you accept mocking up the same calls over the kernel > as pin control, as something else? Well, my point is that modeling this a pinctrl would keep the mmc driver portable. Additionally, it's very common to manage pinctrls in mmc drivers, so it's not like this is an entirely new thing that I propose. If/when it turns out that there is a new HW having a different pinctrl interface, it would just mean that we need a new pinctrl driver, but can leave the mmc driver as is. > > > Would you mind to re-submit to include the gpio/pinctlr list and the > > maintainers, to get their opinion. > > And I will send immediately the same comment which I believe Linus W. supports. > But who knows... > > Cc'ed to Linus as I mentioned him. Thanks, let's see what Linus thinks then. Kind regards Uffe _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel