From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ulf Hansson Subject: Re: [PATCH v3 00/14] Add MMCI support for STM32F SoCs family Date: Thu, 18 Jan 2018 18:16:11 +0100 Message-ID: References: <1516286070-24927-1-git-send-email-patrice.chotard@st.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <1516286070-24927-1-git-send-email-patrice.chotard-qxv4g6HH51o@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Patrice CHOTARD Cc: Russell King , Michael Turquette , Stephen Boyd , Linus Walleij , Rob Herring , Mark Rutland , Alexandre Torgue , "linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Linux Kernel Mailing List , linux-clk , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-gpio@vger.kernel.org On 18 January 2018 at 15:34, wrote: > From: Patrice Chotard > > This series reworks patches submitted one year ago by Andrea Merello [1] > but without succeed to merged it. > > STM32F4 and STM32F7 SoCs families embeds a variant of the ARM PrimeCell > PL18x SD host controller, for which the mmci driver exists. > This series adds support for these SoCs to the mmci driver. > > As other variants, this one need some specific quirks, that this > series address. > > This series has been tested on following boards : > _ stm32f429-eval > _ stm32f469-disco > _ stm32f746-eval > _ stm32f769-disco > > DT update for stm32f7 pinctrl, stm32f746-eval and stm32f769-disco boards > will be sent later to avoid conflict with pending stm32f7 series [1] which > is not yet merged on kernel mainline. > > [1] https://www.spinics.net/lists/linux-mmc/msg41616.html > [2] https://patchwork.kernel.org/patch/10104447/ > > v3: _ patch 3: use variant->opendrain instead of host->variant->opendrain > _ patch 4: exit from probe() if no pinctrl dt node are found > _ previous patch 15: removed as already applied in pinctrl tree > > v2: _ add Revievied-by, Acked-by in some patches > _ replace bool by u32 for start_err and opendrain fields of struct variant_data > _ split previous patch 3 in two parts, first patch clean the open drain bit code > and second part add pinctrl pins management when no open drain bit is available. > _ replace "pl180" by "PL180" in patch "mmc: mmci: Add STM32 variant" > > Andrea Merello (2): > ARM: dts: stm32: Add pin map for SDIO controller on stm32f4 > ARM: dts: stm32: Enable SDIO controller on stm32f469 disco board > > Patrice Chotard (12): > mmc: mmci: Don't pretend all variants to have MMCIMASK1 register > mmc: mmci: Don't pretend all variants to have MCI_STARBITERR flag > mmc: mmci: Don't pretend all variants to have OPENDRAIN bit > mmc: mmci: Add support for setting pad type via pinctrl > mmc: mmci: Add STM32 variant > ARM: dts: stm32: Add SDIO controller for stm32f746 > ARM: dts: stm32: Add SDIO controller for stm32f429 > ARM: dts: stm32: Enable SDIO controller on stm32429i-eval board > ARM: stm32: Add AMBA support for STM32F4 and STM32F7 SoCs > ARM: configs: stm32: Enable MMC_ARMMMCI support > ARM: configs: stm32: Enable EXT3_FS support > clk: stm32: Add clk entry for SDMMC2 on stm32F769 > > arch/arm/boot/dts/stm32429i-eval.dts | 19 +++++ > arch/arm/boot/dts/stm32f4-pinctrl.dtsi | 31 +++++++++ > arch/arm/boot/dts/stm32f429.dtsi | 11 +++ > arch/arm/boot/dts/stm32f469-disco.dts | 19 +++++ > arch/arm/boot/dts/stm32f746.dtsi | 22 ++++++ > arch/arm/configs/stm32_defconfig | 3 + > arch/arm/mach-stm32/Kconfig | 3 + > drivers/clk/clk-stm32f4.c | 3 +- > drivers/mmc/host/mmci.c | 124 ++++++++++++++++++++++++++++----- > drivers/mmc/host/mmci.h | 6 ++ > 10 files changed, 224 insertions(+), 17 deletions(-) > > -- > 1.9.1 > Thanks, applied patch1 to patch5 for next! Kind regards Uffe -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755425AbeARRQP (ORCPT ); Thu, 18 Jan 2018 12:16:15 -0500 Received: from mail-io0-f193.google.com ([209.85.223.193]:43851 "EHLO mail-io0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754935AbeARRQM (ORCPT ); Thu, 18 Jan 2018 12:16:12 -0500 X-Google-Smtp-Source: ACJfBouDWCpffFNLvO7oKj2sXBjFDYTOK3EEuwJfJUK8EMatsy6DTZ2Sh7tXGLs2fkKzCuijNGBlQnX+4wEuzJC+UN8= MIME-Version: 1.0 In-Reply-To: <1516286070-24927-1-git-send-email-patrice.chotard@st.com> References: <1516286070-24927-1-git-send-email-patrice.chotard@st.com> From: Ulf Hansson Date: Thu, 18 Jan 2018 18:16:11 +0100 Message-ID: Subject: Re: [PATCH v3 00/14] Add MMCI support for STM32F SoCs family To: Patrice CHOTARD Cc: Russell King , Michael Turquette , Stephen Boyd , Linus Walleij , Rob Herring , Mark Rutland , Alexandre Torgue , "linux-mmc@vger.kernel.org" , Linux Kernel Mailing List , linux-clk , linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18 January 2018 at 15:34, wrote: > From: Patrice Chotard > > This series reworks patches submitted one year ago by Andrea Merello [1] > but without succeed to merged it. > > STM32F4 and STM32F7 SoCs families embeds a variant of the ARM PrimeCell > PL18x SD host controller, for which the mmci driver exists. > This series adds support for these SoCs to the mmci driver. > > As other variants, this one need some specific quirks, that this > series address. > > This series has been tested on following boards : > _ stm32f429-eval > _ stm32f469-disco > _ stm32f746-eval > _ stm32f769-disco > > DT update for stm32f7 pinctrl, stm32f746-eval and stm32f769-disco boards > will be sent later to avoid conflict with pending stm32f7 series [1] which > is not yet merged on kernel mainline. > > [1] https://www.spinics.net/lists/linux-mmc/msg41616.html > [2] https://patchwork.kernel.org/patch/10104447/ > > v3: _ patch 3: use variant->opendrain instead of host->variant->opendrain > _ patch 4: exit from probe() if no pinctrl dt node are found > _ previous patch 15: removed as already applied in pinctrl tree > > v2: _ add Revievied-by, Acked-by in some patches > _ replace bool by u32 for start_err and opendrain fields of struct variant_data > _ split previous patch 3 in two parts, first patch clean the open drain bit code > and second part add pinctrl pins management when no open drain bit is available. > _ replace "pl180" by "PL180" in patch "mmc: mmci: Add STM32 variant" > > Andrea Merello (2): > ARM: dts: stm32: Add pin map for SDIO controller on stm32f4 > ARM: dts: stm32: Enable SDIO controller on stm32f469 disco board > > Patrice Chotard (12): > mmc: mmci: Don't pretend all variants to have MMCIMASK1 register > mmc: mmci: Don't pretend all variants to have MCI_STARBITERR flag > mmc: mmci: Don't pretend all variants to have OPENDRAIN bit > mmc: mmci: Add support for setting pad type via pinctrl > mmc: mmci: Add STM32 variant > ARM: dts: stm32: Add SDIO controller for stm32f746 > ARM: dts: stm32: Add SDIO controller for stm32f429 > ARM: dts: stm32: Enable SDIO controller on stm32429i-eval board > ARM: stm32: Add AMBA support for STM32F4 and STM32F7 SoCs > ARM: configs: stm32: Enable MMC_ARMMMCI support > ARM: configs: stm32: Enable EXT3_FS support > clk: stm32: Add clk entry for SDMMC2 on stm32F769 > > arch/arm/boot/dts/stm32429i-eval.dts | 19 +++++ > arch/arm/boot/dts/stm32f4-pinctrl.dtsi | 31 +++++++++ > arch/arm/boot/dts/stm32f429.dtsi | 11 +++ > arch/arm/boot/dts/stm32f469-disco.dts | 19 +++++ > arch/arm/boot/dts/stm32f746.dtsi | 22 ++++++ > arch/arm/configs/stm32_defconfig | 3 + > arch/arm/mach-stm32/Kconfig | 3 + > drivers/clk/clk-stm32f4.c | 3 +- > drivers/mmc/host/mmci.c | 124 ++++++++++++++++++++++++++++----- > drivers/mmc/host/mmci.h | 6 ++ > 10 files changed, 224 insertions(+), 17 deletions(-) > > -- > 1.9.1 > Thanks, applied patch1 to patch5 for next! Kind regards Uffe From mboxrd@z Thu Jan 1 00:00:00 1970 From: ulf.hansson@linaro.org (Ulf Hansson) Date: Thu, 18 Jan 2018 18:16:11 +0100 Subject: [PATCH v3 00/14] Add MMCI support for STM32F SoCs family In-Reply-To: <1516286070-24927-1-git-send-email-patrice.chotard@st.com> References: <1516286070-24927-1-git-send-email-patrice.chotard@st.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 18 January 2018 at 15:34, wrote: > From: Patrice Chotard > > This series reworks patches submitted one year ago by Andrea Merello [1] > but without succeed to merged it. > > STM32F4 and STM32F7 SoCs families embeds a variant of the ARM PrimeCell > PL18x SD host controller, for which the mmci driver exists. > This series adds support for these SoCs to the mmci driver. > > As other variants, this one need some specific quirks, that this > series address. > > This series has been tested on following boards : > _ stm32f429-eval > _ stm32f469-disco > _ stm32f746-eval > _ stm32f769-disco > > DT update for stm32f7 pinctrl, stm32f746-eval and stm32f769-disco boards > will be sent later to avoid conflict with pending stm32f7 series [1] which > is not yet merged on kernel mainline. > > [1] https://www.spinics.net/lists/linux-mmc/msg41616.html > [2] https://patchwork.kernel.org/patch/10104447/ > > v3: _ patch 3: use variant->opendrain instead of host->variant->opendrain > _ patch 4: exit from probe() if no pinctrl dt node are found > _ previous patch 15: removed as already applied in pinctrl tree > > v2: _ add Revievied-by, Acked-by in some patches > _ replace bool by u32 for start_err and opendrain fields of struct variant_data > _ split previous patch 3 in two parts, first patch clean the open drain bit code > and second part add pinctrl pins management when no open drain bit is available. > _ replace "pl180" by "PL180" in patch "mmc: mmci: Add STM32 variant" > > Andrea Merello (2): > ARM: dts: stm32: Add pin map for SDIO controller on stm32f4 > ARM: dts: stm32: Enable SDIO controller on stm32f469 disco board > > Patrice Chotard (12): > mmc: mmci: Don't pretend all variants to have MMCIMASK1 register > mmc: mmci: Don't pretend all variants to have MCI_STARBITERR flag > mmc: mmci: Don't pretend all variants to have OPENDRAIN bit > mmc: mmci: Add support for setting pad type via pinctrl > mmc: mmci: Add STM32 variant > ARM: dts: stm32: Add SDIO controller for stm32f746 > ARM: dts: stm32: Add SDIO controller for stm32f429 > ARM: dts: stm32: Enable SDIO controller on stm32429i-eval board > ARM: stm32: Add AMBA support for STM32F4 and STM32F7 SoCs > ARM: configs: stm32: Enable MMC_ARMMMCI support > ARM: configs: stm32: Enable EXT3_FS support > clk: stm32: Add clk entry for SDMMC2 on stm32F769 > > arch/arm/boot/dts/stm32429i-eval.dts | 19 +++++ > arch/arm/boot/dts/stm32f4-pinctrl.dtsi | 31 +++++++++ > arch/arm/boot/dts/stm32f429.dtsi | 11 +++ > arch/arm/boot/dts/stm32f469-disco.dts | 19 +++++ > arch/arm/boot/dts/stm32f746.dtsi | 22 ++++++ > arch/arm/configs/stm32_defconfig | 3 + > arch/arm/mach-stm32/Kconfig | 3 + > drivers/clk/clk-stm32f4.c | 3 +- > drivers/mmc/host/mmci.c | 124 ++++++++++++++++++++++++++++----- > drivers/mmc/host/mmci.h | 6 ++ > 10 files changed, 224 insertions(+), 17 deletions(-) > > -- > 1.9.1 > Thanks, applied patch1 to patch5 for next! Kind regards Uffe