From: Ulf Hansson <ulf.hansson@linaro.org>
To: Jaehoon Chung <jh80.chung@samsung.com>
Cc: linux-mmc <linux-mmc@vger.kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Linus Walleij <linus.walleij@linaro.org>,
Chaotian Jing <chaotian.jing@mediatek.com>
Subject: Re: [PATCH 0/4] mmc: core: Clean-up and improve polling code in __mmc_switch()
Date: Fri, 21 Oct 2016 10:22:43 +0200 [thread overview]
Message-ID: <CAPDyKFreRO0660P3JCSxB+N_bPVJnSMj-ce_dr=bJaB5wUyDiA@mail.gmail.com> (raw)
In-Reply-To: <1ba11108-0804-950d-5410-646b53c798e8@samsung.com>
On 21 October 2016 at 09:49, Jaehoon Chung <jh80.chung@samsung.com> wrote:
> On 10/20/2016 05:19 PM, Ulf Hansson wrote:
>> The code in __mmc_switch() is rather messy and hard to follow/understand. This
>> series starts out by cleaning-up and re-factoring that code. In the final patch
>> I intend to improve the behaviour regarding the polling method, which is being
>> used to know when the card stops signal busy.
>
> Looks good to me.
>
> Acked-by: Jaehoon Chung <jh80.chung@samsung.com>
> Tested-by: Jaehoon Chung <jh80.chung@samsung.com>
>
> (Tested on Exynos Series)
>
> Best Regards,
> Jaehoon Chung
Thanks Jaehoon, I have queued them up for my next branch!
Kind regards
Uffe
>
>>
>> Ulf Hansson (4):
>> mmc: core: Make mmc_switch_status() available for mmc core
>> mmc: core: Clarify code which deals with polling in __mmc_switch()
>> mmc: core: Factor out code related to polling in __mmc_switch()
>> mmc: core: Don't use ->card_busy() and CMD13 in combination when
>> polling
>>
>> drivers/mmc/core/mmc.c | 13 -----
>> drivers/mmc/core/mmc_ops.c | 138 +++++++++++++++++++++++++--------------------
>> drivers/mmc/core/mmc_ops.h | 2 +-
>> 3 files changed, 79 insertions(+), 74 deletions(-)
>>
>
prev parent reply other threads:[~2016-10-21 8:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20161020082027epcas1p47e0913622727117286f7ad026259eb2b@epcas1p4.samsung.com>
2016-10-20 8:19 ` [PATCH 0/4] mmc: core: Clean-up and improve polling code in __mmc_switch() Ulf Hansson
2016-10-20 8:19 ` [PATCH 1/4] mmc: core: Make mmc_switch_status() available for mmc core Ulf Hansson
2016-10-20 8:19 ` [PATCH 2/4] mmc: core: Clarify code which deals with polling in __mmc_switch() Ulf Hansson
2016-10-20 8:19 ` [PATCH 3/4] mmc: core: Factor out code related to " Ulf Hansson
2016-10-20 8:19 ` [PATCH 4/4] mmc: core: Don't use ->card_busy() and CMD13 in combination when polling Ulf Hansson
2016-10-21 9:19 ` Adrian Hunter
2016-10-25 8:45 ` Ulf Hansson
2016-10-25 10:58 ` Adrian Hunter
2016-10-24 7:49 ` Linus Walleij
2016-10-25 8:44 ` Ulf Hansson
2016-10-21 7:49 ` [PATCH 0/4] mmc: core: Clean-up and improve polling code in __mmc_switch() Jaehoon Chung
2016-10-21 8:22 ` Ulf Hansson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPDyKFreRO0660P3JCSxB+N_bPVJnSMj-ce_dr=bJaB5wUyDiA@mail.gmail.com' \
--to=ulf.hansson@linaro.org \
--cc=adrian.hunter@intel.com \
--cc=chaotian.jing@mediatek.com \
--cc=jh80.chung@samsung.com \
--cc=linus.walleij@linaro.org \
--cc=linux-mmc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.