From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5A77C433EF for ; Tue, 26 Apr 2022 13:54:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351274AbiDZN5S (ORCPT ); Tue, 26 Apr 2022 09:57:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44284 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1351228AbiDZN4y (ORCPT ); Tue, 26 Apr 2022 09:56:54 -0400 Received: from mail-yb1-xb2c.google.com (mail-yb1-xb2c.google.com [IPv6:2607:f8b0:4864:20::b2c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B4A4C15CF61 for ; Tue, 26 Apr 2022 06:53:46 -0700 (PDT) Received: by mail-yb1-xb2c.google.com with SMTP id y76so3819213ybe.1 for ; Tue, 26 Apr 2022 06:53:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ckCZvmbeyyn635mnaKqXxsF4H+ghoyHwVYsC+7BA0B0=; b=igwGqJ1N3E7ODSLycDSaVr0WbIXpPlLVINt+CdifwDAJ4gIawXS0nViMwM0ZwMz3cM Y4fR5DEtmjMEWumRDWtc4A2/YhCv7x7gKR5KpZZeUJycaCRjTGf9T1tDKw3HDHO92/Cq WypqODghI7Sd8bMnc4Jr9OPbxjmKS+4p/vl2XRKZ7E/Xt51ZoyMaNx1ZCNVkqnPdYoIF m5umgOdDFSMrF1FGHf8mhUZl+LrEInUPltAY8fuNVAAt5GTePYWc5uYbtvPG7igxz2SU by93u6+dbEw46318P4HWU5ZgTv2R08XF+cESh81A43oG2yFIlMBgKK0J52dOiASLqyeC tGjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ckCZvmbeyyn635mnaKqXxsF4H+ghoyHwVYsC+7BA0B0=; b=1xFS+MLTCM6YeErmA/LCgbbGagzJ85Lfv1yb9OVCqr3t8CPZUA98p5hWME6dB3Z9kV 28TGzmHItsN5KEDhnYx33pufG7hWl7kYMvF7JWP0bhBTf/CXKVdWcLQiJydoefRc571N Y31hVCriIVrLbm3Y1H39s/ubp+jw9i/dDcOBhschhH78xVfLUkCko13sc1T8xwiGtMUB otf0aItHzwWwbLzQmK+h3gYET7h60eYjN4K3rOC5PAWLOTZeCXYO9Plt8xkad1IOuNun no/Dj4xQ+Hq42vAd6RGjOVG+AI3wDyA39GzT8deQff4QTSRvie2JMIrPKHOFJ1JyzYNR GehA== X-Gm-Message-State: AOAM531RV3RHRGKFIgLsXLnqp1oYEoQWTIYfQSE4Fm0xnHloPH1fYSrs 3aPp20mV7pZvYRxKXLPtD2BFx3gLxzGTwBNBiZWA1g== X-Google-Smtp-Source: ABdhPJwF18W/ckSAQP+Lb7KRodHA2ZrpGoAfo3MnAwZd2GoH5aVP8IC0RDmP+BEupKkL+maFSkUIUbxWV/ny/0vfhno= X-Received: by 2002:a25:77c1:0:b0:648:3fb0:d5cf with SMTP id s184-20020a2577c1000000b006483fb0d5cfmr13072913ybc.511.1650981225960; Tue, 26 Apr 2022 06:53:45 -0700 (PDT) MIME-Version: 1.0 References: <20220424090422.97070-1-wanjiabing@vivo.com> In-Reply-To: <20220424090422.97070-1-wanjiabing@vivo.com> From: Ulf Hansson Date: Tue, 26 Apr 2022 15:53:09 +0200 Message-ID: Subject: Re: [PATCH] mmc: atmel-mci: simplify if-if to if-else To: Wan Jiabing Cc: Ludovic Desroches , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kael_w@yeah.net Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 24 Apr 2022 at 11:04, Wan Jiabing wrote: > > Use if and else instead of if(A) and if (!A). > > Signed-off-by: Wan Jiabing > --- > drivers/mmc/host/atmel-mci.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/mmc/host/atmel-mci.c b/drivers/mmc/host/atmel-mci.c > index 807177c953f3..98893ccad4bd 100644 > --- a/drivers/mmc/host/atmel-mci.c > +++ b/drivers/mmc/host/atmel-mci.c > @@ -1125,8 +1125,7 @@ atmci_prepare_data_dma(struct atmel_mci *host, struct mmc_data *data) > chan = host->dma.chan; > if (chan) > host->data_chan = chan; > - > - if (!chan) > + else > return -ENODEV; To make a slightly better improvement of the code, I suggest we add an early bail out point in the atmci_prepare_data_dma() function. Like below: if (!host->dma.chan) return -ENODEV; [...] Kind regards Uffe From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D365DC433EF for ; Tue, 26 Apr 2022 14:02:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xApJ1u+XJcmcJAKlLEcgam6Rqb6WKcrpO4LnhLUiDLM=; b=j5TYIy5EQfy+la xC0yzUvQ8eXBWPAP7XCtHKfq9mGc3tDCigedftw07oH4rqDq6QqA31sVD8GXTtPtqzUk2+uRCmjMw M7wOwXxQw+G22GX76Wj3qxPF8Nxi74xGa9C2A9rn4AoAtDy+hqYmrGfvgYnmc0CyF7G5YHlGJ/pSF 80jl6mlumPOjrOcEErX/pawsj9IUZuJmmZR8rEQZjhHTTw/TKsk09sAC6hEsv+lMQ0KBHCP9YMuQN bCjgVEramcWLAjaGoM3NauuaG86v/6gviYzYl9ubQj4TBDRzyk68WxlJ3pgtJcxXEKG9AEOaZKyMg Xue8u2wbb03bMM90vHfg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1njLkO-00EpUX-6H; Tue, 26 Apr 2022 14:00:56 +0000 Received: from mail-yb1-xb30.google.com ([2607:f8b0:4864:20::b30]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1njLdU-00Em7w-1V for linux-arm-kernel@lists.infradead.org; Tue, 26 Apr 2022 13:53:50 +0000 Received: by mail-yb1-xb30.google.com with SMTP id j2so33154593ybu.0 for ; Tue, 26 Apr 2022 06:53:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ckCZvmbeyyn635mnaKqXxsF4H+ghoyHwVYsC+7BA0B0=; b=igwGqJ1N3E7ODSLycDSaVr0WbIXpPlLVINt+CdifwDAJ4gIawXS0nViMwM0ZwMz3cM Y4fR5DEtmjMEWumRDWtc4A2/YhCv7x7gKR5KpZZeUJycaCRjTGf9T1tDKw3HDHO92/Cq WypqODghI7Sd8bMnc4Jr9OPbxjmKS+4p/vl2XRKZ7E/Xt51ZoyMaNx1ZCNVkqnPdYoIF m5umgOdDFSMrF1FGHf8mhUZl+LrEInUPltAY8fuNVAAt5GTePYWc5uYbtvPG7igxz2SU by93u6+dbEw46318P4HWU5ZgTv2R08XF+cESh81A43oG2yFIlMBgKK0J52dOiASLqyeC tGjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ckCZvmbeyyn635mnaKqXxsF4H+ghoyHwVYsC+7BA0B0=; b=BdFDzRfLpUEutsS2AIsIyOy4n956/sBpbzzTB1LJgPJ8xprDoAQ2NyJcwWahptb3ks 4sAWjhqX34M1PYZhqUE4HZnC92uux/JQiWhfW4wzW+cc6rcnZNPh8qS+CJczzgWwebVd yeyiiuc2o38idWMhyxpvjCeqbKAq13VZmLCPgtsVqGzqnSDVxmyL52t+mEEd/Lcxg2UZ 5CKODWOqcnqC1MeXn2oDWsS6q+WeOhparf3D3tH0aHRajCQj6a7KtNsR0sGqSs9T3ZCu gWx32LTuXd0QYdc8o7ejHGzzw2bWFs6QzHrUwdjwDXgUtTPNk+pD/aOSWCIK5ME44Szl DXrw== X-Gm-Message-State: AOAM532nfF/bYJpXOIDKDzOWwMbHst8eDY6XbvJx2zkIyWq+kBkwSFBN MVKwKpt74S0JisyOkWJTiXk1PZV/yTTxoCM9tyA9IA== X-Google-Smtp-Source: ABdhPJwF18W/ckSAQP+Lb7KRodHA2ZrpGoAfo3MnAwZd2GoH5aVP8IC0RDmP+BEupKkL+maFSkUIUbxWV/ny/0vfhno= X-Received: by 2002:a25:77c1:0:b0:648:3fb0:d5cf with SMTP id s184-20020a2577c1000000b006483fb0d5cfmr13072913ybc.511.1650981225960; Tue, 26 Apr 2022 06:53:45 -0700 (PDT) MIME-Version: 1.0 References: <20220424090422.97070-1-wanjiabing@vivo.com> In-Reply-To: <20220424090422.97070-1-wanjiabing@vivo.com> From: Ulf Hansson Date: Tue, 26 Apr 2022 15:53:09 +0200 Message-ID: Subject: Re: [PATCH] mmc: atmel-mci: simplify if-if to if-else To: Wan Jiabing X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220426_065348_197109_7D3B9EB2 X-CRM114-Status: GOOD ( 15.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Belloni , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, Ludovic Desroches , kael_w@yeah.net, Claudiu Beznea , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, 24 Apr 2022 at 11:04, Wan Jiabing wrote: > > Use if and else instead of if(A) and if (!A). > > Signed-off-by: Wan Jiabing > --- > drivers/mmc/host/atmel-mci.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/mmc/host/atmel-mci.c b/drivers/mmc/host/atmel-mci.c > index 807177c953f3..98893ccad4bd 100644 > --- a/drivers/mmc/host/atmel-mci.c > +++ b/drivers/mmc/host/atmel-mci.c > @@ -1125,8 +1125,7 @@ atmci_prepare_data_dma(struct atmel_mci *host, struct mmc_data *data) > chan = host->dma.chan; > if (chan) > host->data_chan = chan; > - > - if (!chan) > + else > return -ENODEV; To make a slightly better improvement of the code, I suggest we add an early bail out point in the atmci_prepare_data_dma() function. Like below: if (!host->dma.chan) return -ENODEV; [...] Kind regards Uffe _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel