From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DATE_IN_PAST_12_24, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12856C388F7 for ; Wed, 28 Oct 2020 23:52:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A74C9207CD for ; Wed, 28 Oct 2020 23:52:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="PvnCwIef" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389303AbgJ1XwC (ORCPT ); Wed, 28 Oct 2020 19:52:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40964 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387563AbgJ1Xvq (ORCPT ); Wed, 28 Oct 2020 19:51:46 -0400 Received: from mail-pl1-x644.google.com (mail-pl1-x644.google.com [IPv6:2607:f8b0:4864:20::644]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2CE91C0613CF for ; Wed, 28 Oct 2020 16:51:45 -0700 (PDT) Received: by mail-pl1-x644.google.com with SMTP id z1so406402plo.12 for ; Wed, 28 Oct 2020 16:51:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=tmTfdAqJelGk4mThvToPB+vvFy/o2Riv909vC5Pwsvc=; b=PvnCwIef6PZCTFzgkQOE6JXpb70433VKOlFqHWLlBDtiPS9mCm8oVghA+eXAC6KxjB j5R3n3VjyjW4vD3eVLDjTBVf1/lCrGPrAwyAGG8NFmzunydB3WwepFlnjhYNpJc4cvdl WK6xIrldFzHeKcCCMKPLPErRCYpr4qMwZmjQVpYAlw/P2+XKWk4oM88xJLIx07qmVhlG vVP4MBcP9wvJpKuwvN31PU+45Fh8W0+q9tF9hEWpvDZfxjq57UcwOkRZru/5mR7uwm8B UGpPz2KxfASR16wNtW1LoSLgnwJiuykxEaWXRcZeji/OlQGhQMqWXSK5n5+ayycZGeN8 EX+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tmTfdAqJelGk4mThvToPB+vvFy/o2Riv909vC5Pwsvc=; b=PscC0+YsMJEORxNhtRy20tWjcfRmWhXKtRO0kF4gYOZZs+gBlFVtsz7vtfeQezMt/9 y+sZ1/4qNVJ0fzpVW0ahAiV/50msgPAb6wl3SszrC46MD1nfCBMeD6EwHMwzpI8yUCel z4fuXz6BgWYoiBUufcgndJ6w/W2A6fMn04BYCLrNGtbe8v93v76CjgyjY46Xi2CNM/Ca X1qvp4rYQYTxOcFq1/J7x3xRVyowV/SnaWGQI2hkBVui+LIinZ7h+T1Fj9L3LEk1UnNO KhoG8k8kB/CeYiRJOw3g/A/AD22MkJeACOJ8tRQiMtBMgfRIXEgEHeBeedqxpVg7P6LX OjLA== X-Gm-Message-State: AOAM531Y0OIIzTCsoOI/GIVXoiQJyeX7aDviqxIXikl3KDWAZcnqVPd2 pD8h11CCxSFXWTTZ0O2FriNM3v8EW7v0pZdtSnWZPNuNEaB4DS0W X-Google-Smtp-Source: ABdhPJxA6mva6c9AuQcMDkfN09APtSH2RneKpFr1NrXpPaeWepLTqSsiRntY8LrK5rP3qon0g31a7FFbXKcv2+GSxOA= X-Received: by 2002:a05:6122:10eb:: with SMTP id m11mr4439593vko.8.1603878079032; Wed, 28 Oct 2020 02:41:19 -0700 (PDT) MIME-Version: 1.0 References: <20201023122950.60903-1-fparent@baylibre.com> <87wnzbg7on.fsf@baylibre.com> <1603869682.6198.23.camel@mhfsdcap03> In-Reply-To: <1603869682.6198.23.camel@mhfsdcap03> From: Ulf Hansson Date: Wed, 28 Oct 2020 10:40:42 +0100 Message-ID: Subject: Re: [PATCH] mmc: host: mtk-sd: enable recheck_sdio_irq for MT8516 SoC To: "yong.mao@mediatek.com" Cc: Mattijs Korpershoek , Fabien Parent , Chaotian Jing , Matthias Brugger , "linux-mmc@vger.kernel.org" , "moderated list:ARM/Mediatek SoC support" , Linux Kernel Mailing List , Linux ARM Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 28 Oct 2020 at 08:22, yong.mao@mediatek.com wrote: > > On Tue, 2020-10-27 at 13:44 +0100, Mattijs Korpershoek wrote: > > Hi Ulf, > > > > Ulf Hansson writes: > > > > > + Yong Mao, Chaotian Jing > > > > > > On Fri, 23 Oct 2020 at 14:29, Fabien Parent wrote: > > >> > > >> MT8516 SoC suffers from sometimes losing SDIO IRQs, this makes SDIO > > >> devices sometimes unstable. Make use of the new property > > >> recheck_sdio_irq to fix the SDIO stability issues on MT8516. > > >> > > >> Signed-off-by: Fabien Parent > > > > > > Maybe this is a common problem, thus I am thinking that potentially we > > > should enable the workaround for all variants? > > Not sure if this is of any help, but: we use the btmtksdio driver on a > > MT8183 soc with an Android kernel based on upstream. > > > > With that kernel, we did not to apply this work-around in order to > > have a stable bluetooth experience (pairing with a remote controller) > > > > However, on the MT8516 SoC, it's impossible for us to use btmtksdio > > without Fabien's fix. > > > Yes. For mt8516 SoC,recheck_sdio_irq should be set to true for avoiding > SDIO dat1 irq lost issue. But for mt8183 SoC, it does not need recheck > sdio irq mechanism. Okay, thanks for confirming. > > > > > > > I have looped in Yong Mao (who invented the workaround) and Chaotian > > > Jing, to see if they can advise us how to proceed. > > > > > > In any case, I think we should add a stable tag and a fixes tag. > > > > > > Kind regards > > > Uffe > > Hi Ulf, > Sorry. On the patch "mmc:mediatek:fix SDIO irq issue", I only consider > fixing the issue on mt8173 SoC.But for the whole MTK upstream SoC, > mt8183, mt2712, mt6779 and mt8192 does not need this mechanism, > but the other upstream Soc such as mt8135, mt8173, mt2701, mt7622, > mt8516 and mt7620 need this recheck mechanism. And all future SoC of our > company does not need this mechanism. > If it's convenient for you, please help me to revise it. > Or I will submit a new patch to correct the value of setting. > Thanks. Please submit a new patch to enable the "recheck_sdio_irq" flag for those variants that need it. I would also add a fixes+stable tag and add reported-by tags from Fabien and Mattijs. Kind regards Uffe > > > > > >> --- > > >> drivers/mmc/host/mtk-sd.c | 2 +- > > >> 1 file changed, 1 insertion(+), 1 deletion(-) > > >> > > >> diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c > > >> index a704745e5882..3dc102eefe49 100644 > > >> --- a/drivers/mmc/host/mtk-sd.c > > >> +++ b/drivers/mmc/host/mtk-sd.c > > >> @@ -524,7 +524,7 @@ static const struct mtk_mmc_compatible mt7622_compat = { > > >> > > >> static const struct mtk_mmc_compatible mt8516_compat = { > > >> .clk_div_bits = 12, > > >> - .recheck_sdio_irq = false, > > >> + .recheck_sdio_irq = true, > > >> .hs400_tune = false, > > >> .pad_tune_reg = MSDC_PAD_TUNE0, > > >> .async_fifo = true, > > >> -- > > >> 2.28.0 > > >> > > > > > > _______________________________________________ > > > Linux-mediatek mailing list > > > Linux-mediatek@lists.infradead.org > > > http://lists.infradead.org/mailman/listinfo/linux-mediatek > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AA2AC4363A for ; Wed, 28 Oct 2020 09:41:35 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A71BD2469B for ; Wed, 28 Oct 2020 09:41:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="tTFEoaDu"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="PvnCwIef" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A71BD2469B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=GlUl9kzAgr1HrR6YuwKXYzl6S4z2KWn2oDFSyF4StRA=; b=tTFEoaDufatHnbphiTB5EoAhj IWWvZe6dGB9PwNNa10974GkBs48fnDTdbdPp8GKwMtfjtX5IJd9zi7O7m1jZyRyoMQtNtglLwYjs1 sLsLi3lUnlA8mke0s6iRSTtg9c4SGcV/IkIsBb9oW2+xeOa5zGI2Hr2r9AuhsDD+DyWjGnvnXJtZp J6wSeXcwJIVemRHhOFwRau51KD62mp91G8OveX6MZoQFVidL0uVe0fOMntnwdeTdMBwP+9+OIgIk7 JC2X0ayRe74KRJR1rYqCHufzM18uCd+TVsKoshsJB+MMsyFv4+PYkD6T/ZZGrBGsHZH821/ZlkjaL kTRpsxanw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kXhxN-0004B0-Sa; Wed, 28 Oct 2020 09:41:25 +0000 Received: from mail-vk1-xa43.google.com ([2607:f8b0:4864:20::a43]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kXhxJ-000498-3L for linux-mediatek@lists.infradead.org; Wed, 28 Oct 2020 09:41:23 +0000 Received: by mail-vk1-xa43.google.com with SMTP id n141so1028176vke.9 for ; Wed, 28 Oct 2020 02:41:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=tmTfdAqJelGk4mThvToPB+vvFy/o2Riv909vC5Pwsvc=; b=PvnCwIef6PZCTFzgkQOE6JXpb70433VKOlFqHWLlBDtiPS9mCm8oVghA+eXAC6KxjB j5R3n3VjyjW4vD3eVLDjTBVf1/lCrGPrAwyAGG8NFmzunydB3WwepFlnjhYNpJc4cvdl WK6xIrldFzHeKcCCMKPLPErRCYpr4qMwZmjQVpYAlw/P2+XKWk4oM88xJLIx07qmVhlG vVP4MBcP9wvJpKuwvN31PU+45Fh8W0+q9tF9hEWpvDZfxjq57UcwOkRZru/5mR7uwm8B UGpPz2KxfASR16wNtW1LoSLgnwJiuykxEaWXRcZeji/OlQGhQMqWXSK5n5+ayycZGeN8 EX+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tmTfdAqJelGk4mThvToPB+vvFy/o2Riv909vC5Pwsvc=; b=FKugTUrp1+Tjx7FrPLiQzvAzwqMVpAISWBZAP4AZLf5aiiJHkjNHK+YcnOfR/w754R 0nzupYNBDGa0L36TodXV2ImzbrdxSGLqPKXlf1kAqnr9gcqbo9CzRroatgy9LOqrlzTo AkHvoVHlBa649M2cLI3ebothE7gRuG8u+rK2ODwdFycjLCG6Qwh2o8PnVNQgJXBw7QFL uxt7jGY9+wnwOphD6UbmcYUDxHfZ9fytLjrURrc4wfuE7YLGgNsUQ19iFGe50YWt/M0F KNpmDlZc9qPUvspb13S4nk/tufvt4AaRAJ2svdaOSLSY2HspR38XLjhQfpB9AHYRbRnJ yLww== X-Gm-Message-State: AOAM5313Q05Hr3d/86hhiakxB60o208L2dqzAuHhaOUPdbEQUvmOf3Na cGXCyKIqigAWiw/lKjtP/PmPIpz7/XmAcPozA+/2JA== X-Google-Smtp-Source: ABdhPJxA6mva6c9AuQcMDkfN09APtSH2RneKpFr1NrXpPaeWepLTqSsiRntY8LrK5rP3qon0g31a7FFbXKcv2+GSxOA= X-Received: by 2002:a05:6122:10eb:: with SMTP id m11mr4439593vko.8.1603878079032; Wed, 28 Oct 2020 02:41:19 -0700 (PDT) MIME-Version: 1.0 References: <20201023122950.60903-1-fparent@baylibre.com> <87wnzbg7on.fsf@baylibre.com> <1603869682.6198.23.camel@mhfsdcap03> In-Reply-To: <1603869682.6198.23.camel@mhfsdcap03> From: Ulf Hansson Date: Wed, 28 Oct 2020 10:40:42 +0100 Message-ID: Subject: Re: [PATCH] mmc: host: mtk-sd: enable recheck_sdio_irq for MT8516 SoC To: "yong.mao@mediatek.com" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201028_054121_466834_A3AAC3A4 X-CRM114-Status: GOOD ( 34.85 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mattijs Korpershoek , "linux-mmc@vger.kernel.org" , Linux Kernel Mailing List , Fabien Parent , "moderated list:ARM/Mediatek SoC support" , Linux ARM , Matthias Brugger , Chaotian Jing Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Wed, 28 Oct 2020 at 08:22, yong.mao@mediatek.com wrote: > > On Tue, 2020-10-27 at 13:44 +0100, Mattijs Korpershoek wrote: > > Hi Ulf, > > > > Ulf Hansson writes: > > > > > + Yong Mao, Chaotian Jing > > > > > > On Fri, 23 Oct 2020 at 14:29, Fabien Parent wrote: > > >> > > >> MT8516 SoC suffers from sometimes losing SDIO IRQs, this makes SDIO > > >> devices sometimes unstable. Make use of the new property > > >> recheck_sdio_irq to fix the SDIO stability issues on MT8516. > > >> > > >> Signed-off-by: Fabien Parent > > > > > > Maybe this is a common problem, thus I am thinking that potentially we > > > should enable the workaround for all variants? > > Not sure if this is of any help, but: we use the btmtksdio driver on a > > MT8183 soc with an Android kernel based on upstream. > > > > With that kernel, we did not to apply this work-around in order to > > have a stable bluetooth experience (pairing with a remote controller) > > > > However, on the MT8516 SoC, it's impossible for us to use btmtksdio > > without Fabien's fix. > > > Yes. For mt8516 SoC,recheck_sdio_irq should be set to true for avoiding > SDIO dat1 irq lost issue. But for mt8183 SoC, it does not need recheck > sdio irq mechanism. Okay, thanks for confirming. > > > > > > > I have looped in Yong Mao (who invented the workaround) and Chaotian > > > Jing, to see if they can advise us how to proceed. > > > > > > In any case, I think we should add a stable tag and a fixes tag. > > > > > > Kind regards > > > Uffe > > Hi Ulf, > Sorry. On the patch "mmc:mediatek:fix SDIO irq issue", I only consider > fixing the issue on mt8173 SoC.But for the whole MTK upstream SoC, > mt8183, mt2712, mt6779 and mt8192 does not need this mechanism, > but the other upstream Soc such as mt8135, mt8173, mt2701, mt7622, > mt8516 and mt7620 need this recheck mechanism. And all future SoC of our > company does not need this mechanism. > If it's convenient for you, please help me to revise it. > Or I will submit a new patch to correct the value of setting. > Thanks. Please submit a new patch to enable the "recheck_sdio_irq" flag for those variants that need it. I would also add a fixes+stable tag and add reported-by tags from Fabien and Mattijs. Kind regards Uffe > > > > > >> --- > > >> drivers/mmc/host/mtk-sd.c | 2 +- > > >> 1 file changed, 1 insertion(+), 1 deletion(-) > > >> > > >> diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c > > >> index a704745e5882..3dc102eefe49 100644 > > >> --- a/drivers/mmc/host/mtk-sd.c > > >> +++ b/drivers/mmc/host/mtk-sd.c > > >> @@ -524,7 +524,7 @@ static const struct mtk_mmc_compatible mt7622_compat = { > > >> > > >> static const struct mtk_mmc_compatible mt8516_compat = { > > >> .clk_div_bits = 12, > > >> - .recheck_sdio_irq = false, > > >> + .recheck_sdio_irq = true, > > >> .hs400_tune = false, > > >> .pad_tune_reg = MSDC_PAD_TUNE0, > > >> .async_fifo = true, > > >> -- > > >> 2.28.0 > > >> > > > > > > _______________________________________________ > > > Linux-mediatek mailing list > > > Linux-mediatek@lists.infradead.org > > > http://lists.infradead.org/mailman/listinfo/linux-mediatek > _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B6EAC4363A for ; Wed, 28 Oct 2020 09:41:56 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1885A2469B for ; Wed, 28 Oct 2020 09:41:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="PIDIo6Zm"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="PvnCwIef" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1885A2469B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=b7mM/Lxjte4vSBUH7nvdff38Me/X4Sn+15JQbsOE+Z0=; b=PIDIo6ZmOZTxd4Q3BVu3n+9b/ RqG7Olbj4BA1fA3IfXEg7XdUhIVTsnRIIF5kPj4V7khzAy1N0eGb+IK/sb+g8O0moGwknRSb5BZlM WHuhQUHn6iu/TwYyBetS4+yzw4p4SOQS8u+EVPGCgAwwHnDlO4hqC8t+l1KobED+8hfwJR0Bdbebc gbLvXLBaEZIBYOAJDU6IjsKg7Z/j2EcoVpnhcI7djzSQV7PffLpp6vi/W0sVWbyCjubS1hAuk/Xrl atepmR0E7Niw2iFDleqvQcSIHSJbeZBrvv+0PXxdYotn01x2n1GxOESsskUpyzc3QFotGO4jOj5Ut +vMM+Qb7w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kXhxM-0004AY-4e; Wed, 28 Oct 2020 09:41:24 +0000 Received: from mail-vk1-xa44.google.com ([2607:f8b0:4864:20::a44]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kXhxJ-000499-3R for linux-arm-kernel@lists.infradead.org; Wed, 28 Oct 2020 09:41:22 +0000 Received: by mail-vk1-xa44.google.com with SMTP id u202so1035331vkb.4 for ; Wed, 28 Oct 2020 02:41:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=tmTfdAqJelGk4mThvToPB+vvFy/o2Riv909vC5Pwsvc=; b=PvnCwIef6PZCTFzgkQOE6JXpb70433VKOlFqHWLlBDtiPS9mCm8oVghA+eXAC6KxjB j5R3n3VjyjW4vD3eVLDjTBVf1/lCrGPrAwyAGG8NFmzunydB3WwepFlnjhYNpJc4cvdl WK6xIrldFzHeKcCCMKPLPErRCYpr4qMwZmjQVpYAlw/P2+XKWk4oM88xJLIx07qmVhlG vVP4MBcP9wvJpKuwvN31PU+45Fh8W0+q9tF9hEWpvDZfxjq57UcwOkRZru/5mR7uwm8B UGpPz2KxfASR16wNtW1LoSLgnwJiuykxEaWXRcZeji/OlQGhQMqWXSK5n5+ayycZGeN8 EX+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tmTfdAqJelGk4mThvToPB+vvFy/o2Riv909vC5Pwsvc=; b=uYi4CEM5rEBWDWMWQhPsBSKgKbBQyBBnww4kTlK9y+486mi+ch7eEJaMrhDnQ+pG9G G8bqXiSJ4XWKEWfzlaTbxrFpfT1TyTH5XI71MLSew/Z6clSvkw6pcRfYZMXYJMXgPg7y ozcoPLvF7HYfplKeyTSt2hi4VkpsEOmLlFMtSpbBkt7ukX8KQ+sr0yo6cFgDZG4h99tp FVRCD4ZI6DIeLpbegL8j9V7dDPJlA4lKsEoICdjet4WUCb03f7vo7QBJlhxMwLU6gr2q gwsOLDhtsvZOW6itpZPry02yLOZA44UZB6tBj0ap1iq4ZiApZ5HVXPR2T1Pb69nPkizA 5l8A== X-Gm-Message-State: AOAM531002Ve+RWIM20iHjQ6PqWe2oLiLgkhpvKfZ5TPxE4VaJBfTX1v OlvHkrDLIDulz/rkn5b1ttrVhBxpZ9dxo4apS/iTzw== X-Google-Smtp-Source: ABdhPJxA6mva6c9AuQcMDkfN09APtSH2RneKpFr1NrXpPaeWepLTqSsiRntY8LrK5rP3qon0g31a7FFbXKcv2+GSxOA= X-Received: by 2002:a05:6122:10eb:: with SMTP id m11mr4439593vko.8.1603878079032; Wed, 28 Oct 2020 02:41:19 -0700 (PDT) MIME-Version: 1.0 References: <20201023122950.60903-1-fparent@baylibre.com> <87wnzbg7on.fsf@baylibre.com> <1603869682.6198.23.camel@mhfsdcap03> In-Reply-To: <1603869682.6198.23.camel@mhfsdcap03> From: Ulf Hansson Date: Wed, 28 Oct 2020 10:40:42 +0100 Message-ID: Subject: Re: [PATCH] mmc: host: mtk-sd: enable recheck_sdio_irq for MT8516 SoC To: "yong.mao@mediatek.com" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201028_054121_466129_6F419920 X-CRM114-Status: GOOD ( 36.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mattijs Korpershoek , "linux-mmc@vger.kernel.org" , Linux Kernel Mailing List , Fabien Parent , "moderated list:ARM/Mediatek SoC support" , Linux ARM , Matthias Brugger , Chaotian Jing Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 28 Oct 2020 at 08:22, yong.mao@mediatek.com wrote: > > On Tue, 2020-10-27 at 13:44 +0100, Mattijs Korpershoek wrote: > > Hi Ulf, > > > > Ulf Hansson writes: > > > > > + Yong Mao, Chaotian Jing > > > > > > On Fri, 23 Oct 2020 at 14:29, Fabien Parent wrote: > > >> > > >> MT8516 SoC suffers from sometimes losing SDIO IRQs, this makes SDIO > > >> devices sometimes unstable. Make use of the new property > > >> recheck_sdio_irq to fix the SDIO stability issues on MT8516. > > >> > > >> Signed-off-by: Fabien Parent > > > > > > Maybe this is a common problem, thus I am thinking that potentially we > > > should enable the workaround for all variants? > > Not sure if this is of any help, but: we use the btmtksdio driver on a > > MT8183 soc with an Android kernel based on upstream. > > > > With that kernel, we did not to apply this work-around in order to > > have a stable bluetooth experience (pairing with a remote controller) > > > > However, on the MT8516 SoC, it's impossible for us to use btmtksdio > > without Fabien's fix. > > > Yes. For mt8516 SoC,recheck_sdio_irq should be set to true for avoiding > SDIO dat1 irq lost issue. But for mt8183 SoC, it does not need recheck > sdio irq mechanism. Okay, thanks for confirming. > > > > > > > I have looped in Yong Mao (who invented the workaround) and Chaotian > > > Jing, to see if they can advise us how to proceed. > > > > > > In any case, I think we should add a stable tag and a fixes tag. > > > > > > Kind regards > > > Uffe > > Hi Ulf, > Sorry. On the patch "mmc:mediatek:fix SDIO irq issue", I only consider > fixing the issue on mt8173 SoC.But for the whole MTK upstream SoC, > mt8183, mt2712, mt6779 and mt8192 does not need this mechanism, > but the other upstream Soc such as mt8135, mt8173, mt2701, mt7622, > mt8516 and mt7620 need this recheck mechanism. And all future SoC of our > company does not need this mechanism. > If it's convenient for you, please help me to revise it. > Or I will submit a new patch to correct the value of setting. > Thanks. Please submit a new patch to enable the "recheck_sdio_irq" flag for those variants that need it. I would also add a fixes+stable tag and add reported-by tags from Fabien and Mattijs. Kind regards Uffe > > > > > >> --- > > >> drivers/mmc/host/mtk-sd.c | 2 +- > > >> 1 file changed, 1 insertion(+), 1 deletion(-) > > >> > > >> diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c > > >> index a704745e5882..3dc102eefe49 100644 > > >> --- a/drivers/mmc/host/mtk-sd.c > > >> +++ b/drivers/mmc/host/mtk-sd.c > > >> @@ -524,7 +524,7 @@ static const struct mtk_mmc_compatible mt7622_compat = { > > >> > > >> static const struct mtk_mmc_compatible mt8516_compat = { > > >> .clk_div_bits = 12, > > >> - .recheck_sdio_irq = false, > > >> + .recheck_sdio_irq = true, > > >> .hs400_tune = false, > > >> .pad_tune_reg = MSDC_PAD_TUNE0, > > >> .async_fifo = true, > > >> -- > > >> 2.28.0 > > >> > > > > > > _______________________________________________ > > > Linux-mediatek mailing list > > > Linux-mediatek@lists.infradead.org > > > http://lists.infradead.org/mailman/listinfo/linux-mediatek > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel